Re: [PATCH] D64029: [PGO] Add PGO support at -O0 in the experimental new pass manager

r367657 should fix this. On Fri, Aug 2, 2019 at 12:20 AM Rong Xu wrote: > yes. I already know this issue as this also breaks windows bolt. > The fix should be simple. > > -Rong > > On Thu, Aug 1, 2019 at 11:52 PM Petr Hosek via Phabricator < > revi...@reviews.llvm.org> wrote: > >> phosek added

Re: [PATCH] D64029: [PGO] Add PGO support at -O0 in the experimental new pass manager

yes. I already know this issue as this also breaks windows bolt. The fix should be simple. -Rong On Thu, Aug 1, 2019 at 11:52 PM Petr Hosek via Phabricator < revi...@reviews.llvm.org> wrote: > phosek added a comment. > > Looks like this change broke `Profile/gcc-flag-compatibility.c` test on >

[PATCH] D64029: [PGO] Add PGO support at -O0 in the experimental new pass manager

phosek added a comment. Looks like this change broke `Profile/gcc-flag-compatibility.c` test on macOS: TEST 'Clang :: Profile/gcc-flag-compatibility.c' FAILED Script: -- : 'RUN: at line 10';

[PATCH] D64029: [PGO] Add PGO support at -O0 in the experimental new pass manager

This revision was automatically updated to reflect the committed changes. xur marked an inline comment as done. Closed by commit rL367628: [PGO] Add PGO support at -O0 in the experimental new pass manager (authored by xur, committed by ). Changed prior to commit:

[PATCH] D64029: [PGO] Add PGO support at -O0 in the experimental new pass manager

xur marked 3 inline comments as done. xur added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:1125 +PB.addPGOInstrPassesForO0(MPM, CodeGenOpts.DebugPassManager, + /* RunProfileGen */ PGOOpt->Action == +

[PATCH] D64029: [PGO] Add PGO support at -O0 in the experimental new pass manager

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM with two nits addressed, thanks! Comment at: clang/lib/CodeGen/BackendUtil.cpp:1125 +PB.addPGOInstrPassesForO0(MPM, CodeGenOpts.DebugPassManager, +

[PATCH] D64029: [PGO] Add PGO support at -O0 in the experimental new pass manager

xur updated this revision to Diff 212237. xur marked an inline comment as done. xur added a comment. Integrated Chandler's review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64029/new/ https://reviews.llvm.org/D64029 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D64029: [PGO] Add PGO support at -O0 in the experimental new pass manager

xur marked 3 inline comments as done. xur added a comment. I'm sorry that I missed this review for this long! In D64029#1581952 , @chandlerc wrote: > Sorry for the delay here. > > It'd be nice to land the LLVM patch first and with its own testing -- we

[PATCH] D64029: [PGO] Add PGO support at -O0 in the experimental new pass manager

chandlerc requested changes to this revision. chandlerc added a comment. This revision now requires changes to proceed. Sorry for the delay here. It'd be nice to land the LLVM patch first and with its own testing -- we should have testing for the pass builder independent of Clang (IE, in the

[PATCH] D64029: [PGO] Add PGO support at -O0 in the experimental new pass manager

xur added a comment. Ping Comment at: llvm/lib/Passes/PassBuilder.cpp:576 +// dramatically increase code size. +MPM.addPass(GlobalDCEPass()); + } I moved this pass under the condition when Early inline is enabled. I'm under the impression that the

[PATCH] D64029: [PGO] Add PGO support at -O0 in the experimental new pass manager

xur updated this revision to Diff 207392. xur marked an inline comment as done. xur added a comment. Sent the wrong test file in last patch. Update to the correct one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64029/new/ https://reviews.llvm.org/D64029 Files:

[PATCH] D64029: [PGO] Add PGO support at -O0 in the experimental new pass manager

xur created this revision. xur added a reviewer: chandlerc. Herald added a subscriber: hiraditya. Herald added a project: LLVM. Add PGO support at -O0 in the experimental new pass manager to sync the behavior with the legacy pass manager. Also change the test of gcc-flag-compatibility.c for