hans added a comment.
Thanks for polishing the UX! :-)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64504/new/
https://reviews.llvm.org/D64504
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
thakis closed this revision.
thakis added a comment.
r365721
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64504/new/
https://reviews.llvm.org/D64504
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: clang/include/clang/Driver/CLCompatOptions.td:294
def _SLASH_GX : CLFlag<"GX">,
- HelpText<"Enable exception handling">;
+ HelpText<"Deprecated (like /EHsc)">;
thakis updated this revision to Diff 209093.
thakis marked 4 inline comments as done.
thakis added a comment.
comments
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64504/new/
https://reviews.llvm.org/D64504
Files:
clang/include/clang/Driver/CLCompatOptions.td
Index: clang/include/c
thakis added inline comments.
Comment at: clang/include/clang/Driver/CLCompatOptions.td:250
def _SLASH_Zi : CLFlag<"Zi">, Alias<_SLASH_Z7>,
- HelpText<"Alias for /Z7. Does not produce PDBs.">;
+ HelpText<"Like /Z7">;
def _SLASH_Zp : CLJoined<"Zp">,
rnk wrote:
rnk added inline comments.
Comment at: clang/include/clang/Driver/CLCompatOptions.td:102
def _SLASH_Gy_ : CLFlag<"Gy-">,
HelpText<"Don't put each function in its own section (default)">,
Alias;
ditto
Comment at: clang/include/clang/Drive
thakis created this revision.
thakis added a reviewer: rnk.
- Add back indentation I accidentally removed in r364901
- Wrap two lines to 80 cols
- Slightly tighten up help text for several flags
- Consistently use "Do not" instead of "Don't"
- Make every option description start with a verb
- Use
