[PATCH] D64672: [X86] Prevent passing vectors of __int128 as in llvm IR

craig.topper closed this revision. craig.topper added a comment. Committed in r371169, but I forgot the Differential Revision line CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64672/new/ https://reviews.llvm.org/D64672 ___ cfe-commits

[PATCH] D64672: [X86] Prevent passing vectors of __int128 as in llvm IR

RKSimon added a comment. @craig.topper Wasn't this committed at rL371169 ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64672/new/ https://reviews.llvm.org/D64672 ___ cfe-commits mailing list

[PATCH] D64672: [X86] Prevent passing vectors of __int128 as in llvm IR

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - cheers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64672/new/ https://reviews.llvm.org/D64672 ___ cfe-commits mailing list

[PATCH] D64672: [X86] Prevent passing vectors of __int128 as in llvm IR

probinson added a comment. It looks to me like the patch does things the New Way only for Linux and NetBSD, so for PS4 backward compatibility I am okay with it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64672/new/ https://reviews.llvm.org/D64672

[PATCH] D64672: [X86] Prevent passing vectors of __int128 as in llvm IR

craig.topper updated this revision to Diff 218506. craig.topper added a comment. Change test name and adjust to the changes I think @rksimon was asking for. I haven't commited the test yet. I'd like to verify that the before version of the test is how you would like it pre-committed CHANGES

[PATCH] D64672: [X86] Prevent passing vectors of __int128 as in llvm IR

RKSimon added a comment. In D64672#1654983 , @craig.topper wrote: > In D64672#1654687 , @RKSimon wrote: > > > Tests look great - please can you pre-commit them and update the patch to > > show the diff? Also,

[PATCH] D64672: [X86] Prevent passing vectors of __int128 as in llvm IR

craig.topper added a comment. In D64672#1654687 , @RKSimon wrote: > Tests look great - please can you pre-commit them and update the patch to > show the diff? Also, maybe call the test file x86-vec-i128.c and add a > comment in the file describing

[PATCH] D64672: [X86] Prevent passing vectors of __int128 as in llvm IR

RKSimon added a comment. Tests look great - please can you pre-commit them and update the patch to show the diff? Also, maybe call the test file x86-vec-i128.c and add a comment in the file describing PR42607? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D64672: [X86] Prevent passing vectors of __int128 as in llvm IR

craig.topper updated this revision to Diff 218284. craig.topper added a comment. Add more tests. Clarify which platforms are affected in LangOptions.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64672/new/ https://reviews.llvm.org/D64672 Files:

[PATCH] D64672: [X86] Prevent passing vectors of __int128 as in llvm IR

craig.topper added a comment. In D64672#1653847 , @RKSimon wrote: > Please can you extend the test coverage to cover more vector sizes and cpu > target features, not just avx512, and also add x86_64-scei-ps4 triple tests. > Maybe 32-bit tests as well?

[PATCH] D64672: [X86] Prevent passing vectors of __int128 as in llvm IR

RKSimon added a comment. Please can you extend the test coverage to cover more vector sizes and cpu target features, not just avx512, and also add x86_64-scei-ps4 triple tests. Maybe 32-bit tests as well? Comment at: clang/include/clang/Basic/LangOptions.h:143 +/// (SVN

[PATCH] D64672: [X86] Prevent passing vectors of __int128 as in llvm IR

hans added a comment. In D64672#1623784 , @xbolva00 wrote: > Maybe this ABI issue should be fixed for 9.0 ? Not sure how important, but > @hans maybe should track this one. IIUC, this is not a new issue, so I'd prefer not trying to rush it in for llvm

[PATCH] D64672: [X86] Prevent passing vectors of __int128 as in llvm IR

craig.topper updated this revision to Diff 214540. craig.topper added a comment. More test check lines. Test the compatibility flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64672/new/ https://reviews.llvm.org/D64672 Files:

[PATCH] D64672: [X86] Prevent passing vectors of __int128 as in llvm IR

craig.topper updated this revision to Diff 214539. craig.topper edited the summary of this revision. craig.topper added a comment. Herald added a project: clang. Add test cases. Change the type to vXi64 instead of vXf64. Add abi compatibility flag. Restrict to linux and freebsd. Repository:

[PATCH] D64672: [X86] Prevent passing vectors of __int128 as in llvm IR

xbolva00 added subscribers: hans, xbolva00. xbolva00 added a comment. Maybe this ABI issue should be fixed for 9.0 ? Not sure how important, but @hans maybe should track this one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64672/new/ https://reviews.llvm.org/D64672

[PATCH] D64672: [X86] Prevent passing vectors of __int128 as in llvm IR

wristow added a comment. > Do we need to keep the old behavior on platforms where clang is the de facto > compiler? I know we (PlayStation) will want to keep the old behavior. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64672/new/ https://reviews.llvm.org/D64672

[PATCH] D64672: [X86] Prevent passing vectors of __int128 as in llvm IR

craig.topper created this revision. craig.topper added reviewers: eli.friedman, RKSimon, spatel, rnk. As far as I can tell, gcc passes 256/512 bit vectors __int128 in memory. And passes a vector of 1 _int128 in an xmm register. The backend considers as an illegal type and will scalarize any