This revision was automatically updated to reflect the committed changes.
Closed by commit rL366451: [Clangd] Changed ExtractVariable to only work on non
empty selections (authored by SureYeaah, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior t
SureYeaah updated this revision to Diff 210577.
SureYeaah added a comment.
Added SelectionBegin and SelectionEnd to Tweak::Selection
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64912/new/
https://reviews.llvm.org/D64912
Files:
clang-tools-extr
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/refactor/Tweak.h:51
+/// The Length of the selection
+unsigned SelectionLength;
/// The AST nodes that were selected.
kadircet wrote:
> SureYeaah wrote:
> > kadircet wrote:
> > > m
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/refactor/Tweak.h:51
+/// The Length of the selection
+unsigned SelectionLength;
/// The AST nodes that were selected.
SureYeaah wrote:
> kadircet wrote:
> > maybe expose a `SourceLo
SureYeaah updated this revision to Diff 210537.
SureYeaah added a comment.
Fixed comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64912/new/
https://reviews.llvm.org/D64912
Files:
clang-tools-extra/clangd/refactor/Tweak.cpp
clang-tools-ex
SureYeaah updated this revision to Diff 210536.
SureYeaah added a comment.
Added selectionend
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64912/new/
https://reviews.llvm.org/D64912
Files:
clang-tools-extra/clangd/refactor/Tweak.cpp
clang-too
SureYeaah marked an inline comment as done.
SureYeaah added inline comments.
Comment at: clang-tools-extra/clangd/refactor/Tweak.h:51
+/// The Length of the selection
+unsigned SelectionLength;
/// The AST nodes that were selected.
kadircet wrote:
>
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/refactor/Tweak.h:51
+/// The Length of the selection
+unsigned SelectionLength;
/// The AST nodes that were selected.
maybe expose a `SourceLocation SelectionEnd` ?
Repository:
SureYeaah updated this revision to Diff 210526.
SureYeaah added a comment.
Added tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64912/new/
https://reviews.llvm.org/D64912
Files:
clang-tools-extra/clangd/refactor/Tweak.cpp
clang-tools-extr
SureYeaah created this revision.
SureYeaah added reviewers: kadircet, sammccall.
Herald added subscribers: cfe-commits, arphaman, jkorous, MaskRay,
ilya-biryukov.
Herald added a project: clang.
- For now, we don't trigger in any case if it's an empty selection
- Fixed unittests
Repository:
rG
10 matches
Mail list logo