[PATCH] D67091: Fix for headers having the same name as a directory

This revision was automatically updated to reflect the committed changes. Closed by commit rL371903: [clang-scan-deps] Fix for headers having the same name as a directory (authored by arphaman, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior

[PATCH] D67091: Fix for headers having the same name as a directory

arphaman added a comment. Sure, I can do that today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67091/new/ https://reviews.llvm.org/D67091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D67091: Fix for headers having the same name as a directory

kousikk added a comment. I don't have commit access - do you mind submitting this for me? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67091/new/ https://reviews.llvm.org/D67091 ___

[PATCH] D67091: Fix for headers having the same name as a directory

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. LGTM, Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67091/new/ https://reviews.llvm.org/D67091

[PATCH] D67091: Fix for headers having the same name as a directory

kousikk added a comment. > I was unable to reproduce the failures when I moved the check to createFile. > What kind of failures did you see? Did you move it right to the start of the > function? I would recommend rebasing the patch and retrying. I saw an assertion error - but I realize now

[PATCH] D67091: Fix for headers having the same name as a directory

kousikk updated this revision to Diff 219976. kousikk added a comment. - Add validation inside the createFile() function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67091/new/ https://reviews.llvm.org/D67091 Files:

[PATCH] D67091: Fix for headers having the same name as a directory

kousikk updated this revision to Diff 219975. kousikk added a comment. - Add validation inside the createFile() function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67091/new/ https://reviews.llvm.org/D67091 Files:

[PATCH] D67091: Fix for headers having the same name as a directory

arphaman added a subscriber: jkorous. arphaman added a comment. In D67091#1667821 , @kousikk wrote: > Sorry about the delay on this - I was OOO (back now). > > 1. I added tests. > 2. I couldn't add isDirectory() check to createFile() since that resulted

[PATCH] D67091: Fix for headers having the same name as a directory

kousikk added a comment. Sorry about the delay on this - I was OOO (back now). 1. I added tests. 2. I couldn't add isDirectory() check to createFile() since that resulted in failures to normal scenarios where it was previously passing. PTAL! Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D67091: Fix for headers having the same name as a directory

kousikk updated this revision to Diff 219918. kousikk added a comment. - Add validation inside the createFile() function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67091/new/ https://reviews.llvm.org/D67091 Files:

[PATCH] D67091: Fix for headers having the same name as a directory

kousikk updated this revision to Diff 219917. kousikk added a comment. - Add tests and remove the fix inside createFile since it fails in other cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67091/new/ https://reviews.llvm.org/D67091 Files:

[PATCH] D67091: Fix for headers having the same name as a directory

kousikk updated this revision to Diff 219890. kousikk added a comment. - Add validation inside the createFile() function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67091/new/ https://reviews.llvm.org/D67091 Files:

[PATCH] D67091: Fix for headers having the same name as a directory

kousikk updated this revision to Diff 219891. kousikk added a comment. - Add validation inside the createFile() function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67091/new/ https://reviews.llvm.org/D67091 Files:

[PATCH] D67091: Fix for headers having the same name as a directory

kousikk added a comment. Sure I'll add a test case! Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:196 + return llvm::ErrorOr>(std::make_error_code(std::errc::is_a_directory)); +} + } arphaman wrote: > This change

[PATCH] D67091: Fix for headers having the same name as a directory

arphaman added a comment. Thanks for fixing this! Could you add a test case which verifies that the assertion no longer happens? Let me know if you need help coming up with a test. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:196 +

[PATCH] D67091: Fix for headers having the same name as a directory

kousikk created this revision. kousikk added a reviewer: arphaman. Herald added subscribers: cfe-commits, jfb, dexonsmith. Herald added a project: clang. Scan deps tool crashes when called on a C++ file, containing an include that has the same name as a directory. For example: test.cpp: #include