[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

nemanjai added a comment. In D67678#3446526 , @rsmith wrote: > @dexonsmith @arphaman What do we need to do to get this re-landed? FWIW, on the PPC side, we are working on cleaning up `altivec.h` and plan to eventually make `-fno-lax-vector-conversions`

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

dexonsmith added a comment. In D67678#3446526 , @rsmith wrote: > @dexonsmith @arphaman What do we need to do to get this re-landed? (I'm sorry I missed your ping two years ago :(... I was on an extended leave at the time and never ended up catching up

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

rsmith reopened this revision. rsmith added a comment. This revision is now accepted and ready to land. Herald added a project: All. @dexonsmith @arphaman What do we need to do to get this re-landed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

rsmith added a comment. In D67678#1856229 , @rsmith wrote: > In D67678#1836953 , @dexonsmith > wrote: > >> In D67678#1836922 , @rsmith wrote: >> >>> If there's no timeline

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

rsmith added a comment. In D67678#1836953 , @dexonsmith wrote: > In D67678#1836922 , @rsmith wrote: > > > If there's no timeline to update the macOS SDK, then perhaps we could add a > > hack to Clang to allow

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

dexonsmith added a comment. In D67678#1836922 , @rsmith wrote: > In D67678#1836668 , @dexonsmith > wrote: > > > In D67678#1836628 , @steven_wu > > wrote: > > > > > In

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

rsmith added a comment. In D67678#1836668 , @dexonsmith wrote: > In D67678#1836628 , @steven_wu wrote: > > > In D67678#1834957 , @rsmith wrote: > > > > > In D67678#1834542

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

hans added a comment. I've cherry-picked the revert (edd4398f4cd33a305afbca76ac4e6590e9337f4d ) to the 10.x branch in b079266dcb6d1ee6446d074ebd1d212a13ce0665

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

dexonsmith added a comment. In D67678#1836628 , @steven_wu wrote: > In D67678#1834957 , @rsmith wrote: > > > In D67678#1834542 , @steven_wu > > wrote: > > > > > @rsmith

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

steven_wu added a subscriber: dexonsmith. steven_wu added a comment. In D67678#1834957 , @rsmith wrote: > In D67678#1834542 , @steven_wu wrote: > > > @rsmith This also breaks macOS SDK. Can we revert this as we

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

rsmith added a comment. In D67678#1834957 , @rsmith wrote: > I'll split out the new flag at least and re-land for Clang 10, while we > figure out how to set the default. Looks like there's nothing to re-land here: only the change of default was

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

rsmith added a comment. In D67678#1834542 , @steven_wu wrote: > @rsmith This also breaks macOS SDK. Can we revert this as we discuss a less > aggressive option? (This was already reverted a couple of days ago.) Do you have a timeline for how long it

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

dmajor added a comment. I noticed that this was merged to the 10.0 release branch. Should the merge be reverted while the dust settles on the trunk implementation? FWIW this change breaks code in skia, as used in both Firefox and Chromium. I see that crbug.com/1042470 added the flag as a

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

arphaman added a comment. This also breaks the macOS SDK. @rsmith could you please disable this change for Darwin when you're recommitting this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67678/new/ https://reviews.llvm.org/D67678

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

steven_wu added a comment. @rsmith This also breaks macOS SDK. Can we revert this as we discuss a less aggressive option? Here is an example in macOS SDK (from /usr/include/simd/logic.h): static inline SIMD_CFUNC simd_bool simd_any(simd_int2 x) { return

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

hctim added a comment. This change broke the sanitizer buildbots and was reverted here . Please see here for more information:

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb72a8c65e4e3: PR17164: Change clangs default behavior from -flax-vector-conversions=all to… (authored by Richard Smith richard-l...@metafoo.co.uk, committed by rsmith). Changed prior to commit:

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67678/new/ https://reviews.llvm.org/D67678

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

rsmith added a comment. Herald added a subscriber: wuzish. Ping, I don't think I have any actionable feedback here and I'd like to get this landed before Clang 10 branches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67678/new/

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

rsmith updated this revision to Diff 238099. rsmith added a comment. Herald added subscribers: kbarton, nemanjai. Rebase and slightly expand release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67678/new/ https://reviews.llvm.org/D67678

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

kristof.beyls added inline comments. Comment at: docs/ReleaseNotes.rst:84 + In a future release of Clang, we intend to change the default to + ``-fno-lax-vector-conversions``. + rsmith wrote: > efriedma wrote: > > kristof.beyls wrote: > > > efriedma wrote: > >

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

rsmith marked an inline comment as done. rsmith added inline comments. Comment at: docs/ReleaseNotes.rst:84 + In a future release of Clang, we intend to change the default to + ``-fno-lax-vector-conversions``. + efriedma wrote: > kristof.beyls wrote: > >

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

efriedma added inline comments. Comment at: docs/ReleaseNotes.rst:84 + In a future release of Clang, we intend to change the default to + ``-fno-lax-vector-conversions``. + kristof.beyls wrote: > efriedma wrote: > > rsmith wrote: > > > efriedma wrote: > > > >

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

kristof.beyls added inline comments. Comment at: docs/ReleaseNotes.rst:84 + In a future release of Clang, we intend to change the default to + ``-fno-lax-vector-conversions``. + efriedma wrote: > rsmith wrote: > > efriedma wrote: > > > And if you want to allow

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

efriedma added inline comments. Comment at: docs/ReleaseNotes.rst:84 + In a future release of Clang, we intend to change the default to + ``-fno-lax-vector-conversions``. + rsmith wrote: > efriedma wrote: > > And if you want to allow your code to build with

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

rsmith marked an inline comment as done. rsmith added inline comments. Comment at: docs/ReleaseNotes.rst:84 + In a future release of Clang, we intend to change the default to + ``-fno-lax-vector-conversions``. + efriedma wrote: > And if you want to allow your

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

efriedma added inline comments. Comment at: docs/ReleaseNotes.rst:84 + In a future release of Clang, we intend to change the default to + ``-fno-lax-vector-conversions``. + And if you want to allow your code to build with both clang-9 and clang-10, you have

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

rsmith added a comment. Ping: is fixed, this is now good to go. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67678/new/ https://reviews.llvm.org/D67678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

rsmith updated this revision to Diff 224473. rsmith added a comment. Test fixup. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67678/new/ https://reviews.llvm.org/D67678 Files: docs/CommandGuide/clang.rst docs/ReleaseNotes.rst

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

rsmith updated this revision to Diff 224138. rsmith added a comment. Update documentation and release notes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67678/new/ https://reviews.llvm.org/D67678 Files: docs/CommandGuide/clang.rst docs/ReleaseNotes.rst

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

rsmith updated this revision to Diff 224130. rsmith added a comment. Remove special-casing of ARM NEON; let's wait for to get fixed before landing this. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67678/new/ https://reviews.llvm.org/D67678 Files:

[PATCH] D67678: PR17164: Change clang's default behavior from -flax-vector-conversions=all to -flax-vector-conversions=integer.

rsmith created this revision. rsmith added a reviewer: SjoerdMeijer. Herald added a subscriber: kristof.beyls. Herald added a project: clang. For ARM compilations with NEON enabled, for now we retain the old default of -flax-vector-conversions=all, because our intrinsic header relies on it, and