This revision was automatically updated to reflect the committed changes.
Closed by commit rGd62e3ed3f4b9: [clangd] Implement GetEligiblePoints (authored
by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68024/new/
kadircet updated this revision to Diff 222590.
kadircet marked an inline comment as done.
kadircet added a comment.
- Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68024/new/
https://reviews.llvm.org/D68024
Files:
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
looks good.
Comment at: clang-tools-extra/clangd/unittests/SourceCodeTests.cpp:610
+ /*FullyQualifiedName=*/const char *,
+
kadircet updated this revision to Diff 222434.
kadircet marked 7 inline comments as done.
kadircet added a comment.
- Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68024/new/
https://reviews.llvm.org/D68024
Files:
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/SourceCode.h:270
+ /// It will be “a::b” for both carrot locations.
+ std::string CurrentNamespace;
+ /// Offsets into the code marking eligible points to insert a function
ilya-biryukov
hokein added inline comments.
Comment at: clang-tools-extra/clangd/SourceCode.h:270
+ /// It will be “a::b” for both carrot locations.
+ std::string CurrentNamespace;
+ /// Offsets into the code marking eligible points to insert a function
kadircet wrote:
>
kadircet marked an inline comment as done.
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/SourceCode.h:270
+ /// It will be “a::b” for both carrot locations.
+ std::string CurrentNamespace;
+ /// Offsets into the code marking eligible points to insert a
kadircet marked 3 inline comments as done.
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/SourceCode.cpp:997
+ // definitions as well. One might use a closing parantheses(")" followed by
an
+ // opening brace "{" to trigger the start.
+
hokein added a comment.
The implementation looks good, just have some questions on the API.
Comment at: clang-tools-extra/clangd/SourceCode.cpp:997
+ // definitions as well. One might use a closing parantheses(")" followed by
an
+ // opening brace "{" to trigger the start.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added inline comments.
Comment at: clang-tools-extra/clangd/SourceCode.cpp:996
+ std::vector Enclosing = {""};
+ // FIXME: In addition to namespaces try to generate events for function
+ // definitions as well. One
kadircet marked 5 inline comments as done.
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/SourceCode.cpp:655
+lex(llvm::StringRef Code, const format::FormatStyle ,
+llvm::function_ref A) {
// FIXME: InMemoryFileAdapter crashes unless the buffer is
kadircet updated this revision to Diff 221920.
kadircet marked an inline comment as done.
kadircet added a comment.
- Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68024/new/
https://reviews.llvm.org/D68024
Files:
ilya-biryukov added a comment.
A few go-by comments from me, Haojian should have better context here!
Comment at: clang-tools-extra/clangd/SourceCode.cpp:655
+lex(llvm::StringRef Code, const format::FormatStyle ,
+llvm::function_ref A) {
// FIXME: InMemoryFileAdapter
kadircet updated this revision to Diff 221896.
kadircet added a comment.
- Rename regions to points
- Return EOF if there are no shared namespaces with the target
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D68024/new/
14 matches
Mail list logo
