This revision was automatically updated to reflect the committed changes.
Closed by commit rGdc1499b90dc4: Improve Clang's getting involved document
and make it more inclusive in wording. (authored by chandlerc).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.l
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
lg
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69351/new/
https://reviews.llvm.org/D69351
___
c
chandlerc updated this revision to Diff 226171.
chandlerc marked an inline comment as done.
chandlerc added a comment.
Address feedback from Manuel.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69351/new/
https://reviews.llvm.org/D69351
Files:
chandlerc marked 2 inline comments as done.
chandlerc added a comment.
Thanks, updated.
Comment at: clang/www/get_involved.html:113
+
+ A high-quality implementation: The implementation must fit well into
+ Clang's architecture, follow LLVM's coding conventions, and meet Clan
chandlerc updated this revision to Diff 226174.
chandlerc marked 3 inline comments as done.
chandlerc added a comment.
More fixes from Manuel.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69351/new/
https://reviews.llvm.org/D69351
Files:
clang/
klimek added inline comments.
Comment at: clang/www/get_involved.html:94
+
+ A complete specification: The specification must be sufficient to
+ understand the design of the feature as well as interpret the meaning of
Remove "complete" - the explanation afterwa
chandlerc created this revision.
chandlerc added a reviewer: klimek.
Herald added a subscriber: mcrosier.
Herald added a project: clang.
Working with Meike and others to improve the wording in this document.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D69351
Files:
clang/w