[PATCH] D69959: [C-index] Fix test when using Debug target & MSVC STL

This revision was automatically updated to reflect the committed changes. Closed by commit rGf55cd39f1913: [C-index] Fix test when using Debug target MSVC STL (authored by aganea). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69959/new/

[PATCH] D69959: [C-index] Fix test when using Debug target & MSVC STL

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Related to this discussion, I noticed `to_vector` in STLExtras.h: https://github.com/llvm/llvm-project/blob/e2369fd197d9e/llvm/include/llvm/ADT/STLExtras.h#L1329 I guess that would be the most

[PATCH] D69959: [C-index] Fix test when using Debug target & MSVC STL

dblaikie added inline comments. Comment at: llvm/include/llvm/ADT/SmallVector.h:905 + + const SmallVector =(const std::vector ) { +this->assign(Vec.begin(), Vec.end()); aganea wrote: > dblaikie wrote: > > aganea wrote: > > > rnk wrote: > > > > +@dblaikie,

[PATCH] D69959: [C-index] Fix test when using Debug target & MSVC STL

aganea marked an inline comment as done. aganea added inline comments. Comment at: llvm/include/llvm/ADT/SmallVector.h:905 + + const SmallVector =(const std::vector ) { +this->assign(Vec.begin(), Vec.end()); dblaikie wrote: > aganea wrote: > > rnk wrote: >

[PATCH] D69959: [C-index] Fix test when using Debug target & MSVC STL

dblaikie added inline comments. Comment at: llvm/include/llvm/ADT/SmallVector.h:905 + + const SmallVector =(const std::vector ) { +this->assign(Vec.begin(), Vec.end()); aganea wrote: > rnk wrote: > > +@dblaikie, who knows more about STL container details

[PATCH] D69959: [C-index] Fix test when using Debug target & MSVC STL

aganea updated this revision to Diff 229136. aganea added a comment. Revert everything, but the change to `FrontendOptions::Inputs`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69959/new/ https://reviews.llvm.org/D69959 Files: clang/include/clang/Frontend/FrontendOptions.h

[PATCH] D69959: [C-index] Fix test when using Debug target & MSVC STL

aganea marked 3 inline comments as done. aganea added inline comments. Comment at: clang-tools-extra/clang-move/tool/ClangMove.cpp:113 move::MoveDefinitionSpec Spec; - Spec.Names = {Names.begin(), Names.end()}; + Spec.Names = (std::vector &)Names; Spec.OldHeader =

[PATCH] D69959: [C-index] Fix test when using Debug target & MSVC STL

dblaikie added inline comments. Comment at: clang-tools-extra/clang-move/tool/ClangMove.cpp:113 move::MoveDefinitionSpec Spec; - Spec.Names = {Names.begin(), Names.end()}; + Spec.Names = (std::vector &)Names; Spec.OldHeader = OldHeader; rnk wrote: >

[PATCH] D69959: [C-index] Fix test when using Debug target & MSVC STL

rnk added a subscriber: dblaikie. rnk added a comment. For reference, this is the code sequence that needs the SmallVector change: https://github.com/llvm/llvm-project/blob/99e2cba219aea80b3f11de2aa4e0192b28852de4/clang/lib/Frontend/CompilerInvocation.cpp#L1872 Comment at:

[PATCH] D69959: [C-index] Fix test when using Debug target & MSVC STL

aganea updated this revision to Diff 228971. aganea edited the summary of this revision. aganea added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Using `SmallVector` as requested. The change in SmallVector.h is to support things such as

[PATCH] D69959: [C-index] Fix test when using Debug target & MSVC STL

dexonsmith added a comment. In D69959#1741456 , @rnk wrote: > What do you think of making `FrontendOptions::Inputs` be a `SmallVector<*, > 0>`? It's janky and inconsistent with the rest of that struct, but it seems > less invasive in the end. +1, we

[PATCH] D69959: [C-index] Fix test when using Debug target & MSVC STL

rnk added a comment. I see. You know, these things would be nicely handled if we just had a reliable asynch SEH implementation. >_> What do you think of making `FrontendOptions::Inputs` be a `SmallVector<*, 0>`? It's janky and inconsistent with the rest of that struct, but it seems less

[PATCH] D69959: [C-index] Fix test when using Debug target & MSVC STL

aganea created this revision. aganea added reviewers: STL_MSFT, rnk, dexonsmith. aganea added a project: clang. Herald added subscribers: cfe-commits, arphaman. This is an attempt to fix `clang/test/Index/crash-recovery-modules.m` when compiling a build with the MSVC STL & _ITERATOR_DEBUG_LEVEL