[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

This revision was automatically updated to reflect the committed changes. Closed by commit rG74e6ce2529fa: [Frontend] Allow OpenMP offloading to aarch64 (authored by bryanpkc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70804/new/

[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70804/new/ https://reviews.llvm.org/D70804

[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

bryanpkc updated this revision to Diff 232627. bryanpkc marked 2 inline comments as done. bryanpkc added a comment. Removed unrelated changes from this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70804/new/ https://reviews.llvm.org/D70804

[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

bryanpkc marked 6 inline comments as done. bryanpkc added inline comments. Comment at: clang/test/OpenMP/openmp_offload_registration.cpp:3-5 +// RUN: %clang_cc1 -verify -fopenmp -x c -triple x86_64-unknown-linux-gnu

[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

ABataev added inline comments. Comment at: clang/test/OpenMP/openmp_offload_registration.cpp:3-5 +// RUN: %clang_cc1 -verify -fopenmp -x c -triple x86_64-unknown-linux-gnu -fopenmp-targets=aarch64-unknown-linux-gnu,powerpc64-ibm-linux-gnu -emit-llvm %s -o - | FileCheck %s +//

[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

bryanpkc added inline comments. Comment at: clang/test/OpenMP/target_messages.cpp:4 + +// RUN: not %clang_cc1 -fopenmp -std=c++11 -fopenmp-targets=aaa-bbb-ccc-ddd -o - %s 2>&1 | FileCheck %s // CHECK: error: OpenMP target is invalid: 'aaa-bbb-ccc-ddd' ABataev

[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

ABataev added inline comments. Comment at: clang/test/OpenMP/target_messages.cpp:4 + +// RUN: not %clang_cc1 -fopenmp -std=c++11 -fopenmp-targets=aaa-bbb-ccc-ddd -o - %s 2>&1 | FileCheck %s // CHECK: error: OpenMP target is invalid: 'aaa-bbb-ccc-ddd' Why do

[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

bryanpkc added a comment. Pinging reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70804/new/ https://reviews.llvm.org/D70804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

bryanpkc updated this revision to Diff 231582. bryanpkc added a comment. Add tests for -fopenmp-targets=. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70804/new/ https://reviews.llvm.org/D70804 Files: clang/lib/Frontend/CompilerInvocation.cpp

[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

Hahnfeld added a comment. In D70804#1763443 , @bryanpkc wrote: > In D70804#1763289 , @ABataev wrote: > > > Tests are required > > > The tests for this were added in D30644 , > but

[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

bryanpkc added a comment. In D70804#1763289 , @ABataev wrote: > Tests are required The tests for this were added in D30644 , but they are currently failing on AArch64 due to D32035 .

[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

ABataev requested changes to this revision. ABataev added a comment. This revision now requires changes to proceed. Tests are required Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70804/new/ https://reviews.llvm.org/D70804

[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70804/new/ https://reviews.llvm.org/D70804

[PATCH] D70804: [Frontend] Allow OpenMP offloading to aarch64

bryanpkc created this revision. bryanpkc added reviewers: pawosm01, gtbercea. Herald added subscribers: cfe-commits, guansong, kristof.beyls. Herald added a reviewer: jdoerfert. Herald added a project: clang. D30644 added OpenMP offloading to AArch64 targets,