[PATCH] D72635: Allow arbitrary capability name in Thread Safety Analysis

aaronpuchert added a comment. In D72635#1912501 , @aaron.ballman wrote: > In D72635#1911844 , @aaronpuchert > wrote: > > > In D72635#1911671 , @aaron.ballman > > wrote: >

[PATCH] D72635: Allow arbitrary capability name in Thread Safety Analysis

aaron.ballman added a comment. In D72635#1911844 , @aaronpuchert wrote: > In D72635#1911671 , @aaron.ballman > wrote: > > > However, do we want to diagnose when the capability strings are different? > > > Hmm,

[PATCH] D72635: Allow arbitrary capability name in Thread Safety Analysis

aaronpuchert added a comment. In D72635#1911671 , @aaron.ballman wrote: > However, do we want to diagnose when the capability strings are different? Hmm, interesting question. The way I think about ordering capabilities is this: assuming I have more

[PATCH] D72635: Allow arbitrary capability name in Thread Safety Analysis

aaron.ballman added a comment. In D72635#1911495 , @aaronpuchert wrote: > @aaron.ballman, I've just noted that one of the `-Wthread-safety-attributes` > warnings says > >

[PATCH] D72635: Allow arbitrary capability name in Thread Safety Analysis

aaronpuchert added a comment. @aaron.ballman, I've just noted that one of the `-Wthread-safety-attributes` warnings says > //A// attribute can only be applied in a context annotated with > ‘capability(“mutex”)’

[PATCH] D72635: Allow arbitrary capability name in Thread Safety Analysis

aaron.ballman closed this revision. aaron.ballman added a comment. In D72635#1831782 , @eti-p-doray wrote: > Thanks! > I don't I have commit access. Can you commit on my behalf? Happy to do so! I've commit on your behalf in

[PATCH] D72635: Allow arbitrary capability name in Thread Safety Analysis

eti-p-doray added a comment. Thanks! I don't I have commit access. Can you commit on my behalf? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72635/new/ https://reviews.llvm.org/D72635 ___ cfe-commits mailing list

[PATCH] D72635: Allow arbitrary capability name in Thread Safety Analysis

eti-p-doray updated this revision to Diff 239362. eti-p-doray added a comment. Added test with custom capability name. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72635/new/ https://reviews.llvm.org/D72635 Files: clang/include/clang/Basic/Attr.td

[PATCH] D72635: Allow arbitrary capability name in Thread Safety Analysis

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a minor testing request, thank you! Comment at: clang/test/Sema/attr-capabilities.c:12 -// Test an invalid capability name -struct

[PATCH] D72635: Allow arbitrary capability name in Thread Safety Analysis

eti-p-doray added a comment. Thank you for checking! I updated the changes to lift the restriction. PTAnL? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72635/new/ https://reviews.llvm.org/D72635 ___ cfe-commits mailing list

[PATCH] D72635: Allow arbitrary capability name in Thread Safety Analysis

eti-p-doray updated this revision to Diff 238782. eti-p-doray retitled this revision from "Add "context" capability to Thread Safety Analysis" to "Allow arbitrary capability name in Thread Safety Analysis". eti-p-doray added a comment. Allow arbitrary capability CHANGES SINCE LAST ACTION