[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader added a comment. In D72857#1895649 , @bader wrote: > In D72857#1895625 , @thakis wrote: > > > This landed here: > > https://github.com/llvm/llvm-project/commit/bd97704eb5a95ecb048ce343c1a4be5d94e5 > > >

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

This revision was automatically updated to reflect the committed changes. Closed by commit rGbd97704e: [SYCL] Driver option to select SYCL version (authored by Ruyk, committed by bader). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader added a comment. In D72857#1895625 , @thakis wrote: > This landed here: > https://github.com/llvm/llvm-project/commit/bd97704eb5a95ecb048ce343c1a4be5d94e5 > > It broke tests on mac: http://45.33.8.238/mac/9011/step_7.txt > > Please take a look,

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

thakis added a comment. This landed here: https://github.com/llvm/llvm-project/commit/bd97704eb5a95ecb048ce343c1a4be5d94e5 It broke tests on mac: http://45.33.8.238/mac/9011/step_7.txt Please take a look, and if it takes a while please revert while you investigate. Repository: rG LLVM

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. If no other comments, LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader updated this revision to Diff 246072. bader added a comment. Rebase. Any other comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857 Files: clang/include/clang/Basic/LangOptions.def

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader marked an inline comment as done. bader added inline comments. Comment at: clang/include/clang/Driver/Options.td:3419 +def sycl_std_EQ : Joined<["-"], "sycl-std=">, Group, Flags<[CC1Option, NoArgumentUnused, CoreOption]>, + HelpText<"SYCL language standard to compile

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader updated this revision to Diff 245373. bader marked 12 inline comments as done. bader added a comment. Rebase to ToT and address comments from Ronan. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

keryell added inline comments. Comment at: clang/include/clang/Driver/Options.td:3419 +def sycl_std_EQ : Joined<["-"], "sycl-std=">, Group, Flags<[CC1Option, NoArgumentUnused, CoreOption]>, + HelpText<"SYCL language standard to compile for.">, Values<"2015, 121, 1.2.1,

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader updated this revision to Diff 245213. bader added a comment. Address comments from Victor and Alexey. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857 Files:

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2549 + Opts.SYCLIsDevice = Opts.SYCL && Args.hasArg(options::OPT_fsycl_is_device); + if (Opts.SYCL || Opts.SYCLIsDevice) { +// -sycl-std applies to any SYCL source, not only those

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader marked 3 inline comments as done. bader added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:206 LANGOPT(OpenCLCPlusPlusVersion , 32, 0, "C++ for OpenCL version") +ENUM_LANGOPT(SYCLVersion, SYCLVersionList, 4, SYCLVersionList::undefined,

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

Naghasan added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:206 LANGOPT(OpenCLCPlusPlusVersion , 32, 0, "C++ for OpenCL version") +ENUM_LANGOPT(SYCLVersion, SYCLVersionList, 4, SYCLVersionList::undefined, "Version of the SYCL standard used")

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

Ruyk added a subscriber: Naghasan. Ruyk added a comment. @Naghasan please take a look Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857 ___ cfe-commits mailing

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader marked 2 inline comments as done. bader added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2548 + Opts.SYCL = Args.hasFlag(options::OPT_fsycl, options::OPT_fno_sycl, false); + Opts.SYCLIsDevice = Args.hasArg(options::OPT_fsycl_is_device); + if

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2548 + Opts.SYCL = Args.hasFlag(options::OPT_fsycl, options::OPT_fno_sycl, false); + Opts.SYCLIsDevice = Args.hasArg(options::OPT_fsycl_is_device); + if (Opts.SYCL || Opts.SYCLIsDevice) {

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader marked 2 inline comments as done. bader added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2548 + Opts.SYCL = Args.hasFlag(options::OPT_fsycl, options::OPT_fno_sycl, false); + Opts.SYCLIsDevice = Args.hasArg(options::OPT_fsycl_is_device); + if

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2548 + Opts.SYCL = Args.hasFlag(options::OPT_fsycl, options::OPT_fno_sycl, false); + Opts.SYCLIsDevice = Args.hasArg(options::OPT_fsycl_is_device); + if (Opts.SYCL || Opts.SYCLIsDevice) {

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader marked 2 inline comments as done. bader added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2548 + Opts.SYCL = Args.hasFlag(options::OPT_fsycl, options::OPT_fno_sycl, false); + Opts.SYCLIsDevice = Args.hasArg(options::OPT_fsycl_is_device); + if

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2548 + Opts.SYCL = Args.hasFlag(options::OPT_fsycl, options::OPT_fno_sycl, false); + Opts.SYCLIsDevice = Args.hasArg(options::OPT_fsycl_is_device); + if (Opts.SYCL || Opts.SYCLIsDevice) {

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader marked 3 inline comments as done. bader added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2548 + Opts.SYCL = Args.hasFlag(options::OPT_fsycl, options::OPT_fno_sycl, false); + Opts.SYCLIsDevice = Args.hasArg(options::OPT_fsycl_is_device); + if

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader updated this revision to Diff 243856. bader marked 3 inline comments as done. bader added a comment. Applied review commits from Alexey. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857 Files:

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2548 + Opts.SYCL = Args.hasFlag(options::OPT_fsycl, options::OPT_fno_sycl, false); + Opts.SYCLIsDevice = Args.hasArg(options::OPT_fsycl_is_device); + if (Opts.SYCL || Opts.SYCLIsDevice) {

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader marked an inline comment as done. bader added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2548 + Opts.SYCL = Args.hasFlag(options::OPT_fsycl, options::OPT_fno_sycl, false); + Opts.SYCLIsDevice = Args.hasArg(options::OPT_fsycl_is_device); + if

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2547 + Opts.SYCL = Args.hasFlag(options::OPT_fsycl, options::OPT_fno_sycl, false); + Opts.SYCLIsDevice = Args.hasArg(options::OPT_fsycl_is_device); `-fno-sycl` should not be

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/include/clang/Driver/Options.td:3414-3416 +def fsycl : Flag<["-"], "fsycl">, Group, Flags<[NoArgumentUnused, CoreOption]>, HelpText<"Enable SYCL kernels compilation for device">; +def fno_sycl : Flag<["-"], "fno-sycl">, Group,

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader marked an inline comment as done. bader added inline comments. Comment at: clang/include/clang/Driver/Options.td:3414-3416 +def fsycl : Flag<["-"], "fsycl">, Group, Flags<[NoArgumentUnused, CoreOption]>, HelpText<"Enable SYCL kernels compilation for device">; +def

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader updated this revision to Diff 243173. bader marked 2 inline comments as done. bader added a comment. Applied code review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857 Files:

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/include/clang/Driver/Options.td:3414-3416 +def fsycl : Flag<["-"], "fsycl">, Group, Flags<[NoArgumentUnused, CoreOption]>, HelpText<"Enable SYCL kernels compilation for device">; +def fno_sycl : Flag<["-"], "fno-sycl">, Group,

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader updated this revision to Diff 243029. bader added a comment. Ignore `-sycl-std` if it used in non-SYCL mode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857 Files:

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4030-4031 + if (Arg *A = Args.getLastArg(options::OPT_sycl_std_EQ)) { +A->render(Args, CmdArgs); + } else if (IsSYCL) { bader wrote: > ABataev wrote: > > bader wrote: > > >

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader marked an inline comment as done. bader added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4030-4031 + if (Arg *A = Args.getLastArg(options::OPT_sycl_std_EQ)) { +A->render(Args, CmdArgs); + } else if (IsSYCL) { ABataev wrote:

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4030-4031 + if (Arg *A = Args.getLastArg(options::OPT_sycl_std_EQ)) { +A->render(Args, CmdArgs); + } else if (IsSYCL) { bader wrote: > ABataev wrote: > > Should this option

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader marked 7 inline comments as done. bader added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4030-4031 + if (Arg *A = Args.getLastArg(options::OPT_sycl_std_EQ)) { +A->render(Args, CmdArgs); + } else if (IsSYCL) { ABataev wrote:

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4030-4031 + if (Arg *A = Args.getLastArg(options::OPT_sycl_std_EQ)) { +A->render(Args, CmdArgs); + } else if (IsSYCL) { Should this option also be controlled by `-fsycl`?

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader updated this revision to Diff 242909. bader marked 2 inline comments as done. bader added a comment. Applied Alexey's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857 Files:

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/include/clang/Basic/LangOptions.h:122 + enum class SYCLVersionList { SYCL_2015, SYCL_1_2_1 = SYCL_2015, undefined }; + s/undefined/Undefined/g Comment at:

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

merge_guards_bot added a comment. {icon question-circle color=gray} Unit tests: unknown. {icon check-circle color=green} clang-tidy: pass. {icon times-circle color=red} clang-format: fail. Please format your changes with clang-format by running `git-clang-format HEAD^` or applying this patch

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader updated this revision to Diff 242845. bader added a comment. Applied suggestions from Alexey and Ruyman and rebased on ToT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857 Files:

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

Ruyk added inline comments. Comment at: clang/include/clang/Basic/LangOptions.def:206 LANGOPT(OpenCLCPlusPlusVersion , 32, 0, "C++ for OpenCL version") +ENUM_LANGOPT(SYCLVersion, SYCLVersionList, 4, SYCLVersionList::undefined, "Version of the SYCL standard used")

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/include/clang/Driver/Options.td:3412-3414 +def fsycl : Flag<["-"], "fsycl">, Group, + HelpText<"Enable SYCL kernels compilation for device">; +def sycl_std_EQ : Joined<["-"], "sycl-std=">, Group, Flags<[CC1Option]>,

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader marked an inline comment as done. bader added inline comments. Comment at: clang/include/clang/Driver/Options.td:3412-3414 +def fsycl : Flag<["-"], "fsycl">, Group, + HelpText<"Enable SYCL kernels compilation for device">; +def sycl_std_EQ : Joined<["-"], "sycl-std=">,

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

ABataev added inline comments. Comment at: clang/include/clang/Driver/Options.td:3412-3414 +def fsycl : Flag<["-"], "fsycl">, Group, + HelpText<"Enable SYCL kernels compilation for device">; +def sycl_std_EQ : Joined<["-"], "sycl-std=">, Group, Flags<[CC1Option]>,

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62372 tests passed, 0 failed and 839 were skipped. {icon check-circle color=green} clang-tidy: pass. {icon check-circle color=green} clang-format: pass. Build artifacts

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader updated this revision to Diff 241872. bader added a comment. Fix clang-format and clang-tidy issues reported by merge_guards_bot Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857 Files:

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

merge_guards_bot added a comment. {icon check-circle color=green} Unit tests: pass. 62372 tests passed, 0 failed and 839 were skipped. {icon times-circle color=red} clang-tidy: fail. clang-tidy found 0 errors and 1 warnings

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader updated this revision to Diff 241757. bader added a comment. Applied suggestion from Ruyman. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72857/new/ https://reviews.llvm.org/D72857 Files: clang/include/clang/Basic/LangOptions.def

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader marked 2 inline comments as done. bader added a comment. > Maybe we should use the year of issue (2015 instead of 1.2.1) for the > -sycl-std version? That would be more stable for the upcoming SYCL versions, > and match somehow the C++ versioning. Sounds good to me. I'll update the

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

Ruyk added a comment. Maybe we should use the year of issue (2015 instead of 1.2.1) for the -sycl-std version? That would be more stable for the upcoming SYCL versions, and match somehow the C++ versioning. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D72857: [SYCL] Driver option to enable SYCL mode and select SYCL version

bader created this revision. Herald added subscribers: cfe-commits, Anastasia, ebevhan. Herald added a project: clang. User can select the version of SYCL the compiler will use via the flag -sycl-std, similar to -cl-std. The flag defines the LangOpts.SYCLVersion option to the version of SYCL.