NoQ marked an inline comment as done.
NoQ added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:612
+ return !(Range.getBegin().isMacroID() || Range.getEnd().isMacroID());
+}
+
Charusso wrote:
> Side note: I like the other form of
This revision was automatically updated to reflect the committed changes.
Closed by commit rG482e236e569e: [analyzer] Fix a couple of bugs in HTML report
generation. (authored by dergachev.a).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73993/new/
Charusso accepted this revision.
Charusso added a comment.
This revision is now accepted and ready to land.
Cool, thanks you!
Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:612
+ return !(Range.getBegin().isMacroID() || Range.getEnd().isMacroID());
+}
+
NoQ updated this revision to Diff 242466.
NoQ added a comment.
Aha, that's what those are! Great. I thought they're only for resolving
conflicts with range highlights, which seemed kinda redundant.
Addressed all comments :)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73993/new/
Charusso added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:925
HighlightRange(R, LPosInfo.first, Range);
- }
}
Here the gray highlighting goes, so the `PopUpRanges` store whether we have
already highlighted the range
Charusso added a comment.
Thanks for the fix! The `PopUpRanges` is very important, please revert it back
in its original shape. Sorry for the inconvenience.
I have ran a quick scan-build with this patch on LLVM because I wanted to give
you a real world example (which you cannot visibly see at
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, Charusso.
Herald added subscribers: cfe-commits, dkrupp, donat.nagy, Szelethus,
mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware.
Herald added a project: clang.
This patch fixes an accidental redundant `` and
