[PATCH] D74847: [CodeGen][RISCV] Fix clang/test/CodeGen/atomic_ops.c for RISC-V

This revision was automatically updated to reflect the committed changes. Closed by commit rG0781e93a6eaa: [CodeGen][RISCV] Fix clang/test/CodeGen/atomic_ops.c for RISC-V (authored by luismarques). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D74847: [CodeGen][RISCV] Fix clang/test/CodeGen/atomic_ops.c for RISC-V

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74847/new/ https://reviews.llvm.org/D74847

[PATCH] D74847: [CodeGen][RISCV] Fix clang/test/CodeGen/atomic_ops.c for RISC-V

luismarques updated this revision to Diff 245881. luismarques edited the summary of this revision. luismarques added a comment. Herald added a subscriber: fedor.sergeev. As suggested by @efriedma, the patch was reworked to have one target with native atomics, and one without. No RUN run with a

[PATCH] D74847: [CodeGen][RISCV] Fix clang/test/CodeGen/atomic_ops.c for RISC-V

efriedma added a comment. Yes, makes sense Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74847/new/ https://reviews.llvm.org/D74847 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D74847: [CodeGen][RISCV] Fix clang/test/CodeGen/atomic_ops.c for RISC-V

luismarques added a comment. In D74847#1883028 , @efriedma wrote: > I'm not really a big fan of running tests with the host target triple, > anyway; it seems to create work with almost no benefit. I'd be happy to just > run the test with one target

[PATCH] D74847: [CodeGen][RISCV] Fix clang/test/CodeGen/atomic_ops.c for RISC-V

efriedma added a comment. On a side-note, we could enhance the test runner to support "XFAIL: riscv32-default-target" if we thought it would be useful. But again, I'm not a fan of tests that depend on the default target in the first place. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D74847: [CodeGen][RISCV] Fix clang/test/CodeGen/atomic_ops.c for RISC-V

efriedma added a comment. I'm not really a big fan of running tests with the host target triple, anyway; it seems to create work with almost no benefit. I'd be happy to just run the test with one target that has native atomics, and one target that doesn't. (The relevant code is all

[PATCH] D74847: [CodeGen][RISCV] Fix clang/test/CodeGen/atomic_ops.c for RISC-V

luismarques created this revision. luismarques added reviewers: jyknight, eli.friedman, lenary. Herald added subscribers: cfe-commits, evandro, sameer.abuasal, s.egerton, Jim, benna, psnobl, PkmX, jfb, rkruppe, rogfer01, shiva0217, kito-cheng, simoncook. Herald added a project: clang. By default