[PATCH] D78024: [FileCheck] - Fix the false positive when -implicit-check-not is used with an unknown -check-prefix.

grimar added a comment. In D78024#2087800 , @Higuoxing wrote: > > btw, do you know why FileCheck seems intentionally allows the case when > > --check-prefixes=KNOWN,UNKNOWN? > > I've mentioned in the description of D78110 > >

[PATCH] D78024: [FileCheck] - Fix the false positive when -implicit-check-not is used with an unknown -check-prefix.

Higuoxing added a comment. Herald added a project: LLVM. > btw, do you know why FileCheck seems intentionally allows the case when > --check-prefixes=KNOWN,UNKNOWN? > I've mentioned in the description of D78110 > that there are about 1000 tests that have >

[PATCH] D78024: [FileCheck] - Fix the false positive when -implicit-check-not is used with an unknown -check-prefix.

grimar added a comment. In D78024#1989287 , @probinson wrote: > I'm just reading this review for the first time, and my thought was, why is > this interacting with implicit-check-not? It was interacting (this patch was committed and fixed the issue),

[PATCH] D78024: [FileCheck] - Fix the false positive when -implicit-check-not is used with an unknown -check-prefix.

probinson added a comment. I'm just reading this review for the first time, and my thought was, why is this interacting with implicit-check-not? I think specifying a `--check-prefix=FOO` with no uses of FOO should be diagnosed. I can't say I recall the previous discussion in detail, but

[PATCH] D78024: [FileCheck] - Fix the false positive when -implicit-check-not is used with an unknown -check-prefix.

jdenny marked an inline comment as done. jdenny added inline comments. Comment at: llvm/lib/Support/FileCheck.cpp:1375-1377 + // We do not allow using -implicit-check-not when an explicitly specified + // check prefix is not present in the input buffer. + if

[PATCH] D78024: [FileCheck] - Fix the false positive when -implicit-check-not is used with an unknown -check-prefix.

grimar marked an inline comment as done. grimar added inline comments. Comment at: llvm/lib/Support/FileCheck.cpp:1375-1377 + // We do not allow using -implicit-check-not when an explicitly specified + // check prefix is not present in the input buffer. + if

[PATCH] D78024: [FileCheck] - Fix the false positive when -implicit-check-not is used with an unknown -check-prefix.

jdenny marked an inline comment as done. jdenny added a subscriber: SjoerdMeijer. jdenny added inline comments. Comment at: llvm/lib/Support/FileCheck.cpp:1375-1377 + // We do not allow using -implicit-check-not when an explicitly specified + // check prefix is not present in

[PATCH] D78024: [FileCheck] - Fix the false positive when -implicit-check-not is used with an unknown -check-prefix.

MaskRay added a comment. > btw, do you know why FileCheck seems intentionally allows the case when > --check-prefixes=KNOWN,UNKNOWN? I've mentioned in the description of D78110 > that there are about 1000 tests that have > this. but is it a feature or a

[PATCH] D78024: [FileCheck] - Fix the false positive when -implicit-check-not is used with an unknown -check-prefix.

grimar marked an inline comment as done. grimar added inline comments. Comment at: llvm/lib/Support/FileCheck.cpp:1375-1377 + // We do not allow using -implicit-check-not when an explicitly specified + // check prefix is not present in the input buffer. + if

[PATCH] D78024: [FileCheck] - Fix the false positive when -implicit-check-not is used with an unknown -check-prefix.

This revision was automatically updated to reflect the committed changes. Closed by commit rG65a2de7e6c98: [FileCheck] - Fix the false positive when -implicit-check-not is used with an… (authored by grimar). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to