[PATCH] D78252: [AArch64] FMLA/FMLS patterns improvement.

ilinpv marked an inline comment as done. ilinpv added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:8058 + def : Pat<(v8f16 (OpNode (v8f16 V128:$Rd), (v8f16 V128:$Rn), + (AArch64duplane16 (v8f16 V128:$Rm), +

[PATCH] D78252: [AArch64] FMLA/FMLS patterns improvement.

ab added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:8058 + def : Pat<(v8f16 (OpNode (v8f16 V128:$Rd), (v8f16 V128:$Rn), + (AArch64duplane16 (v8f16 V128:$Rm), +

[PATCH] D78252: [AArch64] FMLA/FMLS patterns improvement.

ilinpv added a comment. Patterns corrected to comply with encoding 4eca1c06a4a9183fcf7bb230d894617caf3cf3be Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78252/new/

[PATCH] D78252: [AArch64] FMLA/FMLS patterns improvement.

ilinpv marked 2 inline comments as done. ilinpv added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:8058 + def : Pat<(v8f16 (OpNode (v8f16 V128:$Rd), (v8f16 V128:$Rn), + (AArch64duplane16 (v8f16 V128:$Rm), +

[PATCH] D78252: [AArch64] FMLA/FMLS patterns improvement.

ab added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:8058 + def : Pat<(v8f16 (OpNode (v8f16 V128:$Rd), (v8f16 V128:$Rn), + (AArch64duplane16 (v8f16 V128:$Rm), +

[PATCH] D78252: [AArch64] FMLA/FMLS patterns improvement.

ilinpv closed this revision. ilinpv added a comment. Committed be881e2831735d6879ee43710f5a4d1c8d50c615 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78252/new/

[PATCH] D78252: [AArch64] FMLA/FMLS patterns improvement.

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. LGTM. Thanks Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:8094 V128:$Rm, VectorIndexS:$idx)>; - def : Pat<(f32 (OpNode (f32 FPR32:$Rd),

[PATCH] D78252: [AArch64] FMLA/FMLS patterns improvement.

ilinpv updated this revision to Diff 259008. ilinpv edited the summary of this revision. ilinpv added a comment. v2f32 pattern removed, test added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78252/new/ https://reviews.llvm.org/D78252 Files:

[PATCH] D78252: [AArch64] FMLA/FMLS patterns improvement.

ilinpv updated this revision to Diff 258865. ilinpv added a comment. Patterns corrected, vector_extract tests added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78252/new/ https://reviews.llvm.org/D78252 Files:

[PATCH] D78252: [AArch64] FMLA/FMLS patterns improvement.

ilinpv marked an inline comment as not done. ilinpv added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:8055 multiclass SIMDFPIndexedTiedPatterns { + let Predicates = [HasNEON, HasFullFP16] in { + // 1 variant for the .8h version: DUPLANE from

[PATCH] D78252: [AArch64] FMLA/FMLS patterns improvement.

dmgreen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:8055 multiclass SIMDFPIndexedTiedPatterns { + let Predicates = [HasNEON, HasFullFP16] in { + // 1 variant for the .8h version: DUPLANE from 128-bit ilinpv wrote: >

[PATCH] D78252: [AArch64] FMLA/FMLS patterns improvement.

ilinpv added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:8055 multiclass SIMDFPIndexedTiedPatterns { + let Predicates = [HasNEON, HasFullFP16] in { + // 1 variant for the .8h version: DUPLANE from 128-bit dmgreen wrote: >

[PATCH] D78252: [AArch64] FMLA/FMLS patterns improvement.

ilinpv updated this revision to Diff 258337. ilinpv marked an inline comment as done. ilinpv edited the summary of this revision. ilinpv added a comment. More patterns added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78252/new/

[PATCH] D78252: [AArch64] FMLA/FMLS patterns improvement.

dmgreen added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:8055 multiclass SIMDFPIndexedTiedPatterns { + let Predicates = [HasNEON, HasFullFP16] in { + // 1 variant for the .8h version: DUPLANE from 128-bit Should we have equal

[PATCH] D78252: [AArch64] FMLA/FMLS patterns improvement.

ilinpv created this revision. ilinpv added reviewers: samparker, dmgreen, SjoerdMeijer. Herald added subscribers: cfe-commits, danielkiss, hiraditya, kristof.beyls. Herald added a project: clang. FMLA/FMLS 8H duplane indexed patterns added. Fixes https://bugs.llvm.org/show_bug.cgi?id=45467