This revision was automatically updated to reflect the committed changes.
Closed by commit rG9d39df03a984: [Clang][Sema] Capturing section type conflicts
between #pragma clang section… (authored by pratlucas).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
pratlucas updated this revision to Diff 262594.
pratlucas added a comment.
Addressing review comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78573/new/
https://reviews.llvm.org/D78573
Files:
clang/include/clang/AST/ASTContext.h
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: clang/include/clang/AST/ASTContext.h:3008
+/// Insertion operator for diagnostics.
+inline const DiagnosticBuilder &
+operator<<(const DiagnosticBuilder ,
pratlucas added a comment.
Ping.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78573/new/
https://reviews.llvm.org/D78573
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
pratlucas updated this revision to Diff 260630.
pratlucas added a comment.
Updateing test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78573/new/
https://reviews.llvm.org/D78573
Files:
clang/include/clang/AST/ASTContext.h
pratlucas marked 4 inline comments as done.
pratlucas added inline comments.
Comment at: clang/include/clang/AST/ASTContext.h:3008
+/// Insertion operator for diagnostics.
+inline const DiagnosticBuilder &
+operator<<(const DiagnosticBuilder ,
rnk wrote:
> It
rnk added inline comments.
Comment at: clang/include/clang/AST/ASTContext.h:3008
+/// Insertion operator for diagnostics.
+inline const DiagnosticBuilder &
+operator<<(const DiagnosticBuilder ,
It seems like there is no need for this to be defined inline, since
pratlucas updated this revision to Diff 259594.
pratlucas added a comment.
Rebasing.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78573/new/
https://reviews.llvm.org/D78573
Files:
clang/include/clang/AST/ASTContext.h
pratlucas updated this revision to Diff 259048.
pratlucas added a comment.
Removing unnecessary function.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78573/new/
https://reviews.llvm.org/D78573
Files:
clang/include/clang/AST/ASTContext.h
pratlucas updated this revision to Diff 259040.
pratlucas added a comment.
Fixing "mising clang-format" messages.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78573/new/
https://reviews.llvm.org/D78573
Files:
pratlucas created this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Conflicting types for the same section name defined in clang section
pragmas and GNU-style section attributes were not properly captured by
Clang's Sema. The lack of diagnostics was caused by
11 matches
Mail list logo