This revision was automatically updated to reflect the committed changes.
Closed by commit rGb593bfd4d8e3: [clang][SveEmitter] SVE builtins for `svusdot`
and `svsudot` ACLE. (authored by fpetrogalli).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D798
efriedma accepted this revision.
efriedma added inline comments.
Comment at: clang/include/clang/Basic/arm_sve.td:1249
+def SVSUDOT_S: SInst<"svsudot[_s32]","ddqb", "i", MergeNone,
"aarch64_sve_usdot", [ReverseUSDOT]>;
+def SVSUDOT_N_S : SInst<"svsudot[_n_s32]",
fpetrogalli marked an inline comment as done.
fpetrogalli added inline comments.
Comment at: clang/include/clang/Basic/arm_sve.td:1249
+def SVSUDOT_S: SInst<"svsudot[_s32]","ddqb", "i", MergeNone,
"aarch64_sve_usdot", [ReverseUSDOT]>;
+def SVSUDOT_N_S : SInst<"svs
fpetrogalli updated this revision to Diff 264735.
fpetrogalli marked an inline comment as done.
fpetrogalli added a comment.
Fix formatting of code in test. NFC
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79877/new/
https://reviews.llvm.org/D7987
fpetrogalli marked 2 inline comments as done.
fpetrogalli added inline comments.
Comment at: clang/include/clang/Basic/arm_sve.td:1249
+def SVSUDOT_S: SInst<"svsudot[_s32]","ddqb", "i", MergeNone,
"aarch64_sve_usdot", [ReverseUSDOT]>;
+def SVSUDOT_N_S : SInst<"svs
efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.
LGTM with one small comment.
Comment at: clang/include/clang/Basic/arm_sve.td:1249
+def SVSUDOT_S: SInst<"svsudot[_s32]","ddqb", "i", MergeNone,
"aarch64_s
fpetrogalli created this revision.
fpetrogalli added reviewers: sdesmalen, efriedma, david-arm.
Herald added subscribers: cfe-commits, kristof.beyls, tschuett.
Herald added a reviewer: rengolin.
Herald added a project: clang.
fpetrogalli added a parent revision: D79639: [SveEmitter] Builtins for SV
