[PATCH] D80692: Run Coverage pass before other *San passes under new pass manager, round 2

This revision was automatically updated to reflect the committed changes. Closed by commit rG1285e8bcac2c: Run Coverage pass before other *San passes under new pass manager, round 2 (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80692: Run Coverage pass before other *San passes under new pass manager, round 2

aeubanks updated this revision to Diff 267087. aeubanks added a comment. Update some CHECKs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80692/new/ https://reviews.llvm.org/D80692 Files: clang/lib/CodeGen/BackendUtil.cpp

[PATCH] D80692: Run Coverage pass before other *San passes under new pass manager, round 2

leonardchan accepted this revision. leonardchan added a comment. In D80692#2061739 , @aeubanks wrote: > I foolishly submitted without running check-all, and it turns out this broke > a test under check-clang. > Looks like https://reviews.llvm.org/D62888

[PATCH] D80692: Run Coverage pass before other *San passes under new pass manager, round 2

aeubanks updated this revision to Diff 267073. aeubanks added a comment. I foolishly submitted without running check-all, and it turns out this broke a test under check-clang. Looks like https://reviews.llvm.org/D62888 added tests in sancov-new-pm.c to make sure that sancov + LTO work together,

[PATCH] D80692: Run Coverage pass before other *San passes under new pass manager, round 2

This revision was automatically updated to reflect the committed changes. Closed by commit rG922fa2fce38b: Run Coverage pass before other *San passes under new pass manager, round 2 (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D80692: Run Coverage pass before other *San passes under new pass manager, round 2

aeubanks added a comment. In D80692#2061219 , @leonardchan wrote: > Would be worthwhile to write a small test that asserts Sancov runs before the > other sanitizers under the new PM? > > Aside from this, LGTM. Asserting that sancov runs before other

[PATCH] D80692: Run Coverage pass before other *San passes under new pass manager, round 2

leonardchan accepted this revision. leonardchan added a comment. This revision is now accepted and ready to land. Would be worthwhile to write a small test that asserts Sancov runs before the other sanitizers under the new PM? Aside from this, LGTM. Comment at:

[PATCH] D80692: Run Coverage pass before other *San passes under new pass manager, round 2

aeubanks marked 2 inline comments as done. aeubanks added inline comments. Comment at: llvm/include/llvm/Passes/PassBuilder.h:597-598 /// /// This extension point allows adding optimizations at the very end of the /// function optimization pipeline. A key difference

[PATCH] D80692: Run Coverage pass before other *San passes under new pass manager, round 2

leonardchan added inline comments. Comment at: llvm/include/llvm/Passes/PassBuilder.h:597-598 /// /// This extension point allows adding optimizations at the very end of the /// function optimization pipeline. A key difference between this and the /// legacy

[PATCH] D80692: Run Coverage pass before other *San passes under new pass manager, round 2

aeubanks created this revision. Herald added subscribers: llvm-commits, cfe-commits, hiraditya. Herald added projects: clang, LLVM. aeubanks added reviewers: vitalybuka, leonardchan. This was attempted once before in https://reviews.llvm.org/D79698, but was reverted due to the coverage pass