Re: [PATCH] D82225: [libTooling] Delete deprecated `Stencil` combinators.

2020-06-25 Thread Fāng-ruì Sòng via cfe-commits
On Thu, Jun 25, 2020 at 5:53 AM Yitzhak Mandelbaum wrote: > > Thanks for alerting me. Why is it important to strip out this information? > Also, might this be something we can change on the arcanist side (to not add > to the commit message) rather than strip out on the git end? Mostly to keep

Re: [PATCH] D82225: [libTooling] Delete deprecated `Stencil` combinators.

2020-06-25 Thread Yitzhak Mandelbaum via cfe-commits
Thanks for alerting me. Why is it important to strip out this information? Also, might this be something we can change on the arcanist side (to not add to the commit message) rather than strip out on the git end? On Wed, Jun 24, 2020 at 3:28 PM Fangrui Song via Phabricator <

[PATCH] D82225: [libTooling] Delete deprecated `Stencil` combinators.

2020-06-24 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Hi, your git commit contains extra Phabricator tags. You can drop `Reviewers:` `Subscribers:` `Tags:` and the text `Summary:` from the git commit with the following script: arcfilter () { arc amend git log -1 --pretty=%B | awk

[PATCH] D82225: [libTooling] Delete deprecated `Stencil` combinators.

2020-06-24 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG87340a2bf1d2: [libTooling] Delete deprecated `Stencil` combinators. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82225/new/

[PATCH] D82225: [libTooling] Delete deprecated `Stencil` combinators.

2020-06-19 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel updated this revision to Diff 272157. ymandel added a comment. fix additional refs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82225/new/ https://reviews.llvm.org/D82225 Files: clang/include/clang/Tooling/Transformer/Stencil.h

[PATCH] D82225: [libTooling] Delete deprecated `Stencil` combinators.

2020-06-19 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel created this revision. ymandel added a reviewer: tdl-g. Herald added a project: clang. Deletes `text()` and `selection()` combinators, since they have been deprecated for months. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D82225 Files: