Re: [PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white, black}list to -fsanitize-coverage-{allow,block}list

On Fri, Jun 19, 2020 at 10:43 PM Fangrui Song via Phabricator < revi...@reviews.llvm.org> wrote: > MaskRay added inline comments. > > > > Comment at: clang/docs/ClangCommandLineReference.rst:891 > > Restrict sanitizer coverage instrumentation exclusively to modules and > function

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a4317bfb319: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize… (authored by MaskRay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

MaskRay added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:891 Restrict sanitizer coverage instrumentation exclusively to modules and functions that match the provided special case list, except the blacklisted ones echristo wrote: >

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

MaskRay updated this revision to Diff 272237. MaskRay marked 4 inline comments as done. MaskRay added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82244/new/ https://reviews.llvm.org/D82244 Files: clang/docs/ClangCom

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

echristo added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:891 Restrict sanitizer coverage instrumentation exclusively to modules and functions that match the provided special case list, except the blacklisted ones MaskRay wrote: >

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:891 Restrict sanitizer coverage instrumentation exclusively to modules and functions that match the provided special case list, except the blacklisted

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Couple of inline comments then looks good to go. Thank you so much for your effort here. -eric Comment at: clang/docs/ClangCommandLineReference.rst:891 Restrict sani

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

MaskRay marked 6 inline comments as done. MaskRay added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:891 Restrict sanitizer coverage instrumentation exclusively to modules and functions that match the provided special case list, except the blacklisted

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

MaskRay updated this revision to Diff 272209. MaskRay marked an inline comment as done. MaskRay added a comment. Fix more words Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82244/new/ https://reviews.llvm.org/D82244 Files: clang/docs/ClangComma

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

echristo added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:313-316 +.. option:: -mharden-sls= + +Select straight-line speculation hardening scope + Miss merge? Comment at: clang/docs/ClangCommandLineReference.rst:891

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

MaskRay updated this revision to Diff 272201. MaskRay added a comment. Fix documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82244/new/ https://reviews.llvm.org/D82244 Files: clang/docs/ClangCommandLineReference.rst clang/docs/Saniti

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

echristo added a reviewer: HAPPY. echristo added a comment. You'll want to grab blacklist/whitelist in the comments around as well. We've been talking about having a need for deprecated aliases file for these options - it's probably worth bringing this patch up on cfe-dev and cc'ing richardsmit

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

MaskRay updated this revision to Diff 272200. MaskRay edited the summary of this revision. MaskRay edited reviewers, added: pcc; removed: HAPPY. MaskRay added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Add aliases Repository: rG LLVM Github Mono

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

MaskRay updated this revision to Diff 272193. MaskRay added a comment. Update more files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82244/new/ https://reviews.llvm.org/D82244 Files: clang/docs/ClangCommandLineReference.rst clang/docs/Saniti

[PATCH] D82244: [SanitizeCoverage] Rename -fsanitize-coverage-{white,black}list to -fsanitize-coverage-{allow,block}list

MaskRay created this revision. MaskRay added reviewers: echristo, mehdi_amini, morehouse. Herald added subscribers: Sanitizers, cfe-commits, aaron.ballman. Herald added projects: clang, Sanitizers. MaskRay updated this revision to Diff 272193. MaskRay added a comment. Update more files Repositor