[PATCH] D82720: [clang-tidy] performance-faster-string-find string-view

This revision was automatically updated to reflect the committed changes. Closed by commit rG2efba0e8122a: [clang-tidy] performance-faster-string-find string-view (authored by njames93). Changed prior to commit: https://reviews.llvm.org/D82720?vs=274200=274512#toc Repository: rG LLVM Github

[PATCH] D82720: [clang-tidy] performance-faster-string-find string-view

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82720/new/ https://reviews.llvm.org/D82720

[PATCH] D82720: [clang-tidy] performance-faster-string-find string-view

njames93 updated this revision to Diff 274200. njames93 added a comment. Update docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82720/new/ https://reviews.llvm.org/D82720 Files:

[PATCH] D82720: [clang-tidy] performance-faster-string-find string-view

aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/performance-faster-string-find.rst:27 + ``::std::basic_string`` and ``::std::basic_string_view`` are considered. + The list of methods to consired is fixed.

[PATCH] D82720: [clang-tidy] performance-faster-string-find string-view

njames93 marked an inline comment as done. njames93 added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/performance-faster-string-find.rst:27 + ``::std::basic_string`` and ``::std::basic_string_view`` are considered. + The list of methods to

[PATCH] D82720: [clang-tidy] performance-faster-string-find string-view

aaron.ballman added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/performance-faster-string-find.rst:27 + ``::std::basic_string`` and ``::std::basic_string_view`` are considered. + The list of methods to consired is fixed. I'm not

[PATCH] D82720: [clang-tidy] performance-faster-string-find string-view

njames93 created this revision. njames93 added reviewers: aaron.ballman, gribozavr2, sbenza, alexfh. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. Extend the default string like classes to include `std::basic_string_view`. Repository: rG LLVM Github Monorepo