[PATCH] D82994: [RFC] Instrumenting Clang/LLVM with Perfetto

Mordante added inline comments. Comment at: clang/include/clang/Basic/CodeGenOptions.def:244 VALUE_CODEGENOPT(TimeTraceGranularity, 32, 500) ///< Minimum time granularity (in microseconds), +CODEGENOPT(Perfetto , 1, 0) ///< Set when -perfetto is enabled.

[PATCH] D82994: [RFC] Instrumenting Clang/LLVM with Perfetto

Nathan-Huckleberry updated this revision to Diff 286866. Nathan-Huckleberry added a comment. - Attach translation unit names to trace processes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82994/new/ https://reviews.llvm.org/D82994 Files: clang

[PATCH] D82994: [RFC] Instrumenting Clang/LLVM with Perfetto

lebedev.ri added inline comments. Comment at: llvm/cmake/modules/AddPerfetto.cmake:9 + ExternalProject_Add(perfetto_git + GIT_REPOSITORY https://github.com/google/perfetto.git + GIT_TAG releases/v4.x nickdesaulniers wrote: > lebedev.ri wrote: > > nickd

[PATCH] D82994: [RFC] Instrumenting Clang/LLVM with Perfetto

nickdesaulniers added inline comments. Comment at: llvm/cmake/modules/AddPerfetto.cmake:9 + ExternalProject_Add(perfetto_git + GIT_REPOSITORY https://github.com/google/perfetto.git + GIT_TAG releases/v4.x lebedev.ri wrote: > nickdesaulniers wrote: > >

[PATCH] D82994: [RFC] Instrumenting Clang/LLVM with Perfetto

lebedev.ri added inline comments. Comment at: llvm/cmake/modules/AddPerfetto.cmake:9 + ExternalProject_Add(perfetto_git + GIT_REPOSITORY https://github.com/google/perfetto.git + GIT_TAG releases/v4.x nickdesaulniers wrote: > lebedev.ri wrote: > > I hav

[PATCH] D82994: [RFC] Instrumenting Clang/LLVM with Perfetto

nickdesaulniers added inline comments. Herald added a subscriber: dang. Comment at: clang/lib/Driver/Driver.cpp:3754 + // We don't need to count the assembler as a job since it doesn't + // cause the memory issue that requires disabling integrated-cc1. lebede

[PATCH] D82994: [RFC] Instrumenting Clang/LLVM with Perfetto

lebedev.ri added a comment. New files are missing standard license header blurb. Also probably missing some tests. Comment at: clang/lib/Driver/Driver.cpp:3754 + // We don't need to count the assembler as a job since it doesn't + // cause the memory issue that requires disa

[PATCH] D82994: [RFC] Instrumenting Clang/LLVM with Perfetto

Nathan-Huckleberry created this revision. Herald added subscribers: llvm-commits, cfe-commits, arphaman, hiraditya, mgorny. Herald added projects: clang, LLVM. Nathan-Huckleberry edited the summary of this revision. Nathan-Huckleberry edited the summary of this revision. Nathan-Huckleberry edited