[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

jansvoboda11 updated this revision to Diff 307837. jansvoboda11 added a comment. Herald added subscribers: llvm-commits, mgorny. Herald added a project: LLVM. Implement review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83211/new/

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

Bigcheese added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3938 + if ((FLAGS)::CC1Option) { \ +const auto = EXTRACTOR(this->KEYPATH); \ +if (ALWAYS_EMIT || Extracted !=

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

Bigcheese accepted this revision. Bigcheese added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3938 + if ((FLAGS)::CC1Option) { \ +const auto = EXTRACTOR(this->KEYPATH); \ +

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4062 + if ((FLAGS)::CC1Option) { \ +const auto = EXTRACTOR(this->KEYPATH); \ +if (ALWAYS_EMIT || Extracted !=

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

dexonsmith requested changes to this revision. dexonsmith added a comment. This revision now requires changes to proceed. Marking as "requested changes" to get this off my queue, but if my lambda suggestion doesn't work well for some reason (maybe it significantly increases compile-time), I'm

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

dexonsmith added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3938 + if ((FLAGS)::CC1Option) { \ +const auto = EXTRACTOR(this->KEYPATH); \ +if (ALWAYS_EMIT || Extracted !=

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

dexonsmith added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:4062 + if ((FLAGS)::CC1Option) { \ +const auto = EXTRACTOR(this->KEYPATH); \ +if (ALWAYS_EMIT || Extracted !=

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

jansvoboda11 updated this revision to Diff 306035. jansvoboda11 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83211/new/ https://reviews.llvm.org/D83211 Files: clang/lib/Frontend/CompilerInvocation.cpp Index:

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

jansvoboda11 added a comment. Addressed review feedback. WDYT @Bigcheese? Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3938 + if ((FLAGS)::CC1Option) { \ +const auto = EXTRACTOR(this->KEYPATH);

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

jansvoboda11 updated this revision to Diff 305437. jansvoboda11 added a comment. Rebase and add documenting possible reference lifetime extension issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83211/new/ https://reviews.llvm.org/D83211

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

jansvoboda11 commandeered this revision. jansvoboda11 added a reviewer: dang. jansvoboda11 added a comment. Taking over this patch as Daniel is no longer involved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83211/new/

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

Bigcheese added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3938 + if ((FLAGS)::CC1Option) { \ +const auto = EXTRACTOR(this->KEYPATH); \ +if (ALWAYS_EMIT || Extracted !=

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

dang updated this revision to Diff 276466. dang added a comment. Rebase on top of latest changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83211/new/ https://reviews.llvm.org/D83211 Files: clang/lib/Frontend/CompilerInvocation.cpp Index:

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83211 Files: clang/lib/Frontend/CompilerInvocation.cpp Index: