[PATCH] D86373: [analyzer] Add modeling for unique_ptr move constructor

This revision was automatically updated to reflect the committed changes. Closed by commit rG1b743a9efa08: [analyzer] Add modeling for unique_ptr move constructor (authored by vrnithinkumar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86373/new/

[PATCH] D86373: [analyzer] Add modeling for unique_ptr move constructor

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Yup, that's more like it!~ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86373/new/ https://reviews.llvm.org/D86373 _

[PATCH] D86373: [analyzer] Add modeling for unique_ptr move constructor

vrnithinkumar marked an inline comment as done. vrnithinkumar added a comment. In D86373#2231605 , @NoQ wrote: > This is easier than D86293 because there's > no old value in the freshly constructed smart pointer, right? I

[PATCH] D86373: [analyzer] Add modeling for unique_ptr move constructor

vrnithinkumar marked an inline comment as done. vrnithinkumar added inline comments. Comment at: clang/test/Analysis/smart-ptr.cpp:295 + P->foo(); // No warning. +} NoQ wrote: > vrnithinkumar wrote: > > I was trying to test the below code. > > ``` > > void foo_

[PATCH] D86373: [analyzer] Add modeling for unique_ptr move constructor

vrnithinkumar added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/SmartPtrModeling.cpp:456 if (BR.isInteresting(ThisRegion) && IsArgValNull) { -OS << "Null pointer value move-assigned to "; +OS << "A null pointer value is moved

[PATCH] D86373: [analyzer] Add modeling for unique_ptr move constructor

vrnithinkumar updated this revision to Diff 288101. vrnithinkumar added a comment. - Refactoring to reuse common duplicated code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86373/new/ https://reviews.llvm.org/D86373 Files: clang/lib/StaticAnal

[PATCH] D86373: [analyzer] Add modeling for unique_ptr move constructor

NoQ added a comment. This is easier than D86293 because there's no old value in the freshly constructed smart pointer, right? I suspect that you can still re-use a lot of the implementation with D86293 , at least partially. =

[PATCH] D86373: [analyzer] Add modeling for unique_ptr move constructor

vrnithinkumar added inline comments. Comment at: clang/test/Analysis/smart-ptr.cpp:295 + P->foo(); // No warning. +} I was trying to test the below code. ``` void foo_() { std::unique_ptr PToMove; std::unique_ptr&& AfterRValeRefCast = std::move(functionRet

[PATCH] D86373: [analyzer] Add modeling for unique_ptr move constructor

vrnithinkumar created this revision. Herald added subscribers: cfe-commits, steakhal, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: clang. vrnithinkumar requested review of this revision.