[PATCH] D87956: [WIP][IR] add fn attr for no_stack_protector; prevent inlining ssp into no-ssp

nickdesaulniers updated this revision to Diff 297970. nickdesaulniers added a comment. - remove modification to docs about legacy fn attr encoding Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87956/new/ https://reviews.llvm.org/D87956 Files:

[PATCH] D87956: [WIP][IR] add fn attr for no_stack_protector; prevent inlining ssp into no-ssp

nickdesaulniers added inline comments. Comment at: llvm/docs/BitCodeFormat.rst:953 base 2 of the requested alignment, plus 1 +* bit 40: ``nossp`` ah, I should remove this; this block is legacy encodings which I do not modify. Comment at:

[PATCH] D87956: [WIP][IR] add fn attr for no_stack_protector; prevent inlining ssp into no-ssp

nickdesaulniers updated this revision to Diff 297969. nickdesaulniers added a comment. - add -passes='cgscc(inline)' to inline_nossp.ll Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87956/new/ https://reviews.llvm.org/D87956 Files:

[PATCH] D87956: [WIP][IR] add fn attr for no_stack_protector; prevent inlining ssp into no-ssp

nickdesaulniers updated this revision to Diff 297967. nickdesaulniers marked 2 inline comments as done. nickdesaulniers added a comment. - address todos and review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87956/new/

[PATCH] D87956: [WIP][IR] add fn attr for no_stack_protector; prevent inlining ssp into no-ssp

nickdesaulniers added inline comments. Comment at: llvm/include/llvm/Bitcode/LLVMBitCodes.h:610 + // TODO: reorder + ATTR_KIND_NO_STACK_PROTECT = 70, ATTR_KIND_STACK_PROTECT = 26, nickdesaulniers wrote: > any comments from reviewers before I go and do a

[PATCH] D87956: [WIP][IR] add fn attr for no_stack_protector; prevent inlining ssp into no-ssp

void added inline comments. Comment at: llvm/lib/Transforms/Utils/InlineFunction.cpp:1679 + // Inlining a function the explicitly should not have a stack protector may + // break the code if inlined into a function that does have a stack s/the/that/

[PATCH] D87956: [WIP][IR] add fn attr for no_stack_protector; prevent inlining ssp into no-ssp

nickdesaulniers added a comment. bumping for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87956/new/ https://reviews.llvm.org/D87956 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D87956: [WIP][IR] add fn attr for no_stack_protector; prevent inlining ssp into no-ssp

nickdesaulniers added inline comments. Comment at: clang/test/CodeGen/stack-protector.c:39 // SAFESTACK-NOSSP: attributes #[[A]] = {{.*}} safestack -// SAFESTACK-NOSSP-NOT: ssp +// SAFESTACK-NOSSP-NOT: attribute #[[A]] = {{.*}} ssp should be `attributes`

[PATCH] D87956: [WIP][IR] add fn attr for no_stack_protector; prevent inlining ssp into no-ssp

nickdesaulniers added a comment. I obviously have a few todos left to resolve, but CC'ing reviewers now for general feedback. One thing I'm unsure of; it felt curious to me that nothing was enforcing that these different levels of stack protection were mutually exclusive. I've added that

[PATCH] D87956: [WIP][IR] add fn attr for no_stack_protector; prevent inlining ssp into no-ssp

nickdesaulniers updated this revision to Diff 293559. nickdesaulniers added a comment. Herald added a reviewer: whitequark. Herald added a reviewer: aaron.ballman. - add tests, make fn attrs mutually exclusive Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D87956: [WIP][IR] add fn attr for no_stack_protector; prevent inlining ssp into no-ssp

nickdesaulniers planned changes to this revision. nickdesaulniers added a comment. Not ready for review yet, posting a WIP fix for https://bugs.llvm.org/show_bug.cgi?id=47479. TODO next week: - tests, tests, and more tests. - interaction with `__attribute__((always_inline))`. - fix TODOs in

[PATCH] D87956: [WIP][IR] add fn attr for no_stack_protector; prevent inlining ssp into no-ssp

nickdesaulniers created this revision. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, steven_wu, hiraditya. Herald added a reviewer: jdoerfert. Herald added projects: clang, LLVM. nickdesaulniers requested review of this revision. It's currently ambiguous in IR whether the