This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa200501bca4d: [clangd] Addusing tweak: find insertion point
after definition (authored by adamcz).
Repository:
rG LLVM Github Monorepo
CHANGES
adamcz added inline comments.
Comment at: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp:201
+ for (const auto : TLDs) {
+if (MustInsertAfterLoc.isValid() &&
+SM.isBeforeInTranslationUnit(TLD->getBeginLoc(), MustInsertAfterLoc))
kadircet
adamcz updated this revision to Diff 307446.
adamcz marked an inline comment as done.
adamcz added a comment.
addressed review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92053/new/
https://reviews.llvm.org/D92053
Files:
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, LGTM
Comment at: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp:158
+
+if (MustInsertAfterLoc.isValid() &&
+
adamcz updated this revision to Diff 307429.
adamcz added a comment.
typo in description
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92053/new/
https://reviews.llvm.org/D92053
Files:
clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp
adamcz created this revision.
Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman.
Herald added a project: clang.
adamcz requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
When type/function is defined in the middle of the file, previuosly we
