[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

jrtc27 added a comment. In D98113#2872080 , @jroelofs wrote: >> compiler-rt depends on a libc, typically newlib, which then depends on your >> compiler > > The builtins should only depend on compiler-provided headers, and not on the > rest of libc.

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

arichardson added a comment. In D98113#2872080 , @jroelofs wrote: >> compiler-rt depends on a libc, typically newlib, which then depends on your >> compiler > > The builtins should only depend on compiler-provided headers, and not on the > rest of libc.

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

jroelofs added a comment. > compiler-rt depends on a libc, typically newlib, which then depends on your > compiler The builtins should only depend on compiler-provided headers, and not on the rest of libc. Agreed re: the rest of compiler-rt. Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

jroelofs added a comment. Why do you want to ship the builtins as part of your sysroot? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98113/new/ https://reviews.llvm.org/D98113 ___ cfe-commits mailing

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

luismarques accepted this revision. luismarques added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98113/new/ https://reviews.llvm.org/D98113

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

jrtc27 added a comment. Ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98113/new/ https://reviews.llvm.org/D98113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

jrtc27 added a comment. In D98113#2634758 , @luismarques wrote: > I just looked at this again and I don't have the full context in my mind > right now but won't the test just exercise the BareMetal toolchain and not > your changes? I've since lost my

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

luismarques added a comment. I just looked at this again and I don't have the full context in my mind right now but won't the test just exercise the BareMetal toolchain and not your changes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

luismarques added a comment. This makes sense to me but I'm not quite sure about the implications, especially when we consider compatibility. I think we need more eyes on this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98113/new/

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

jrtc27 added a comment. In D98113#2610775 , @abidh wrote: > In D98113#2609027 , @jrtc27 wrote: > >> One thing that is currently rather ugly about BareMetal is that it ignores >> the AddArch argument. Once you have

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

abidh added a comment. In D98113#2609027 , @jrtc27 wrote: > One thing that is currently rather ugly about BareMetal is that it ignores > the AddArch argument. Once you have a sysroot, the architecture suffix is > rather unnecessary, and given

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

jrtc27 added a comment. One thing that is currently rather ugly about BareMetal is that it ignores the AddArch argument. Once you have a sysroot, the architecture suffix is rather unnecessary, and given compiler-rt uses LLVM_ENABLE_PER_TARGET_RUNTIME_DIR to decide both whether to add a suffix

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

jrtc27 updated this revision to Diff 328773. jrtc27 added a comment. ... and another accidental change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98113/new/ https://reviews.llvm.org/D98113 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

jrtc27 updated this revision to Diff 328772. jrtc27 added a comment. Dropped unintended change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98113/new/ https://reviews.llvm.org/D98113 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

jrtc27 updated this revision to Diff 328771. jrtc27 added a comment. Added missing file for test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98113/new/ https://reviews.llvm.org/D98113 Files: clang/lib/Driver/ToolChain.cpp

[PATCH] D98113: [Driver] Also search FilePaths for compiler-rt before falling back

jrtc27 created this revision. jrtc27 added reviewers: jroelofs, abidh, manojgupta, asb, luismarques. Herald added subscribers: frasercrmck, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, niosHD, sabuasal, simoncook,