https://github.com/phoebewang closed
https://github.com/llvm/llvm-project/pull/75992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pogo59 wrote:
Thanks for adding the guard to the include adxintrin.h, now that it has only
the ADX stuff it is the right way to go. As PS4 code owner I approve!
https://github.com/llvm/llvm-project/pull/75992
___
cfe-commits mailing list
cfe-commits@l
MaxEW707 wrote:
> Thanks @MaxEW707 ! I don't have other comments now. Do you need help to merge
> it for you?
Thanks for the review :). I don't have commit access so we need someone to
commit the PR for me.
https://github.com/llvm/llvm-project/pull/75992
__
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/75992
>From b6ea2ffe22f414ec79cd9ccd7e47c7b063583bcc Mon Sep 17 00:00:00 2001
From: MaxEW707 <82551778+maxew...@users.noreply.github.com>
Date: Tue, 19 Dec 2023 19:55:21 -0500
Subject: [PATCH 1/5] Move Intel ADC instri
@@ -14,9 +14,6 @@
#ifndef __ADXINTRIN_H
#define __ADXINTRIN_H
-/* Define the default attributes for the functions in this file. */
-#define __DEFAULT_FN_ATTRS __attribute__((__always_inline__, __nodebug__))
RKSimon wrote:
(minor) You could put this back with
phoebewang wrote:
Thanks @MaxEW707 ! I don't have other comments now. Do you need help to merge
it for you?
https://github.com/llvm/llvm-project/pull/75992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/75992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -580,8 +580,7 @@ _storebe_i64(void * __P, long long __D) {
#include
#endif
-/* Some intrinsics inside adxintrin.h are available only on processors with
ADX,
- * whereas others are also available at all times. */
MaxEW707 wrote:
Confirmed that Intel ADX i
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/75992
>From b6ea2ffe22f414ec79cd9ccd7e47c7b063583bcc Mon Sep 17 00:00:00 2001
From: MaxEW707 <82551778+maxew...@users.noreply.github.com>
Date: Tue, 19 Dec 2023 19:55:21 -0500
Subject: [PATCH 1/4] Move Intel ADC instri
@@ -580,8 +580,7 @@ _storebe_i64(void * __P, long long __D) {
#include
#endif
-/* Some intrinsics inside adxintrin.h are available only on processors with
ADX,
- * whereas others are also available at all times. */
phoebewang wrote:
I think comment is good.
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/75992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/75992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/75992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 edited
https://github.com/llvm/llvm-project/pull/75992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -580,8 +580,7 @@ _storebe_i64(void * __P, long long __D) {
#include
#endif
-/* Some intrinsics inside adxintrin.h are available only on processors with
ADX,
- * whereas others are also available at all times. */
MaxEW707 wrote:
> add comment for adcintri
@@ -580,8 +580,7 @@ _storebe_i64(void * __P, long long __D) {
#include
#endif
-/* Some intrinsics inside adxintrin.h are available only on processors with
ADX,
- * whereas others are also available at all times. */
phoebewang wrote:
Sorry, just noticed this
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/75992
>From b6ea2ffe22f414ec79cd9ccd7e47c7b063583bcc Mon Sep 17 00:00:00 2001
From: MaxEW707 <82551778+maxew...@users.noreply.github.com>
Date: Tue, 19 Dec 2023 19:55:21 -0500
Subject: [PATCH 1/3] Move Intel ADC instri
@@ -92,136 +92,11 @@ __INLINE unsigned char
}
#endif
-/* Intrinsics that are also available if __ADX__ is undefined. */
-
-/// Adds unsigned 32-bit integers \a __x and \a __y, plus 0 or 1 as indicated
-///by the carry flag \a __cf. Stores the unsigned 32-bit sum in the mem
https://github.com/phoebewang approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/75992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/75992
>From b6ea2ffe22f414ec79cd9ccd7e47c7b063583bcc Mon Sep 17 00:00:00 2001
From: MaxEW707 <82551778+maxew...@users.noreply.github.com>
Date: Tue, 19 Dec 2023 19:55:21 -0500
Subject: [PATCH 1/2] Move Intel ADC instri
@@ -0,0 +1,160 @@
+/*=== adxintrin.h - ADX intrinsics -===
phoebewang wrote:
adx -> adc
https://github.com/llvm/llvm-project/pull/75992
___
cfe-commits mailing list
cfe-commits@l
llvmbot wrote:
@llvm/pr-subscribers-backend-x86
Author: Max Winkler (MaxEW707)
Changes
See https://github.com/llvm/llvm-project/pull/75711 for discussion.
As a summary from the PR above, `` includes adc intrinsics
and adx intrinsics.
To support MSVC STL we need to expose the
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Max Winkler (MaxEW707)
Changes
See https://github.com/llvm/llvm-project/pull/75711 for discussion.
As a summary from the PR above, `` includes adc intrinsics
and adx intrinsics.
To support MSVC STL we need to expose the adc i
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it i
https://github.com/MaxEW707 created
https://github.com/llvm/llvm-project/pull/75992
See https://github.com/llvm/llvm-project/pull/75711 for discussion.
As a summary from the PR above, `` includes adc intrinsics and adx
intrinsics.
To support MSVC STL we need to expose the adc intrinsics inside
25 matches
Mail list logo
