https://github.com/vgvassilev approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/86727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aytey wrote:
> > @weliveindetail @vgvassilev @junaire: sorry for pinging you directly, but
> > could you take a look at this PR? I see you're all active on other
> > `clang-repl` PRs, so thought you might be the best place to start to take a
> > look at this one 🤞
>
> Hi, thanks for the PR. I
junaire wrote:
> @weliveindetail @vgvassilev @junaire: sorry for pinging you directly, but
> could you take a look at this PR? I see you're all active on other
> `clang-repl` PRs, so thought you might be the best place to start to take a
> look at this one 🤞
Hi, thanks for the PR. I think the
aytey wrote:
@weliveindetail @vgvassilev @junaire: sorry for pinging you directly, but could
you take a look at this PR? I see you're all active on other `clang-repl` PRs,
so thought you might be the best place to start to take a look at this one 🤞
https://github.com/llvm/llvm-project/pull/86
https://github.com/aytey updated https://github.com/llvm/llvm-project/pull/86727
>From 480d77eb88df2abc589c4be90ceab200cb3fac98 Mon Sep 17 00:00:00 2001
From: "Andrew V. Teylu"
Date: Tue, 26 Mar 2024 20:10:24 +
Subject: [PATCH 1/2] [clang-repl] Add call to 'InitializeAllAsmParsers'
Signed-o
aytey wrote:
```avj@host /tmp/clang_build$ ./bin/llvm-lit -v
/tmp/llvm-project/clang/test/Interpreter/inline-asm.cpp
llvm-lit: /tmp/llvm-project/llvm/utils/lit/lit/llvm/config.py:502: note: using
clang: /tmp/clang_build/bin/clang
-- Testing: 1 tests, 1 workers --
PASS: Clang :: Interpreter/inli
https://github.com/aytey updated https://github.com/llvm/llvm-project/pull/86727
>From 784dd45324566775439b3c06674ab7d70b292d0b Mon Sep 17 00:00:00 2001
From: "Andrew V. Teylu"
Date: Tue, 26 Mar 2024 20:10:24 +
Subject: [PATCH 1/2] [clang-repl] Add call to 'InitializeAllAsmParsers'
Signed-o
aytey wrote:
> This my first PR against LLVM; does something like this need tests? I'm 100%
> happy to add tests for this, but are there some examples of "good"
> `clang-repl` tests I can learn from/extend from?
Maybe this is reasonable:
```cpp
// REQUIRES: host-supports-jit, x86_64-linux
//
aytey wrote:
This my first PR against LLVM; does something like this need tests? I'm 100%
happy to add tests for this, but are there some examples of "good" `clang-repl`
tests I can learn from/extend from?
https://github.com/llvm/llvm-project/pull/86727
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Andrew V. Teylu (aytey)
Changes
This PR fixes the following issue when working with `clang-repl`:
```
fatal error: error in backend: Inline asm not supported by this streamer
because we don't have an asm parser for this target
```
When w
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
https://github.com/aytey created https://github.com/llvm/llvm-project/pull/86727
This PR fixes the following issue when working with `clang-repl`:
```
fatal error: error in backend: Inline asm not supported by this streamer
because we don't have an asm parser for this target
```
When working w
12 matches
Mail list logo
