https://github.com/ChuanqiXu9 closed
https://github.com/llvm/llvm-project/pull/69551
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/benlangmuir approved this pull request.
https://github.com/llvm/llvm-project/pull/69551
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -666,13 +666,19 @@ static StringRef
makeAbsoluteAndPreferred(CompilerInstance , StringRef Path,
}
void ModuleDepCollector::addFileDep(StringRef Path) {
- llvm::SmallString<256> Storage;
- Path = makeAbsoluteAndPreferred(ScanInstance, Path, Storage);
+ // Within P1689
https://github.com/ChuanqiXu9 updated
https://github.com/llvm/llvm-project/pull/69551
>From 6ee8058b3ce5c8c64fd21109407f8a081dc64df5 Mon Sep 17 00:00:00 2001
From: Chuanqi Xu
Date: Mon, 30 Oct 2023 11:51:04 +0800
Subject: [PATCH] [clang-scan-deps] [P1689] Keep consistent behavior for make
@@ -666,13 +666,19 @@ static StringRef
makeAbsoluteAndPreferred(CompilerInstance , StringRef Path,
}
void ModuleDepCollector::addFileDep(StringRef Path) {
- llvm::SmallString<256> Storage;
- Path = makeAbsoluteAndPreferred(ScanInstance, Path, Storage);
+ // Within P1689
ChuanqiXu9 wrote:
> Thanks for the ping, I had missed your question
>
> > How do you think about the idea to add a flag to the MDC about whether or
> > not calling makeAbsoluteAndPreferred?
>
> SGTM; this seems like a good compromise since we can't easily extract this
> into the consumer.
https://github.com/ChuanqiXu9 updated
https://github.com/llvm/llvm-project/pull/69551
>From c91007b51e164d22c8f73a864105494ebc10a004 Mon Sep 17 00:00:00 2001
From: Chuanqi Xu
Date: Mon, 30 Oct 2023 11:51:04 +0800
Subject: [PATCH] [clang-scan-deps] [P1689] Keep consistent behavior for make
benlangmuir wrote:
Thanks for the ping, I had missed your question
> How do you think about the idea to add a flag to the MDC about whether or not
> calling makeAbsoluteAndPreferred?
SGTM; this seems like a good compromise since we can't easily extract this into
the consumer.
ChuanqiXu9 wrote:
@benlangmuir ping~
https://github.com/llvm/llvm-project/pull/69551
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ChuanqiXu9 wrote:
> Is the issue with MDC's FileDeps that we are calling
> `makeAbsoluteAndPreferred` on the paths? Maybe we could instead move that
> call into `FullDependencyConsumer`. Or are there other issues?
>
> The fact we need to add additional `MDC.IsStdModuleP1689Format` checks in
https://github.com/benlangmuir commented:
Is the issue with MDC's FileDeps that we are calling `makeAbsoluteAndPreferred`
on the paths? Maybe we could instead move that call into
`FullDependencyConsumer`. Or are there other issues?
The fact we need to add additional
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Chuanqi Xu (ChuanqiXu9)
Changes
Close https://github.com/llvm/llvm-project/issues/69439.
This patch tries to reuse the codes to generate make style dependencies
information with P1689 format directly.
---
Full diff:
https://github.com/ChuanqiXu9 created
https://github.com/llvm/llvm-project/pull/69551
Close https://github.com/llvm/llvm-project/issues/69439.
This patch tries to reuse the codes to generate make style dependencies
information with P1689 format directly.
>From
13 matches
Mail list logo
