Re: [PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

2020-07-10 Thread Eric Christopher via cfe-commits
lla.com; > john.rea...@vmssoftware.com; ztur...@roblox.com; ...@gmail.com; > llvm-commits ; > stefan.reinal...@molecular-matters.com; Ulrich Weigand < > ulrich.weig...@de.ibm.com>; mlek...@skidmore.edu; Clang Commits < > cfe-commits@lists.llvm.org>; Han Shen > *Objet

RE: [PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

2020-07-10 Thread Alexandre Ganea via cfe-commits
; Amy Huang ; dma...@mozilla.com; john.rea...@vmssoftware.com; ztur...@roblox.com; ...@gmail.com; llvm-commits ; stefan.reinal...@molecular-matters.com; Ulrich Weigand ; mlek...@skidmore.edu; Clang Commits ; Han Shen Objet : Re: [PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

Re: [PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

2020-07-10 Thread Eric Christopher via cfe-commits
You'll probably want the assert as well: assert.h assertion failed at llvm-project/llvm/lib/MC/MCStreamer.cpp:134 in virtual void llvm::MCStreamer::emitIntValue(uint64_t, unsigned int): (isUIntN(8 * Size, Value) || isIntN(8 * Size, Value)) && "Invalid size" On Fri, Jul 10, 2020 at 4:03 PM Eric Ch

Re: [PATCH] D80833: [CodeView] Add full repro to LF_BUILDINFO record

2020-07-10 Thread Eric Christopher via cfe-commits
I'm seeing tests fail with a crash. Can we revert the patch and attempted fixes and start working from there? Stacktrace for the curious :) @ 0x56420187cbbe llvm::MCStreamer::emitIntValue() @ 0x5641fec38899 llvm::MCStreamer::emitInt16() @ 0x5641ff73b337 llvm::CodeViewDe