RE: [ReviewRequest] [Sema/Parser] GCC Compatibility Patch: Support for __final specifier

2016-07-28 Thread Keane, Erich via cfe-commits
gt;> Cc: cfe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org> Subject: Re: [ReviewRequest] [Sema/Parser] GCC Compatibility Patch: Support for __final specifier I'd rename VS_Alt_Final to VS_GNU_Final. On Mon, Jul 25, 2016 at 2:24 PM, Keane, Erich via cfe-commits mailto:cfe-

RE: [ReviewRequest] [Sema/Parser] GCC Compatibility Patch: Support for __final specifier

2016-07-25 Thread Keane, Erich via cfe-commits
Done! Attached a new diff. From: David Majnemer [mailto:david.majne...@gmail.com] Sent: Monday, July 25, 2016 1:18 PM To: Keane, Erich Cc: cfe-commits@lists.llvm.org Subject: Re: [ReviewRequest] [Sema/Parser] GCC Compatibility Patch: Support for __final specifier You've added a co

Re: [ReviewRequest] [Sema/Parser] GCC Compatibility Patch: Support for __final specifier

2016-07-25 Thread David Majnemer via cfe-commits
d diff file. > > > > *From:* David Majnemer [mailto:david.majne...@gmail.com] > *Sent:* Monday, July 25, 2016 12:40 PM > *To:* Keane, Erich > *Cc:* cfe-commits@lists.llvm.org > *Subject:* Re: [ReviewRequest] [Sema/Parser] GCC Compatibility Patch: > Support for __final specif

RE: [ReviewRequest] [Sema/Parser] GCC Compatibility Patch: Support for __final specifier

2016-07-25 Thread Keane, Erich via cfe-commits
Compatibility Patch: Support for __final specifier I'd rename VS_Alt_Final to VS_GNU_Final. On Mon, Jul 25, 2016 at 2:24 PM, Keane, Erich via cfe-commits mailto:cfe-commits@lists.llvm.org>> wrote: Hi all, my first potential-contribution, so I apologize if I’m submitting this impr

Re: [ReviewRequest] [Sema/Parser] GCC Compatibility Patch: Support for __final specifier

2016-07-25 Thread David Majnemer via cfe-commits
I'd rename VS_Alt_Final to VS_GNU_Final. On Mon, Jul 25, 2016 at 2:24 PM, Keane, Erich via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi all, my first potential-contribution, so I apologize if I’m submitting > this improperly, I’m unfamiliar with the ‘type’ keys that you use in the > topi