Re: [PATCH] D27763: Debug Info: Modified DIBuilder::createCompileUnit() to take DIFile instead of FileName and Directory. (Clang part)

2016-12-19 Thread David Blaikie via cfe-commits
Ah, sure - no worries. Good to mention/link to the other change, etc, in the future. (if the changes on the clang side are trivial enough to not need review, may not need to send them out for review either - or could include them as an addendum to the llvm change ("oh, and here's what it looks

RE: [PATCH] D27763: Debug Info: Modified DIBuilder::createCompileUnit() to take DIFile instead of FileName and Directory. (Clang part)

2016-12-19 Thread Aboud, Amjad via cfe-commits
It was approved by Reid. This patch had two parts, he did not stamp the change in Clang, but he did stamp the change for LLVM. https://reviews.llvm.org/D27762 I assumed that this means a green light to commit. Did I misinterpret the rules? Thanks, Amjad From: David Blaikie

Re: [PATCH] D27763: Debug Info: Modified DIBuilder::createCompileUnit() to take DIFile instead of FileName and Directory. (Clang part)

2016-12-19 Thread David Blaikie via cfe-commits
Was this change approved by anyone? Generally once it's sent for review, you should wait until it's approved before committing (the assumption being, if you sent it for review it's because it needed review) On Wed, Dec 14, 2016 at 12:49 PM Amjad Aboud via Phabricator via cfe-commits