Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies

2019-07-16 Thread Shoaib Meenai via cfe-commits
Makes sense, thanks. Seems like INTERFACE is the way to go then. From: on behalf of Chris Bieneman Date: Tuesday, July 16, 2019 at 10:32 AM To: Shoaib Meenai Cc: Alex Bradbury , cfe-commits Subject: Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies I get that CMake does

Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies

2019-07-16 Thread Chris Bieneman via cfe-commits
> Date: Friday, July 12, 2019 at 9:08 AM > To: Shoaib Meenai > Cc: Alex Bradbury , cfe-commits > Subject: Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies > > Ah! I see what is going on here. This is kinda a silliness of CMake. > `PRIVATE` linkage for a

Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies

2019-07-12 Thread Shoaib Meenai via cfe-commits
of Chris Bieneman Date: Friday, July 12, 2019 at 9:08 AM To: Shoaib Meenai Cc: Alex Bradbury , cfe-commits Subject: Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies Ah! I see what is going on here. This is kinda a silliness of CMake. `PRIVATE` linkage for a static archive

Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies

2019-07-12 Thread Shoaib Meenai via cfe-commits
Reverted in r365922. From: on behalf of Chris Bieneman Date: Friday, July 12, 2019 at 9:08 AM To: Shoaib Meenai Cc: Alex Bradbury , cfe-commits Subject: Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies Ah! I see what is going on here. This is kinda a silliness of CMake

Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies

2019-07-12 Thread Shoaib Meenai via cfe-commits
Meenai Cc: Alex Bradbury , cfe-commits Subject: Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies Ah! I see what is going on here. This is kinda a silliness of CMake. `PRIVATE` linkage for a static archive is silly, and shouldn't be possible. All link dependencies for static

Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies

2019-07-12 Thread Chris Bieneman via cfe-commits
Bradbury mailto:a...@lowrisc.org>> > Date: Friday, July 12, 2019 at 2:02 AM > To: Shoaib Meenai mailto:smee...@fb.com>> > Cc: cfe-commits <mailto:cfe-commits@lists.llvm.org>> > Subject: Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies > &g

Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies

2019-07-12 Thread Shoaib Meenai via cfe-commits
, 2019 at 8:49 AM To: Shoaib Meenai Cc: Alex Bradbury , cfe-commits Subject: Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies One of the benefits of the object library approach for generating the clang dylib is that it was compatible with BUILD_SHARED_LIBS. We had lots

Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies

2019-07-12 Thread Chris Bieneman via cfe-commits
Should we disable building the latter if the former is set? > > From: Alex Bradbury > Date: Friday, July 12, 2019 at 2:02 AM > To: Shoaib Meenai > Cc: cfe-commits > Subject: Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies > > On Thu, 11 Jul 20

Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies

2019-07-12 Thread Shoaib Meenai via cfe-commits
-shlib] Fix clang-shlib for PRIVATE dependencies On Thu, 11 Jul 2019 at 22:20, Shoaib Meenai via cfe-commits mailto:cfe-commits@lists.llvm.org>> wrote: Author: smeenai Date: Thu Jul 11 14:20:38 2019 New Revision: 365825 URL: https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewv

Re: r365825 - [clang-shlib] Fix clang-shlib for PRIVATE dependencies

2019-07-12 Thread Alex Bradbury via cfe-commits
On Thu, 11 Jul 2019 at 22:20, Shoaib Meenai via cfe-commits wrote: > > Author: smeenai > Date: Thu Jul 11 14:20:38 2019 > New Revision: 365825 > > URL: http://llvm.org/viewvc/llvm-project?rev=365825=rev > Log: > [clang-shlib] Fix clang-shlib for PRIVATE dependencies > > Any static library with a