Re: [PATCH] D12489: [clang-format] Fixed missing space between Obj-C for/in and a typecast

klimek added a comment. In the future, please add cfe-commits as subscriber on the initial post, otherwise the initial email will not go to the mailing list. Thx! http://reviews.llvm.org/D12489 ___ cfe-commits mailing list

Re: [PATCH] D12508: [libcxx] Make it drastically simpler to link libc++.

jroelofs added inline comments. Comment at: utils/gen_link_script/gen_link_script.py:1 @@ +1,2 @@ +#!/usr/bin/env python +import os Do you foresee these linker scripts being significantly more complicated for other platforms? ISTM that it would be much simpler

[libcxx] r246772 - Make a helper routine __throw_future_error, and encapsulate the #ifdef _LIBCPP_NO_EXCEPTIONS there, instead of duplicating it throughout the code. No functionality change

Author: marshall Date: Thu Sep 3 10:11:32 2015 New Revision: 246772 URL: http://llvm.org/viewvc/llvm-project?rev=246772=rev Log: Make a helper routine __throw_future_error, and encapsulate the #ifdef _LIBCPP_NO_EXCEPTIONS there, instead of duplicating it throughout the code. No functionality

Re: [PATCH] D12402: PR24595: clang-cl fails to compile vswriter.h header from Windows SDK 8.1 in 32 bit mode

andreybokhanko marked 4 inline comments as done. Comment at: lib/Sema/SemaType.cpp:5873-5877 @@ +5872,7 @@ + return; + +ToCC = DefaultCC; + +// Issue a warning on ignored calling convention -- except of __stdcall. +// Again, this is what MS compiler does. +if

Re: [PATCH] D11182: [OPENMP 4.0] Initial support for 'omp declare reduction' construct.

ABataev added a comment. Ping http://reviews.llvm.org/D11182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12471: Correct documentation for numSelectorArgs matcher

klimek added a reviewer: dfsuther. klimek added a comment. +Dean, as I really don't know Obj-C (sorry for the delay in reply, was on vacation) http://reviews.llvm.org/D12471 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12402: PR24595: clang-cl fails to compile vswriter.h header from Windows SDK 8.1 in 32 bit mode

rnk added inline comments. Comment at: lib/Sema/SemaType.cpp:5855-5856 @@ -5854,3 +5854,4 @@ CallingConv CurCC = FT->getCallConv(); - CallingConv FromCC = + CallingConv DefaultCC = Context.getDefaultCallingConvention(IsVariadic, IsStatic); + CallingConv ToCC;

Re: [PATCH] D12489: [clang-format] Fixed missing space between Obj-C for/in and a typecast

klimek added a comment. Oh, and you'll want to add tests :) unittests/Format/FormatTest.cpp http://reviews.llvm.org/D12489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12402: PR24595: clang-cl fails to compile vswriter.h header from Windows SDK 8.1 in 32 bit mode

andreybokhanko updated this revision to Diff 33945. andreybokhanko added a comment. Patch updated after fixing all (but one) of Reid's comments. http://reviews.llvm.org/D12402 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/DeclSpec.h include/clang/Sema/Sema.h

Re: [PATCH] D12547: Add support for function attribute "disable_tail_calls"

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:894 @@ -893,1 +893,3 @@ +def DisableTailCalls : InheritableAttr { + let Spellings = [GNU<"disable_tail_calls">, Pardon me if this is obvious, but -- are there times when you would

Re: [PATCH] D12547: Add support for function attribute "disable_tail_calls"

Oops, apologies for making this harder than it needs to be. It seems phab didn't provide context to these comments. Check out the phab review link for more context, if you'd like it. ~Aaron On Thu, Sep 3, 2015 at 9:48 AM, Aaron Ballman wrote: > aaron.ballman added

Patch for PR23472

http://llvm.org/pr23472 As suggested by Reid, OK to commit? Index: tools/clang/lib/CodeGen/ItaniumCXXABI.cpp === --- tools/clang/lib/CodeGen/ItaniumCXXABI.cpp (revision 246575) +++ tools/clang/lib/CodeGen/ItaniumCXXABI.cpp

Re: [PATCH] D12022: Refactored dtor sanitizing into EHScopeStack

nmusgrave updated this revision to Diff 33959. nmusgrave added a comment. - Refined testing for bit fields. http://reviews.llvm.org/D12022 Files: lib/CodeGen/CGCXX.cpp lib/CodeGen/CGClass.cpp lib/CodeGen/CodeGenModule.h test/CodeGenCXX/sanitize-dtor-bit-field.cpp

Re: Patch for PR23472

I fully trust Reid review on this, so OK with me. On 3 September 2015 at 14:04, Yaron Keren wrote: > http://llvm.org/pr23472 > > As suggested by Reid, OK to commit? > ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12580: Added StrictVTablePointers linking requirement

Prazek added a comment. I see that CGObjCMac.cpp names it like this: "Objective-C Garbage Collection" http://reviews.llvm.org/D12580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12594: [X86-64] Allow additional register names in inline assembler.

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. If you could interleave the test and the check I'd really appreciate it, e.g.: __asm__ ("mov r8w, 100;"); // CHECK: call void asm sideeffect "mov r8w, 100;" Otherwise LGTM. Thanks!

r246795 - Add -target flag to Clang invocations in this test.

Author: samsonov Date: Thu Sep 3 14:11:42 2015 New Revision: 246795 URL: http://llvm.org/viewvc/llvm-project?rev=246795=rev Log: Add -target flag to Clang invocations in this test. ASan may not be supported for the default target triple. Modified:

Re: [PATCH] D11976: [libclang] Return deduced type for auto type, not the one written in the source.

klimek closed this revision. klimek added a comment. Submitted as r246778. http://reviews.llvm.org/D11976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11797: [LIbClang] Report the named type for ElaboratedType

klimek added a subscriber: klimek. klimek added a comment. Is this still ready for submission or do you want to change something (not clear after your last comment :) http://reviews.llvm.org/D11797 ___ cfe-commits mailing list

Re: [PATCH] D12489: [clang-format] Fixed missing space between Obj-C for/in and a typecast

ksuther updated this revision to Diff 33947. ksuther added a comment. Added two tests: One of a for/in loop with a cast, and one without. http://reviews.llvm.org/D12489 Files: lib/Format/TokenAnnotator.cpp unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp

Re: [PATCH] D12580: Added StrictVTablePointers linking requirement

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D12580 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12119: Analyzer: Fix a crasher in UbigraphViz

ismailp added a comment. Ping! http://reviews.llvm.org/D12119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r246804 - Add target flag to clang-cl invocation in this test.

Author: samsonov Date: Thu Sep 3 15:53:14 2015 New Revision: 246804 URL: http://llvm.org/viewvc/llvm-project?rev=246804=rev Log: Add target flag to clang-cl invocation in this test. Modified: cfe/trunk/test/Driver/fsanitize-coverage.c Modified: cfe/trunk/test/Driver/fsanitize-coverage.c

Re: [PATCH] D12022: Refactored dtor sanitizing into EHScopeStack

rsmith added inline comments. Comment at: lib/CodeGen/CGCXX.cpp:140-147 @@ -131,1 +139,10 @@ + // If sanitizing memory to check for use-after-dtor, do not emit as + // an alias, unless this class owns no members with trivial destructors. + const CXXMethodDecl *MD = +

Re: [PATCH] fix parentheses location in a CXXConstructExpr

On Thursday 3. September 2015 13:41:12 Richard Smith wrote: > On Thu, Sep 3, 2015 at 8:58 AM, Manuel Klimek wrote: > > On Tue, Sep 1, 2015 at 12:31 AM Olivier Goffart wrote: > >> On Monday 31. August 2015 08:07:58 Manuel Klimek wrote: > >> > On Sat, Aug 29,

Re: [PATCH] D12002: Initial WebAssembly support in clang

echristo added inline comments. Comment at: lib/Basic/Targets.cpp:7643-7649 @@ +7642,9 @@ + case llvm::Triple::wasm64: +// Until specific variations are defined, don't permit any. +if (!(Triple == llvm::Triple("wasm64-unknown-unknown")) || +

Re: [PATCH] D12022: Refactored dtor sanitizing into EHScopeStack

nmusgrave updated this revision to Diff 33978. nmusgrave marked 4 inline comments as done. nmusgrave added a comment. - Simplified fields and checks for aliasing. http://reviews.llvm.org/D12022 Files: lib/CodeGen/CGCXX.cpp lib/CodeGen/CGClass.cpp lib/CodeGen/CodeGenModule.h

Re: Patch for PR23472

LGTM, but I would expand on the comment a bit: // The ABI says: "It is suggested that it be emitted in the same COMDAT group // as the associated data object." In practice, this doesn't work for non-ELF object formats, so only do it for ELF. On Thu, Sep 3, 2015 at 11:31 AM, Rafael

Re: [PATCH] fix parentheses location in a CXXConstructExpr

On Thu, Sep 3, 2015 at 8:58 AM, Manuel Klimek wrote: > On Tue, Sep 1, 2015 at 12:31 AM Olivier Goffart wrote: > >> On Monday 31. August 2015 08:07:58 Manuel Klimek wrote: >> > On Sat, Aug 29, 2015 at 12:23 PM Olivier Goffart via cfe-commits < >> > >> >

Re: [PATCH] fix parentheses location in a CXXConstructExpr

On Thu, Sep 3, 2015 at 2:26 PM, Olivier Goffart wrote: > On Thursday 3. September 2015 13:41:12 Richard Smith wrote: > > On Thu, Sep 3, 2015 at 8:58 AM, Manuel Klimek wrote: > > > On Tue, Sep 1, 2015 at 12:31 AM Olivier Goffart > wrote: >

Re: [PATCH] D12358: [Analyzer] Handling constant bound loops

krememek added a comment. In http://reviews.llvm.org/D12358#238303, @seaneveson wrote: > In http://reviews.llvm.org/D12358#237099, @krememek wrote: > > > To get the conservative invalidation that Anna suggests (actually, a little > > less conservative), I think you can just pass in a two

Re: [PATCH] D12244: Implement ACLE 2.0 macros of chapters 6.4 and 6.5 for [ARM] and [Aarch64] targets

rengolin added a comment. Hi Alexandros, Sorry, I was on holidays. Apart from my comment, everything else looks good. cheers, --renato Comment at: lib/Basic/Targets.cpp:4790 @@ +4789,3 @@ + Builder.defineMacro("__ARM_FEATURE_SAT", "1"); +

r246748 - [OPENMP 4.1] Codegen for extended format of 'if' clause.

Author: abataev Date: Thu Sep 3 03:45:56 2015 New Revision: 246748 URL: http://llvm.org/viewvc/llvm-project?rev=246748=rev Log: [OPENMP 4.1] Codegen for extended format of 'if' clause. Fixed codegen for extended format of 'if' clauses with special 'directive-name-modifier' + ast-print tests for

Re: [PATCH] D12148: [ARM] Allow passing/returning of __fp16 arguments

rengolin accepted this revision. rengolin added a reviewer: rengolin. rengolin added a comment. This revision is now accepted and ready to land. LGTM, thanks! http://reviews.llvm.org/D12148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r246747 - [OPENMP 4.1] Parsing/sema analysis for extended format of 'if' clause.

Author: abataev Date: Thu Sep 3 02:23:48 2015 New Revision: 246747 URL: http://llvm.org/viewvc/llvm-project?rev=246747=rev Log: [OPENMP 4.1] Parsing/sema analysis for extended format of 'if' clause. OpenMP 4.1 added special 'directive-name-modifier' to the 'if' clause. Format of 'if' clause is

Re: [PATCH] D12358: [Analyzer] Handling constant bound loops

seaneveson updated this revision to Diff 33906. seaneveson added a comment. Refactored into a new file: LoopWidening.cpp (and LoopWidening.h). Added an analyzer-config option, which defaults to false: widen-constant-bound-loops=false Modified analyzer-config tests to check for the new option.

libtooling and ast matchers owners

After Aaron updated the clang-tools-extra owners, I looked at the clang owners and noticed that I'm not in there for libtooling and ast matchers. Doug suggested 3 years back that I should be in there, but apparently I forgot to update it. Anybody raising objections to me putting myself in for

Re: [PATCH] D12244: Implement ACLE 2.0 macros of chapters 6.4 and 6.5 for [ARM] and [Aarch64] targets

rengolin added a comment. Also, the target parser code has changed, please make sure it still works with the new version. http://reviews.llvm.org/D12244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12445: [Static Analyzer] Remove sinks from nullability checks.

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. LGTM. Thanks! Anna. http://reviews.llvm.org/D12445 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D10833: Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface

RedX2501 added a comment. Ping http://reviews.llvm.org/D10833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r246755 - [ARM] Allow passing/returning of __fp16 arguments

Author: olista01 Date: Thu Sep 3 04:34:53 2015 New Revision: 246755 URL: http://llvm.org/viewvc/llvm-project?rev=246755=rev Log: [ARM] Allow passing/returning of __fp16 arguments The ACLE (ARM C Language Extensions) 2.0 allows the __fp16 type to be used as a functon argument or return type

Re: [PATCH] D12148: [ARM] Allow passing/returning of __fp16 arguments

olista01 closed this revision. olista01 added a comment. Thanks, committed as r246755. http://reviews.llvm.org/D12148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12400: Fix store detection for return value in CGCall

kuhar updated this revision to Diff 33919. kuhar added a comment. Some refactoring + comments added. Repository: rL LLVM http://reviews.llvm.org/D12400 Files: lib/CodeGen/CGCall.cpp test/CodeGen/arm_function_epilog.cpp Index: test/CodeGen/arm_function_epilog.cpp

Re: [PATCH] D12597: Two more fixes to loop convert.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg http://reviews.llvm.org/D12597 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r246760 - Revert 246755 as it breaks buildbots

Author: olista01 Date: Thu Sep 3 06:46:24 2015 New Revision: 246760 URL: http://llvm.org/viewvc/llvm-project?rev=246760=rev Log: Revert 246755 as it breaks buildbots Original commit message: [ARM] Allow passing/returning of __fp16 arguments The ACLE (ARM C Language Extensions) 2.0 allows the

Re: r246755 - [ARM] Allow passing/returning of __fp16 arguments

On 3 September 2015 at 10:34, Oliver Stannard via cfe-commits wrote: > Author: olista01 > Date: Thu Sep 3 04:34:53 2015 > New Revision: 246755 > > URL: http://llvm.org/viewvc/llvm-project?rev=246755=rev > Log: > [ARM] Allow passing/returning of __fp16 arguments > >

Re: [PATCH] D12148: [ARM] Allow passing/returning of __fp16 arguments

olista01 updated this revision to Diff 33932. olista01 added a comment. Don't make this change for OpenCL, which handles the half type natively. http://reviews.llvm.org/D12148 Files: lib/Basic/Targets.cpp lib/CodeGen/TargetInfo.cpp lib/Driver/Tools.cpp test/CodeGen/arm-fp16-arguments.c

Re: [PATCH] D12022: Refactored dtor sanitizing into EHScopeStack

nmusgrave updated this revision to Diff 33982. nmusgrave marked 2 inline comments as done. nmusgrave added a comment. - Clean method headers, style. http://reviews.llvm.org/D12022 Files: lib/CodeGen/CGCXX.cpp lib/CodeGen/CGClass.cpp lib/CodeGen/CodeGenModule.h

[PATCH] D12614: [OpenMP] Offloading descriptor registration and device codegen.

sfantao created this revision. sfantao added reviewers: ABataev, rjmccall, hfinkel, tra. sfantao added a subscriber: cfe-commits. In order to offloading work properly two things need to be in place: - a descriptor with all the offloading information (device entry functions, and global variable)

Re: [PATCH] D12616: Failing test highlighting no poisoning if dtor undeclared.

eugenis added inline comments. Comment at: test/CodeGenCXX/sanitize-dtor-generated.cpp:5 @@ +4,3 @@ + +// TODO Success pending on resolution of issue 596 +// XFAIL: * Add the link to the issue. Comment at:

r246830 - Fix a potential APInt memory leak when using __attribute__((flag_enum)), and

Author: rsmith Date: Thu Sep 3 20:03:03 2015 New Revision: 246830 URL: http://llvm.org/viewvc/llvm-project?rev=246830=rev Log: Fix a potential APInt memory leak when using __attribute__((flag_enum)), and simplify the implementation a bit. Modified: cfe/trunk/include/clang/Basic/Attr.td

Re: [PATCH] D12002: Initial WebAssembly support in clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL246814: [WebAssembly] Initial WebAssembly support in clang (authored by djg). Changed prior to commit: http://reviews.llvm.org/D12002?vs=33637=33985#toc Repository: rL LLVM

r246814 - [WebAssembly] Initial WebAssembly support in clang

Author: djg Date: Thu Sep 3 17:51:53 2015 New Revision: 246814 URL: http://llvm.org/viewvc/llvm-project?rev=246814=rev Log: [WebAssembly] Initial WebAssembly support in clang This implements basic support for compiling (though not yet assembling or linking) for a WebAssembly target. Note that

[PATCH] D12619: [Static Analyzer] Minor cleanups for the nullability checker.

xazax.hun created this revision. xazax.hun added reviewers: dcoughlin, zaks.anna. xazax.hun added a subscriber: cfe-commits. This patch contains minor cleanups and style fixes for the nullability checker. NFC. http://reviews.llvm.org/D12619 Files:

[PATCH] D12616: Failing test highlighting no poisoning if dtor undeclared.

nmusgrave created this revision. nmusgrave added reviewers: eugenis, kcc. nmusgrave added a subscriber: cfe-commits. If class or struct has not declared a destructor, no destsructor is emitted, and members are not poisoned after destruction. This case highlights bug in current implementation of

Re: [PATCH] D12022: Refactored dtor sanitizing into EHScopeStack

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM with a couple of tweaks. Comment at: lib/CodeGen/CGCXX.cpp:45-46 @@ +44,4 @@ + // an alias, unless this class owns no members. + unsigned totalFields = +

Re: [PATCH] D12002: Initial WebAssembly support in clang

sunfishcode added inline comments. Comment at: lib/Basic/Targets.cpp:7643-7649 @@ +7642,9 @@ + case llvm::Triple::wasm64: +// Until specific variations are defined, don't permit any. +if (!(Triple == llvm::Triple("wasm64-unknown-unknown")) || +

Re: [PATCH] D12087: always_inline codegen rewrite

eugenis added a comment. In http://reviews.llvm.org/D12087#239243, @yaron.keren wrote: > In CGCXX.cpp, may be fixable after this commit: > > // FIXME: An extern template instantiation will create functions with > // linkage "AvailableExternally". In libc++, some classes also define > //

Re: [PATCH] D12594: [X86-64] Allow additional register names in inline assembler.

This revision was automatically updated to reflect the committed changes. Closed by commit rL246835: [X86-64] Allow additional register names in inline assembler. (authored by ABataev). Changed prior to commit: http://reviews.llvm.org/D12594?vs=33926=34011#toc Repository: rL LLVM

Re: [PATCH] D1623: Support __builtin_ms_va_list.

cdavis5x updated this revision to Diff 34012. cdavis5x added a comment. Address @rsmith's comments. http://reviews.llvm.org/D1623 Files: include/clang/AST/ASTContext.h include/clang/AST/Expr.h include/clang/Basic/BuiltinsX86.def include/clang/Basic/DiagnosticSemaKinds.td

Re: [PATCH] D1623: Support __builtin_ms_va_list.

cdavis5x added inline comments. Comment at: include/clang/AST/Expr.h:3709 @@ -3708,3 +3708,3 @@ VAArgExpr(SourceLocation BLoc, Expr* e, TypeSourceInfo *TInfo, -SourceLocation RPLoc, QualType t) +SourceLocation RPLoc, QualType t, bool IsMS = false)

Re: Patch for PR23472

r246803, thanks! 2015-09-03 23:16 GMT+03:00 Reid Kleckner : > LGTM, but I would expand on the comment a bit: > // The ABI says: "It is suggested that it be emitted in the same > COMDAT group > // as the associated data object." In practice, this doesn't work for >

[PATCH] D12622: [Shave]: add a -MT option to moviCompile if there wasn't one

dougk created this revision. dougk added a reviewer: chandlerc. dougk added a subscriber: cfe-commits. http://reviews.llvm.org/D12622 Files: lib/Driver/Tools.cpp test/Driver/shave-toolchain.c Index: test/Driver/shave-toolchain.c

[PATCH] D12627: Fix a small bug in clang where generating some temporary files would have an extra period before the extension.

dirty created this revision. dirty added a reviewer: akyrtzi. dirty added a subscriber: cfe-commits. Fix a small bug in clang where generating some temporary files would have an extra period before the extension. http://reviews.llvm.org/D12627 Files: lib/ARCMigrate/FileRemapper.cpp

Re: [PATCH] D12244: Implement ACLE 2.0 macros of chapters 6.4 and 6.5 for [ARM] and [Aarch64] targets

rengolin added inline comments. Comment at: lib/Basic/Targets.cpp:4790 @@ +4789,3 @@ + Builder.defineMacro("__ARM_FEATURE_SAT", "1"); + Builder.defineMacro("__ARM_FEATURE_QBIT", "1"); +} labrinea wrote: > rengolin wrote: > > Isn't there a

Re: [PATCH] D12244: Implement ACLE 2.0 macros of chapters 6.4 and 6.5 for [ARM] and [Aarch64] targets

labrinea added a comment. This means accepted? http://reviews.llvm.org/D12244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D12598: clang should emulate GCC's -fabi-version=

steleman created this revision. steleman added a subscriber: cfe-commits. This changeset provides an implementation of GCC's -fabi-version= flag. -fabi-version is documented at GCC here: https://gcc.gnu.org/onlinedocs/gcc/C_002b_002b-Dialect-Options.html GCC implements it here:

[clang-tools-extra] r246762 - Two more fixes to loop convert.

Author: angelgarcia Date: Thu Sep 3 07:28:11 2015 New Revision: 246762 URL: http://llvm.org/viewvc/llvm-project?rev=246762=rev Log: Two more fixes to loop convert. Summary: Ensure that the alias has the same type than the loop variable. Now it works with lambda captures. Reviewers: klimek

Re: [PATCH] D12148: [ARM] Allow passing/returning of __fp16 arguments

rengolin added a comment. I don't like the idea of making it language-specific, but I don't have a better idea. I don't know if there are support flags in Clang's languages like we have for back-ends. Anyway, this should fix the current problem. Maybe adding a comment to that effect on the

Re: [PATCH] D12148: [ARM] Allow passing/returning of __fp16 arguments

olista01 added a comment. Committed as r246764, with an additional comment explaining why we don't do this for OpenCL. http://reviews.llvm.org/D12148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D12619: [Static Analyzer] Minor cleanups for the nullability checker.

Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. Why static was removed from getMostNullable() and getNullabilityString()? If these functions are not intended to be used outside this source file, it's good idea to limit their scope. Same should be done for

Re: [PATCH] D12619: [Static Analyzer] Minor cleanups for the nullability checker.

xazax.hun added a comment. They are in the anonymous namespace. Maybe it would be cleaner to move them outside of the namespace and preserve the static keyword? http://reviews.llvm.org/D12619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org