Re: [PATCH] D15411: [clang-tidy] Check for suspicious string assignments.

alexfh added a comment. In http://reviews.llvm.org/D15411#307274, @aaron.ballman wrote: > In http://reviews.llvm.org/D15411#307030, @alexfh wrote: > > > BTW, Richard, is the possibility of assignment of an integer to a > > std::string a bug in the standard? > > > This is the result of: > >

Re: [PATCH] D15411: [clang-tidy] Check for suspicious string assignments.

alexfh added inline comments. Comment at: clang-tidy/misc/StringIntegerAssignmentCheck.cpp:45 @@ +44,3 @@ + + auto Diag = diag(Loc, "probably missing to_string operation"); + if (!Loc.isMacroID() && getLangOpts().CPlusPlus11) { I'd expand the message with an

r255267 - [Modules] Fix regression when an elaborated-type-specifier mentions a hidden tag

Author: benlangmuir Date: Thu Dec 10 11:28:51 2015 New Revision: 255267 URL: http://llvm.org/viewvc/llvm-project?rev=255267=rev Log: [Modules] Fix regression when an elaborated-type-specifier mentions a hidden tag This makes non-C++ languages find the same decl as C++ does to workaround a

Re: [PATCH] D15366: [Clang] Use autos in lib/AST/ASTImporter.cpp

Eugene.Zelenko added inline comments. Comment at: lib/AST/ASTImporter.cpp:5855 @@ -5888,3 +5854,3 @@ } - else if (ObjCProtocolDecl *PD = dyn_cast(D)) { + else if (auto *PD = dyn_cast(D)) { if (!PD->getDefinition()) aaron.ballman wrote: > Can you fix the

r255288 - [Sema] Replace pointer-to-map with a map. NFC.

Author: gbiv Date: Thu Dec 10 13:25:21 2015 New Revision: 255288 URL: http://llvm.org/viewvc/llvm-project?rev=255288=rev Log: [Sema] Replace pointer-to-map with a map. NFC. Modified: cfe/trunk/lib/Sema/AnalysisBasedWarnings.cpp Modified: cfe/trunk/lib/Sema/AnalysisBasedWarnings.cpp URL:

Re: [PATCH] D15030: [clang-tidy] add check cppcoreguidelines-pro-bounds-constant-array-index

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. With the fix for Alex's last comment, LGTM! http://reviews.llvm.org/D15030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D15411: [clang-tidy] Check for suspicious string assignments.

aaron.ballman added inline comments. Comment at: clang-tidy/misc/StringIntegerAssignmentCheck.cpp:19 @@ +18,3 @@ +namespace { +AST_MATCHER(QualType, isAnyCharacter) { return Node->isAnyCharacterType(); } +} // namespace I think this would be reasonable to add to

Re: [PATCH] D15388: [Clang] Use autos in lib/AST/Expr.cpp

aaron.ballman added inline comments. Comment at: lib/AST/Expr.cpp:67 @@ -65,3 +66,3 @@ E = CE->getSubExpr(); -CXXRecordDecl *Derived +auto *Derived = cast(E->getType()->getAs()->getDecl()); Again, I don't think it is an

Re: [PATCH] D15366: [Clang] Use autos in lib/AST/ASTImporter.cpp

aaron.ballman added inline comments. Comment at: lib/AST/ASTImporter.cpp:1676 @@ -1690,3 +1675,3 @@ QualType ASTNodeImporter::VisitTypedefType(const TypedefType *T) { - TypedefNameDecl *ToDecl + const auto *ToDecl =

Re: [PATCH] D15400: [Clang] Use autos in lib/AST/Type.cpp

aaron.ballman added inline comments. Comment at: lib/AST/Type.cpp:2016 @@ -2019,3 +2015,3 @@ case Type::Record: -if (CXXRecordDecl *ClassDecl +if (const auto *ClassDecl = dyn_cast(cast(CanonicalType)->getDecl())) Not certain this is an

Re: [PATCH] D15388: [Clang] Use autos in lib/AST/Expr.cpp

aaron.ballman added inline comments. Comment at: lib/AST/Expr.cpp:3715 @@ -3741,3 +3714,3 @@ assert(D.Kind == Designator::ArrayDesignator && "Requires array designator"); - Stmt *const *SubExprs = reinterpret_cast(this + 1); + auto SubExprs = reinterpret_cast(this + 1);

r255281 - Do not generate DW_TAG_imported_module for anonymous namespaces (even nested) for all the platforms except PS4.

Author: kromanova Date: Thu Dec 10 12:52:50 2015 New Revision: 255281 URL: http://llvm.org/viewvc/llvm-project?rev=255281=rev Log: Do not generate DW_TAG_imported_module for anonymous namespaces (even nested) for all the platforms except PS4. For PS4, generate explicit import for anonymous

Re: [PATCH] D15388: [Clang] Use autos in lib/AST/Expr.cpp

Eugene.Zelenko added inline comments. Comment at: lib/AST/Expr.cpp:1956 @@ -1967,1 +1955,3 @@ +for (const auto : InitExprs) { + if (Stmt *S = I) { Beg = S->getLocStart(); aaron.ballman wrote: > Is this line still required? I thought InitExprs

r255231 - Add parentheses to suppress a -Wparentheses warning.

Author: ctopper Date: Thu Dec 10 02:49:55 2015 New Revision: 255231 URL: http://llvm.org/viewvc/llvm-project?rev=255231=rev Log: Add parentheses to suppress a -Wparentheses warning. Modified: cfe/trunk/lib/Sema/SemaTemplateDeduction.cpp Modified: cfe/trunk/lib/Sema/SemaTemplateDeduction.cpp

[PATCH] D15410: AnalysisConsumer: use canonical decl for both lookup and store of visited decls

a.sidorin created this revision. a.sidorin added reviewers: zaks.anna, xazax.hun, dcoughlin. a.sidorin added a subscriber: cfe-commits. a.sidorin set the repository for this revision to rL LLVM. Due to redeclarations, the function may have different declarations used in CallExpr and in the

Re: [PATCH] D12726: [analyzer] A fix for symbolic element region index lifetime.

This revision was automatically updated to reflect the committed changes. Closed by commit rL255236: [analyzer] Fix symbolic element index lifetime. (authored by dergachev). Changed prior to commit: http://reviews.llvm.org/D12726?vs=37267=42400#toc Repository: rL LLVM

Re: [PATCH] D15087: [PATCH] Add CERT license clarification

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. Danny's OK is enough for me. LGTM http://reviews.llvm.org/D15087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r255232 - [Sema] Use UnaryOperatorKind and BinaryOperatorKind in parameter lists instead of just unsigned. Removes a few explicit casts. NFC

Author: ctopper Date: Thu Dec 10 02:51:49 2015 New Revision: 255232 URL: http://llvm.org/viewvc/llvm-project?rev=255232=rev Log: [Sema] Use UnaryOperatorKind and BinaryOperatorKind in parameter lists instead of just unsigned. Removes a few explicit casts. NFC Modified:

Re: [PATCH] D14274: Add alloc_size attribute to clang

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:714 @@ +713,3 @@ + let Spellings = [GCC<"alloc_size">]; + let Subjects = SubjectList<[Function]>; + let Args = [IntArgument<"ElemSizeParam">, IntArgument<"NumElemsParam", 1>]; Should

Re: [PATCH] D9600: Add scan-build python implementation

rizsotto.mailinglist marked an inline comment as done. Comment at: tools/scan-build-py/bin/analyze-c++:2 @@ +1,3 @@ +#!/usr/bin/env python +# -*- coding: utf-8 -*- +# The LLVM Compiler Infrastructure zaks.anna wrote: > Where/How is analyze-c++

[PATCH] D15432: [libcxx] Move member function definition before it's explicit template instantiation declaration in to satisfy GCC.

EricWF created this revision. EricWF added reviewers: mclow.lists, rsmith, eugenis. EricWF added subscribers: cfe-commits, rsmith. GCC fail's to compile a number of tests because three valarray member functions cannot be inlined at various points throughout the header. This is an error because

r255297 - www: Mention -DGCC_INSTALL_PREFIX instead of --with-gcc-toolchain

Author: bogner Date: Thu Dec 10 14:52:59 2015 New Revision: 255297 URL: http://llvm.org/viewvc/llvm-project?rev=255297=rev Log: www: Mention -DGCC_INSTALL_PREFIX instead of --with-gcc-toolchain Since the instructions use cmake, we should probably refer to the cmake flags and not the configure

Re: [PATCH] D9600: Add scan-build python implementation

dcoughlin added inline comments. Comment at: tools/scan-build-py/libear/ear.c:140 @@ +139,3 @@ +#ifdef HAVE_NSGETENVIRON +environ = *_NSGetEnviron(); +#endif The issue I am seeing with library-interposition on OS X seems to be caused by eagerly stashing

[PATCH] D15433: [libcxx] Remove inline/visibility attributes from exported template methods in valarray.

eugenis created this revision. eugenis added a reviewer: EricWF. eugenis added a subscriber: cfe-commits. eugenis set the repository for this revision to rL LLVM. This does not affect the libc++ export list now. It is required for internal_linkage switch to not affect the libc++ export list. This

Re: [PATCH] D14411: Use __attribute__((internal_linkage)) when available.

eugenis added dependencies: D15433: [libcxx] Remove inline/visibility attributes from exported template methods in valarray., D15432: [libcxx] Move member function definition before it's explicit template instantiation declaration in to satisfy GCC.. eugenis added a comment. Depends on

Re: [PATCH] D15225: [Driver] Sanitizer support based on runtime library presence

samsonov added inline comments. Comment at: test/Driver/fsanitize.c:221 @@ +220,3 @@ +// RUN: %clang -target x86_64-apple-darwin10 -resource-dir=%S/Inputs/resource_dir -fsanitize=memory -fsanitize=thread,memory %s -### 2>&1 | FileCheck %s

Re: [libcxx] Reinstate and fix overload sets to be const-correct wherever possible

On Thu, Dec 10, 2015 at 11:45 AM, Marshall Clow wrote: > On Tue, Dec 8, 2015 at 3:52 PM, Richard Smith >> wrote: >> >>> Ping. >>> >> > Sorry about that. > Completely missed this in my email flood. > > This approach looks ok to me, but I wonder if it

r255309 - Objective-C properties: merge attributes when redeclaring 'readonly' as 'readwrite' in an extension.

Author: dgregor Date: Thu Dec 10 17:02:09 2015 New Revision: 255309 URL: http://llvm.org/viewvc/llvm-project?rev=255309=rev Log: Objective-C properties: merge attributes when redeclaring 'readonly' as 'readwrite' in an extension. r251874 stopped back-patching the AST when an Objective-C

Re: [libcxx] Reinstate and fix overload sets to be const-correct wherever possible

Fwiw, if you ever here me gripe about the C++ committee’s poor record of messing around in the C headers with detrimental effects, this is what I’m referring to. Yes, the C++ signatures are superior. No, this wasn’t a good thing to do. The C++ committee should not try to change or delete

Re: [PATCH] D14411: Use __attribute__((internal_linkage)) when available.

eugenis added a comment. With http://reviews.llvm.org/D15434, there is no difference in libc++ export list with the switch to internal_linkage. Repository: rL LLVM http://reviews.llvm.org/D14411 ___ cfe-commits mailing list

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

hubert.reinterpretcast added a comment. I would like to see a test: __float128 qf(); long double ldf(); long double ld{qf()}; // error: narrowing __float128 q{ldf()}; // passes Comment at: include/clang/Basic/TargetInfo.h:384 @@ +383,3 @@ + unsigned

Re: [PATCH] D15163: Attach maximum function count to Module when using PGO mode.

davidxl added a comment. LGTM. Wait a little longer in case other reviews want to chime in. Repository: rL LLVM http://reviews.llvm.org/D15163 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14877: Fix ICE on lowering of constexpr vector splats

rsmith added a comment. Changes to ExprConstant and CGExprConstant appear to be pure cleanups; please check those in as a separate change. When this is done, you should also be able to remove the `IgnoreImpCasts` and `EmitScalarConversion` calls in the `CK_VectorSplat` handling in

Re: [PATCH] D12761: MPI-Checker patch for Clang Static Analyzer

Alexander_Droste added a comment. > Yes, less boilerplate code needed to work with AST matchers, powerful clang > diagnostic infrastructure is used to report errors, also the add_new_check.py > script ;) Pretty convincing advertisement line :). > If this class stays in the static analyzer,

PATCH: error on code that redeclares with an __asm__ label after the first ODR use

PR22830 shows a case where some code was adding an __asm__ label after the first use of a function. GCC and Clang diverged on this code, GCC emitting the name in the last __asm__ label for all uses while clang would switch in the middle of the TU as the redeclaration was parsed. The attached patch

Re: [PATCH] D15163: Attach maximum function count to Module when using PGO mode.

rsmith added a subscriber: rsmith. Comment at: lib/CodeGen/CodeGenModule.cpp:380-381 @@ -379,1 +379,4 @@ + // In PGO mode, attach maximum function count to the module. + if (PGOReader) +getModule().setMaximumFunctionCount(PGOReader->getMaximumFunctionCount());

r255311 - In Objective-C, ignore attempts to redefine the ARC/GC qualifier macros.

Author: rjmccall Date: Thu Dec 10 17:31:01 2015 New Revision: 255311 URL: http://llvm.org/viewvc/llvm-project?rev=255311=rev Log: In Objective-C, ignore attempts to redefine the ARC/GC qualifier macros. This works around existing system headers which unconditionally redefine these macros. This

r255314 - Clean ExprConstant/CGExprConstant up a bit. NFC.

Author: gbiv Date: Thu Dec 10 18:23:35 2015 New Revision: 255314 URL: http://llvm.org/viewvc/llvm-project?rev=255314=rev Log: Clean ExprConstant/CGExprConstant up a bit. NFC. Modified: cfe/trunk/lib/AST/ExprConstant.cpp cfe/trunk/lib/CodeGen/CGExprConstant.cpp Modified:

Re: [PATCH] D9600: Add scan-build python implementation

zaks.anna added inline comments. Comment at: tools/scan-build-py/README.md:86 @@ +85,3 @@ +The 2. mode is available only on FreeBSD, Linux and OSX. Where library preload +is available from the dynamic loader. On OSX System Integrity Protection security +feature enabled prevents

r255323 - Add some more tests for initializer lists related to CWG1591

Author: faisalv Date: Thu Dec 10 19:04:30 2015 New Revision: 255323 URL: http://llvm.org/viewvc/llvm-project?rev=255323=rev Log: Add some more tests for initializer lists related to CWG1591 Modified: cfe/trunk/test/CXX/drs/dr15xx.cpp Modified: cfe/trunk/test/CXX/drs/dr15xx.cpp URL:

Re: [PATCH] D9600: Add scan-build python implementation

rizsotto.mailinglist added inline comments. Comment at: tools/scan-build-py/libear/ear.c:141 @@ +140,3 @@ +environ = *_NSGetEnviron(); +#endif +if (!initialized) this call just sets up the `environ` variables for the `bear_capture_env_t` method, two

r255312 - [VFS] Fix status() of opened redirected file

Author: benlangmuir Date: Thu Dec 10 17:41:39 2015 New Revision: 255312 URL: http://llvm.org/viewvc/llvm-project?rev=255312=rev Log: [VFS] Fix status() of opened redirected file Make RedirectedFileSystem::openFilForRead(path)->status() the same as RedirectedFileSystem::status(path). Previously

Re: [PATCH] D15406: Add warning for attribute-cleanup on function parameter.

aaron.ballman added a subscriber: aaron.ballman. aaron.ballman accepted this revision. aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. In http://reviews.llvm.org/D15406#307733, @rsmith wrote: > This looks fine to me, though it would be better to express the

Re: [PATCH] D15370: [scan-view] replace deprecated optparse with argparse

djasper added a comment. I know nothing about this code. http://reviews.llvm.org/D15370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15411: [clang-tidy] Check for suspicious string assignments.

xazax.hun updated this revision to Diff 42406. xazax.hun added a comment. Minor update to docs. http://reviews.llvm.org/D15411 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/StringAssignmentCheck.cpp clang-tidy/misc/StringAssignmentCheck.h

Re: [PATCH] D9600: Add scan-build python implementation

rizsotto.mailinglist marked 7 inline comments as done. rizsotto.mailinglist added a comment. thanks for the comments. Comment at: tools/scan-build-py/bin/analyze-c++:1 @@ +1,2 @@ +#!/usr/bin/env python +# -*- coding: utf-8 -*- zaks.anna wrote: > What calls this

Re: [PATCH] D9600: Add scan-build python implementation

rizsotto.mailinglist added inline comments. Comment at: tools/scan-build-py/libear/ear.c:282 @@ +281,3 @@ +DLSYM(func, fp, "execve"); + +char const **const menvp = bear_update_environment(envp, _env); okay, since i don't have access for OSX machines can

Re: [PATCH] D14653: [libcxx] Introduce the mechanism for fixing -fno-exceptions test failures.

rmaprath added a comment. In http://reviews.llvm.org/D14653#306675, @EricWF wrote: > - I like the approach taken in the library. `__throw_helper` and > `__libcxx_noexceptions_abort()`. However I don't like that they are in their > own header. We should find another header for these to live in.

[clang-tools-extra] r255243 - [clang-tidy] Sort includes case-sensitively.

Author: alexfh Date: Thu Dec 10 06:24:19 2015 New Revision: 255243 URL: http://llvm.org/viewvc/llvm-project?rev=255243=rev Log: [clang-tidy] Sort includes case-sensitively. The motivation is: 1. consistency with clang-format, vim :sort etc. 2. we don't want the tools to depend on the current

[PATCH] D15411: [clang-tidy] Check for suspicious string assignments.

xazax.hun created this revision. xazax.hun added a reviewer: alexfh. xazax.hun added subscribers: dkrupp, cfe-commits. It is possible to assign arbitrary integer types to strings. Sometimes it is the result of missing to_string call or apostrophes. This check aims to find such errors.

Re: [PATCH] D13351: [Power PC] add soft float support for ppc32

hfinkel added inline comments. Comment at: lib/Driver/Tools.cpp:1477 @@ +1476,3 @@ + // If unspecified, choose the default based on the platform. + if (ABI == ppc::FloatABI::Invalid) { +ABI = ppc::FloatABI::Hard; rjmccall wrote: > hfinkel wrote: > > Don't

r255273 - libclang: expose dllexport, dllimport attributes

Author: compnerd Date: Thu Dec 10 12:45:18 2015 New Revision: 255273 URL: http://llvm.org/viewvc/llvm-project?rev=255273=rev Log: libclang: expose dllexport, dllimport attributes These attributes were previously unexposed. Expose them through the libclang interfaces. Add tests that cover both

[PATCH] D15421: [Feature] Add a builtin for indexing into parameter packs

ldionne created this revision. ldionne added a reviewer: majnemer. ldionne added a subscriber: cfe-commits. This patch adds a `__nth_element` builtin that allows fetching the n-th type of a parameter pack with very little compile-time overhead. The patch was inspired by r252036 and r252115 by

Re: [PATCH] D14653: [libcxx] Introduce the mechanism for fixing -fno-exceptions test failures.

rmaprath updated this revision to Diff 42440. rmaprath added a comment. Addressing review comments by @EricWF: - Introduced `_LIBCPP_THROW` macro to appropriately throw or call the no-exceptions report routine to handle the exceptional situation (avoid the overhead of a function call in the

Re: [PATCH] D15421: [Feature] Add a builtin for indexing into parameter packs

Hi Louis, It would probably be useful to get the lines of context as well by doing a full diff as describer here: http://llvm.org/docs/Phabricator.html#id3 For example, git diff -U99 On Thu, Dec 10, 2015 at 11:32 AM, Louis Dionne via cfe-commits < cfe-commits@lists.llvm.org> wrote: >

Re: [PATCH] D15421: [Feature] Add a builtin for indexing into parameter packs

ldionne added a comment. We should probably consider changing the name from `__nth_element` to something else, perhaps something that contains the word "pack". This is especially true if we are to implement other intrinsics for manipulating parameter packs, like slicing (as proposed by Eric

Re: [PATCH] D13351: [Power PC] add soft float support for ppc32

rjmccall added inline comments. Comment at: lib/Driver/Tools.cpp:1477 @@ +1476,3 @@ + // If unspecified, choose the default based on the platform. + if (ABI == ppc::FloatABI::Invalid) { +ABI = ppc::FloatABI::Hard; hfinkel wrote: > rjmccall wrote: > >

Re: [PATCH] D12624: Top-level anonymous namespaces are missing import DW_TAG_imported_module and nested anonymous namespaces are not

This revision was automatically updated to reflect the committed changes. Closed by commit rL255281: Do not generate DW_TAG_imported_module for anonymous namespaces (even nested)… (authored by kromanova). Changed prior to commit: http://reviews.llvm.org/D12624?vs=42364=42449#toc Repository:

Re: [PATCH] D15433: [libcxx] Remove inline/visibility attributes from exported template methods in valarray.

EricWF added a comment. Won't this mean that libc++ possibly exports 3 more template definitions? I think this is likely safe but I would rather not export any more symbols if it can be avoided. I'm probably nitpicking here though. Comment at: include/valarray:823 @@ -822,3

Re: [libcxx] Reinstate and fix overload sets to be const-correct wherever possible

> On 2015-Dec-10, at 15:32, Richard Smith wrote: > > On Thu, Dec 10, 2015 at 11:45 AM, Marshall Clow wrote: > On Tue, Dec 8, 2015 at 3:52 PM, Richard Smith wrote: > Ping. > > Sorry about that. > Completely missed this in my

r255325 - Correctly type-check the default arguments of local functions

Author: rjmccall Date: Thu Dec 10 19:56:36 2015 New Revision: 255325 URL: http://llvm.org/viewvc/llvm-project?rev=255325=rev Log: Correctly type-check the default arguments of local functions when eagerly instantiating them. rdar://23721638 Modified:

Re: [PATCH] D15433: [libcxx] Remove inline/visibility attributes from exported template methods in valarray.

eugenis added a comment. Libc++.so does not instantiate valarray for any other types, so this does not add any extra exports. Definitions valarray members (with types other than size_t) will now be exported from user code. This looks like a positive change to me: - these methods are already

r255326 - [PGO] Add a test case to cover version-3 format

Author: davidxl Date: Thu Dec 10 22:02:57 2015 New Revision: 255326 URL: http://llvm.org/viewvc/llvm-project?rev=255326=rev Log: [PGO] Add a test case to cover version-3 format Added: cfe/trunk/test/Profile/Inputs/c-general.profdata.v3 (with props) Modified:

r255324 - Revert "[Modules] Fix regression when an elaborated-type-specifier mentions a hidden tag"

Author: benlangmuir Date: Thu Dec 10 19:44:43 2015 New Revision: 255324 URL: http://llvm.org/viewvc/llvm-project?rev=255324=rev Log: Revert "[Modules] Fix regression when an elaborated-type-specifier mentions a hidden tag" This is causing assertion failures; reverting until I can fix. This

r255244 - [NFC] Improve a comment from my previous commit (r255221)

Author: faisalv Date: Thu Dec 10 06:29:11 2015 New Revision: 255244 URL: http://llvm.org/viewvc/llvm-project?rev=255244=rev Log: [NFC] Improve a comment from my previous commit (r255221) Modified: cfe/trunk/lib/Sema/SemaTemplateDeduction.cpp Modified:

Re: [PATCH] D14653: [libcxx] Introduce the mechanism for fixing -fno-exceptions test failures.

EricWF added a comment. Before you spend time changing the tests to use `TEST_TRY`/`TEST_CATCH` I would like somebody else to weigh in. I don't really think my solution is that great either. @jroelofs, @mclow any thoughts? A couple of more thoughts: - Forget what I said about putting it in .

Re: [PATCH] D15030: [clang-tidy] add check cppcoreguidelines-pro-bounds-constant-array-index

alexfh added a comment. One more nit. Leaving the rest to Aaron, since most of the comments were his. Comment at: clang-tidy/cppcoreguidelines/ProBoundsConstantArrayIndexCheck.h:25 @@ +24,3 @@ +class ProBoundsConstantArrayIndexCheck : public ClangTidyCheck { + std::string

Re: [PATCH] D15411: [clang-tidy] Check for suspicious string assignments.

alexfh added a comment. That's quite a surprising behavior. Looks like a bug in the library implementation (or in the standard) to me. But the check is awesome. Thank you! Comment at: clang-tidy/misc/StringAssignmentCheck.cpp:21 @@ +20,3 @@ +void

Re: [PATCH] D15411: [clang-tidy] Check for suspicious string assignments.

alexfh added a comment. BTW, Richard, is the possibility of assignment of an integer to a std::string a bug in the standard? http://reviews.llvm.org/D15411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r255236 - [analyzer] Fix symbolic element index lifetime.

Author: dergachev Date: Thu Dec 10 03:28:06 2015 New Revision: 255236 URL: http://llvm.org/viewvc/llvm-project?rev=255236=rev Log: [analyzer] Fix symbolic element index lifetime. SymbolReaper was destroying the symbol too early when it was referenced only from an index SVal of a live

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

nemanjai updated this revision to Diff 42414. nemanjai added a comment. Updated to address review comments. Rather than listing responses and justification for some of the changes, I'll provide comments inline for better readability. Repository: rL LLVM http://reviews.llvm.org/D15120

Re: [PATCH] D15120: Add support for __float128 type to be used by targets that support it

nemanjai added inline comments. Comment at: lib/AST/ItaniumMangle.cpp:2064 @@ +2063,3 @@ +if (getASTContext().getTargetInfo().useFloat128ManglingForLongDouble()) + Out << "U10__float128"; // Match the GCC mangling +else Please refer to

[clang-tools-extra] r255248 - Add a license clarification for use of links and titles of CERT secure coding guidelines.

Author: aaronballman Date: Thu Dec 10 07:53:36 2015 New Revision: 255248 URL: http://llvm.org/viewvc/llvm-project?rev=255248=rev Log: Add a license clarification for use of links and titles of CERT secure coding guidelines. Added: clang-tools-extra/trunk/clang-tidy/cert/LICENSE.TXT

Re: [PATCH] D15087: [PATCH] Add CERT license clarification

aaron.ballman closed this revision. aaron.ballman added a comment. Commit in r255248, thank you for the review! ~Aaron http://reviews.llvm.org/D15087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D14839: [libcxx] LWG2485: get() should be overloaded for const tuple&

K-ballo updated this revision to Diff 42432. K-ballo added a comment. Addressed review comments http://reviews.llvm.org/D14839 Files: include/__tuple include/array include/tuple include/utility test/std/containers/sequences/array/array.tuple/get_const_rv.pass.cpp

Re: r252960 - [modules] Simplify and generalize the existing rule for finding hidden

> On Dec 9, 2015, at 2:49 PM, Richard Smith wrote: > > On Wed, Dec 9, 2015 at 2:00 PM, Ben Langmuir > wrote: > >> On Dec 9, 2015, at 1:36 PM, Richard Smith > >

Re: [PATCH] D15421: [Feature] Add a builtin for indexing into parameter packs

ldionne updated this revision to Diff 42443. ldionne added a comment. Added full lines of context. Sorry for not doing it the first time around. http://reviews.llvm.org/D15421 Files: include/clang/AST/ASTContext.h include/clang/AST/DeclTemplate.h include/clang/Basic/Builtins.h

Re: [PATCH] D15440: [libc++abi] Use libgcc and libgcc_s to provide _Unwind symbols instead of libgcc_eh.a

compnerd added inline comments. Comment at: cmake/config-ix.cmake:45 @@ -44,3 +44,3 @@ check_library_exists(pthread pthread_once "" LIBCXXABI_HAS_PTHREAD_LIB) -check_library_exists(gcc_eh _Unwind_GetRegionStart "" LIBCXXABI_HAS_GCC_EH_LIB) +check_library_exists(gcc_s

Re: [PATCH] D15440: [libc++abi] Use libgcc and libgcc_s to provide _Unwind symbols instead of libgcc_eh.a

EricWF added inline comments. Comment at: cmake/config-ix.cmake:45 @@ -44,3 +44,3 @@ check_library_exists(pthread pthread_once "" LIBCXXABI_HAS_PTHREAD_LIB) -check_library_exists(gcc_eh _Unwind_GetRegionStart "" LIBCXXABI_HAS_GCC_EH_LIB) +check_library_exists(gcc_s

Re: [PATCH] D13351: [Power PC] add soft float support for ppc32

rjmccall added inline comments. Comment at: lib/Driver/Tools.cpp:1477 @@ +1476,3 @@ + // If unspecified, choose the default based on the platform. + if (ABI == ppc::FloatABI::Invalid) { +ABI = ppc::FloatABI::Hard; hfinkel wrote: > Don't need the { } here.

r255328 - Driver: add multilibs for ARM EB

Author: compnerd Date: Fri Dec 11 00:20:59 2015 New Revision: 255328 URL: http://llvm.org/viewvc/llvm-project?rev=255328=rev Log: Driver: add multilibs for ARM EB This improves the coverage for the multilib directories used for ARM. Also add tests covering the internal triple (thumbv7-*). The

[PATCH] D15440: [libc++abi] Use libgcc and libgcc_s to provide _Unwind symbols instead of libgcc_eh.a

EricWF created this revision. EricWF added reviewers: danalbert, chandlerc, mclow.lists, compnerd, ismail. EricWF added a subscriber: cfe-commits. libgcc_eh.a cannot be used when building libc++abi as a shared library (the default configuration). See this post for some more discussion:

[PATCH] D15441: [libc++] Use libgcc_s and libgcc instead of libgcc_eh when running the libc++ tests

EricWF created this revision. EricWF added reviewers: danalbert, jroelofs, chandlerc. EricWF added a subscriber: cfe-commits. EricWF added a dependency: D15440: [libc++abi] Use libgcc and libgcc_s to provide _Unwind symbols instead of libgcc_eh.a. This change depends on D15440.

Re: [PATCH] D15195: PR4941: Add support for -fno-builtin-foo options.

hfinkel added a subscriber: hfinkel. hfinkel added a comment. Can you use a StringSet instead of a vector and avoid all (most) of the code iterating over the vector of builtins being disabled? Comment at: lib/Frontend/CompilerInvocation.cpp:147 @@ +146,3 @@ +

Re: [PATCH] D15411: [clang-tidy] Check for suspicious string assignments.

xazax.hun updated this revision to Diff 42427. xazax.hun marked 5 inline comments as done. xazax.hun added a comment. - Modified the patch according to the review. http://reviews.llvm.org/D15411 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp

Re: [PATCH] D15411: [clang-tidy] Check for suspicious string assignments.

xazax.hun added a comment. Thank you for the review. I have seen a few false positives in the llvm codebase. I agree that these kind of conversions are unfortunate but I am sure fixing this would cause a huge backward compatibility problem. Nontheless I also think that it might be something

Re: [PATCH] D14839: [libcxx] LWG2485: get() should be overloaded for const tuple&

K-ballo marked 2 inline comments as done. K-ballo added a comment. In http://reviews.llvm.org/D14839#306306, @EricWF wrote: > int x = 42; > int const y = 43; > std::pair const p(x, y); > static_assert(std::is_same decltype(std::get<0>(std::move(p)))>::value, ""); >

Re: [PATCH] D15370: [scan-view] replace deprecated optparse with argparse

jroelofs added a comment. Looks reasonable to me from a "I haven't actually tried it with this patch" perspective. http://reviews.llvm.org/D15370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13126: New static analyzer checker for loss of sign/precision

danielmarjamaki marked an inline comment as done. danielmarjamaki added a comment. I have looked all warnings that I got. 1678 projects where scanned. In total I got 124 warnings. I classified 91 warnings as TP. 14 as FP. and then there were 19 that I failed to triage. I for instance failed to

Re: [PATCH] D13126: New static analyzer checker for loss of sign/precision

danielmarjamaki added a comment. > I classified 91 warnings as TP. 14 as FP. and then there were 19 that I > failed to triage. I for instance failed to triage code implemented in headers > when I don't know what values function arguments will have. Sorry I calculated wrong. I classified 91