Re: [PATCH] D16376: clang-tidy check: misc-deprecated-special-member-functions

jbcoe added a comment. The Sema diagnostic warning is only produced if a deprecated special member function is used whereas I want to find places where it would be compiler-generated and explicitly delete them. This is useful for library code where I don't have control over the warnings my

[PATCH] D17567: [GCC] Sema part of attrbute abi_tag support

DmitryPolukhin created this revision. DmitryPolukhin added a reviewer: aaron.ballman. DmitryPolukhin added subscribers: cfe-commits, stbuehler. Original patch by Stefan Bühler http://reviews.llvm.org/D12834 Difference between original and this one: - fixed all comments in original code review -

Re: r261717 - Default vaarg lowering should support indirect struct types.

On Wed, Feb 24, 2016 at 03:03:32AM -, James Y Knight via cfe-commits wrote: > Author: jyknight > Date: Tue Feb 23 20:59:33 2016 > New Revision: 261717 > > URL: http://llvm.org/viewvc/llvm-project?rev=261717=rev > Log: > Default vaarg lowering should support indirect struct types. > > Fixes

Re: [PATCH] D17244: [clang-tidy] readability-ternary-operator new check

omtcyf0 marked 3 inline comments as done. omtcyf0 added a comment. Thanks for the review! I'll fix these issues as soon as I manage to get time for that! http://reviews.llvm.org/D17244 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D13980: Add "x87" in x86 target feature map

aturetsk added a comment. Hi, The related LLVM patch (http://reviews.llvm.org/D13979) was approved. Is this patch ok for commit? http://reviews.llvm.org/D13980 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16545: [libcxxabi] Enable testing for static libc++abi

bcraig added a comment. ping http://reviews.llvm.org/D16545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15539: [libcxxabi] Reducing stack usage of test

bcraig added a comment. @mclow.lists ping http://reviews.llvm.org/D15539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17484: [clang-tidy] introduce modernize-deprecated-headers check

omtcyf0 updated this revision to Diff 48905. omtcyf0 added a comment. replaced few explicit casts to llvm::Twine with implicit ones http://reviews.llvm.org/D17484 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/DeprecatedHeadersCheck.cpp

Re: [PATCH] D17484: [clang-tidy] introduce modernize-deprecated-headers check

omtcyf0 added a comment. In http://reviews.llvm.org/D17484#359634, @alexfh wrote: > Looks good with one nit. > > Let me know if you need me to commit the patch for you. Yes, commit please! http://reviews.llvm.org/D17484 ___ cfe-commits mailing

[clang-tools-extra] r261737 - [clang-tidy] Added a check for forward declaration in the potentially wrong namespace

Author: alexfh Date: Wed Feb 24 07:35:32 2016 New Revision: 261737 URL: http://llvm.org/viewvc/llvm-project?rev=261737=rev Log: [clang-tidy] Added a check for forward declaration in the potentially wrong namespace Adds a new check "misc-forward-declaration-namespace". In check, A forward

Re: [PATCH] D16544: [libcxx] Framework to allow testing of static libc++abi

bcraig added a comment. ping http://reviews.llvm.org/D16544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17385: clang-format: [JS] single quote double quoted strings.

mprobst marked an inline comment as done. Comment at: lib/Format/Format.cpp:1579 @@ +1578,3 @@ + // The width of the extra \ escapes is taken into account in getNextToken. + void requoteJSStringLiterals(tooling::Replacements , + FormatToken

Re: [PATCH] D15883: Add ARM EHABI-related constants to unwind.h.

logan added inline comments. Comment at: lib/Headers/unwind.h:61 @@ +60,3 @@ +#define _UNWIND_ARM_EHABI 0 +#endif + logan wrote: > compnerd wrote: > > logan wrote: > > > compnerd wrote: > > > > logan wrote: > > > > > Since this is `unwind.h`, I feel that we can

r261744 - [docs] Change non-c++ code blocks to 'text' format to fix a sphinx warning.

Author: alexfh Date: Wed Feb 24 09:07:48 2016 New Revision: 261744 URL: http://llvm.org/viewvc/llvm-project?rev=261744=rev Log: [docs] Change non-c++ code blocks to 'text' format to fix a sphinx warning. Modified: cfe/trunk/docs/InternalsManual.rst Modified:

Re: [PATCH] D17385: clang-format: [JS] single quote double quoted strings.

mprobst updated this revision to Diff 48946. mprobst marked an inline comment as done. mprobst added a comment. - Move code closer together by piping Replacements into the FormatTokenLexer. - remove sstream import http://reviews.llvm.org/D17385 Files: lib/Format/Format.cpp

Re: [PATCH] SemaCXX: Support templates in availability attributes

On Tue, Feb 23, 2016 at 6:39 PM, Duncan P. N. Exon Smith wrote: > >> On 2016-Feb-23, at 11:18, Aaron Ballman wrote: >> >> On Tue, Feb 23, 2016 at 1:52 PM, Manman Ren wrote: >>> This patch looks good to me. But I am not sure if Aaron

Re: [PATCH] D17561: [CUDA] Add conversion operators for threadIdx, blockIdx, gridDim, and blockDim to uint3 and dim3.

tra added inline comments. Comment at: lib/Headers/cuda_builtin_vars.h:72 @@ -66,1 +71,3 @@ + // uint3). This function is defined after we pull in vector_types.h. + __attribute__((device)) operator uint3() const; private: Considering that built-in variables

Re: r261297 - Implement the likely resolution of core issue 253.

On Wed, Feb 24, 2016 at 3:53 PM, Richard Smith wrote: > On Wed, Feb 24, 2016 at 10:47 AM, Nico Weber wrote: > > Thanks for patiently explaining this. The attached patch is your email in > > diff form. Does this look alright? > > Yes, it looks great.

Re: [PATCH] D17575: Determine if there's a getDecl member function using less hacks

sbenza added a comment. I assume you checked that the new trait works on MSVC. Aren't both the same type of expression SFINAE? Is somehow one supported but not the other? http://reviews.llvm.org/D17575 ___ cfe-commits mailing list

Re: [PATCH] D17575: Determine if there's a getDecl member function using less hacks

On Wed, Feb 24, 2016 at 4:14 PM, Samuel Benzaquen via cfe-commits wrote: > sbenza added a comment. > > I assume you checked that the new trait works on MSVC. Yes. It's also used in ThreadSafety.cpp, so maybe at some point we may want to consider generalizing the

Re: [clang-tools-extra] r261738 - [clang-tidy] introduce modernize-deprecated-headers check

This broke the Windows bot: http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/10093/steps/build%20stage%201/logs/stdio FAILED: C:\PROGRA~2\MICROS~1.0\VC\bin\amd64\cl.exe /nologo /TP /DWIN32 /D_WINDOWS /W4 -wd4141 -wd4146 -wd4180 -wd4244 -wd4258 -wd4267 -wd4291 -wd4345 -wd4351

Re: [clang-tools-extra] r261738 - [clang-tidy] introduce modernize-deprecated-headers check

Looking into this... On Wed, Feb 24, 2016 at 10:21 PM, Nico Weber wrote: > This broke the Windows bot: > http://lab.llvm.org:8011/builders/clang-x64-ninja-win7/builds/10093/steps/build%20stage%201/logs/stdio > > FAILED: C:\PROGRA~2\MICROS~1.0\VC\bin\amd64\cl.exe /nologo

Re: [PATCH] D17385: clang-format: [JS] single quote double quoted strings.

djasper added inline comments. Comment at: lib/Format/Format.cpp:1579 @@ +1578,3 @@ + // The width of the extra \ escapes is taken into account in getNextToken. + void requoteJSStringLiterals(tooling::Replacements , + FormatToken *Current) {

Re: r261717 - Default vaarg lowering should support indirect struct types.

On Wed, Feb 24, 2016 at 5:11 AM, Joerg Sonnenberger via cfe-commits wrote: > On Wed, Feb 24, 2016 at 03:03:32AM -, James Y Knight via cfe-commits > wrote: >> Author: jyknight >> Date: Tue Feb 23 20:59:33 2016 >> New Revision: 261717 >> >> URL:

Re: [PATCH] D16044: getVariableName() for MemRegion

xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Core/MemRegion.cpp:636 @@ +635,3 @@ +std::string MemRegion::getVariableName() const { + std::string VariableName{""}; + std::string ArrayIndices{""}; Small nit, I prefer to call the default

r261762 - Fix typo in test/CodeGen/object-size.c CHECK line.

Author: bwilson Date: Wed Feb 24 12:38:35 2016 New Revision: 261762 URL: http://llvm.org/viewvc/llvm-project?rev=261762=rev Log: Fix typo in test/CodeGen/object-size.c CHECK line. Modified: cfe/trunk/test/CodeGen/object-size.c Modified: cfe/trunk/test/CodeGen/object-size.c URL:

Re: r261297 - Implement the likely resolution of core issue 253.

Thanks for patiently explaining this. The attached patch is your email in diff form. Does this look alright? Since you mention C++98: We emit this diagnostic in C++98 mode (before and after my change). The rule is new in C+++11, right? Should I add a check for CPlusPlus11 before emitting this

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

Anastasia added inline comments. Comment at: include/clang/Basic/AttrDocs.td:1572 @@ +1571,3 @@ +The __read_only, __write_only, __read_write, read_only, write_only and +read_write names are reserved for use as access qualifiers and shall not be +used otherwise.

Re: [PATCH] D17345: [OpenCL] Improve diagnostics of address spaces for variables inside function

Anastasia added inline comments. Comment at: test/SemaOpenCL/storageclass-cl20.cl:11 @@ -10,3 +10,3 @@ static global int S2 = 5; - static private int S3 = 5;// expected-error{{program scope variable must reside in global or constant address space}} + static private int S3 =

[PATCH] D17575: Determine if there's a getDecl member function using less hacks

aaron.ballman created this revision. aaron.ballman added reviewers: sbenza, klimek. aaron.ballman added a subscriber: cfe-commits. Herald added a subscriber: klimek. ASTMatchersInternal uses a custom type trait to determine the presence or absence of a getDecl member function. While the current

Re: r261762 - Fix typo in test/CodeGen/object-size.c CHECK line.

Nice catch. :) On Wed, Feb 24, 2016, 10:43 AM Bob Wilson via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: bwilson > Date: Wed Feb 24 12:38:35 2016 > New Revision: 261762 > > URL: http://llvm.org/viewvc/llvm-project?rev=261762=rev > Log: > Fix typo in test/CodeGen/object-size.c

Re: [PATCH] D16044: getVariableName() for MemRegion

Alexander_Droste updated this revision to Diff 48959. Alexander_Droste added a comment. - removed `reverse` - fixed twine usage I think `VariableName.insert(VariableName.size() - 1, ArrayIndices);` is needed here. varName, indices -> 'varname[...]' If append would be used, the second single

Re: [PATCH] D17438: [OpenCL] Add Sema checks for atomics and implicit declaration

Anastasia added a comment. Yes, I think it deserves clarification. Could you submit a bug to Khronos then? http://reviews.llvm.org/D17438 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r261756 - Objective-C: Add a size field to non-fragile category metadata.

Author: mren Date: Wed Feb 24 11:49:50 2016 New Revision: 261756 URL: http://llvm.org/viewvc/llvm-project?rev=261756=rev Log: Objective-C: Add a size field to non-fragile category metadata. This is mainly for extensibility. Note that fragile category metadata, metadata for classes and protocols

r261758 - AArch64: fix Cyclone CPU features list.

Author: tnorthover Date: Wed Feb 24 11:57:48 2016 New Revision: 261758 URL: http://llvm.org/viewvc/llvm-project?rev=261758=rev Log: AArch64: fix Cyclone CPU features list. It turns out we don't have CRC after all. Who knew? Modified: cfe/trunk/lib/Driver/Tools.cpp

[PATCH] D17576: Fix assertion failure on MaybeODRUseExprs.

manmanren created this revision. manmanren added reviewers: rsmith, EricWF, faisalv. manmanren added a subscriber: cfe-commits. In VisitNonTypeTemplateParamDecl, before SubstExpr with the default argument, we should create a ConstantEvaluated ExpressionEvaluationContext. Without this, it is

Re: [PATCH] D16044: getVariableName() for MemRegion

Alexander_Droste updated this revision to Diff 48953. Alexander_Droste added a comment. - remove string idx variable -> remove string copy assignments - use Twine to reduce temporary string objects, built during concatenation Is `ArrayIndices = llvm::Twine(ArrayIndices + "]" +

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

davidxl added a comment. Looks good to me -- and it makes the profile-gen and profile-use's cc1 option handling consistent. Please check with Sean or Justin just in case before proceeding. http://reviews.llvm.org/D15829 ___ cfe-commits mailing

Re: [PATCH] D16044: getVariableName() for MemRegion

xazax.hun added a comment. Since we went with the twine solution, I think we can get rid of the reverse stuff. Note that: Twine should be used like: (Twine(A) + B + C).str() So the operator+ has twine as one of the operands. Once these are fixed, it looks good to me. Do you have commit access

Re: [PATCH] D16044: getVariableName() for MemRegion

xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Core/MemRegion.cpp:672 @@ +671,3 @@ +// Combine variable name with indices. +VariableName.insert(VariableName.size() - 1, ArrayIndices); + } nit: this is in fact an append. It is cleaner

r261755 - [CLANG] [AVX512] [BUILTIN] Adding PSHUF{L|H}W{128|256|512} builtin to clang .

Author: mzuckerm Date: Wed Feb 24 11:39:35 2016 New Revision: 261755 URL: http://llvm.org/viewvc/llvm-project?rev=261755=rev Log: [CLANG] [AVX512] [BUILTIN] Adding PSHUF{L|H}W{128|256|512} builtin to clang . Differential Revision: http://reviews.llvm.org/D17539 Modified:

Re: [PATCH][modules][PR26237]

On 24/02/16 02:05, Richard Smith wrote: Calling getMostRecentDecl seems like a slightly fragile way to avoid iterator invalidation here. Instead... @@ -214,6 +212,19 @@ namespace clang { unsigned I = Record.size(); Record.push_back(0); + auto = Common->Specializations; +

r261751 - [WinEH] Make sure terminate handlers have funclet operands

Author: majnemer Date: Wed Feb 24 11:02:45 2016 New Revision: 261751 URL: http://llvm.org/viewvc/llvm-project?rev=261751=rev Log: [WinEH] Make sure terminate handlers have funclet operands Calls to the terminate handler must be annotated within the exception region they are within. Modified:

Re: [PATCH] D17562: [CUDA] Add hack so code which includes "curand.h" doesn't break.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. OK. http://reviews.llvm.org/D17562 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D17561: [CUDA] Add conversion operators for threadIdx, blockIdx, gridDim, and blockDim to uint3 and dim3.

jlebar added inline comments. Comment at: lib/Headers/cuda_builtin_vars.h:72 @@ -66,1 +71,3 @@ + // uint3). This function is defined after we pull in vector_types.h. + __attribute__((device)) operator uint3() const; private: tra wrote: > Considering that

Re: [PATCH] D17217: Bail on compilation as soon as a job fails.

jlebar added a comment. Upon further consideration, I'm going to push this with post-submit review -- the only difference from what echristo reviewed is an obvious change to output-file-cleanup.c. http://reviews.llvm.org/D17217 ___ cfe-commits

Re: [PATCH] D17576: Fix assertion failure on MaybeODRUseExprs.

rsmith accepted this revision. This revision is now accepted and ready to land. Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:2114 @@ -2113,1 +2113,3 @@ +EnterExpressionEvaluationContext ConstantEvaluated(SemaRef, +

Re: [PATCH][modules][PR26237]

On 24/02/16 22:50, Richard Smith wrote: On Wed, Feb 24, 2016 at 8:10 AM, Vassil Vassilev wrote: On 24/02/16 02:05, Richard Smith wrote: Calling getMostRecentDecl seems like a slightly fragile way to avoid iterator invalidation here. Instead... @@ -214,6 +212,19 @@

Re: r261780 - Don't convert a char to a const char *

Ah, good point. I assumed that the report was valid because they aren't showing up in the doxygen: http://llvm.org/docs/doxygen/html/classllvm_1_1StringRef.html I'll go ahead and revert. On Wed, Feb 24, 2016 at 2:06 PM, Benjamin Kramer wrote: > Were you able to reproduce

Re: [PATCH] D17561: [CUDA] Add conversion operators for threadIdx, blockIdx, gridDim, and blockDim to uint3 and dim3.

tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. OK. http://reviews.llvm.org/D17561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r261777 - [CUDA] Add conversion operators for threadIdx, blockIdx, gridDim, and blockDim to uint3 and dim3.

Author: jlebar Date: Wed Feb 24 15:49:33 2016 New Revision: 261777 URL: http://llvm.org/viewvc/llvm-project?rev=261777=rev Log: [CUDA] Add conversion operators for threadIdx, blockIdx, gridDim, and blockDim to uint3 and dim3. Summary: This lets you write, e.g. uint3 a = threadIdx; uint3 b

Re: [PATCH] D17562: [CUDA] Add hack so code which includes "curand.h" doesn't break.

This revision was automatically updated to reflect the committed changes. Closed by commit rL261776: [CUDA] Add hack so code which includes "curand.h" doesn't break. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D17562?vs=48885=48977#toc Repository: rL LLVM

r261773 - Make test/Driver/output-file-cleanup.c hermetic.

Author: jlebar Date: Wed Feb 24 15:49:26 2016 New Revision: 261773 URL: http://llvm.org/viewvc/llvm-project?rev=261773=rev Log: Make test/Driver/output-file-cleanup.c hermetic. Summary: It checks that certain files do and exist, so make sure that they don't exist at the beginning of the test.

r261774 - Bail on compilation as soon as a job fails.

Author: jlebar Date: Wed Feb 24 15:49:28 2016 New Revision: 261774 URL: http://llvm.org/viewvc/llvm-project?rev=261774=rev Log: Bail on compilation as soon as a job fails. Summary: (Re-land of r260448, which was reverted in r260522 due to a test failure in Driver/output-file-cleanup.c that only

r261775 - [CUDA] Don't specify exact line numbers in cuda-builtin-vars.cu.

Author: jlebar Date: Wed Feb 24 15:49:30 2016 New Revision: 261775 URL: http://llvm.org/viewvc/llvm-project?rev=261775=rev Log: [CUDA] Don't specify exact line numbers in cuda-builtin-vars.cu. This makes the test less fragile to changes to cuda_builtin_vars.h. Test-only change. Modified:

r261776 - [CUDA] Add hack so code which includes "curand.h" doesn't break.

Author: jlebar Date: Wed Feb 24 15:49:31 2016 New Revision: 261776 URL: http://llvm.org/viewvc/llvm-project?rev=261776=rev Log: [CUDA] Add hack so code which includes "curand.h" doesn't break. Summary: curand.h includes curand_mtgp32_kernel.h. In host mode, this header redefines threadIdx and

Re: [PATCH] D17056: Mark all CUDA device-side function defs and decls as convergent.

This revision was automatically updated to reflect the committed changes. Closed by commit rL261779: [CUDA] Mark all CUDA device-side function defs, decls, and calls as convergent. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D17056?vs=48261=48979#toc Repository:

r261781 - PR26237: Fix iterator invalidation bug that occurs if serializing

Author: rsmith Date: Wed Feb 24 15:59:10 2016 New Revision: 261781 URL: http://llvm.org/viewvc/llvm-project?rev=261781=rev Log: PR26237: Fix iterator invalidation bug that occurs if serializing specializations of a template manages to trigger deserialization of more specializations of the same

Re: [PATCH][modules][PR26237]

On Wed, Feb 24, 2016 at 2:01 PM, Vassil Vassilev wrote: > On 24/02/16 22:50, Richard Smith wrote: >> >> On Wed, Feb 24, 2016 at 8:10 AM, Vassil Vassilev >> wrote: >>> >>> On 24/02/16 02:05, Richard Smith wrote: Calling getMostRecentDecl

Re: [PATCH] Canonicalize UnaryTransformType types when they don't have a known underlying type

ping... On 07/01/16 08:09, Vassil Vassilev via cfe-commits wrote: Hi all, I am attaching a fix for https://llvm.org/bugs/show_bug.cgi?id=26014 To which type should I tie the canonical type of the unknown underlying type? Currently it is tied to its BaseType. Please review. --Vassil

Re: [PATCH] D17313: [CUDA] Annotate all calls in CUDA device mode as convergent.

jlebar abandoned this revision. jlebar added a comment. Subsumed by http://reviews.llvm.org/D17056. http://reviews.llvm.org/D17313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r261784 - Revert "Don't convert a char to a const char *"

Author: majnemer Date: Wed Feb 24 16:07:26 2016 New Revision: 261784 URL: http://llvm.org/viewvc/llvm-project?rev=261784=rev Log: Revert "Don't convert a char to a const char *" This reverts commit r261780. It turns out the original code was just fine. An overload for ltrim which takes char

Re: [PATCH] D17216: Make test/Driver/output-file-cleanup.c hermetic.

jlebar added a comment. Upon further consideration, I think I'm going to push this with post-submit review, as we know this test is quite broken, and I think this change is unlikely to make the situation worse. http://reviews.llvm.org/D17216 ___

Re: [PATCH] D17056: Mark all CUDA device-side function defs and decls as convergent.

jlebar added a comment. Friendly ping -- are we happy with this? http://reviews.llvm.org/D17056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r261782 - Fix build by using hasFlag instead of hasArg.

Author: pcc Date: Wed Feb 24 16:03:06 2016 New Revision: 261782 URL: http://llvm.org/viewvc/llvm-project?rev=261782=rev Log: Fix build by using hasFlag instead of hasArg. Modified: cfe/trunk/lib/Driver/Tools.cpp Modified: cfe/trunk/lib/Driver/Tools.cpp URL:

r261798 - Minor cleanup of Sema::CheckEnableIf. NFC.

Author: gbiv Date: Wed Feb 24 16:31:14 2016 New Revision: 261798 URL: http://llvm.org/viewvc/llvm-project?rev=261798=rev Log: Minor cleanup of Sema::CheckEnableIf. NFC. Modified: cfe/trunk/lib/Sema/SemaOverload.cpp Modified: cfe/trunk/lib/Sema/SemaOverload.cpp URL:

Re: [PATCH] D17550: Adding doxygen comments to the LLVM intrinsics (part 6, popcntintrin.h)

Those are all compelling reasons for me. Let's go with whatever you and Dmitri think would be best for now. :) -eric On Wed, Feb 24, 2016 at 12:41 PM Romanova, Katya < katya_roman...@playstation.sony.com> wrote: > Hello, > > > > I don’t think it will too hard to convert C++ style doxygen

Re: [clang-tools-extra] r261738 - [clang-tidy] introduce modernize-deprecated-headers check

The build should be fixed, but the tests for this check fail. I'll fix the tests tomorrow. On Thu, Feb 25, 2016 at 12:46 AM, Alexander Kornienko wrote: > I have a couple ideas, will try on the buildbot, since I don't have MSVC > to try fixes locally. > > On Wed, Feb 24, 2016

Re: [PATCH] D17519: AMDGPU: Fix broken/confusing predefined macro

tstellarAMD accepted this revision. tstellarAMD added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D17519 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17520: AMDGPU: Fix inconsistent register name for flat_scratch

tstellarAMD accepted this revision. tstellarAMD added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D17520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17515: AMDGPU: Add builtins for recently added intrinsics

tstellarAMD accepted this revision. tstellarAMD added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D17515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [clang-tools-extra] r261737 - [clang-tidy] Added a check for forward declaration in the potentially wrong namespace

This or r261737 seem to be causing a bot failure: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/636 -- Sean Silva On Wed, Feb 24, 2016 at 5:35 AM, Alexander Kornienko via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: alexfh > Date: Wed

[clang-tools-extra] r261811 - [clang-tidy] Another attempt to fix MSVC build

Author: alexfh Date: Wed Feb 24 18:39:11 2016 New Revision: 261811 URL: http://llvm.org/viewvc/llvm-project?rev=261811=rev Log: [clang-tidy] Another attempt to fix MSVC build Modified: clang-tools-extra/trunk/clang-tidy/modernize/DeprecatedHeadersCheck.cpp Modified:

Re: [clang-tools-extra] r261738 - [clang-tidy] introduce modernize-deprecated-headers check

On Wed, Feb 24, 2016 at 5:36 AM, Alexander Kornienko via cfe-commits wrote: > Author: alexfh > Date: Wed Feb 24 07:36:34 2016 > New Revision: 261738 > > URL: http://llvm.org/viewvc/llvm-project?rev=261738=rev > Log: > [clang-tidy] introduce modernize-deprecated-headers

r261820 - [OPENMP 4.5] Support fielddecls in 'shared' clause.

Author: abataev Date: Wed Feb 24 21:59:29 2016 New Revision: 261820 URL: http://llvm.org/viewvc/llvm-project?rev=261820=rev Log: [OPENMP 4.5] Support fielddecls in 'shared' clause. OpenMP 4.5 allows to use non-static data members of current class in non-static member functions in different kind

r261818 - [OpenCL] Add Sema checks for types

Author: pxl Date: Wed Feb 24 21:34:20 2016 New Revision: 261818 URL: http://llvm.org/viewvc/llvm-project?rev=261818=rev Log: [OpenCL] Add Sema checks for types Summary: Add Sema checks for opencl type: image, pipe This patch is partitioned from http://reviews.llvm.org/D16047 Reviewers:

Re: [PATCH] D17589: Fix Clang tests that used CHECK-NEXT-NOT and CHECK-DAG-NOT

tstellarAMD accepted this revision. tstellarAMD added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D17589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r261823 - Twek fix for PR24473 (r261506) - Preserve the template arguments as written

Author: faisalv Date: Wed Feb 24 23:09:30 2016 New Revision: 261823 URL: http://llvm.org/viewvc/llvm-project?rev=261823=rev Log: Twek fix for PR24473 (r261506) - Preserve the template arguments as written (within the DeclRefExpr Node) when creating AST nodes that reference specializations of

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

pxli168 updated this revision to Diff 49007. http://reviews.llvm.org/D16040 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td include/clang/Basic/DiagnosticSemaKinds.td lib/CodeGen/CodeGenFunction.cpp lib/Parse/ParseDecl.cpp lib/Sema/SemaChecking.cpp

Re: [PATCH] D17578: [OpenCL]Allowing explicit conversion of "0" to event_t type

pxli168 added a comment. foo((event_t)0); Is above use have been hint by some test cases? Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7679 @@ -7678,2 +7678,3 @@ def err_wrong_sampler_addressspace: Error< - "sampler type cannot be used with the __local and

r261824 - [OPENMP 4.5] Codegen for member decls in 'lastprivate' clause.

Author: abataev Date: Wed Feb 24 23:25:57 2016 New Revision: 261824 URL: http://llvm.org/viewvc/llvm-project?rev=261824=rev Log: [OPENMP 4.5] Codegen for member decls in 'lastprivate' clause. OpenMP 4.5 allows to privatize non-static member decls in non-static member functions. Patch captures

Re: [PATCH] D17355: [Sema] Remove assert in TreeTransform::TransformObjCObjectType

ahatanak added a comment. Is this OK to commit? I've committed the patch to fix the TypeLocBuilder bug in r261260. http://reviews.llvm.org/D17355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D17355: [Sema] Remove assert in TreeTransform::TransformObjCObjectType

ahatanak added a comment. Thanks, I'll commit this shortly. http://reviews.llvm.org/D17355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16040: [OpenCL] Refine OpenCLImageAccessAttr to OpenCLAccessAttr

pxli168 marked 2 inline comments as done. pxli168 added a comment. Remove test case for access quilifier in test/SemaOpenCL/invalid-kernel-attrs.cl. Due to the patch http://reviews.llvm.org/D17437. read_only can only be used in parameters with pipe and image type. Comment at:

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

silvas added a comment. In http://reviews.llvm.org/D15829#360006, @xur wrote: > Here is the new patch that removes the auto detection of profile kind. > > In this patch, I replace the CC1 option of -fprofile-instr-use=<> with > -fprofile-instrument={llvm-use|clang-use}. For the use compilation,

Re: [PATCH] D16876: [OpenCL] Refine pipe builtin support

pxli168 updated this revision to Diff 49008. pxli168 added a comment. 1. Make new indent and leave space for the incoming OpenCL C++. 2. Check for the index to see if they are integers. http://reviews.llvm.org/D16876 Files: include/clang/Basic/Builtins.h

Re: [PATCH] D17528: [analyzer] Warn on use of 'self' after call to to [super dealloc].

zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Checkers/ObjCSuperDeallocChecker.cpp:165 @@ +164,3 @@ + if (Desc.empty()) +Desc = "use of 'self' after it is freed with call to [super dealloc]"; + Does "has been freed" sound better?

r261829 - [Sema] Remove assert in TreeTransform::TransformObjCObjectType.

Author: ahatanak Date: Thu Feb 25 01:08:33 2016 New Revision: 261829 URL: http://llvm.org/viewvc/llvm-project?rev=261829=rev Log: [Sema] Remove assert in TreeTransform::TransformObjCObjectType. The assert isn't correct since TypeLoc::ObjCObjectTypeLoc doesn't indicate whether the type is a

Re: [PATCH] D17355: [Sema] Remove assert in TreeTransform::TransformObjCObjectType

This revision was automatically updated to reflect the committed changes. Closed by commit rL261829: [Sema] Remove assert in TreeTransform::TransformObjCObjectType. (authored by ahatanak). Changed prior to commit: http://reviews.llvm.org/D17355?vs=48247=49012#toc Repository: rL LLVM

Re: [PATCH] D17355: [Sema] Remove assert in TreeTransform::TransformObjCObjectType

doug.gregor accepted this revision. doug.gregor added a comment. This revision is now accepted and ready to land. LGTM, sorry for the delay. http://reviews.llvm.org/D17355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

RE: [PATCH] D17550: Adding doxygen comments to the LLVM intrinsics (part 6, popcntintrin.h)

Hello, I don’t think it will too hard to convert C++ style doxygen comments into C style doxygen comments by writing a post-processing python script. However, at first we need to decide if we really want to do that. If so, we need to settle on the exact format. After that, I need to make sure

r261767 - Add whole-program vtable optimization feature to Clang.

Author: pcc Date: Wed Feb 24 14:46:36 2016 New Revision: 261767 URL: http://llvm.org/viewvc/llvm-project?rev=261767=rev Log: Add whole-program vtable optimization feature to Clang. This patch introduces the -fwhole-program-vtables flag, which enables the whole-program vtable optimization feature

Re: [PATCH] D16821: Add whole-program vtable optimization feature to Clang.

This revision was automatically updated to reflect the committed changes. Closed by commit rL261767: Add whole-program vtable optimization feature to Clang. (authored by pcc). Changed prior to commit: http://reviews.llvm.org/D16821?vs=46697=48968#toc Repository: rL LLVM

Re: r261297 - Implement the likely resolution of core issue 253.

On Wed, Feb 24, 2016 at 10:47 AM, Nico Weber wrote: > Thanks for patiently explaining this. The attached patch is your email in > diff form. Does this look alright? Yes, it looks great. Thanks for the excellent test cases. > Since you mention C++98: We emit this diagnostic

r261770 - Fix rejects-valid caused by r261297.

Author: nico Date: Wed Feb 24 14:58:14 2016 New Revision: 261770 URL: http://llvm.org/viewvc/llvm-project?rev=261770=rev Log: Fix rejects-valid caused by r261297. r261297 called hasUserProvidedDefaultConstructor() to check if defining a const object is ok. This is incorrect for this example:

Re: [PATCH] D17576: Fix assertion failure on MaybeODRUseExprs.

This revision was automatically updated to reflect the committed changes. Closed by commit rL261803: Fix assertion failure on MaybeODRUseExprs. (authored by mren). Changed prior to commit: http://reviews.llvm.org/D17576?vs=48963=48986#toc Repository: rL LLVM http://reviews.llvm.org/D17576

r261803 - Fix assertion failure on MaybeODRUseExprs.

Author: mren Date: Wed Feb 24 17:05:43 2016 New Revision: 261803 URL: http://llvm.org/viewvc/llvm-project?rev=261803=rev Log: Fix assertion failure on MaybeODRUseExprs. In VisitNonTypeTemplateParamDecl, before SubstExpr with the default argument, we should create a ConstantEvaluated

[PATCH] D17578: [OpenCL]Allowing explicit conversion of "0" to event_t type

ashi1 created this revision. ashi1 added reviewers: Anastasia, pxli168, yaxunl. ashi1 added subscribers: pekka.jaaskelainen, tstellarAMD, cfe-commits. This patch will allow the cast of 0 to event_t type. http://reviews.llvm.org/D17578 Files: include/clang/Basic/DiagnosticSemaKinds.td

Re: [PATCH] D17576: Fix assertion failure on MaybeODRUseExprs.

faisalv added inline comments. Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:2114 @@ -2113,1 +2113,3 @@ +EnterExpressionEvaluationContext ConstantEvaluated(SemaRef, + Sema::ConstantEvaluated); ExprResult Value

Re: [PATCH] D17412: PR19957: [OpenCL] incorrectly accepts implicit address space conversion with ternary operator

yaxunl updated the summary for this revision. yaxunl removed a reviewer: pekka.jaaskelainen. yaxunl added a subscriber: pekka.jaaskelainen. yaxunl set the repository for this revision to rL LLVM. yaxunl updated this revision to Diff 48967. yaxunl marked 5 inline comments as done. yaxunl added a

  1   2   >