[PATCH] D24091: [Driver] Warn on -nodefaultlibs and -fsanitize

beanz created this revision. beanz added reviewers: bogner, zaks.anna, bruno, filcab. beanz added a subscriber: cfe-commits. Herald added a subscriber: emaste. The FreeBSD and GNUTools drivers support -fsanitize arguments bypassing -nodefaultlibs. With https://reviews.llvm.org/D24048, Darwin

[PATCH] D24105: [libc++] Limit gets to CRT versions below 14

smeenai created this revision. smeenai added reviewers: compnerd, EricWF, mclow.lists. smeenai added subscribers: cfe-commits, kastiglione. Microsoft removed gets from the CRT in Visual Studio 2015 onwards [1]. Attempting to reference it when targeting CRT versions 14 and above will cause compile

r280288 - Fix mishandling of deletedness for assignment operators of classes with

Author: rsmith Date: Wed Aug 31 15:37:39 2016 New Revision: 280288 URL: http://llvm.org/viewvc/llvm-project?rev=280288=rev Log: Fix mishandling of deletedness for assignment operators of classes with indirect virtual bases. We don't need to be able to invoke such an assignment operator from the

Re: [PATCH] D22494: [analyzer] Explain why analyzer report is not generated (fix for PR12421).

ayartsev added a comment. Gentle ping. https://reviews.llvm.org/D22494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22494: [analyzer] Explain why analyzer report is not generated (fix for PR12421).

zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Core/PathDiagnostic.cpp:216 @@ +215,3 @@ +llvm::raw_svector_ostream warning(buf); +warning << "warning: Path diagnostic report is not generated. Current " +<< "output format does not support

Re: r262189 - [modules] Prefer more complete array types.

Hi Akira, Thanks for your email. I am on vacation right now and I will try to look at this issue as soon as I can. Sorry for the inconvenience. Cheers, Vassil On 31/08/16 22:56, Akira Hatanaka wrote: Vassil and Richard, After this commit, clang errors out when compiling the following

Re: [PATCH] D24097: Add testcases for PR30188

davidxl added inline comments. Comment at: clang/test/CodeGen/pr30188.c:3 @@ +2,3 @@ + +// Check that optimizers are able to optimize the number of loads in the loop. +// CHECK: load Can you just do ... | grep load | count 3 Comment at:

r280290 - DebugInfo: Fix -gsplit-dwarf + -fno-split-dwarf-inlining

Author: dblaikie Date: Wed Aug 31 15:54:35 2016 New Revision: 280290 URL: http://llvm.org/viewvc/llvm-project?rev=280290=rev Log: DebugInfo: Fix -gsplit-dwarf + -fno-split-dwarf-inlining I tested the cases involving split-dwarf + gmlt + no-split-dwarf-inlining, but didn't verify the simpler case

Re: [PATCH] D23734: Add -fprofile-dir= to clang.

nlewycky updated this revision to Diff 69905. https://reviews.llvm.org/D23734 Files: lib/Transforms/Instrumentation/GCOVProfiling.cpp test/Transforms/GCOVProfiling/three-element-mdnode.ll tools/clang/include/clang/Driver/CC1Options.td tools/clang/include/clang/Driver/Options.td

Re: [PATCH] D24097: Add testcases for PR30188

rsmith added a subscriber: rsmith. rsmith requested changes to this revision. rsmith added a reviewer: rsmith. rsmith added a comment. This revision now requires changes to proceed. This belongs in LLVM's test suite, not Clang's. https://reviews.llvm.org/D24097

Re: [PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

beanz added a comment. @zaks.anna, the driver behind this is supporting building libcxx with sanitizers. The drivers for GNUTools and FreeBSD already support this workflow. I have updates to the test in https://reviews.llvm.org/D24091, which also cover this code. I'll push the updated test

Re: [PATCH] D24091: [Driver] Warn on -nodefaultlibs and -fsanitize

beanz updated this revision to Diff 69910. beanz added a comment. Updates based on bruno's feedback. https://reviews.llvm.org/D24091 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Driver/SanitizerArgs.h lib/Driver/Driver.cpp lib/Driver/ToolChains.cpp

Re: [PATCH] D24091: [Driver] Warn on -nodefaultlibs and -fsanitize

beanz added a comment. I can change the implementation, but that quickly falls into target specific driver code. It results in adding the warning in one place for Darwin, another for FreeBSD, and a third for GNUTools. If that is the preferred way I can work up that patch.

r280289 - Don't diagnoes a mismatch between implicit and explicit exception

Author: rsmith Date: Wed Aug 31 15:38:32 2016 New Revision: 280289 URL: http://llvm.org/viewvc/llvm-project?rev=280289=rev Log: Don't diagnoes a mismatch between implicit and explicit exception specifications under -fno-exceptions, just as we don't diagnose other exception specification mismatch

Re: [PATCH] D22494: [analyzer] Explain why analyzer report is not generated (fix for PR12421).

ayartsev added inline comments. Comment at: lib/StaticAnalyzer/Core/PathDiagnostic.cpp:216 @@ +215,3 @@ +llvm::raw_svector_ostream warning(buf); +warning << "warning: Path diagnostic report is not generated. Current " +<< "output format does not support

r280281 - Revert "Driver: use the canonical static library naming"

Author: compnerd Date: Wed Aug 31 14:27:07 2016 New Revision: 280281 URL: http://llvm.org/viewvc/llvm-project?rev=280281=rev Log: Revert "Driver: use the canonical static library naming" This breaks chromium and its unclear if this is actually a modern convention. This reverts SVN r280169.

[PATCH] D24099: [libc++] Don't add -fPIC on Windows

smeenai created this revision. smeenai added reviewers: compnerd, EricWF, mclow.lists. smeenai added a subscriber: cfe-commits. -fPIC doesn't make much sense for Windows, since Windows DLLs aren't compiled position independent and are instead relocated at runtime instead.

Re: r262189 - [modules] Prefer more complete array types.

Vassil and Richard, After this commit, clang errors out when compiling the following code, which used to compile without any errors. $ cat f2.cpp extern int compile_time_assert_failed[1]; template class C { enum { D }; public: template void foo1() { extern int compile_time_assert_failed[

[libcxxabi] r280286 - libc++abi: fix some -Wunused-function warnings

Author: compnerd Date: Wed Aug 31 15:29:05 2016 New Revision: 280286 URL: http://llvm.org/viewvc/llvm-project?rev=280286=rev Log: libc++abi: fix some -Wunused-function warnings is_initialized is only used in the no threads case or if on non ARM Apple targets. Use the preprocessor to remove the

r280287 - [codeview] Don't emit vshape info for classes without vfptrs

Author: rnk Date: Wed Aug 31 15:35:01 2016 New Revision: 280287 URL: http://llvm.org/viewvc/llvm-project?rev=280287=rev Log: [codeview] Don't emit vshape info for classes without vfptrs Classes with no virtual methods or whose virtual methods were all inherited from virtual bases don't have a

[PATCH] D24110: [Sema] Don't diagnose an array type mismatch when the new or previous declaration has a dependent type

ahatanak created this revision. ahatanak added reviewers: v.g.vassilev, rsmith. ahatanak added a subscriber: cfe-commits. We shouldn't compare the bounds of two arrays and issue a diagnostic if one of them is dependent. https://reviews.llvm.org/D24110 Files: lib/Sema/SemaDecl.cpp

Re: [PATCH] D24110: [Sema] Don't diagnose an array type mismatch when the new or previous declaration has a dependent type

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM as-is, but one suggestion if you want to still allow diagnosing a few more cases. Comment at: lib/Sema/SemaDecl.cpp:3377-3378 @@ -3376,4 +3376,4 @@ if

Re: [PATCH] D24110: [Sema] Don't diagnose an array type mismatch when the new or previous declaration has a dependent type

ahatanak added a comment. I'll commit the patch as-is first and come up with a new patch which implements the improvements you suggested later. https://reviews.llvm.org/D24110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxxabi] r280318 - Creating release candidate final from release_390 branch

Author: hans Date: Wed Aug 31 18:31:22 2016 New Revision: 280318 URL: http://llvm.org/viewvc/llvm-project?rev=280318=rev Log: Creating release candidate final from release_390 branch Added: libcxxabi/tags/RELEASE_390/final/ (props changed) - copied from r280317,

[libcxx] r280317 - Creating release candidate final from release_390 branch

Author: hans Date: Wed Aug 31 18:31:18 2016 New Revision: 280317 URL: http://llvm.org/viewvc/llvm-project?rev=280317=rev Log: Creating release candidate final from release_390 branch Added: libcxx/tags/RELEASE_390/final/ (props changed) - copied from r280316,

Re: [PATCH] D22494: [analyzer] Explain why analyzer report is not generated (fix for PR12421).

zaks.anna added inline comments. Comment at: lib/StaticAnalyzer/Core/PathDiagnostic.cpp:216 @@ +215,3 @@ +llvm::raw_svector_ostream warning(buf); +warning << "warning: Path diagnostic report is not generated. Current " +<< "output format does not support

Re: [PATCH] D24091: [Driver] Warn on -nodefaultlibs and -fsanitize

beanz updated this revision to Diff 69926. beanz added a comment. - Changed warning text based on feedback from bruno - Made the warning apply to -nostdlib as well as -nodefaultlibs based on offline discussion with Anna https://reviews.llvm.org/D24091 Files:

[PATCH] D24119: [libc++] add linker option "-Wl, -z, defs" in standalone build

zlei created this revision. zlei added a reviewer: cfe-commits. This option is used to avoid underlinking. It's available in LLVM's main tree, but not in a standalone build of libc++. This patch ensures the option is passed in whether libc++ is built in-tree or out-of-tree.

[PATCH] D24115: [Clang] Fix some Clang-tidy modernize-use-using and Include What You Use warnings; other minor fixes

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: mehdi_amini, compnerd. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. I checked this patch on my own build on RHEL 6. Regressions were OK. Repository: rL LLVM

Re: [PATCH] D24091: [Driver] Warn on -nodefaultlibs and -fsanitize

bruno added inline comments. Comment at: include/clang/Basic/DiagnosticDriverKinds.td:276 @@ +275,3 @@ +def warn_drv_sanitizers_and_nodefaultlibs : Warning< + "Passing -nodefaultlibs and -fsanitize has resulted in linking sanitizer runtimes.">, +

r280306 - Add -fprofile-dir= to clang.

Author: nicholas Date: Wed Aug 31 18:04:32 2016 New Revision: 280306 URL: http://llvm.org/viewvc/llvm-project?rev=280306=rev Log: Add -fprofile-dir= to clang. -fprofile-dir=path allows the user to specify where .gcda files should be emitted when the program is run. In particular, this is the

[libunwind] r280324 - Creating release candidate final from release_390 branch

Author: hans Date: Wed Aug 31 18:31:40 2016 New Revision: 280324 URL: http://llvm.org/viewvc/llvm-project?rev=280324=rev Log: Creating release candidate final from release_390 branch Added: libunwind/tags/RELEASE_390/final/ (props changed) - copied from r280323,

Re: [PATCH] D24110: [Sema] Don't diagnose an array type mismatch when the new or previous declaration has a dependent type

This revision was automatically updated to reflect the committed changes. Closed by commit rL280330: [Sema] Don't diagnose an array type mismatch when the new or previous (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D24110?vs=69927=69935#toc Repository: rL LLVM

Re: [PATCH] D24110: [Sema] Don't diagnose an array type mismatch when the new or previous declaration has a dependent type

rsmith added inline comments. Comment at: lib/Sema/SemaDecl.cpp:3370-3374 @@ -3369,7 +3369,7 @@ // mismatch. - if (!NewArray->isIncompleteArrayType()) { + if (!NewArray->isIncompleteArrayType() && !NewArray->isDependentType()) { for (VarDecl *PrevVD =

Re: [PATCH] D24069: Document option '-rtlib' in clang's man page and help info

bruno added inline comments. Comment at: docs/CommandGuide/clang.rst:114 @@ -110,1 +113,3 @@ + compiler-rt. + .. option:: -ansi zlei wrote: > bruno wrote: > > It might be worth mentioning what's the default behaviour in case the flag > > isn't specified? > This

Re: [PATCH] D24110: [Sema] Don't diagnose an array type mismatch when the new or previous declaration has a dependent type

ahatanak added inline comments. Comment at: lib/Sema/SemaDecl.cpp:3377-3378 @@ -3376,4 +3376,4 @@ if (!Context.hasSameType(NewArray, PrevVDTy)) return diagnoseVarDeclTypeMismatch(*this, New, PrevVD); } rsmith wrote: > ahatanak

[libcxx] r280335 - Fix libc++ configuration with -fsanitize-coverage

Author: krasin Date: Wed Aug 31 20:38:32 2016 New Revision: 280335 URL: http://llvm.org/viewvc/llvm-project?rev=280335=rev Log: Fix libc++ configuration with -fsanitize-coverage Summary: a recent change (r280015) in libc++ configuration broke LibFuzzer bot:

Re: [PATCH] D24110: [Sema] Don't diagnose an array type mismatch when the new or previous declaration has a dependent type

rsmith added inline comments. Comment at: lib/Sema/SemaDecl.cpp:3377-3378 @@ -3376,4 +3376,4 @@ if (!Context.hasSameType(NewArray, PrevVDTy)) return diagnoseVarDeclTypeMismatch(*this, New, PrevVD); } ahatanak wrote: > rsmith

r280333 - Fix typos in comments.

Author: gbiv Date: Wed Aug 31 20:26:58 2016 New Revision: 280333 URL: http://llvm.org/viewvc/llvm-project?rev=280333=rev Log: Fix typos in comments. Modified: cfe/trunk/lib/Sema/SemaExprObjC.cpp Modified: cfe/trunk/lib/Sema/SemaExprObjC.cpp URL:

Re: [PATCH] D22584: constexpr array support C++1z (P0031)

mclow.lists added a comment. Other than the iterator.primitives/iterator.operations/prev.pass.cpp test, I think this is good to go. Comment at: test/std/iterators/iterator.primitives/iterator.operations/prev.pass.cpp:47 @@ +46,3 @@ + +{ +constexpr const char* s =

r280309 - Fix all tests under test/CXX (and test/Analysis) to pass if clang's default

Author: rsmith Date: Wed Aug 31 18:24:08 2016 New Revision: 280309 URL: http://llvm.org/viewvc/llvm-project?rev=280309=rev Log: Fix all tests under test/CXX (and test/Analysis) to pass if clang's default C++ language standard is not C++98. Modified:

r280308 - DR259: Demote the pedantic error for an explicit instantiation after an

Author: rsmith Date: Wed Aug 31 18:23:25 2016 New Revision: 280308 URL: http://llvm.org/viewvc/llvm-project?rev=280308=rev Log: DR259: Demote the pedantic error for an explicit instantiation after an explicit specialization to a warning for C++98 mode (this is a defect report resolution, so per

Re: [PATCH] D24110: [Sema] Don't diagnose an array type mismatch when the new or previous declaration has a dependent type

ahatanak added inline comments. Comment at: lib/Sema/SemaDecl.cpp:3377-3378 @@ -3376,4 +3376,4 @@ if (!Context.hasSameType(NewArray, PrevVDTy)) return diagnoseVarDeclTypeMismatch(*this, New, PrevVD); } rsmith wrote: > If you do

[PATCH] D24113: Allow implicit conversions between incompatible pointer types in overload resolution in C.

george.burgess.iv created this revision. george.burgess.iv added a reviewer: rsmith. george.burgess.iv added a subscriber: cfe-commits. In C, we allow pointer conversions like: ``` void foo(int *a); long b; void runFoo() { foo(); } ``` ...But not when overloading: ``` int bar(char *a)

r280330 - [Sema] Don't diagnose an array type mismatch when the new or previous

Author: ahatanak Date: Wed Aug 31 20:03:21 2016 New Revision: 280330 URL: http://llvm.org/viewvc/llvm-project?rev=280330=rev Log: [Sema] Don't diagnose an array type mismatch when the new or previous declaration has a dependent type. This fixes a bug where clang errors out on a valid code.

Re: [PATCH] D24040: codechecker tool core

mehdi_amini added a subscriber: mehdi_amini. mehdi_amini added a comment. This looks like a fairly large tool. Should it get its own "subproject level" directory in the SVN instead of being nested within clang? Comment at: tools/codechecker/README.md:50 @@ +49,3 @@ +# get

Re: [PATCH] D24040: codechecker tool core

mehdi_amini added a comment. > This looks like a fairly large tool. Should it get its own "subproject level" > directory in the SVN instead of being nested within clang? I'd add that the clang-tools-extra are more closely tied to clang than what this seems to be. Is there a strong rev-lock

Re: [PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

beanz added a comment. I've sent out an additional patch that adds a warning for using -nostdlibs and -fsanitize (See: https://reviews.llvm.org/D24091) https://reviews.llvm.org/D24048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D19910: [unwinder] Get rid of unused code

logan accepted this revision. logan added a comment. This revision is now accepted and ready to land. Sorry for the late reply. Thanks for your work. Yes, this is correct. However, it seems that this differential can be closed since it has been committed as https://reviews.llvm.org/rL271737.

[PATCH] D24097: Add testcases for PR30188

sebpop created this revision. sebpop added reviewers: jmolloy, danielcdh, davidxl, mkuper, dberlin. sebpop added subscribers: llvm-commits, cfe-commits. Add testcases to clang test/ to make sure that the combined middle-end optimizations do not regress on optimizing the number of loads in the

Re: [PATCH] D24091: [Driver] Warn on -nodefaultlibs and -fsanitize

bruno added a comment. Hi Chris, Thanks for doing this. Comment at: lib/Driver/Driver.cpp:1554 @@ -1551,1 +1553,3 @@ +Args.hasArg(options::OPT_fsanitize_EQ)) + Diag(clang::diag::warn_drv_sanitizers_and_nodefaultlibs); } How hard is to fire the

Re: [PATCH] D24083: [CMake] Fix libc++abi __aeabi_idiv() link error.

rengolin added a comment. This looks like a work around the fact that --rtlib is being ignored with --nodefaultlibs. I'm not sure that's a sane behaviour, if you explicitly specify --rtlib. https://reviews.llvm.org/D24083 ___ cfe-commits mailing

Re: [PATCH] D24069: Document option '-rtlib' in clang's man page and help info

bruno added a subscriber: bruno. bruno added a comment. Hi Lei, Thanks for the doc improvement! Comment at: docs/CommandGuide/clang.rst:114 @@ -110,1 +113,3 @@ + compiler-rt. + .. option:: -ansi It might be worth mentioning what's the default behaviour in

r280269 - Fix a typo in a comment.

Author: gbiv Date: Wed Aug 31 13:14:15 2016 New Revision: 280269 URL: http://llvm.org/viewvc/llvm-project?rev=280269=rev Log: Fix a typo in a comment. Modified: cfe/trunk/include/clang/Sema/Sema.h Modified: cfe/trunk/include/clang/Sema/Sema.h URL:

Re: r280169 - Driver: use the canonical static library naming

This broke the win asan build: http://lab.llvm.org:8011/builders/sanitizer-windows/builds/28203 More generally, though, this seems like it's a Boost convention and an MSVCRT convention, and not a general Windows convention:

Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

tavianator added a comment. Ping? https://reviews.llvm.org/D21803 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21803: [libcxxabi] Provide a fallback __cxa_thread_atexit() implementation

bcraig added a comment. In https://reviews.llvm.org/D21803#530678, @tavianator wrote: > Ping? Well, I still think it's fine. Maybe a direct message to @mclow.lists or @EricWF? https://reviews.llvm.org/D21803 ___ cfe-commits mailing list

Re: [PATCH] D23279: clang-reorder-fields

alexshap updated this revision to Diff 69807. alexshap added a comment. 1. Fix handling of initListExprs. http://clang.llvm.org/doxygen/Expr_8h_source.html#l03701 2. Fix handling of unchanged files 3. Add tests (AggregatePartialInitialization and ClassDifferentFieldsAccesses) Repository: rL

Re: [PATCH] D23279: clang-reorder-fields

alexshap updated this revision to Diff 69814. alexshap added a comment. 1. Fix comments (hope so). 2. if (const auto *SyntacticForm = InitListEx->getSyntacticForm()) InitListEx = SyntacticForm; Repository: rL LLVM https://reviews.llvm.org/D23279 Files: CMakeLists.txt

Re: [PATCH] D23279: clang-reorder-fields

djasper added a comment. Looks good :). Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23279: clang-reorder-fields

alexshap added a comment. good call, i have found a bug in handling of initListExprs. Will update this diff and add tests. Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D23279: clang-reorder-fields

alexshap marked an inline comment as done. alexshap added a comment. Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23279: clang-reorder-fields

alexshap marked an inline comment as done. alexshap added a comment. Repository: rL LLVM https://reviews.llvm.org/D23279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23918: [clang-tidy docs] Add missing option docs.

hokein updated this revision to Diff 69812. hokein marked 26 inline comments as done. hokein added a comment. Address aaron's comments. https://reviews.llvm.org/D23918 Files: docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst

Re: [PATCH] D23918: [clang-tidy docs] Add missing option docs.

hokein added a comment. wow, thanks for many detailed comments. Comment at: docs/clang-tidy/checks/google-build-namespaces.rst:21 @@ +20,3 @@ + extensions should not contain "." prefix). "h,hh,hpp,hxx" by default. For + extension-less header files, using an empty string or

Re: [PATCH] D23279: clang-reorder-fields

djasper added inline comments. Comment at: clang-reorder-fields/ReorderFieldsAction.cpp:181 @@ +180,3 @@ + assert(InitListEx && "Init list expression is null"); + // we care only about brace initializations + // which have valid source locations Write full

[PATCH] D24069: Document option '-rtlib' in clang's man page and help info

zlei created this revision. zlei added reviewers: cfe-commits, Hahnfeld. This patch adds an entry for "-rtlib" in the output of `man clang` and `clang -help`. https://reviews.llvm.org/D24069 Files: docs/CommandGuide/clang.rst include/clang/Driver/Options.td Index:

Re: [PATCH] D23987: [Coverage] Suppress creating a code region if the same area is covered by an expansion region.

This revision was automatically updated to reflect the committed changes. Closed by commit rL280199: [Coverage] Suppress creating a code region if the same area is covered by an… (authored by ikudrin). Changed prior to commit: https://reviews.llvm.org/D23987?vs=69709=69799#toc Repository:

Re: r280104 - Disable clang/test/SemaTemplate/instantiation-depth-default.cpp temporarily for targeting mingw32. It crashes. Investigating.

On 30 Aug 2016 4:05 pm, "NAKAMURA Takumi" wrote: Thanks, Richard. Conversely, do we need to give sufficient amount of stack to the clang executable whenever this fails? By default, clang.exe has 2MiB (and *-tblgen.exe(s) are gaven 16MiB) of stack on mingw-w64. 10,000,000

r280199 - [Coverage] Suppress creating a code region if the same area is covered by an expansion region.

Author: ikudrin Date: Wed Aug 31 02:04:16 2016 New Revision: 280199 URL: http://llvm.org/viewvc/llvm-project?rev=280199=rev Log: [Coverage] Suppress creating a code region if the same area is covered by an expansion region. In most cases these code regions are just redundant, but sometimes they

Re: r280065 - Fix for commit 280064 that break the build.

On 30 August 2016 at 09:56, Sjoerd Meijer via cfe-commits wrote: > Author: sjoerdmeijer > Date: Tue Aug 30 03:56:00 2016 > New Revision: 280065 > > URL: http://llvm.org/viewvc/llvm-project?rev=280065=rev > Log: > Fix for commit 280064 that break the build. Any more

RE: r280065 - Fix for commit 280064 that break the build.

Hi, I uploaded the incorrect patch, it shouldn't have included the -fexceptions-fp-math because we decided to use trapping-math and therefore I removed these test lines in the quick fix. Regression test test/CodeGen/noexceptionsfpmath.c makes sure -fno-trapping-math ends up as a function

Re: r280133 - PR30195: Fix clang-cl attempting to precompile bogus (non-precompilable) input types.

Thanks! On 31 August 2016 at 01:02, Richard Smith wrote: > Hopefully r280178 should fix this. > > On Tue, Aug 30, 2016 at 4:00 PM, Renato Golin > wrote: >> >> On 30 August 2016 at 22:44, Renato Golin wrote: >> > This

r280220 - Attempt to pacify buildbots after r280217

Author: jamesm Date: Wed Aug 31 06:01:41 2016 New Revision: 280220 URL: http://llvm.org/viewvc/llvm-project?rev=280220=rev Log: Attempt to pacify buildbots after r280217 These clang tests check diagnostics from the backend by giving it an unvectorizable loop. This loop is now vectorized :/

Re: r280065 - Fix for commit 280064 that break the build.

On 31 August 2016 at 11:30, Sjoerd Meijer wrote: > Regression test test/CodeGen/noexceptionsfpmath.c makes sure > -fno-trapping-math ends up as a function attribute, and I relied on that. > Flag -fno-trapping-math is used a lot in test/Driver/fast-math.c, but you are >

[PATCH] D24075: [include-fixer] Add a `query-symbol` option to query symbol without parsing the source file.

hokein created this revision. hokein added a reviewer: bkramer. hokein added a subscriber: cfe-commits. https://reviews.llvm.org/D24075 Files: include-fixer/find-all-symbols/SymbolInfo.h include-fixer/tool/ClangIncludeFixer.cpp test/include-fixer/query_symbol.cpp Index:

Re: [PATCH] D23918: [clang-tidy docs] Add missing option docs.

hokein updated this revision to Diff 69839. hokein added a comment. Update HeaderFileExtensions doc for all documents. https://reviews.llvm.org/D23918 Files: docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst docs/clang-tidy/checks/google-build-namespaces.rst

r280245 - clang-format: Set default WebKit style to use C++11.

Author: djasper Date: Wed Aug 31 09:05:56 2016 New Revision: 280245 URL: http://llvm.org/viewvc/llvm-project?rev=280245=rev Log: clang-format: Set default WebKit style to use C++11. The WebKit style page says to use nullptr, so this should be fine: https://webkit.org/code-style-guidelines/ This

Re: [PATCH] D23918: [clang-tidy docs] Add missing option docs.

aaron.ballman added inline comments. Comment at: docs/clang-tidy/checks/google-build-namespaces.rst:21 @@ +20,3 @@ + extensions should not include "." prefix). Default is "h,hh,hpp,hxx". + For header files without an extension, use an empty string (if there are no + other

Re: [libcxx] r279955 - Fix pair::operator=(TupleLike&&).

ping. On Sun, Aug 28, 2016 at 7:52 PM, Eric Fiselier wrote: > @Hans While working on the std::tuple bug I found this bug in std::pair. > Since we are already doing another RC I would like to merge this fix. > > @Marshall Sound OK to you? > > /Eric > > On Sun, Aug 28, 2016 at 7:43

Re: [PATCH] D23918: [clang-tidy docs] Add missing option docs.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, thank you for the updated documentation! https://reviews.llvm.org/D23918 ___ cfe-commits mailing list

[clang-tools-extra] r280235 - [docs] Fix docs build error.

Author: hokein Date: Wed Aug 31 08:17:48 2016 New Revision: 280235 URL: http://llvm.org/viewvc/llvm-project?rev=280235=rev Log: [docs] Fix docs build error. Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst Modified: clang-tools-extra/trunk/docs/ReleaseNotes.rst URL:

Re: [PATCH] D24040: codechecker tool core

rizsotto.mailinglist added a comment. Gyorgy and the ericsson team, thanks for doing this. very good job! good targeted functionality. i don't want to underestimate the complexity it requires, but to me this is a giant code. i do miss the explanation of the overall functional description what

Re: [PATCH] D23918: [clang-tidy docs] Add missing option docs.

This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rL280236: [clang-tidy docs] Add missing option docs. (authored by hokein). Changed prior to commit: https://reviews.llvm.org/D23918?vs=69839=69840#toc

Re: [PATCH] D23918: [clang-tidy docs] Add missing option docs.

hokein marked an inline comment as done. Comment at: docs/clang-tidy/checks/google-build-namespaces.rst:21 @@ +20,3 @@ + extensions should not include "." prefix). Default is "h,hh,hpp,hxx". + For header files without an extension, use an empty string (if there are no +

Re: [PATCH] D23918: [clang-tidy docs] Add missing option docs.

hokein updated this revision to Diff 69838. hokein marked 3 inline comments as done. hokein added a comment. Fix more comments. https://reviews.llvm.org/D23918 Files: docs/clang-tidy/checks/cppcoreguidelines-pro-bounds-constant-array-index.rst

r280240 - [clang-format-vim] Support vim linked against py3

Author: ldrumm Date: Wed Aug 31 08:36:36 2016 New Revision: 280240 URL: http://llvm.org/viewvc/llvm-project?rev=280240=rev Log: [clang-format-vim] Support vim linked against py3 clang-format.py previously only worked in vim compiled against python2. This patch adds the necessary syntax changes

Re: [PATCH] D23918: [clang-tidy docs] Add missing option docs.

aaron.ballman added inline comments. Comment at: docs/clang-tidy/checks/google-build-namespaces.rst:21 @@ +20,3 @@ + extensions should not include "." prefix). Default is "h,hh,hpp,hxx". + For header files without an extension, use an empty string (if there are no + other

[clang-tools-extra] r280236 - [clang-tidy docs] Add missing option docs.

Author: hokein Date: Wed Aug 31 08:21:18 2016 New Revision: 280236 URL: http://llvm.org/viewvc/llvm-project?rev=280236=rev Log: [clang-tidy docs] Add missing option docs. Reviewers: alexfh, Eugene.Zelenko, aaron.ballman Subscribers: aaron.ballman, cfe-commits Differential Revision:

r280227 - Revision r280064 adds new options -fdenormal-fp-math and passes through option

Author: sjoerdmeijer Date: Wed Aug 31 07:31:03 2016 New Revision: 280227 URL: http://llvm.org/viewvc/llvm-project?rev=280227=rev Log: Revision r280064 adds new options -fdenormal-fp-math and passes through option -ffast-math to CC1, but it included a wrong llvm regression tests which was removed

Re: [PATCH] D23918: [clang-tidy docs] Add missing option docs.

hokein added inline comments. Comment at: docs/clang-tidy/checks/google-build-namespaces.rst:21 @@ +20,3 @@ + extensions should not include "." prefix). Default is "h,hh,hpp,hxx". + For header files without an extension, use an empty string (if there are no + other desired

Re: [PATCH] D24084: [CMake] Cleanup libunwind lookup code.

rengolin added a comment. > We have to do so because we need the modified "unwind.h" from libunwind. > (Note: which is bundled with clang/gcc is not sufficient.) So, you need libunwind's sources, even if you're not building or using them, to build libc++abi? https://reviews.llvm.org/D24084

[libcxxabi] r280251 - Wrap LIBCXXABI_USE_LLVM_UNWINDER with defined().

Author: logan Date: Wed Aug 31 10:16:40 2016 New Revision: 280251 URL: http://llvm.org/viewvc/llvm-project?rev=280251=rev Log: Wrap LIBCXXABI_USE_LLVM_UNWINDER with defined(). This commit fixes -Wundef by replacing: #if !LIBCXXABI_USE_LLVM_UNWINDER with: #if

[PATCH] D24083: [CMake] Fix libc++abi __aeabi_idiv() link error.

logan created this revision. logan added reviewers: mclow.lists, rengolin, EricWF. logan added a subscriber: cfe-commits. Herald added a subscriber: aemerson. This commit fixes __aeabi_idiv() link error when we are building libc++abi with compiler-rt. When compiler-rt is enabled, the option

[PATCH] D24082: [CMake] Fix libc++abi arm build w/o libunwind.

logan created this revision. logan added reviewers: mclow.lists, rengolin, EricWF. logan added a subscriber: cfe-commits. Herald added subscribers: samparker, rengolin, aemerson. This commit fixes libc++abi build when LLVM unwinder (libunwind_llvm) is not enabled. This commit fixes the problem

[PATCH] D24084: [CMake] Cleanup libunwind lookup code.

logan created this revision. logan added reviewers: mclow.lists, rengolin, EricWF, danalbert, thakis. logan added a subscriber: cfe-commits. This commit refines the code for libunwind lookup. First, this commit will always search for libunwind no matter LLVM unwinder is enabled or not. We have

Re: [PATCH] D24075: [include-fixer] Add a `query-symbol` option to query symbol without parsing the source file.

hokein updated this revision to Diff 69847. hokein added a comment. Update the test. https://reviews.llvm.org/D24075 Files: include-fixer/find-all-symbols/SymbolInfo.h include-fixer/tool/ClangIncludeFixer.cpp test/include-fixer/query_symbol.cpp Index: test/include-fixer/query_symbol.cpp

Re: [PATCH] D24040: codechecker tool core

artem.tamazov resigned from this revision. artem.tamazov removed a reviewer: artem.tamazov. artem.tamazov added a comment. It seems that my name got into reviewers list by mistake. https://reviews.llvm.org/D24040 ___ cfe-commits mailing list

[PATCH] D24080: [lit] Replace print with lit_config.note().

logan created this revision. logan added reviewers: mclow.lists, rengolin, EricWF. logan added a subscriber: cfe-commits. This commit replaces print statement with lit_config.note(). This fixes python3 support for check-libcxxabi. https://reviews.llvm.org/D24080 Files: test/lit.cfg Index:

[PATCH] D24085: arm: Fix ttype encoding assertion failure.

logan created this revision. logan added reviewers: mclow.lists, rengolin. logan added a subscriber: cfe-commits. Herald added subscribers: samparker, rengolin, aemerson. GCC 4.7 or newer emits 0x90 (indirect | pcrel) as the ttype encoding. This would hit an assertion in cxa_personality.cpp.

  1   2   >