Re: [PATCH] D24245: [ARM] ARM-specific attributes should be accepted for big-endian

olista01 added a comment. Ping. Repository: rL LLVM https://reviews.llvm.org/D24245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24349: [clang-tidy] Extend readability-container-size-empty to arbitrary class with size() and empty()

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. In https://reviews.llvm.org/D24349#538102, @aaron.ballman wrote: > In https://reviews.llvm.org/D24349#538098, @alexfh wrote: > > > Thank you for the patch! > > > > In

Re: [PATCH] D24238: StaticAnalyzer CastToStruct : No memory corruption when casting array to struct

danielmarjamaki abandoned this revision. danielmarjamaki added a comment. hmm.. I don't actually care much about this specific check at the moment. I saw other false positives (unreachable code) and thought that this check made the analyzer think there was corrupted memory. Now I can't

Re: [PATCH] D23842: [CFG] Add iterator_ranges to CFG and CFGBlock.

This revision was automatically updated to reflect the committed changes. mboehme marked an inline comment as done. Closed by commit rL281200: [CFG] Add iterator_ranges to CFG and CFGBlock. (authored by mboehme). Changed prior to commit: https://reviews.llvm.org/D23842?vs=69129=70981#toc

Re: [PATCH] D24380: [migrate-tool] Framework for a codebase-dependent migration tool.

klimek added inline comments. Comment at: migrate-tool/BuildManager.h:22 @@ +21,3 @@ +public: + virtual bool addHeaderOnlyLibrary(llvm::StringRef HeaderPath) = 0; + I'm not sure the header-only distinction makes sense. I'd start with virtual bool

r281203 - clang-format: Make emacs integration work with narrowed buffers.

Author: djasper Date: Mon Sep 12 05:02:46 2016 New Revision: 281203 URL: http://llvm.org/viewvc/llvm-project?rev=281203=rev Log: clang-format: Make emacs integration work with narrowed buffers. Use (call-process region nil ...) instead of (point-min) so that the call works in narrowed buffers.

Re: [PATCH] D24349: [clang-tidy] Extend readability-container-size-empty to arbitrary class with size() and empty()

omtcyfz updated this revision to Diff 70989. omtcyfz added a comment. Messed up with the last diff; fix that + clang-format the check. https://reviews.llvm.org/D24349 Files: clang-tidy/readability/ContainerSizeEmptyCheck.cpp docs/clang-tidy/checks/readability-container-size-empty.rst

[PATCH] D24448: [atomics] New warning -Watomic-libcall when atomic operation expands to a library call

sdardis created this revision. sdardis added a subscriber: cfe-commits. Herald added a reviewer: vkalintiris. Herald added a subscriber: aemerson. Targets typically support atomics that are word sized (e.g. 32 or 64 bit) or half word sized (e.g. 32 bit on 64 bit systems). For larger sizes, some

Re: [PATCH] D24238: StaticAnalyzer CastToStruct : No memory corruption when casting array to struct

danielmarjamaki added a comment. If the -fno-strict-aliasing would fix this warning then it would be OK. If you are telling me that this CastToStruct check is about alignment or endianness then I think the message is highly misleading. We should rewrite the message. In general, using char

Re: [PATCH] D24193: Allow variables with asm labels in naked functions

nikola updated this revision to Diff 70985. nikola added a comment. This should address Hans' comments, as for the code get I have no idea. I was hoping someone more knowledgeable would tell me if this made sense or not? https://reviews.llvm.org/D24193 Files: lib/Sema/SemaDecl.cpp

Re: [PATCH] D24349: [clang-tidy] Extend readability-container-size-empty to arbitrary class with size() and empty()

omtcyfz updated this revision to Diff 70986. omtcyfz marked 4 inline comments as done. omtcyfz added a comment. Address another round of comments. https://reviews.llvm.org/D24349 Files: clang-tidy/readability/ContainerSizeEmptyCheck.cpp

r281198 - Add virtual destructor (necessary due to the switch to shared_ptr).

Author: rsmith Date: Mon Sep 12 01:51:11 2016 New Revision: 281198 URL: http://llvm.org/viewvc/llvm-project?rev=281198=rev Log: Add virtual destructor (necessary due to the switch to shared_ptr). Modified: cfe/trunk/utils/TableGen/ClangDiagnosticsEmitter.cpp Modified:

Re: [PATCH] D24005: [compiler-rt cmake] Support overriding llvm-config query results

Hahnfeld added a reviewer: beanz. Hahnfeld added a comment. SGTM, I don't see any drawback Comment at: cmake/Modules/CompilerRTUtils.cmake:200 @@ -199,5 +199,3 @@ string(REGEX REPLACE "[ \t]*[\r\n]+[ \t]*" ";" CONFIG_OUTPUT ${CONFIG_OUTPUT}) - list(GET CONFIG_OUTPUT 0

r281195 - Attempt #2 to placate MSVC

Author: rsmith Date: Mon Sep 12 01:23:26 2016 New Revision: 281195 URL: http://llvm.org/viewvc/llvm-project?rev=281195=rev Log: Attempt #2 to placate MSVC Modified: cfe/trunk/utils/TableGen/ClangDiagnosticsEmitter.cpp Modified: cfe/trunk/utils/TableGen/ClangDiagnosticsEmitter.cpp URL:

Re: [PATCH] D24069: Document option '-rtlib' in clang's man page and help info

Hahnfeld accepted this revision. Hahnfeld added a comment. This revision is now accepted and ready to land. LGTM, thanks for the improvement! https://reviews.llvm.org/D24069 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r281194 - Attempt to placate MSVC.

Author: rsmith Date: Mon Sep 12 01:13:44 2016 New Revision: 281194 URL: http://llvm.org/viewvc/llvm-project?rev=281194=rev Log: Attempt to placate MSVC. Modified: cfe/trunk/utils/TableGen/ClangDiagnosticsEmitter.cpp Modified: cfe/trunk/utils/TableGen/ClangDiagnosticsEmitter.cpp URL:

r281197 - Attempt #3 to placate MSVC.

Author: rsmith Date: Mon Sep 12 01:38:31 2016 New Revision: 281197 URL: http://llvm.org/viewvc/llvm-project?rev=281197=rev Log: Attempt #3 to placate MSVC. Modified: cfe/trunk/utils/TableGen/ClangDiagnosticsEmitter.cpp Modified: cfe/trunk/utils/TableGen/ClangDiagnosticsEmitter.cpp URL:

Re: [PATCH] D21134: clang-tidy: new check readability-misplaced-array-index

This revision was automatically updated to reflect the committed changes. Closed by commit rL281206: [clang-tidy] readability-misplaced-array-index: add new check that warns when… (authored by danielmarjamaki). Changed prior to commit: https://reviews.llvm.org/D21134?vs=69558=70994#toc

[clang-tools-extra] r281206 - [clang-tidy] readability-misplaced-array-index: add new check that warns when array index is misplaced.

Author: danielmarjamaki Date: Mon Sep 12 07:04:13 2016 New Revision: 281206 URL: http://llvm.org/viewvc/llvm-project?rev=281206=rev Log: [clang-tidy] readability-misplaced-array-index: add new check that warns when array index is misplaced. Reviewers: alexfh Differential Revision:

Re: [PATCH] D18462: Fix for clang_Cursor_getSpellingNameRange()

klimek added a reviewer: bkramer. klimek added a comment. +Benjamin https://reviews.llvm.org/D18462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16171: Warning on redeclaring with a conflicting asm label

phabricss added a subscriber: phabricss. phabricss added a comment. It is still impossible to compile glibc with clang due to this bug. Could this patch be reviewed please. https://reviews.llvm.org/D16171 ___ cfe-commits mailing list

Re: [PATCH] D23921: Remove va_start diagnostic false positive with enumerations

aaron.ballman added a comment. In https://reviews.llvm.org/D23921#531883, @aaron.ballman wrote: > Ping Ping https://reviews.llvm.org/D23921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D24238: StaticAnalyzer CastToStruct : No memory corruption when casting array to struct

NoQ added a comment. Random thoughts: - This checker doesn't alter the exploded graph, so it cannot be causing or suppressing positives in other checkers. - We should not be adding platform-specific behavior (eg. working as if `sizeof(int) == 1`) without actually ensuring that it is so on

Re: [PATCH] D24383: Add addOrMerge interface to tooling::Replacements.

djasper added a comment. Ok.. Thought some more and discussed with Manuel. I think we should do a partial solution for now. I still think addOrMerge is harmful and it is always never the right thing to use. The codepaths that currently implement some version of it, should likely reconsider.

Re: [PATCH] D23820: Do not warn about format strings that are indexed string literals.

meikeb marked 4 inline comments as done. Comment at: lib/Sema/SemaChecking.cpp:4166-4167 @@ +4165,4 @@ +if (BinOp->isAdditiveOp()) { + bool LIsInt = false; + bool RIsInt = false; + // Prevent asserts triggering in EvaluateAsInt by checking if we deal with

Re: r281198 - Add virtual destructor (necessary due to the switch to shared_ptr).

Ah, hmm - we do use this technique in a few places. Oh, right - protected in the base, final derived classes (maybe that's the missing element?). So I think we've disabled whatever GCC warnings get in the way of that particular cliche. But, fair enough - thanks for the context. All power to the

Re: r281057 - [DebugInfo] Ensure complete type is emitted with -fstandalone-debug

Looks like this test could be a bit simpler: struct foo; foo *f; // produces a forward decl struct foo { virtual ~foo(); }; foo f; // requires the type to be complete A cursory glance looks like this reproduces the issue, but I may've missed something. Also the bracing in the new condition

Re: [PATCH] D23820: Do not warn about format strings that are indexed string literals.

meikeb updated this revision to Diff 71043. meikeb added a comment. Fix the mentioned issues. https://reviews.llvm.org/D23820 Files: lib/Sema/SemaChecking.cpp test/Sema/format-strings.c Index: test/Sema/format-strings.c ===

Re: [PATCH] D24005: [compiler-rt cmake] Support overriding llvm-config query results

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. One comment below, otherwise LGTM. Comment at: cmake/Modules/CompilerRTUtils.cmake:200 @@ -199,5 +199,3 @@ string(REGEX REPLACE "[ \t]*[\r\n]+[ \t]*" ";" CONFIG_OUTPUT

[PATCH] D24467: Fix an error after D21678

vbyakovlcl created this revision. vbyakovlcl added reviewers: ahatanak, aaron.ballman. vbyakovlcl added subscribers: andreybokhanko, cfe-commits. vbyakovlcl set the repository for this revision to rL LLVM. vbyakovlcl changed the visibility of this Differential Revision from "Public (No Login

Re: [PATCH] D24005: [compiler-rt cmake] Support overriding llvm-config query results

mgorny marked 3 inline comments as done. mgorny added a comment. And done. https://reviews.llvm.org/D24005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24005: [compiler-rt cmake] Support overriding llvm-config query results

mgorny updated this revision to Diff 71040. Herald added subscribers: mgorny, beanz. https://reviews.llvm.org/D24005 Files: cmake/Modules/CompilerRTUtils.cmake Index: cmake/Modules/CompilerRTUtils.cmake === ---

Re: [PATCH] D23820: Do not warn about format strings that are indexed string literals.

rsmith added inline comments. Comment at: lib/Sema/SemaChecking.cpp:3842-3843 @@ -3841,2 +3841,4 @@ -static void CheckFormatString(Sema , const StringLiteral *FExpr, +static void reckonUpOffset(llvm::APSInt , llvm::APSInt Addend, + BinaryOperatorKind

[PATCH] D24461: CodeGen: Cast llvm.flt.rounds result to match __builtin_flt_rounds

edward-jones created this revision. edward-jones added a reviewer: rjmccall. edward-jones added a subscriber: cfe-commits. llvm.flt.rounds returns an i32, but the builtin expects an integer. On targets where integers are not 32-bits clang tries to bitcast the result, causing an assertion

Re: [PATCH] D23300: [analyzer] Add "Assuming..." diagnostic pieces for unsupported condition expressions.

zaks.anna added a comment. @NoQ, Let's test in an IDE. Can you send screenshots? https://reviews.llvm.org/D23300 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r281198 - Add virtual destructor (necessary due to the switch to shared_ptr).

Does that actually need a virtual dtor? The type erasure handling in shared_ptr would handle it so long as each instance is constructed with the derived type (looks like it probably is - make_shared used consistently) & we should get a warning (or could make the base dtor protected non-virtual to

Re: [PATCH] D22968: [analyzer] A checker for macOS-specific bool-like objects.

zaks.anna added a comment. Let's test it on more real word bugs. Comment at: lib/StaticAnalyzer/Checkers/BoolConversionChecker.cpp:11 @@ +10,3 @@ +// This file defines BoolConversionChecker, which checks for a particular +// common mistake when dealing with NSNumber and

Re: [PATCH] D24193: Allow variables with asm labels in naked functions

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm I'm a little bit worried that we've started down a slippery slope of deciding what is and isn't allowed in naked functions (for example, some initializers could be allowed if we're sure

r281241 - Diagnostics reference: "error:" should be red, not orange.

Author: rsmith Date: Mon Sep 12 12:55:49 2016 New Revision: 281241 URL: http://llvm.org/viewvc/llvm-project?rev=281241=rev Log: Diagnostics reference: "error:" should be red, not orange. Modified: cfe/trunk/docs/DiagnosticsReference.rst cfe/trunk/include/clang/Basic/DiagnosticDocs.td

r281227 - Trivial documentation fix regarding Obj-C ARC objc_arc_weak_reference_unavailable

Author: jroelofs Date: Mon Sep 12 11:14:52 2016 New Revision: 281227 URL: http://llvm.org/viewvc/llvm-project?rev=281227=rev Log: Trivial documentation fix regarding Obj-C ARC objc_arc_weak_reference_unavailable Fixed incorrect docs that referred to: objc_arc_weak_unavailable when it should

Re: [PATCH] D24307: calculate extent size for memory regions allocated by C++ new expression

dkrupp marked 11 inline comments as done. dkrupp added a comment. issues fixed https://reviews.llvm.org/D24307 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r281056 - Make -fstandalone-debug and -flimit-debug-info available in clang-cl

standalone and limit-debug-info are the same functionality - -fstandalone-debug is the more modern and apt description, so perhaps just keep that one & drop/don't provide -flimit-debug-info (since there's no real need to be backwards compatible in the flag support in clang-cl, I expect)? On Fri,

Re: [PATCH] D16171: Warning on redeclaring with a conflicting asm label

On 11 September 2016 at 21:14, Sam Shepperd via cfe-commits < cfe-commits@lists.llvm.org> wrote: > phabricss added a subscriber: phabricss. > phabricss added a comment. > > It is still impossible to compile glibc with clang due to this bug. Could > this patch be reviewed please. > Firstly, I

[PATCH] D24469: [clang-cl] Diagnose duplicate uuids.

thakis created this revision. thakis added a reviewer: rnk. thakis added subscribers: cfe-commits, aaron.ballman. This mostly behaves cl.exe's behavior, even though clang-cl is stricter in some corner cases and more lenient in others (see the included test). To make the `uuid declared

[PATCH] D24470: [analyzer] scan-build-py: Remove relative path hack for SATestsBuild.py

dcoughlin created this revision. dcoughlin added a reviewer: rizsotto.mailinglist. dcoughlin added a subscriber: cfe-commits. Remove the relative path hack in scan-build-py that converts a fully qualified directory name and a fully qualified file path to a relative path before running the

Re: [libcxx] r281179 - [libcxx] Introduce an externally-threaded libc++ variant.

Hi Mike, That does look related to my change. Is this an internal build? I was looking out for the bots on llvm.org but didn't spot any issues (yet). Will try to reproduce locally. Would it be OK if I find a fix tomorrow? (night time here in the UK), can revert if this is blocking you. Cheers,

Re: [PATCH] D22494: [analyzer] Explain why analyzer report is not generated (fix for PR12421).

ayartsev updated this revision to Diff 71056. ayartsev added a comment. Updated the patch. Important change in Options.td was missing in the last patch + indentation fixed. Still Ok to commit? https://reviews.llvm.org/D22494 Files: include/clang/Driver/Options.td

Re: [PATCH] D24065: [libc++] Use _LIBCPP_TYPE_VIS_ONLY with enum class

This revision was automatically updated to reflect the committed changes. Closed by commit rL281264: config: Use _LIBCPP_TYPE_VIS_ONLY with enum class (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D24065?vs=70087=71059#toc Repository: rL LLVM

[libcxx] r281264 - config: Use _LIBCPP_TYPE_VIS_ONLY with enum class

Author: smeenai Date: Mon Sep 12 16:41:12 2016 New Revision: 281264 URL: http://llvm.org/viewvc/llvm-project?rev=281264=rev Log: config: Use _LIBCPP_TYPE_VIS_ONLY with enum class An enum class has associated type info. In the Microsoft ABI, type info is emitted in the COMDAT section and isn't

Re: [PATCH] D24383: Add addOrMerge interface to tooling::Replacements.

ioeric added a comment. In https://reviews.llvm.org/D24383#539942, @djasper wrote: > Ok.. Thought some more and discussed with Manuel. > > I think we should do a partial solution for now. I still think addOrMerge is > harmful and it is always never the right thing to use. The codepaths that >

[PATCH] D24472: [Sema] Support lax conversions for compound assignments

bruno created this revision. bruno added a reviewer: rnk. bruno added subscribers: cfe-commits, ahatanak. Support lax conversions on compound assignment expressions like: typedef __attribute__((vector_size(8))) double float64x1_t; typedef __attribute__((vector_size(16))) double float64x2_t;

[libcxx] r281250 - config: Fix typo in comment

Author: smeenai Date: Mon Sep 12 15:14:44 2016 New Revision: 281250 URL: http://llvm.org/viewvc/llvm-project?rev=281250=rev Log: config: Fix typo in comment Testing commit access. NFC. Modified: libcxx/trunk/include/__config Modified: libcxx/trunk/include/__config URL:

Re: [libcxx] r281179 - [libcxx] Introduce an externally-threaded libc++ variant.

Asiri, The boot strap build has started to fail for. Your change seems to be related, right? [14/22] Building CXX object projects/libcxx/lib/CMakeFiles/cxx_objects.dir/__/src/locale.cpp.o FAILED: /usr/bin/g++ -D_DEBUG -D_GNU_SOURCE -D_LIBCPP_HAS_NO_PRAGMA_SYSTEM_HEADER -D__STDC_CONSTANT_MACROS

Re: [PATCH] D24469: [clang-cl] Diagnose duplicate uuids.

thakis updated this revision to Diff 71050. thakis added a comment. On conflict, keep first uuid in ast instead of having different uuids on different redeclarations. https://reviews.llvm.org/D24469 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/AttributeList.h

Re: [libcxx] r281179 - [libcxx] Introduce an externally-threaded libc++ variant.

OK, I'm able to reproduce locally. Looks like gcc (4.8.3 at least) does not like my patch. Working on a fix... On Mon, Sep 12, 2016 at 9:43 PM, Asiri Rathnayake < asiri.rathnay...@gmail.com> wrote: > Hi Mike, > > That does look related to my change. Is this an internal build? I was > looking

Re: [libcxx] r281179 - [libcxx] Introduce an externally-threaded libc++ variant.

Hi Mike, Can you check if https://reviews.llvm.org/D24475 fixes the issue for you? This looks like a bug in the gcc pre-processor (in older versions of gcc). I'm a bit hesitant because my gcc (4.8.3) bumps into a different issue (crash!) as well, but that seem to have nothing to do with my patch

Re: [PATCH] D16171: Warning on redeclaring with a conflicting asm label

phabricss added a comment. On 09/12/2016 01:26 PM, Nick Lewycky wrote: > Firstly, I thought glibc had applied a patch to fix this bug? As in, the > error is correct and glibc fixed their bug? I can confirm that the bug still exists in glibc 2.24 and HEAD from glibc git. Also it appears that

r281259 - Add a couple of test files missed in r281258.

Author: rsmith Date: Mon Sep 12 16:07:09 2016 New Revision: 281259 URL: http://llvm.org/viewvc/llvm-project?rev=281259=rev Log: Add a couple of test files missed in r281258. Added: cfe/trunk/test/Modules/Inputs/merge-template-pattern-visibility/c.h

r281258 - [modules] When we merge two definitions of a function, mark the retained

Author: rsmith Date: Mon Sep 12 16:06:40 2016 New Revision: 281258 URL: http://llvm.org/viewvc/llvm-project?rev=281258=rev Log: [modules] When we merge two definitions of a function, mark the retained definition as visible in the discarded definition's module, as we do for other kinds of

Re: [PATCH] D24469: [clang-cl] Diagnose duplicate uuids.

thakis updated this revision to Diff 71049. thakis added a comment. Remove local XXXs I've since addressed. https://reviews.llvm.org/D24469 Files: include/clang/Basic/DiagnosticSemaKinds.td include/clang/Sema/AttributeList.h include/clang/Sema/Sema.h lib/Parse/ParseDecl.cpp

Re: [PATCH] D24383: Add addOrMerge interface to tooling::Replacements.

djasper added a comment. The problem is that it is implicit behavior, that's not easy to understand. What's worse is that the behavior of add and merge would fundamentally be reverse. If you add two inserts at the same location, the first one would come first. If you merge them, the second one

Re: [PATCH] D24467: Fix an error after D21678

ahatanak added inline comments. Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8733 @@ -8731,2 +8732,3 @@ if (!IsCompAssign) { -LHS = S.UsualUnaryConversions(LHS.get()); +if (S.LangOpts.OpenCL || S.LangOpts.ZVector) + LHS = S.UsualUnaryConversions(LHS.get());

Re: [PATCH] D24469: [clang-cl] Diagnose duplicate uuids.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: lib/Parse/ParseDecl.cpp:1456 @@ -1451,1 +1455,3 @@ + TypeAttrTail = AL; + TypeAttrTail->setNext(nullptr); mmm hand rolled singly

Re: [PATCH] D23852: [SemaObjC] Fix crash while parsing type arguments and protocols

bruno added a comment. Ping! https://reviews.llvm.org/D23852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r281198 - Add virtual destructor (necessary due to the switch to shared_ptr).

On Mon, Sep 12, 2016 at 10:55 AM, David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Does that actually need a virtual dtor? The type erasure handling in > shared_ptr would handle it so long as each instance is constructed with the > derived type (looks like it probably is -

Re: [PATCH] D24319: clang-format: Add a flag to limit git-clang-format's diff to a single commit

lhchavez updated this revision to Diff 71103. lhchavez added a comment. Using lodato's proposed interface. This patch: - Accepts an arbitrary number of commits as arguments. Validation will be done in main(), such that two commits are valid only when running in --diff mode. - Allows diffing two

Re: [PATCH] D24319: clang-format: Add a flag to limit git-clang-format's diff to a single commit

lhchavez marked 3 inline comments as done. Comment at: cfe/trunk/tools/clang-format/git-clang-format:93 @@ -92,1 +92,3 @@ help='default commit to use if none is specified'), + p.add_argument('--single-commit', action='store_true', + help=('run

RE: [PATCH] D24426: DebugInfo: Pass non-zero alignment to DIBuilder only if aligment was forced

The text in the committee draft is different (e.g., the exhortation about non-default alignment is gone), with an example to the effect that a value of 8 means the entity's address is a multiple of 8 (not 2^8). So, alignment is conceived in terms of address bits, whatever those represent (not

Re: [PATCH] D24401: clang-format: Add Java detection to git-clang-format.

lhchavez updated this revision to Diff 71087. lhchavez added a comment. Using arcanist to fix the paths as well https://reviews.llvm.org/D24401 Files: tools/clang-format/git-clang-format Index: tools/clang-format/git-clang-format

r281285 - Update Clang for D20147 ("DebugInfo: New metadata representation for global variables.")

Author: pcc Date: Mon Sep 12 20:13:19 2016 New Revision: 281285 URL: http://llvm.org/viewvc/llvm-project?rev=281285=rev Log: Update Clang for D20147 ("DebugInfo: New metadata representation for global variables.") Differential Revision: http://reviews.llvm.org/D20415 Modified:

[PATCH] D24487: [Clang] Fix some Clang-tidy modernize-use-bool-literals and Include What You Use warnings in AST; other minor fixes

Eugene.Zelenko created this revision. Eugene.Zelenko added reviewers: mehdi_amini, compnerd, Prazek. Eugene.Zelenko added a subscriber: cfe-commits. Eugene.Zelenko set the repository for this revision to rL LLVM. Herald added a subscriber: klimek. I checked this patch on my own build on RHEL 6.

[PATCH] D24488: Simplify Clang's version number configuration in CMake.

dlj created this revision. dlj added a reviewer: rsmith. dlj added a subscriber: cfe-commits. Herald added subscribers: mgorny, beanz. Simplify Clang's version number configuration in CMake. Currently, the Clang version is computed as follows: 1. LLVM defines major, minor, and patch

Re: [PATCH] D21506: [analyzer] Block in critical section

NoQ added a comment. I think there's still this problem i've outlined in the comment above: you can step into an integer-underflow if your analysis begins with unlock(). You could just ignore all unlocks that move you below 0, which would be ok. Could you add this test? std::mutex m; void

Re: [PATCH] D21698: [OpenCL] Allow disabling types and declarations associated with extensions

Anastasia added a comment. I have made an experiment with a simple kernel: void foo1(void); void foo2(void); void foo3(void); void foo4(void); void foo5(void); void foo6(void); void foo7(void); void foo8(void); void foo9(void); void foo10(void); void test(){ foo1();

Re: [PATCH] D24426: DebugInfo: Pass non-zero alignment to DIBuilder only if aligment was forced

On Mon, Sep 12, 2016 at 6:01 PM Robinson, Paul wrote: > The text in the committee draft is different (e.g., the exhortation about > non-default alignment is gone), with an example to the effect that a value > of 8 means the entity's address is a multiple of 8 (not 2^8).

r281286 - Fix interaction between serialization and c++1z feature.

Author: rtrieu Date: Mon Sep 12 20:20:40 2016 New Revision: 281286 URL: http://llvm.org/viewvc/llvm-project?rev=281286=rev Log: Fix interaction between serialization and c++1z feature. In c++1z, static_assert is not required to have a StringLiteral message, where previously it was required.

Re: [PATCH] D15075: No error for conflict between inputs\outputs and clobber list

ahatanak added a comment. You can create a separate patch for the changes made to lib/Headers/intrin.h and have it reviewed before committing this patch. Also, __dst, __x and __n should be added to the output list and "memory" to the clobber list as majnemer pointed out. I think you can use

r281287 - Handle empty message in static_asserts.

Author: rtrieu Date: Mon Sep 12 20:37:01 2016 New Revision: 281287 URL: http://llvm.org/viewvc/llvm-project?rev=281287=rev Log: Handle empty message in static_asserts. Modified: cfe/trunk/tools/libclang/CIndex.cpp Modified: cfe/trunk/tools/libclang/CIndex.cpp URL:

Re: [PATCH] D23820: Do not warn about format strings that are indexed string literals.

meikeb marked 6 inline comments as done. meikeb added a comment. Thanks for taking the time and doing these great reviews! Really appreciated! Comment at: lib/Sema/SemaChecking.cpp:4143-4150 @@ -4049,3 +4142,10 @@ if (StrE) { - CheckFormatString(S, StrE, E, Args,

Re: [PATCH] D24439: [Clang] Fix some Clang-tidy modernize-use-bool-literals and Include What You Use warnings; other minor fixes

Eugene.Zelenko updated this revision to Diff 71063. Eugene.Zelenko added a comment. Implement Saleem suggestions. Repository: rL LLVM https://reviews.llvm.org/D24439 Files: lib/Analysis/PrintfFormatString.cpp lib/Basic/Diagnostic.cpp lib/Basic/SourceManager.cpp

Re: [PATCH] D24439: [Clang] Fix some Clang-tidy modernize-use-bool-literals and Include What You Use warnings; other minor fixes

Eugene.Zelenko marked 3 inline comments as done. Eugene.Zelenko added a comment. Repository: rL LLVM https://reviews.llvm.org/D24439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23852: [SemaObjC] Fix crash while parsing type arguments and protocols

doug.gregor accepted this revision. doug.gregor added a comment. This revision is now accepted and ready to land. I don't love the fact that it makes callers fragile, but having to do tentative parsing for these otherwise-unambiguous cases is expensive (in compile time). We should only use

Re: [PATCH] D24426: DebugInfo: Pass non-zero alignment to DIBuilder only if aligment was forced

dblaikie added a comment. Like the backend patch, should/could this be broken up into separate patches for the different places/features that have alignment? (probably just passing zero for alignment in general could be a simple cleanup patch to start, if it's otherwise unused)

Re: [PATCH] D23079: ObjC: Use a new type for ObjC type parameter (patch 2 out of 3)

doug.gregor accepted this revision. doug.gregor added a comment. This revision is now accepted and ready to land. This looks great, thank you! https://reviews.llvm.org/D23079 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D24319: clang-format: Add a flag to limit git-clang-format's diff to a single commit

lodato added a subscriber: lodato. lodato added a comment. Hi lhchavez, This patch does not work as intended. If I understand correctly, you want to see if a given `` has any clang-format problems. However: 1. This patch only computes `changed_lines` from `` but then runs clang-format on the

Re: [PATCH] D23080: ObjC: Use a new type for ObjC type parameter (patch 3 out of 3)

doug.gregor accepted this revision. doug.gregor added a comment. This revision is now accepted and ready to land. Ahhh, much cleaner. Thanks! https://reviews.llvm.org/D23080 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D24059: NFC: refactor applyObjCProtocolQualifiers from SemaType.cpp to ASTContext so it can be shared.

doug.gregor accepted this revision. doug.gregor added a comment. This revision is now accepted and ready to land. Yep, this refactor looks good! https://reviews.llvm.org/D24059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r281275 - Fix a long comment line

Author: anemet Date: Mon Sep 12 18:48:11 2016 New Revision: 281275 URL: http://llvm.org/viewvc/llvm-project?rev=281275=rev Log: Fix a long comment line Modified: cfe/trunk/include/clang/Frontend/CodeGenOptions.def Modified: cfe/trunk/include/clang/Frontend/CodeGenOptions.def URL:

r281276 - Add -fdiagnostics-show-hotness

Author: anemet Date: Mon Sep 12 18:48:16 2016 New Revision: 281276 URL: http://llvm.org/viewvc/llvm-project?rev=281276=rev Log: Add -fdiagnostics-show-hotness Summary: I've recently added the ability for optimization remarks to include the hotness of the corresponding code region. This uses PGO

Re: [PATCH] D24469: [clang-cl] Diagnose duplicate uuids.

aaron.ballman added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2258 @@ -2257,1 +2257,3 @@ "uuid attribute contains a malformed GUID">; +def err_mismatched_uuid : Error<"uiid does not match previous declaration">; +def note_previous_uuid :

Re: [PATCH] D16171: Warning on redeclaring with a conflicting asm label

Sorry, I was distracted by other issues after I uploaded the patch. I will take another look of the implementation. Thanks, Weiming On 9/12/2016 1:31 PM, Sam Shepperd wrote: phabricss added a comment. On 09/12/2016 01:26 PM, Nick Lewycky wrote: Firstly, I thought glibc had applied a

Re: [PATCH] D24426: DebugInfo: Pass non-zero alignment to DIBuilder only if aligment was forced

probinson added a subscriber: probinson. Comment at: lib/CodeGen/CGDebugInfo.cpp:3691 @@ -3635,1 +3690,3 @@ + if (D->hasAttr()) +AlignInBits = D->getMaxAlignment(); StringRef DeclName, LinkageName; dblaikie wrote: > is max alignment the right thing here?

Re: r281057 - [DebugInfo] Ensure complete type is emitted with -fstandalone-debug

On Mon, Sep 12, 2016 at 11:41 AM, David Blaikie wrote: > (idle thought: It'd be good to make the code common between the first time > a type is encountered, and the later callbacks when the type is completed, > required to be complete, vtable is emitted, etc - the

Re: [PATCH] D24401: clang-format: Add Java detection to git-clang-format.

lhchavez updated this revision to Diff 71075. lhchavez added a comment. Generated the diff properly this time, and it now shows full context. Repository: rL LLVM https://reviews.llvm.org/D24401 Files: cfe/trunk/tools/clang-format/git-clang-format Index:

[PATCH] D24484: [analyzer] Fix ExprEngine::VisitMemberExpr

alexshap created this revision. alexshap added reviewers: NoQ, bcraig, zaks.anna. alexshap added a subscriber: cfe-commits. alexshap set the repository for this revision to rL LLVM. alexshap changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users".

Re: [PATCH] D24484: [analyzer] Fix ExprEngine::VisitMemberExpr

alexshap added a comment. 1. For the code: struct TestBufferStruct { int Buffer[3]; }; struct TestBufferStruct GetTestBufferStruct() { struct TestBufferStruct a; return a; } void AcceptPointer(int *a) { } void TestFunc() {

[PATCH] D24477: clang-format: [JS] Do not wrap taze: IWYU comments

mprobst created this revision. mprobst added a reviewer: djasper. mprobst added a subscriber: cfe-commits. Herald added a subscriber: klimek. See (sorry, internal link): go/taze#global-symbols-dts-externs. Before: // taze: many, different, symbols from // //some/long/iwyu/style/target

Re: [PATCH] D23284: Add -fdiagnostics-show-hotness

This revision was automatically updated to reflect the committed changes. Closed by commit rL281276: Add -fdiagnostics-show-hotness (authored by anemet). Changed prior to commit: https://reviews.llvm.org/D23284?vs=70547=71078#toc Repository: rL LLVM https://reviews.llvm.org/D23284 Files:

r281277 - [Sema] Fix PR30346: relax __builtin_object_size checks.

Author: gbiv Date: Mon Sep 12 18:50:35 2016 New Revision: 281277 URL: http://llvm.org/viewvc/llvm-project?rev=281277=rev Log: [Sema] Fix PR30346: relax __builtin_object_size checks. This patch makes us act more conservatively when trying to determine the objectsize for an array at the end of an

r281278 - [DebugInfo] Deduplicate debug info limiting logic

Author: rnk Date: Mon Sep 12 19:01:23 2016 New Revision: 281278 URL: http://llvm.org/viewvc/llvm-project?rev=281278=rev Log: [DebugInfo] Deduplicate debug info limiting logic We should be doing the same checks when a type is completed as we do when a complete type is used during emission.

  1   2   >