[PATCH] D26546: [PPC] Add vec_insert4b/vec_extract4b to altivec.h

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. Overall, I'd like to see another revision of this. This is not because I feel the patch requires major rework, but because there is a number of minor comments that I'd like to

[PATCH] D27033: [ASTImporter] Support importing UnresolvedLookupExpr nodes

khazem created this revision. khazem added reviewers: spyffe, dergachev.a. khazem added subscribers: cfe-commits, phosek, seanklein. This patch adds support for importing AST nodes of type UnresolvedLookupExpr, as well as a test for such an import. This resolves an issue where attempting to

[PATCH] D26882: Refactor how FunctionDecl handles constexpr:

nwilson added inline comments. Comment at: include/clang/AST/Decl.h:1915 +IsConstexprSpecified = IC; +IsConstexpr = IC; + } hubert.reinterpretcast wrote: > How is the `inline` property transmitted here? Why does the > `setImplicitlyConstexpr` function

[libcxx] r287732 - Don't "LIBCPP_ONLY(stuff;)" at namespace scope.

Author: caseycarter Date: Tue Nov 22 19:44:53 2016 New Revision: 287732 URL: http://llvm.org/viewvc/llvm-project?rev=287732=rev Log: Don't "LIBCPP_ONLY(stuff;)" at namespace scope. Differential review: https://reviews.llvm.org/D27029 Modified:

r287733 - [X86] Replace valignd/q builtins with appropriate __builtin_shufflevector.

Author: ctopper Date: Tue Nov 22 19:47:12 2016 New Revision: 287733 URL: http://llvm.org/viewvc/llvm-project?rev=287733=rev Log: [X86] Replace valignd/q builtins with appropriate __builtin_shufflevector. Modified: cfe/trunk/include/clang/Basic/BuiltinsX86.def

[PATCH] D26903: [libcxx] Add tests (but not implementation)

EricWF accepted this revision. EricWF added a reviewer: EricWF. EricWF added a comment. This revision is now accepted and ready to land. Checking these into libc++ shortly. (But I'm disabling them for libc++ for obvious reasons). https://reviews.llvm.org/D26903

[PATCH] D26903: [libcxx] Add tests (but not implementation)

EricWF closed this revision. EricWF added a comment. r287728. https://reviews.llvm.org/D26903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26885: [libcxx] Fix max_size() across all containers

EricWF updated this revision to Diff 79007. EricWF updated the summary for this revision. EricWF added a comment. Address mclows changes https://reviews.llvm.org/D26885 Files: .clang-format include/__hash_table include/__tree include/deque include/forward_list include/list

[libcxx] r287729 - [libcxx] Fix max_size() across all containers

Author: ericwf Date: Tue Nov 22 19:18:56 2016 New Revision: 287729 URL: http://llvm.org/viewvc/llvm-project?rev=287729=rev Log: [libcxx] Fix max_size() across all containers Summary: The `max_size()` method of containers should respect both the allocator's reported `max_size` and the range of

[PATCH] D26885: [libcxx] Fix max_size() across all containers

EricWF added a comment. This patch reminds me; The way we test our containers is ridiculous. We should have a single template that tests the container requirements, and each container test should just use that template. Anyway. accepting before commit. Comment at:

[PATCH] D27029: [libc++] [test] Unbreak variant::swap test for non-libc++ libraries

CaseyCarter created this revision. CaseyCarter added reviewers: EricWF, mclow.lists. CaseyCarter added a subscriber: cfe-commits. `LIBCPP_ONLY(foo;)` at namespace scope is bad, and it should feel bad. https://reviews.llvm.org/D27029 Files:

[PATCH] D26964: Handle more declarations in DeclContextPrinter to fix -print-decl-contexts crashes

arphaman created this revision. arphaman added reviewers: rsmith, mehdi_amini. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch handles more declarations in DeclContextPrinter to avoid crashes when clang is given the

[PATCH] D26968: [ARM] Add Driver support for emmitting the missing Tag_ABI_enum_size build attribute values

labrinea created this revision. labrinea added reviewers: cfe-commits, rengolin. Herald added a subscriber: aemerson. The ABI for the ARM architecture describes four build attribute values for the size of

r287639 - Make llvm::Error generated from replacement interfaces more specific.

Author: ioeric Date: Tue Nov 22 07:46:42 2016 New Revision: 287639 URL: http://llvm.org/viewvc/llvm-project?rev=287639=rev Log: Make llvm::Error generated from replacement interfaces more specific. Summary: The new error information contains the type of error (e.g. overlap or bad file path) and

[PATCH] D26853: Make llvm::Error generated from replacement interfaces more specific.

This revision was automatically updated to reflect the committed changes. Closed by commit rL287639: Make llvm::Error generated from replacement interfaces more specific. (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D26853?vs=78733=78861#toc Repository: rL LLVM

[PATCH] D26966: [clang-move] Add some options allowing to add old/new.h to new/old.h respectively.

hokein created this revision. hokein added a reviewer: ioeric. hokein added a subscriber: cfe-commits. - --new_depend_on_old: new header will include old header - --old_depend_on_new: old header will include new header. https://reviews.llvm.org/D26966 Files: clang-move/ClangMove.cpp

[PATCH] D26960: [docs] Use x86_64 and i386 instead of x86 as arch for triples.

fhahn created this revision. fhahn added reviewers: rengolin, silvas. fhahn added a subscriber: cfe-commits. x86 is not a valid arch for target triples, but x86_64 and i386 are. https://reviews.llvm.org/D26960 Files: docs/CrossCompilation.rst Index: docs/CrossCompilation.rst

[PATCH] D26137: [clang-tidy] Add check name to YAML export

Alpha added a comment. Ping Repository: rL LLVM https://reviews.llvm.org/D26137 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26966: [clang-move] Add some options allowing to add old/new.h to new/old.h respectively.

ioeric added inline comments. Comment at: clang-move/ClangMove.cpp:309 + llvm::StringRef FileName, bool IsHeader = false, + StringRef OldHeaderInclude = "") { std::string NewCode; How do you handle the case

r287633 - Missing initializer.

Author: axel Date: Tue Nov 22 04:00:23 2016 New Revision: 287633 URL: http://llvm.org/viewvc/llvm-project?rev=287633=rev Log: Missing initializer. Modified: cfe/trunk/include/clang/AST/DeclFriend.h Modified: cfe/trunk/include/clang/AST/DeclFriend.h URL:

[PATCH] D26978: [Sema][Atomics] Treat expected pointer in compare exchange atomics as _Nonnull

rjmccall added a comment. LGTM. Repository: rL LLVM https://reviews.llvm.org/D26978 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D13289: [libc++] Provide additional templates for valarray transcendentals that satisfy the standard synopsis

jasonliu added a comment. Ping. Any review for this patch? It would be great if we can get this issue fixed. https://reviews.llvm.org/D13289 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26991: Hoist redundant load

hiraditya created this revision. hiraditya added reviewers: EricWF, mclow.lists. hiraditya added a subscriber: cfe-commits. Worked with Sebastian Pop https://reviews.llvm.org/D26991 Files: libcxx/include/algorithm Index: libcxx/include/algorithm

[PATCH] D26546: [PPC] Add vec_insert4b/vec_extract4b to altivec.h

sfertile updated this revision to Diff 78911. sfertile added a comment. Fixed spelling error in comment Repository: rL LLVM https://reviews.llvm.org/D26546 Files: include/clang/Basic/BuiltinsPPC.def lib/CodeGen/CGBuiltin.cpp lib/Headers/altivec.h test/CodeGen/builtins-ppc-p9vector.c

[PATCH] D26984: Unconditionally pass -lto_library, remove -Wliblto warning.

thakis closed this revision. thakis added a comment. 287685, thanks! https://reviews.llvm.org/D26984 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r287687 - Cleanup module.modulemap

Author: ericwf Date: Tue Nov 22 14:00:21 2016 New Revision: 287687 URL: http://llvm.org/viewvc/llvm-project?rev=287687=rev Log: Cleanup module.modulemap Modified: libcxx/trunk/include/module.modulemap Modified: libcxx/trunk/include/module.modulemap URL:

[PATCH] D26979: Do not hard-code locale data in unit tests: get it from the OS instead

vangyzen added a comment. @EricWF, would you like to see anything more from me? I could set up an LLVM development environment on my Mac if you want me to run the unit tests on Mac. https://reviews.llvm.org/D26979 ___ cfe-commits mailing list

[PATCH] D26920: Add validation to Stage 2 of num_get

vangyzen added a comment. On Fedora 24, all std/localization test results are as expected. On FreeBSD 11, all std/.../category.numeric tests pass, and there are no additional unexpected results under std/localization. While I'm on that topic: Under std/localization, the number of unexpected

Re: [PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

After some discussion on IRC, we agreed to give https://reviews.llvm.org/D26984 a try. On Tue, Nov 22, 2016 at 11:41 AM, Mehdi Amini wrote: > This has been like that forever, this is not new with 3.9. > Note also that the system ar/ranlib are sensitive to the environment

r287685 - darwin: Unconditionally pass -lto_library, remove -Wliblto warning.

Author: nico Date: Tue Nov 22 13:38:07 2016 New Revision: 287685 URL: http://llvm.org/viewvc/llvm-project?rev=287685=rev Log: darwin: Unconditionally pass -lto_library, remove -Wliblto warning. https://reviews.llvm.org/D25932 made it so that clang always checks if libLTO.dylib is present on

[PATCH] D26979: Do not hard-code locale data in unit tests: get it from the OS instead

vangyzen updated this revision to Diff 78919. vangyzen added a comment. Fix comment vim + Caps Lock == :( https://reviews.llvm.org/D26979 Files: test/std/localization/locale.categories/facet.numpunct/locale.numpunct.byname/grouping.pass.cpp

[PATCH] D26979: Do not hard-code locale data in unit tests: get it from the OS instead

vangyzen updated this revision to Diff 78916. vangyzen added a comment. Reset the global locale so it's different than the one we pass to std::locale l(...). That way we're testing that we don't accidentally use the global locale. https://reviews.llvm.org/D26979 Files:

[PATCH] D26979: Do not hard-code locale data in unit tests: get it from the OS instead

vangyzen added inline comments. Comment at: test/std/localization/locale.categories/facet.numpunct/locale.numpunct.byname/thousands_sep.pass.cpp:50 +} std::locale l(LOCALE_en_US_UTF_8); { EricWF wrote: > I think we should reset the

[PATCH] D26984: Unconditionally pass -lto_library, remove -Wliblto warning.

rnk accepted this revision. rnk added a comment. lgtm, great idea! https://reviews.llvm.org/D26984 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26984: Unconditionally pass -lto_library, remove -Wliblto warning.

mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. LGTM, thanks! https://reviews.llvm.org/D26984 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26984: Unconditionally pass -lto_library, remove -Wliblto warning.

thakis created this revision. thakis added reviewers: rnk, mehdi_amini. thakis added a subscriber: cfe-commits. https://reviews.llvm.org/D25932 made it so that clang always checks if libLTO.dylib is present on disk, even if -flto is not being used. The motivation for that change was that if a

[PATCH] D26944: Suppress -Wliblto warning when -flto is not present

rnk abandoned this revision. rnk added a comment. Superseded by https://reviews.llvm.org/D26984 https://reviews.llvm.org/D26944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r287689 - Add test for D21736.

Author: koriakin Date: Tue Nov 22 14:03:40 2016 New Revision: 287689 URL: http://llvm.org/viewvc/llvm-project?rev=287689=rev Log: Add test for D21736. Differential Revision: http://reviews.llvm.org/D21741 Modified: cfe/trunk/test/Profile/c-indirect-call.c

[PATCH] D21737: [PATCH] [CodeGen] Insert TargetLibraryInfoWrapperPass before anything else.

This revision was automatically updated to reflect the committed changes. Closed by commit rL287688: [CodeGen] Insert TargetLibraryInfoWrapperPass before anything else. (authored by koriakin). Changed prior to commit: https://reviews.llvm.org/D21737?vs=75550=78917#toc Repository: rL LLVM

[PATCH] D26979: Do not hard-code locale data in unit tests: get it from the OS instead

vangyzen updated this revision to Diff 78921. vangyzen added a comment. Remove XFAIL on linux-gnu These tests now pass on Fedora 24. https://reviews.llvm.org/D26979 Files: test/std/localization/locale.categories/facet.numpunct/locale.numpunct.byname/grouping.pass.cpp

[PATCH] D26546: [PPC] Add vec_insert4b/vec_extract4b to altivec.h

sfertile marked an inline comment as done. sfertile added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:8185 + +// Need to cast the second argument from a vector of cahr to a vector +// of long long. syzaara wrote: > tiny comment, char is

[libcxx] r287690 - Attempt to fix stdint/cstdint modules try 2

Author: ericwf Date: Tue Nov 22 14:05:19 2016 New Revision: 287690 URL: http://llvm.org/viewvc/llvm-project?rev=287690=rev Log: Attempt to fix stdint/cstdint modules try 2 Added: libcxx/trunk/test/libcxx/modules/cinttypes_exports.sh.cpp

[PATCH] D26196: Add support for non-zero null pointer for C and OpenCL

rjmccall added a comment. In https://reviews.llvm.org/D26196#602660, @yaxunl wrote: > > But if you do need to support these conversions for some reason, the > > correct behavior is to ensure that null is mapped to null. > > I only need to do this for constant folding, right? I found that the

[PATCH] D21741: Add test for D21736 + D21737.

This revision was automatically updated to reflect the committed changes. Closed by commit rL287689: Add test for D21736. (authored by koriakin). Changed prior to commit: https://reviews.llvm.org/D21741?vs=61922=78918#toc Repository: rL LLVM https://reviews.llvm.org/D21741 Files:

r287688 - [CodeGen] Insert TargetLibraryInfoWrapperPass before anything else.

Author: koriakin Date: Tue Nov 22 14:03:35 2016 New Revision: 287688 URL: http://llvm.org/viewvc/llvm-project?rev=287688=rev Log: [CodeGen] Insert TargetLibraryInfoWrapperPass before anything else. Currently, TargetLibraryInfoWrapperPass is inserted by PMBuilder. However, some passes are

[PATCH] D23835: [compiler-rt] tsan/tests: Add missing -I for top-level include directory

mgorny abandoned this revision. mgorny added a comment. In https://reviews.llvm.org/D23835#602545, @dvyukov wrote: > What is standalone build? A stand-alone build is a build performed outside LLVM source tree, e.g. out of split checkout, done against installed LLVM. In this case, with

r287691 - Remove variable only used in an assertion.

Author: rjmccall Date: Tue Nov 22 14:12:32 2016 New Revision: 287691 URL: http://llvm.org/viewvc/llvm-project?rev=287691=rev Log: Remove variable only used in an assertion. Modified: cfe/trunk/lib/CodeGen/CGBlocks.cpp Modified: cfe/trunk/lib/CodeGen/CGBlocks.cpp URL:

[libcxx] r287693 - Allow libc++ to use modules in C++03.

Author: ericwf Date: Tue Nov 22 14:15:39 2016 New Revision: 287693 URL: http://llvm.org/viewvc/llvm-project?rev=287693=rev Log: Allow libc++ to use modules in C++03. Libc++ internal uses in C++03 code but the module map forbids its use. This causes the libc++ 'std' module to fail to build in

[PATCH] D26968: [ARM] Add Driver support for emitting the missing Tag_ABI_enum_size build attribute values

labrinea added inline comments. Comment at: lib/Basic/Targets.cpp:5407 + Builder.defineMacro("__ARM_SIZEOF_MINIMAL_ENUM", + Opts.ShortEnums || Opts.ABIEnums ? "1" : "4"); rengolin wrote: > Isn't ABIEnums 4? Shouldn't this be: > >

[PATCH] D26137: [clang-tidy] Add check name to YAML export

malcolm.parsons added a comment. What happens to diagnostics without fixes? e.g. from the readability-function-size check. Repository: rL LLVM https://reviews.llvm.org/D26137 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26968: [ARM] Add Driver support for emitting the missing Tag_ABI_enum_size build attribute values

rengolin added inline comments. Comment at: lib/Basic/Targets.cpp:5407 + Builder.defineMacro("__ARM_SIZEOF_MINIMAL_ENUM", + Opts.ShortEnums || Opts.ABIEnums ? "1" : "4"); labrinea wrote: > rengolin wrote: > > Isn't ABIEnums 4?

[PATCH] D26968: [ARM] Add Driver support for emitting the missing Tag_ABI_enum_size build attribute values

rengolin added a comment. Hi Alexandros, My interpretation of `Tag_ABI_enum_size` is that value 3 is that **all** enums are 32-bit and value 4 is that only those ABI-visible (ie. public interfaces) have to be 32-bits. This is similar to the other PCS tags. So, the table is: - 0: no enums -

[PATCH] D23835: [compiler-rt] tsan/tests: Add missing -I for top-level include directory

dvyukov added a comment. What is standalone build? And how does it fail? https://reviews.llvm.org/D23835 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26453: [clang-tidy] Remove duplicated check from move-constructor-init

malcolm.parsons updated this revision to Diff 78867. malcolm.parsons added a comment. Mention in release notes. https://reviews.llvm.org/D26453 Files: clang-tidy/cert/CERTTidyModule.cpp clang-tidy/misc/MoveConstructorInitCheck.cpp clang-tidy/misc/MoveConstructorInitCheck.h

[PATCH] D26137: [clang-tidy] Add check name to YAML export

Alpha added a comment. This shouldn't affect diagnostics without fixes. If there is no fix, there won't be anything to export, and the diagnostic just behaves normally. Repository: rL LLVM https://reviews.llvm.org/D26137 ___ cfe-commits mailing

Re: [PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

I would also note that llvm 3.9.x and 4.0svn also require use of their own llvm-ar and llvm-ranlib for archiving under -flto as well (beyond using the matching libLTO.dylib). On Tue, Nov 22, 2016 at 12:59 AM, Mehdi Amini wrote: > Double-checked on the latest binary release

[PATCH] D26636: patch for llvm/clang bug 25965, suppress warning diagnostic on float-to-bool conversion when in condition context

mibintc added a comment. BTW I tried a couple different approaches to suppress the message. One of them was to call IgnoreParenImpCasts(). This worked great to suppress the unwanted diagnostic but the call also inhibited constant folding and dead code elimination, so there were many test

[PATCH] D26137: [clang-tidy] Add check name to YAML export

malcolm.parsons added a comment. In https://reviews.llvm.org/D26137#602591, @Alpha wrote: > This shouldn't affect diagnostics without fixes. If there is no fix, there > won't be anything to export, and the diagnostic just behaves normally. That's a shame; I need a machine readable report of

[PATCH] D26137: [clang-tidy] Add check name to YAML export

Alpha added a comment. In https://reviews.llvm.org/D26137#602602, @malcolm.parsons wrote: > In https://reviews.llvm.org/D26137#602591, @Alpha wrote: > > > This shouldn't affect diagnostics without fixes. If there is no fix, there > > won't be anything to export, and the diagnostic just behaves

[PATCH] D26968: [ARM] Add Driver support for emitting the missing Tag_ABI_enum_size build attribute values

labrinea added a comment. Your suggestion that if all four options are mutually exclusive, then they should be a single integer option, totally makes sense to me. We could use a single integer option and make the old boolean flags deprecated (i.e. map '-fshort-enums' and 'fno-short enums' to

[PATCH] D26966: [clang-move] Add some options allowing to add old/new.h to new/old.h respectively.

hokein updated this revision to Diff 78874. hokein marked 8 inline comments as done. hokein added a comment. Address review comments. https://reviews.llvm.org/D26966 Files: clang-move/ClangMove.cpp clang-move/ClangMove.h clang-move/tool/ClangMoveMain.cpp

[PATCH] D26196: Add support for non-zero null pointer for C and OpenCL

yaxunl marked 3 inline comments as done. yaxunl added a comment. > But if you do need to support these conversions for some reason, the correct > behavior is to ensure that null is mapped to null. I only need to do this for constant folding, right? I found that the current implementation is

Re: [PATCH] D25932: Unconditionally pass `-lto_library` to the linker on Darwin

This has been like that forever, this is not new with 3.9. Note also that the system ar/ranlib are sensitive to the environment DYLD_LIBRARY_PATH and will look for libLTO appropriately (since they aren’t invoked with clang, we haven’t been able to do any “magic” here yet). — Mehdi > On Nov

[PATCH] D26968: [ARM] Add Driver support for emitting the missing Tag_ABI_enum_size build attribute values

rengolin added a comment. How does GCC behave with those arguments? Thinking back now, we may be required to follow, as the principle of least surprise has to hold. https://reviews.llvm.org/D26968 ___ cfe-commits mailing list

[PATCH] D26966: [clang-move] Add some options allowing to add old/new.h to new/old.h respectively.

hokein added inline comments. Comment at: clang-move/ClangMove.cpp:309 + llvm::StringRef FileName, bool IsHeader = false, + StringRef OldHeaderInclude = "") { std::string NewCode; ioeric wrote: > How do you

[PATCH] D26966: [clang-move] Add some options allowing to add old/new.h to new/old.h respectively.

ioeric added inline comments. Comment at: clang-move/ClangMove.cpp:604 + // Post process of cleanup around all the replacements. + for (auto& It: FileToReplacements) { +StringRef FilePath = It.first; Maybe call this `FileAndReplacements` instead of `It`,

[clang-tools-extra] r287649 - [clang-rename] Prune away AST nodes more correctly and effectively when looking for a point

Author: d0k Date: Tue Nov 22 11:29:45 2016 New Revision: 287649 URL: http://llvm.org/viewvc/llvm-project?rev=287649=rev Log: [clang-rename] Prune away AST nodes more correctly and effectively when looking for a point Due to the way the preprocessor works nodes can be half in a macro or a

[PATCH] D26636: patch for llvm/clang bug 25965, suppress warning diagnostic on float-to-bool conversion when in condition context

erichkeane added a comment. I believe that this is a good patch that solves an open Bug. See : https://llvm.org/bugs/show_bug.cgi?id=25965 I think the SPEC case is much less compelling, but I think that using a float explicitly in a conditional is something I really wouldn't expect a warning

[PATCH] D26978: [Sema][Atomics] Treat expected pointer in compare exchange atomics as _Nonnull

arphaman created this revision. arphaman added reviewers: rsmith, manmanren. arphaman added a subscriber: cfe-commits. arphaman set the repository for this revision to rL LLVM. This patch teaches clang that it has to emit a warning when NULL is passed as the 'expected' pointer parameter into an

[PATCH] D26546: [PPC] Add vec_insert4b/vec_extract4b to altivec.h

kbarton accepted this revision. kbarton added a comment. This revision is now accepted and ready to land. LGTM, but I'd like @nemanjai to have a quick look at the __builtin_vsx_insertword and __builtin_vsx_extractuword too. Repository: rL LLVM https://reviews.llvm.org/D26546

[PATCH] D26546: [PPC] Add vec_insert4b/vec_extract4b to altivec.h

nemanjai added inline comments. Comment at: lib/CodeGen/CGBuiltin.cpp:8182 +ConstantInt *ArgCI = dyn_cast(Ops[2]); +assert(ArgCI); +int64_t index = clamp(ArgCI->getSExtValue(), 0, 12); ```assert(ArgCI && "The third operand of this intrinsic must be a

[PATCH] D27007: Remove C++ default arg side table for MS ABI ctor closures

rnk added a comment. It's worth pointing out that we have a few more side tables right next door in ASTContext, addCopyConstructorForExceptionObject / getCopyConstructorForExceptionObject. It looks like if those aren't populated, they we might copy the bytes of an exception when catching

[PATCH] D27007: Remove C++ default arg side table for MS ABI ctor closures

rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: lib/Sema/SemaExprCXX.cpp:861 // friendship or any other means). Context.addCopyConstructorForExceptionObject(Subobject, CD);

[PATCH] D27005: [lit] Support custom parsers in parseIntegratedTestScript

mgrang added a comment. I ran pep8 on this script: line 742: E302 expected 2 blank lines, found 1 line 757: E302 expected 2 blank lines, found 1 line 819: E301 expected 1 blank line, found 0 Can you pep-ify this script? https://reviews.llvm.org/D27005

[PATCH] D26903: [libcxx] Add tests (but not implementation)

EricWF marked 45 inline comments as done. EricWF added a comment. Address almost all inline comments. Comment at: test/std/utilities/variant/variant.get/get_if_index.pass.cpp:92 +V v(42l); +ASSERT_SAME_TYPE(decltype(std::get_if<1>(std::addressof(v))), long*); +

[PATCH] D26903: [libcxx] Add tests (but not implementation)

STL_MSFT added inline comments. Comment at: test/std/utilities/variant/variant.helpers/variant_alternative.pass.cpp:33 +void test() { +static_assert(std::is_same_v< +typename std::variant_alternative::type, E>, ""); EricWF wrote: > STL_MSFT

[PATCH] D27014: [libcxx] [test] Fix MSVC warning C4018 "signed/unsigned mismatch", part 2/12.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix MSVC warning C4018 "signed/unsigned mismatch", part 2/12. Add static_cast when comparing int to std::size_t. Also, include when it wasn't already being

[PATCH] D27018: [libcxx] [test] Fix MSVC warning C4018 "signed/unsigned mismatch", part 5/12.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix MSVC warning C4018 "signed/unsigned mismatch", part 5/12. Various changes:

[PATCH] D27016: [libcxx] [test] Fix MSVC warning C4018 "signed/unsigned mismatch", part 4/12.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix MSVC warning C4018 "signed/unsigned mismatch", part 4/12. Change "int j;" indices to "std::size_t j;". Also, include when it wasn't already being

[PATCH] D27005: [lit] Support custom parsers in parseIntegratedTestScript

EricWF updated this revision to Diff 78988. EricWF added a comment. Pepify the changed lines. https://reviews.llvm.org/D27005 Files: utils/lit/lit/TestRunner.py Index: utils/lit/lit/TestRunner.py === ---

[PATCH] D27024: [libcxx] [test] Fix MSVC warning C4389 "signed/unsigned mismatch", part 11/12.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix MSVC warning C4389 "signed/unsigned mismatch", part 11/12. Change "unsigned n = 0;" to "int n = 0;". It's being compared to int elements and ptrdiff_t

[PATCH] D26903: [libcxx] Add tests (but not implementation)

CaseyCarter added inline comments. Comment at: test/std/utilities/variant/variant.helpers/variant_alternative.pass.cpp:33 +void test() { +static_assert(std::is_same_v< +typename std::variant_alternative::type, E>, ""); STL_MSFT wrote: > EricWF

[PATCH] D27029: [libc++] [test] Unbreak variant::swap test for non-libc++ libraries

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. Sorry my bad. I thought `LIBCPP_ONLY` expanded to nothing for non-libc++. https://reviews.llvm.org/D27029 ___ cfe-commits mailing list

r287713 - Make diagnostic for use of default member initializer before enclosing class is

Author: rsmith Date: Tue Nov 22 16:55:12 2016 New Revision: 287713 URL: http://llvm.org/viewvc/llvm-project?rev=287713=rev Log: Make diagnostic for use of default member initializer before enclosing class is complete a little more general; it is produced in other cases than the one that it

[PATCH] D27005: [lit] Support custom parsers in parseIntegratedTestScript

EricWF created this revision. EricWF added reviewers: ddunbar, modocache, rnk, danalbert, jroelofs. EricWF added subscribers: cfe-commits, llvm-commits. Libc++ frequently has the need to parse more than just the builtin *test keywords* (`RUN`, `REQUIRES`, `XFAIL`, ect). For example libc++

[PATCH] D27007: Remove C++ default arg side table for MS ABI ctor closures

rnk created this revision. rnk added reviewers: thakis, rsmith, majnemer. rnk added a subscriber: cfe-commits. We don't need a side table in ASTContext to hold CXXDefaultArgExprs. The important part of building the CXXDefaultArgExprs was to ODR use the default argument expressions, not to make

[PATCH] D26903: [libcxx] Add tests (but not implementation)

EricWF marked an inline comment as done. EricWF added inline comments. Comment at: test/std/utilities/variant/variant.variant/variant.swap/swap.pass.cpp:487 +// This is why variant should SFINAE member hash. :-) +template class std::variant; +

[PATCH] D27005: [lit] Support custom parsers in parseIntegratedTestScript

jroelofs added a comment. Should probably add a testcase in lit/tests that exercises the new CUSTOM parser stuff, so people working on LIT don't have to build/test libc++ in order to know whether they've broken its testsuite. https://reviews.llvm.org/D27005

[PATCH] D27015: [libcxx] [test] Fix MSVC warning C4018 "signed/unsigned mismatch", part 3/12.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix MSVC warning C4018 "signed/unsigned mismatch", part 3/12. Change unsigned to int in parameters. https://reviews.llvm.org/D27015 Files:

[PATCH] D27019: [libcxx] [test] Fix MSVC warning C4245 "conversion from 'X' to 'Y', signed/unsigned mismatch", part 6/12.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix MSVC warning C4245 "conversion from 'X' to 'Y', signed/unsigned mismatch", part 6/12. Add static_cast when initializing unsigned integers with negative

[PATCH] D27020: [libcxx] [test] Fix MSVC warning C4245 "conversion from 'X' to 'Y', signed/unsigned mismatch", part 7/12.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix MSVC warning C4245 "conversion from 'X' to 'Y', signed/unsigned mismatch", part 7/12. When initializing unsigned integers to their maximum values, change

[PATCH] D27022: [libcxx] [test] Fix MSVC warning C4389 "signed/unsigned mismatch", part 9/12.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix MSVC warning C4389 "signed/unsigned mismatch", part 9/12. Add static_cast to more comparisons. (Performed manually, unlike part 8/12.) Also, include

[PATCH] D27023: [libcxx] [test] Fix MSVC warning C4389 "signed/unsigned mismatch", part 10/12.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix MSVC warning C4389 "signed/unsigned mismatch", part 10/12. Add static_cast. In these cases, the values are guaranteed to be small-ish, and they're being

[PATCH] D26903: [libcxx] Add tests (but not implementation)

CaseyCarter added a comment. Other than the note in variant.variant\variant.swap\swap.pass.cpp, all passes pass and all fails fail with out implementation. Comment at: test/std/utilities/variant/variant.variant/variant.swap/swap.pass.cpp:487 +// This is why variant should

[PATCH] D27025: [libcxx] [test] Fix MSVC warning C4389 "signed/unsigned mismatch", part 12/12.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. Herald added a subscriber: mehdi_amini. [libcxx] [test] Fix MSVC warning C4389 "signed/unsigned mismatch", part 12/12. Various changes:

[PATCH] D27026: [libcxx] [test] Fix copy-paste silliness; ULL can't ever be 32-bit.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix copy-paste silliness; ULL can't ever be 32-bit. https://reviews.llvm.org/D27026 Files:

[PATCH] D27027: [libcxx] [test] Strip trailing whitespace.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Strip trailing whitespace. https://reviews.llvm.org/D27027 Files: test/std/algorithms/alg.sorting/alg.clamp/clamp.comp.pass.cpp

[PATCH] D26903: [libcxx] Add tests (but not implementation)

CaseyCarter added inline comments. Comment at: test/std/utilities/variant/variant.hash/hash.pass.cpp:34 + +void test_hash_variant() +{ This is non-portable. The fact that both your implementation and mine pass this test suggests they both have poor QoI: There's

Re: r287229 - Link include-fixer into libclang if clang-tools-extra is checked out.

I just did a fresh build with `cmake -GNinja ../llvm-rw/ -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_ASSERTIONS=ON`. `ninja check-clang` failed with: FAILED: lib/libclang.so.4.0 : && /usr/bin/c++ -fPIC -fPIC -fvisibility-inlines-hidden -Wall -W -Wno-unused-parameter -Wwrite-strings -Wcast-qual

[PATCH] D26903: [libcxx] Add tests (but not implementation)

EricWF added inline comments. Comment at: test/std/utilities/variant/variant.helpers/variant_size.pass.cpp:41 +{ +test, 0>(); +test, 1>(); CaseyCarter wrote: > STL_MSFT wrote: > > Hmm, is this cromulent now that empty

  1   2   >