[PATCH] D27250: [OpenMP] TargetLibraryInfo from "declare simd".

fpetrogalli added a comment. In https://reviews.llvm.org/D27250#609006, @ABataev wrote: > Hi! Thanks for your review! > 1. Please provide full context for your changes (check this document how to > do this http://llvm.org/docs/Phabricator.html). I missed that out, should be done now. > 2.

[PATCH] D27142: [clang-tidy] Make format style customizable

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG. Thanks! Repository: rL LLVM https://reviews.llvm.org/D27142 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27251: [PPC] some bugs mainly about sign problem fixed in altivec.h

jtony added inline comments. Comment at: lib/Headers/altivec.h:16456 #ifdef __VSX__ static __inline__ vector signed long long __ATTRS_o_ai Thanks a lot for your good catch for the macro issue in vec_xst_be, that's a good catch. BTW, Can you move this up

Re: [PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

So remove the ifStmt from the third and fourth case? So that I keep if(str1.compare(str2)) and if(!str1.compare(str2)), and change the other two to str1.compare(str2) == 0 and str1.compare(str2) != 0 ? That makes good sense. Then I could also add some of the test cases you mentioned earlier. On

[PATCH] D27253: Protect futures test under libcpp-no-exceptions

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D27253 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27109: [OpenCL] Prevent generation of globals in non-constant address space for OpenCL

Anastasia closed this revision. Anastasia added a comment. Committed in r288163. https://reviews.llvm.org/D27109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27252: Protect sequences test under libcpp-no-exceptions

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. LGTM> https://reviews.llvm.org/D27252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

malcolm.parsons added a comment. I don't know why you're restricting this check to only match within the condition of an if statement. https://reviews.llvm.org/D27210 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27254: Protect optional test under libcpp-no-exceptions

rogfer01 added inline comments. Comment at: test/std/experimental/optional/optional.specalg/swap.pass.cpp:225 } +#ifndef TEST_HAS_NO_EXCEPTIONS { mclow.lists wrote: > Why is this here, and not before line L#236? Yep, I'm wrong here. Probably a fallout

[PATCH] D27263: Address of bitfield in anonymous struct doesn't error.

jacobly created this revision. jacobly added a subscriber: cfe-commits. struct A { struct { int B : 1; } } int A::*addr_anon_bitfield() { return ::B; } This code does not error, but instead returns a member pointer to a full int that starts at the beginning of the

[PATCH] D27255: Protect std::ostream::sentry test under libcpp-no-exceptions

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D27255 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27199: [libcxx] Make std::ignore constexpr

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. This looks good to me. https://reviews.llvm.org/D27199 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27254: Protect optional test under libcpp-no-exceptions

rogfer01 updated this revision to Diff 79765. rogfer01 added a comment. Protect the right set of tests. https://reviews.llvm.org/D27254 Files: test/std/experimental/optional/optional.specalg/swap.pass.cpp Index: test/std/experimental/optional/optional.specalg/swap.pass.cpp

Re: [RFC] Embedded bitcode and related upstream (Part II)

Hi Steven, On Fri, Jun 3, 2016 at 2:36 PM, Steven Wu via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi everyone > > I am still in the process of upstreaming some improvements to the embed > bitcode option. If you want more background, you can read the previous RFC ( >

[PATCH] D26137: [clang-tidy] Add check name to YAML export

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Looks mostly good. A few more nits. Comment at: include/clang/Tooling/Core/Diagnostic.h:68-71 + /// A freeform chunk of text to describe the context of the

[PATCH] D27254: Protect optional test under libcpp-no-exceptions

mclow.lists added inline comments. Comment at: test/std/experimental/optional/optional.specalg/swap.pass.cpp:225 } +#ifndef TEST_HAS_NO_EXCEPTIONS { Why is this here, and not before line L#236? https://reviews.llvm.org/D27254

[PATCH] D27054: Introducing clang::tooling::EditList for refactoring tools.

ioeric updated this revision to Diff 79736. ioeric added a comment. - Added replace() and insert() to replace current replacement interfaces. https://reviews.llvm.org/D27054 Files: include/clang/Tooling/Refactoring/EditList.h lib/Tooling/CMakeLists.txt

[PATCH] D27250: [OpenMP] TargetLibraryInfo from "declare simd".

fpetrogalli added a comment. In https://reviews.llvm.org/D27250#609063, @ABataev wrote: > You did just some minor changes. The main questions are still unanswered. Hopefully now they are! :) Francesco https://reviews.llvm.org/D27250 ___

[PATCH] D26979: Do not hard-code locale data in unit tests: get it from the OS instead

vangyzen added a comment. > @EricWF Do you have time and interest to review this again? I should ask, do you have time and interest to //commit// this? https://reviews.llvm.org/D26979 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27066: Fix crash with unsupported architectures in Linux/Gnu target triples.

fhahn added a comment. Ping. https://reviews.llvm.org/D27066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

madsravn updated this revision to Diff 79747. madsravn marked 2 inline comments as done. madsravn added a comment. Added integerLiteral on both sides of the == operator. https://reviews.llvm.org/D27210 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp

Re: [PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

On 30 November 2016 at 17:18, Mads Ravn wrote: > So remove the ifStmt from the third and fourth case? I was thinking all cases. Can the first case be restricted to casts to bool? If not, keep the cast to int case with an ifStmt and add a cast to bool case. Does it matter

[PATCH] D27266: [libcxx] [test] Remove spurious semicolons.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Remove spurious semicolons. https://reviews.llvm.org/D27266 Files:

[PATCH] D27267: [libcxx] [test] Fix MSVC x64 warning C4267 "conversion from 'size_t' to 'int' [or 'unsigned int'], possible loss of data", part 1/4.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix MSVC x64 warning C4267 "conversion from 'size_t' to 'int' [or 'unsigned int'], possible loss of data", part 1/4. Replace "int n = str_.size();" with "int

[PATCH] D26836: [analyzer] SValExplainer: Support ObjC ivars and __block variables.

NoQ abandoned this revision. NoQ added a comment. Decided to go ahead and commit as r288260. https://reviews.llvm.org/D26836 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D21099: [Sema] Teach -Wcast-align to look at the aligned attribute of the declared variables

This revision was automatically updated to reflect the committed changes. Closed by commit rL288267: [Sema] Teach -Wcast-align to look at the aligned attribute of the (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D21099?vs=78594=79792#toc Repository: rL LLVM

r288267 - [Sema] Teach -Wcast-align to look at the aligned attribute of the

Author: ahatanak Date: Wed Nov 30 13:42:03 2016 New Revision: 288267 URL: http://llvm.org/viewvc/llvm-project?rev=288267=rev Log: [Sema] Teach -Wcast-align to look at the aligned attribute of the declared variables. Teach Sema to check the aligned attribute attached to variable declarations so

Re: [RFC] Embedded bitcode and related upstream (Part II)

On 30 November 2016 at 15:46, Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi Steven, > > On Fri, Jun 3, 2016 at 2:36 PM, Steven Wu via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Hi everyone >> >> I am still in the process of upstreaming some improvements to the

Re: [PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

I think I got it. I will throw a new diff up within the hour. Thanks for the ideas :) On Wed, Nov 30, 2016 at 6:48 PM Malcolm Parsons wrote: > On 30 November 2016 at 17:18, Mads Ravn wrote: > > So remove the ifStmt from the third and fourth case?

[PATCH] D26753: ASTImporter: improve support for C++ templates

khazem added a comment. Sorry for the late comment, but one of the tests that this introduces is breaking on my end: /usr/local/google/home/khazem/doc/llvm/tools/clang/test/ASTMerge/class-template-partial-spec.cpp:9:11: error: expected string not found in input // CHECK:

[PATCH] D27277: Make _LIBCPP_DEPRECATED_ABI_DISABLE_PAIR_TRIVIAL_COPY_CTOR user-settable

dim created this revision. dim added reviewers: EricWF, emaste, mclow.lists, theraven. dim added a subscriber: cfe-commits. In https://reviews.llvm.org/rL275749 the old _LIBCPP_TRIVIAL_PAIR_COPY_CTOR define was replaced by _LIBCPP_DEPRECATED_ABI_DISABLE_PAIR_TRIVIAL_COPY_CTOR, which is also

r288260 - [analyzer] SValExplainer: Support ObjC ivars and __block variables.

Author: dergachev Date: Wed Nov 30 12:26:43 2016 New Revision: 288260 URL: http://llvm.org/viewvc/llvm-project?rev=288260=rev Log: [analyzer] SValExplainer: Support ObjC ivars and __block variables. Additionally, explain the difference between normal and heap-based symbolic regions. Added:

[PATCH] D27210: [clang-tidy] misc-string-compare. Adding a new check to clang-tidy

madsravn updated this revision to Diff 79788. madsravn added a comment. Trimmed down the ast matcher a little. https://reviews.llvm.org/D27210 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/MiscTidyModule.cpp clang-tidy/misc/StringCompareCheck.cpp

[PATCH] D27091: Add the way to extract SVals of arguments used in a call for a given StackFrameCtx

zaks.anna added a comment. > Hmm, i'm thinking of just the opposite - refactor the CallEvent methods to > use the respective new ProgramState methods. > > This way we'd avoid touching the CallEvent allocator for a simple Environment > lookup, while still avoiding code duplication. I see what

[PATCH] D27268: [libcxx] [test] Fix MSVC x64 warning C4267 "conversion from 'size_t' to 'int' [or 'unsigned int'], possible loss of data", part 2/4.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix MSVC x64 warning C4267 "conversion from 'size_t' to 'int' [or 'unsigned int'], possible loss of data", part 2/4. Use static_cast when storing size_t in

[PATCH] D27270: [libcxx] [test] Fix MSVC x64 warning C4267 "conversion from 'size_t' to 'int' [or 'unsigned int'], possible loss of data", part 4/4.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix MSVC x64 warning C4267 "conversion from 'size_t' to 'int' [or 'unsigned int'], possible loss of data", part 4/4. Change a few allocators'

[PATCH] D26657: [Sema] Respect DLL attributes more faithfully

hans added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:7439 +void Sema::ActOnDLLAttr(ClassTemplateSpecializationDecl *Def, +InheritableAttr *Attr) { + // We reject explicit instantiations in class scope, so there should

r288263 - [analyzer] Construct temporary objects of correct types, destroy them properly.

Author: dergachev Date: Wed Nov 30 13:02:44 2016 New Revision: 288263 URL: http://llvm.org/viewvc/llvm-project?rev=288263=rev Log: [analyzer] Construct temporary objects of correct types, destroy them properly. When constructing a temporary object region, which represents the result of

r288257 - [analyzer] Minor fixes and improvements to debug.ExprInspection

Author: dergachev Date: Wed Nov 30 11:57:18 2016 New Revision: 288257 URL: http://llvm.org/viewvc/llvm-project?rev=288257=rev Log: [analyzer] Minor fixes and improvements to debug.ExprInspection - Fix the bug with transition handling in ExprInspectionChecker's checkDeadSymbols implementation.

[PATCH] D26835: [analyzer] Minor fixes and improvements to debug.ExprInspection

This revision was automatically updated to reflect the committed changes. Closed by commit rL288257: [analyzer] Minor fixes and improvements to debug.ExprInspection (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D26835?vs=78468=79776#toc Repository: rL LLVM

[PATCH] D27091: Add the way to extract SVals of arguments used in a call for a given StackFrameCtx

zaks.anna added a comment. Artem just pointed out that I have "Smalls" instead of "SVals" in my first comment. https://reviews.llvm.org/D27091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27180: Testbed and skeleton of a new expression parser

spyffe marked 3 inline comments as done. spyffe added a comment. Thank you for your review, Vedant! I will update the patch to reflect your comments in a moment. > I'm concerned about the amount of covered-but-untested code this patch > introduces. Since there are no CHECK lines, it's hard

[PATCH] D25263: [Driver] Allow setting the default linker during build

sfertile added inline comments. Comment at: lib/Driver/ToolChain.cpp:721-724 + +const char *ToolChain::getDefaultLinker() const { + return CLANG_DEFAULT_LINKER; +} Hahnfeld wrote: > I think this could go into the header The CLANG_DEFAULT_LINKER macro is getting

[PATCH] D25435: Add -femit-accurate-debug-info to emit more debug info for sample pgo profile collection

danielcdh updated this revision to Diff 79770. danielcdh added a comment. change the flag name to -fprofile-debug https://reviews.llvm.org/D25435 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def lib/CodeGen/BackendUtil.cpp lib/CodeGen/CGDebugInfo.cpp

[PATCH] D27269: [libcxx] [test] Fix MSVC x64 warning C4267 "conversion from 'size_t' to 'int' [or 'unsigned int'], possible loss of data", part 3/4.

STL_MSFT created this revision. STL_MSFT added reviewers: EricWF, mclow.lists. STL_MSFT added a subscriber: cfe-commits. [libcxx] [test] Fix MSVC x64 warning C4267 "conversion from 'size_t' to 'int' [or 'unsigned int'], possible loss of data", part 3/4.

[PATCH] D27090: Add LocationContext as a parameter to checkRegionChanges

zaks.anna added a comment. Thank you for doing this!!! Artem, do you want to disallow the creation of successors from checkRegionChanges callback or can this go in as is? Anna. Comment at: lib/StaticAnalyzer/Checkers/CheckerDocumentation.cpp:240 - /// #checkRegionChanges

[PATCH] D26267: [Modules] Include builtins with #include instead of #import for ObjC

bruno added inline comments. Comment at: lib/Frontend/FrontendActions.cpp:227 +IsBuiltin = true; + addHeaderInclude(H.NameAsWritten, Includes, LangOpts, Module->IsExternC, + IsBuiltin /*AlwaysInclude*/); rsmith wrote: > I don't

Re: [PATCH] D26267: [Modules] Include builtins with #include instead of #import for ObjC

On 30 November 2016 at 11:08, Bruno Cardoso Lopes via Phabricator via cfe-commits wrote: > > I suspect the problem is instead that #import just doesn't work properly > with modules > > (specifically, either with local submodule visibility or with modules > that do not

[clang-tools-extra] r288258 - [clang-tidy] Make format style customizable

Author: jdevlieghere Date: Wed Nov 30 12:06:42 2016 New Revision: 288258 URL: http://llvm.org/viewvc/llvm-project?rev=288258=rev Log: [clang-tidy] Make format style customizable Summary: I came across an outstanding FIXME to make the format style customizable. Inspired by the include fixer, I

[PATCH] D26839: [analyzer] An attempt to fix pr19539 - crashes on temporaries life-extended via members

This revision was automatically updated to reflect the committed changes. Closed by commit rL288263: [analyzer] Construct temporary objects of correct types, destroy them properly. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D26839?vs=79540=79783#toc Repository:

[PATCH] D14274: Add alloc_size attribute to clang

george.burgess.iv added a comment. Ping https://reviews.llvm.org/D14274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r288272 - Prospective MSVC workaround.

Author: rjmccall Date: Wed Nov 30 14:46:55 2016 New Revision: 288272 URL: http://llvm.org/viewvc/llvm-project?rev=288272=rev Log: Prospective MSVC workaround. Modified: cfe/trunk/lib/CodeGen/CGObjCGNU.cpp Modified: cfe/trunk/lib/CodeGen/CGObjCGNU.cpp URL:

[PATCH] D25216: Improve error message when referencing a non-tag type with a tag

rnk updated this revision to Diff 79805. rnk added a comment. - rebase https://reviews.llvm.org/D25216 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp lib/Sema/SemaTemplate.cpp lib/Sema/TreeTransform.h test/CXX/basic/basic.lookup/basic.lookup.elab/p2.cpp

[PATCH] D25216: Improve error message when referencing a non-tag type with a tag

rsmith added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:4556-4558 + "%0 is a %select{non-tag type|typedef|type alias|template|type alias " + "template|template template argument}1 that cannot be referenced with a " +

[PATCH] D25475: [analyzer] Add a new SVal to support pointer-to-member operations.

dcoughlin added a comment. PointerToMemberData looks like it is on the right track! One thing that is still missing is using the base specifier list to figure out the correct subobject field to read and write from. This is important when there is non-virtual multiple inheritance, as there will

[PATCH] D25581: Implement __builtin_alloca_with_align for GCC compatibility

rnk abandoned this revision. rnk added a subscriber: majnemer. rnk added a comment. @majnemer did this in https://reviews.llvm.org/rL285544 https://reviews.llvm.org/D25581 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26454: Implement no_sanitize_address for global vars

dougk added a comment. Suppression of sanitizing is necessary if the variable is magically a memory-mapped device I/O address. The linker can arrange for this to be the case using fancy scripts, or even just as simple as a section attribute that requires that you take up exactly a certain

r288269 - Finish adopting ConstantInitBuilder in CGObjCGNU. NFC.

Author: rjmccall Date: Wed Nov 30 14:19:46 2016 New Revision: 288269 URL: http://llvm.org/viewvc/llvm-project?rev=288269=rev Log: Finish adopting ConstantInitBuilder in CGObjCGNU. NFC. Modified: cfe/trunk/lib/CodeGen/CGObjCGNU.cpp cfe/trunk/lib/CodeGen/ConstantBuilder.h Modified:

[PATCH] D25216: Improve error message when referencing a non-tag type with a tag

inglorion added a comment. I like it. I'll give others a little time to respond, but if no objections are raised and nobody else accepts first, I'll accept it tomorrow. https://reviews.llvm.org/D25216 ___ cfe-commits mailing list

[PATCH] D27180: Testbed and skeleton of a new expression parser

spyffe updated this revision to Diff 79807. spyffe marked an inline comment as done. spyffe added a comment. Updated to reflect Vedant's comments. Also ensured 100% test coverage, by removing handling for errors that will never happen and by adding a few new tests. Repository: rL LLVM

[PATCH] D27254: Protect optional test under libcpp-no-exceptions

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. Looks good now - thanks. https://reviews.llvm.org/D27254 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27279: Store decls in prototypes on the declarator instead of in the AST

rnk created this revision. rnk added a reviewer: rsmith. rnk added subscribers: cfe-commits, jmolloy. This saves two pointers (!) from FunctionDecl that were being used for some rare and questionable C-only functionality. The DeclsInPrototypeScope ArrayRef was added in r151712 in order to parse

[PATCH] D27180: Testbed and skeleton of a new expression parser

vsk added a comment. Looks good. Apart from some nitpicks, I'm happy with this. This isn't really my area so it'd be good to get an explicit lgtm from one of the reviewers. Comment at: tools/clang-import-test/CMakeLists.txt:7 + clang-import-test.cpp + ) +

[PATCH] D25216: Improve error message when referencing a non-tag type with a tag

rnk added a comment. Ping, found this in my tree. Maybe you weren't that excited about the wording change. https://reviews.llvm.org/D25216 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26588: Add LocationContext to members of check::RegionChanges

NoQ commandeered this revision. NoQ added a reviewer: k-wisniewski. NoQ added a comment. Seems to become outdated with https://reviews.llvm.org/D27090. https://reviews.llvm.org/D26588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26589: Add static analyzer checker for finding infinite recursion

NoQ commandeered this revision. NoQ added a reviewer: k-wisniewski. NoQ added a comment. Seems to become outdated with https://reviews.llvm.org/D27092. https://reviews.llvm.org/D26589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27248: [clang-tidy] Do not trigger unnecessary-value-param check on methods marked as final

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. Repository: rL LLVM https://reviews.llvm.org/D27248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27054: Introducing clang::tooling::EditList for refactoring tools.

ioeric added a comment. Ping. Daniel, could you take a look? Manuel and I would like your opinion on this. https://reviews.llvm.org/D27054 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27248: [clang-tidy] Do not trigger unnecessary-value-param check on methods marked as final

malcolm.parsons added inline comments. Comment at: test/clang-tidy/performance-unnecessary-value-param.cpp:276 +// Virtual method overrides of dependent types cannot be recognized unless they +// are marked as override or final. Test that check is not triggered on methods +//

[PATCH] D27091: Add the way to extract SVals of arguments used in a call for a given StackFrameCtx

NoQ added a comment. Hmm, i'm thinking of just the opposite - refactor the CallEvent methods to use the respective new ProgramState methods. This way we'd avoid touching the CallEvent allocator for a simple Environment lookup, while still avoiding code duplication.

[PATCH] D26760: Add the way to extract SVals of arguments used in a call for a given StackFrameCtx

NoQ commandeered this revision. NoQ edited reviewers, added: k-wisniewski; removed: NoQ. NoQ added a comment. Seems to become outdated with https://reviews.llvm.org/D27091. https://reviews.llvm.org/D26760 ___ cfe-commits mailing list

[PATCH] D27054: Introducing clang::tooling::EditList for refactoring tools.

djasper added inline comments. Comment at: include/clang/Tooling/Refactoring/EditList.h:41 + /// \brief Creates an edit list for a key position. + EditList(const SourceManager , SourceLocation KeyPosition); + I wonder whether we should always use a

[PATCH] D27084: [OpenMP] Sema and parsing for 'teams distribute parallel for simd' pragma

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D27084 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26922: [ObjC++] Don't enter a C++ declarator context when the current context is an Objective-C declaration

arphaman added a comment. In https://reviews.llvm.org/D26922#608815, @ahatanak wrote: > Yes, I meant ParseDecl:5266. Reading the comment in > ShouldEnterDeclaratorScope, it seemed to me that it shouldn't return true in > this context (when parsing an objective-c). Yes, I agree that it's

[PATCH] D27250: [OpenMP] TargetLibraryInfo from "declare simd".

fpetrogalli created this revision. fpetrogalli added a reviewer: cfe-commits. This patch generates a list of global external variables that are passed to the llvm::TargetLibraryInfo (TLI) to enable the vectorization of loops containing calls to function that are marked with a #pragma omp declare

[PATCH] D26922: [ObjC++] Don't enter a C++ declarator context when the current context is an Objective-C declaration

arphaman added a comment. In https://reviews.llvm.org/D26922#608815, @ahatanak wrote: > Yes, I meant ParseDecl:5266. Reading the comment in > ShouldEnterDeclaratorScope, it seemed to me that it shouldn't return true in > this context (when parsing an objective-c). > > Also, the following code

[PATCH] D27255: Protect std::ostream::sentry test under libcpp-no-exceptions

rogfer01 created this revision. rogfer01 added reviewers: mclow.lists, EricWF, rmaprath. rogfer01 added a subscriber: cfe-commits. Skip test that throws an exception. https://reviews.llvm.org/D27255 Files: test/std/input.output/iostream.format/output.streams/ostream_sentry/destruct.pass.cpp

[PATCH] D26922: [ObjC++] Don't enter a C++ declarator context when the current context is an Objective-C declaration

arphaman added a comment. > Also, the following code (which is not valid) crashes with ToT trunk, > > @property (nonatomic) int OuterType::InnerType > > > but compiles without any errors with your patch applied. Do you know why > clang doesn't error out? This worked because clang continued

[PATCH] D27054: Introducing clang::tooling::EditList for refactoring tools.

ioeric updated this revision to Diff 79716. ioeric marked 4 inline comments as done. ioeric added a comment. - Addressed review comments. https://reviews.llvm.org/D27054 Files: include/clang/Tooling/Refactoring/EditList.h lib/Tooling/CMakeLists.txt lib/Tooling/Refactoring/CMakeLists.txt

[PATCH] D27054: Introducing clang::tooling::EditList for refactoring tools.

ioeric added inline comments. Comment at: include/clang/Tooling/Refactoring/EditList.h:41 + /// \brief Creates an edit list for a key position. + EditList(const SourceManager , SourceLocation KeyPosition); + djasper wrote: > I wonder whether we should always

[PATCH] D27252: Protect sequences test under libcpp-no-exceptions

rogfer01 created this revision. rogfer01 added reviewers: mclow.lists, EricWF, rmaprath. rogfer01 added a subscriber: cfe-commits. Replace throw with TEST_THROW and protect tests that do throw. Also add missing assert(false). https://reviews.llvm.org/D27252 Files:

[PATCH] D27253: Protect futures test under libcpp-no-exceptions

rogfer01 created this revision. rogfer01 added reviewers: mclow.lists, EricWF, rmaprath. rogfer01 added a subscriber: cfe-commits. Skip tests that expect an exception be thrown. https://reviews.llvm.org/D27253 Files: test/std/thread/futures/futures.promise/move_assign.pass.cpp Index:

[PATCH] D27254: Protect optional test under libcpp-no-exceptions

rogfer01 created this revision. rogfer01 added reviewers: mclow.lists, EricWF, rmaprath. rogfer01 added a subscriber: cfe-commits. Replace throw with TEST_THROW and skip tests that throw exceptions https://reviews.llvm.org/D27254 Files:

[PATCH] D26922: [ObjC++] Don't enter a C++ declarator context when the current context is an Objective-C declaration

arphaman updated this revision to Diff 79722. arphaman added a comment. The updated patch performs the check in `ShouldEnterDeclaratorScope`. Repository: rL LLVM https://reviews.llvm.org/D26922 Files: lib/Parse/ParseDecl.cpp lib/Sema/SemaCXXScopeSpec.cpp test/SemaObjCXX/crash.mm

[PATCH] D27054: Introducing clang::tooling::EditList for refactoring tools.

ioeric added inline comments. Comment at: include/clang/Tooling/Refactoring/EditList.h:41 + /// \brief Creates an edit list for a key position. + EditList(const SourceManager , SourceLocation KeyPosition); + klimek wrote: > ioeric wrote: > > djasper wrote: > >

[PATCH] D27250: [OpenMP] TargetLibraryInfo from "declare simd".

ABataev requested changes to this revision. ABataev added a comment. This revision now requires changes to proceed. 1. Please provide full context for your changes (check this document how to do this http://llvm.org/docs/Phabricator.html). 2. Use clang-format for all your changes. 3. Do not use

[PATCH] D27066: Fix crash with unsupported architectures in Linux/Gnu target triples.

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM. Thanks! https://reviews.llvm.org/D27066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r288269 - Finish adopting ConstantInitBuilder in CGObjCGNU. NFC.

So, I always push for leading upper case variable names. Over time we've gotten to the point where the majority of the code that I read in clang follows this convention. You seem to be pushing the other direction. What do you think we should be doing? I'll admit the LLVM naming conventions are

[PATCH] D27284: [ClangTidy] Add new performance-type-promotion-in-math-fn check.

jlebar added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/performance-type-promotion-in-math-fn.rst:6 + +Finds calls to math.h functions with implicit float to double promotions. + Eugene.Zelenko wrote: > Please enclose math.h, float

[PATCH] D27284: [ClangTidy] Add new performance-type-promotion-in-math-fn check.

jlebar updated this revision to Diff 79829. jlebar marked 3 inline comments as done. jlebar added a comment. Formatting fixes in documentation. https://reviews.llvm.org/D27284 Files: clang-tools-extra/clang-tidy/performance/CMakeLists.txt

[PATCH] D27251: [PPC] some bugs mainly about sign problem fixed in altivec.h

Zeson updated this revision to Diff 79856. Zeson added a comment. Make vec_xst_be and vec_xl_be test cases put together seperately in `builtins-ppc-vsx.c` Move up macro `__VSX__` to make all vec_xst_be functions included https://reviews.llvm.org/D27251 Files: lib/Headers/altivec.h

r288301 - PR31081: ignore exception specifications when deducing function template

Author: rsmith Date: Wed Nov 30 20:11:49 2016 New Revision: 288301 URL: http://llvm.org/viewvc/llvm-project?rev=288301=rev Log: PR31081: ignore exception specifications when deducing function template arguments from a declaration; despite what the standard says, this form of deduction should not

[PATCH] D26837: [analyzer] Litter the SVal/SymExpr/MemRegion class hierarchy with asserts.

zaks.anna added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h:23 #include "clang/StaticAnalyzer/Core/PathSensitive/StoreRef.h" +#include "clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h" It's a bit sad

r288305 - P0012R1: add Itanium ABI support for throwing non-noexcept function pointers and catching as noexcept.

Author: rsmith Date: Wed Nov 30 21:32:42 2016 New Revision: 288305 URL: http://llvm.org/viewvc/llvm-project?rev=288305=rev Log: P0012R1: add Itanium ABI support for throwing non-noexcept function pointers and catching as noexcept. Added: cfe/trunk/test/CodeGenCXX/rtti-qualfn.cpp Modified:

[PATCH] D26546: [PPC] Add vec_insert4b/vec_extract4b to altivec.h

sfertile updated this revision to Diff 79860. sfertile marked an inline comment as done. sfertile added a comment. Changed all variable names to start with capitals, added description strings to the assertions, changed uses of '12' to MaxIndex and initialized the arrays in their definition.

[PATCH] D27284: [ClangTidy] Add new performance-type-promotion-in-math-fn check.

jlebar created this revision. jlebar added a subscriber: cfe-commits. Herald added a subscriber: mgorny. This checks for calls to double-precision math.h with single-precision arguments. For example, it suggests replacing ::sin(0.f) with ::sinf(0.f). https://reviews.llvm.org/D27284 Files:

[PATCH] D27214: [ObjC] Encode type arguments in property information string constants

ahatanak added a comment. Do you know whether this patch would have any effect on the objective-c runtime? I suspect it wouldn't cause the runtime to crash, but I don't know how the runtime uses the encoded type information. Other than that, the changes made in this patch look good to me.

[PATCH] D22862: [analyzer] Fix for PR15623: eliminate unwanted ProgramState checker data propagation.

dcoughlin accepted this revision. dcoughlin added a comment. Overall, this looks good to me. Thanks for tackling this! One request, though. Could you move the tests into already existing test files? We're trying to avoid test files that only test a single issue. This makes it easier for people

r288289 - Introduce a type-safe enum for ForDefinition.

Author: rjmccall Date: Wed Nov 30 17:25:13 2016 New Revision: 288289 URL: http://llvm.org/viewvc/llvm-project?rev=288289=rev Log: Introduce a type-safe enum for ForDefinition. Modified: cfe/trunk/lib/CodeGen/CGCXX.cpp cfe/trunk/lib/CodeGen/CodeGenModule.cpp

[PATCH] D27284: [ClangTidy] Add new performance-type-promotion-in-math-fn check.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/performance-type-promotion-in-math-fn.rst:6 + +Finds calls to math.h functions with implicit float to double promotions. + jlebar wrote: > Eugene.Zelenko wrote: > >

  1   2   >