[PATCH] D27053: [CodeCompletion] Provide Objective-C class property completion results

manmanren accepted this revision. manmanren added a comment. This revision is now accepted and ready to land. LGTM . Manman Comment at: lib/Sema/SemaCodeComplete.cpp:3763 +if (!M->getSelector().isUnarySelector() || +M->getReturnType()->isVoidType() || M->is

[PATCH] D27166: [clang-tidy] Enhance modernize-use-auto to templated function casts

malcolm.parsons added a comment. ping. https://reviews.llvm.org/D27166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27523: [change-namespace] don't fix using shadow decls in classes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL288919: [change-namespace] don't fix using shadow decls in classes. (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D27523?vs=80613&id=80615#toc Repository: rL LLVM https://r

[clang-tools-extra] r288919 - [change-namespace] don't fix using shadow decls in classes.

Author: ioeric Date: Wed Dec 7 11:04:07 2016 New Revision: 288919 URL: http://llvm.org/viewvc/llvm-project?rev=288919&view=rev Log: [change-namespace] don't fix using shadow decls in classes. Summary: Using shadow declarations in classes always refers to base class, which does not need to be fix

[PATCH] D27523: [change-namespace] don't fix using shadow decls in classes.

ioeric updated this revision to Diff 80613. ioeric added a comment. - address review comment. https://reviews.llvm.org/D27523 Files: change-namespace/ChangeNamespace.cpp unittests/change-namespace/ChangeNamespaceTests.cpp Index: unittests/change-namespace/ChangeNamespaceTests.cpp =

[PATCH] D27523: [change-namespace] don't fix using shadow decls in classes.

bkramer accepted this revision. bkramer added inline comments. This revision is now accepted and ready to land. Comment at: change-namespace/ChangeNamespace.cpp:331 + // Using shadow declarations in classes always refers to base class, which + // does not need to be qualified s

[PATCH] D27408: [analyzer] RetainCountChecker: remove unused enum value; NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rL288917: [analyzer] Remove an unused enum value in RetainCountChecker. (authored by dergachev). Changed prior to commit: https://reviews.llvm.org/D27408?vs=80431&id=80608#toc Repository: rL LLVM http

r288917 - [analyzer] Remove an unused enum value in RetainCountChecker.

Author: dergachev Date: Wed Dec 7 10:51:54 2016 New Revision: 288917 URL: http://llvm.org/viewvc/llvm-project?rev=288917&view=rev Log: [analyzer] Remove an unused enum value in RetainCountChecker. No functional change intended. Differential Revision: https://reviews.llvm.org/D27408 Modified:

[PATCH] D27438: clang-format-vsix: add a date stamp to the VSIX version number to ensure upgradability

hans added a comment. In https://reviews.llvm.org/D27438#615396, @amaiorano wrote: > > Yes, I think this is still a worthwhile change. Let's add the hour and > > minute and get it landed. > > Alright, added hour and minute. How do we land this change? Is this something > I can now do myself? Or

[PATCH] D27409: [analyzer] RetainCountChecker: The callback in dispatch_data_create() doesn't free the return symbol.

NoQ retitled this revision from "[analyzer] RetainCountChecker: Improve support for libdispatch APIs." to "[analyzer] RetainCountChecker: The callback in dispatch_data_create() doesn't free the return symbol.". NoQ updated the summary for this revision. NoQ updated this revision to Diff 80606. No

[PATCH] D26196: Add support for non-zero null pointer for C and OpenCL

yaxunl updated the summary for this revision. yaxunl updated this revision to Diff 80600. yaxunl marked an inline comment as done. yaxunl added a comment. Revised by John's comments. Fixed typos. Changed parameter of performAddrSpaceCast. Fixed constant folding of ptrtoint with side effect and ad

[PATCH] D26503: [Parser][ObjC] Improve diagnostics and recovery when C++ keywords are used as identifiers in Objective-C++

manmanren accepted this revision. manmanren added a comment. This revision is now accepted and ready to land. LGTM Manman Repository: rL LLVM https://reviews.llvm.org/D26503 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

r288914 - [analyzer] pr31226: Disable CastSizeChecker in C++ because it's not quite ready.

Author: dergachev Date: Wed Dec 7 10:12:26 2016 New Revision: 288914 URL: http://llvm.org/viewvc/llvm-project?rev=288914&view=rev Log: [analyzer] pr31226: Disable CastSizeChecker in C++ because it's not quite ready. Avoids a crash and a related false positive. Investigation by Daniel Krupp! Mo

[PATCH] D26196: Add support for non-zero null pointer for C and OpenCL

yaxunl marked 4 inline comments as done. yaxunl added inline comments. Comment at: lib/CodeGen/CGExprScalar.cpp:1532 + return llvm::ConstantInt::get(ConvertType(DestTy), + CGF.getContext().getTargetNullPtrValue(E->getType())); assert(!DestTy->isBooleanType() &&

[PATCH] D27123: Add AVR target and toolchain to Clang

jroelofs added a comment. In https://reviews.llvm.org/D27123#615738, @saaadhu wrote: > Thanks, setting DoubleFormat and LongDoubleFormat fixed the __DBL_ and > __LDBL_ differences. Also, setting SigAtomicType fixed the __SIG_ATOMIC_ > differences as well. I've added those defines to the test. U

[PATCH] D27304: [PATCH] [Sema][X86] Don't allow floating-point return types when SSE is disabled

thegameg added a comment. LLVM patch here: https://reviews.llvm.org/D27522 https://reviews.llvm.org/D27304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27523: [change-namespace] don't fix using shadow decls in classes.

ioeric created this revision. ioeric added a reviewer: bkramer. ioeric added a subscriber: cfe-commits. Using shadow declarations in classes always refers to base class, which does not need to be fixed/qualified since it can be inferred from inheritance. https://reviews.llvm.org/D27523 Files:

[PATCH] D15994: Allow for unfinished #if blocks in preambles.

erikjv updated this revision to Diff 80589. https://reviews.llvm.org/D15994 Files: include/clang/Lex/Preprocessor.h include/clang/Lex/PreprocessorLexer.h include/clang/Lex/PreprocessorOptions.h include/clang/Serialization/ASTBitCodes.h lib/Frontend/ASTUnit.cpp lib/Lex/Lexer.cpp lib/

[PATCH] D15994: Allow for unfinished #if blocks in preambles.

erikjv marked 7 inline comments as done. erikjv added inline comments. Comment at: lib/Serialization/ASTReader.cpp:2816 +} +PP.setReplayablePreambleConditionalStack(ConditionalStack); + } rsmith wrote: > Why can't we set the conditional stack

[PATCH] D27520: [clang-tidy] Add check for redundant function pointer dereferences

malcolm.parsons created this revision. malcolm.parsons added reviewers: alexfh, aaron.ballman, hokein. malcolm.parsons added a subscriber: cfe-commits. Herald added subscribers: JDevlieghere, mgorny. See https://youtu.be/6eX9gPithBo https://reviews.llvm.org/D27520 Files: clang-tidy/readabilit

[clang-tools-extra] r288908 - [change-namespace] move template class forward-declarations and don't move fwd-decls in classes.

Author: ioeric Date: Wed Dec 7 08:20:52 2016 New Revision: 288908 URL: http://llvm.org/viewvc/llvm-project?rev=288908&view=rev Log: [change-namespace] move template class forward-declarations and don't move fwd-decls in classes. Summary: Forward declarations in moved namespaces should be moved

[PATCH] D27515: [change-namespace] move template class forward-declarations and don't move fwd-decls in classes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL288908: [change-namespace] move template class forward-declarations and don't move fwd… (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D27515?vs=80571&id=80586#toc Repository:

[PATCH] D23130: [Clang-tidy] Add a check for definitions in the global namespace.

malcolm.parsons added inline comments. Comment at: clang-tidy/google/GoogleTidyModule.cpp:68 +CheckFactories.registerCheck( +"google-global-names"); CheckFactories.registerCheck( bkramer wrote: > aaron.ballman wrote: > > Given that this was shipp

[PATCH] D27123: Add AVR target and toolchain to Clang

saaadhu updated this revision to Diff 80575. saaadhu added a comment. Thanks, setting DoubleFormat and LongDoubleFormat fixed the __DBL_ and __LDBL_ differences. Also, setting SigAtomicType fixed the __SIG_ATOMIC_ differences as well. I've added those defines to the test. Unrelated, but I also r

[PATCH] D23130: [Clang-tidy] Add a check for definitions in the global namespace.

bkramer added inline comments. Comment at: clang-tidy/google/GlobalNamesCheck.cpp:90 +// extern "C" globals need to be in the global namespace. +if (VDecl->isExternC()) + return; alexfh wrote: > Is this already filtered-out by the matcher? Nope. ==

[PATCH] D23130: [Clang-tidy] Add a check for definitions in the global namespace.

bkramer updated this revision to Diff 80574. bkramer marked 9 inline comments as done. bkramer added a comment. Herald added a subscriber: JDevlieghere. - Moved external linkage check to matcher - added msvcrt entry point check - fixed comment typos. https://reviews.llvm.org/D23130 Files: cla

[PATCH] D27515: [change-namespace] move template class forward-declarations and don't move fwd-decls in classes.

ioeric created this revision. ioeric added a reviewer: bkramer. ioeric added a subscriber: cfe-commits. Forward declarations in moved namespaces should be moved back to the old namespaces. We should also move template class forward declarations. Also fix a bug that moves forward declarations of n

[PATCH] D16533: Bug 20796 - GCC's -Wstrict-prototypes warning not implemented in Clang

This revision was automatically updated to reflect the committed changes. Closed by commit rL288896: Implement the -Wstrict-prototypes warning (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D16533?vs=80285&id=80560#toc Repository: rL LLVM https://reviews.llvm.org/

r288896 - Implement the -Wstrict-prototypes warning

Author: arphaman Date: Wed Dec 7 04:52:18 2016 New Revision: 288896 URL: http://llvm.org/viewvc/llvm-project?rev=288896&view=rev Log: Implement the -Wstrict-prototypes warning This commit fixes PR20796. It implements the C only -Wstrict-prototypes warning. Clang now emits a warning for function

[PATCH] D26546: [PPC] Add vec_insert4b/vec_extract4b to altivec.h

nemanjai requested changes to this revision. nemanjai added a comment. This revision now requires changes to proceed. The finalized wording for vec_insert4b: Let W be the first doubleword element of ARG1, truncated to 32 bits. The result vector is formed by inserting W into ARG2 at the byte posi

[PATCH] D26922: [ObjC++] Don't enter a C++ declarator context when the current context is an Objective-C declaration

This revision was automatically updated to reflect the committed changes. Closed by commit rL288893: [ObjC++] Don't enter a C++ declarator scope when the current context is (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D26922?vs=79722&id=80556#toc Repository: rL L

r288893 - [ObjC++] Don't enter a C++ declarator scope when the current context is

Author: arphaman Date: Wed Dec 7 04:24:44 2016 New Revision: 288893 URL: http://llvm.org/viewvc/llvm-project?rev=288893&view=rev Log: [ObjC++] Don't enter a C++ declarator scope when the current context is an Objective-C declaration This commit ensures that Sema won't enter a C++ declarator scop

[PATCH] D27478: Make ASTContext::getDeclAlign return the correct alignment for FunctionDecls

arphaman added a comment. Does this happen with blocks as well? https://reviews.llvm.org/D27478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r288689 - Fix stack-use-after-scope in CheckExplicitlyDefaultedMemberExceptionSpec

On 6 December 2016 at 19:39, Vitaly Buka wrote: > Hi Alex, > > > > On Tue, Dec 6, 2016 at 11:14 AM Alex L wrote: > > Hi Vitaly, > > I noticed that you posted this patch up for review at > https://reviews.llvm.org/D27422, but then committed it instantly without > waiting for approval (and you did

[PATCH] D27504: Compilation database test: don't try to output to CWD

This revision was automatically updated to reflect the committed changes. Closed by commit rL288892: Compilation database test: don't try to output to CWD (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D27504?vs=80553&id=80554#toc Repository: rL LLVM https://revi

[PATCH] D27504: Compilation database test: don't try to output to CWD

sammccall marked an inline comment as done. sammccall added a comment. Thanks! That makes sense. https://reviews.llvm.org/D27504 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27504: Compilation database test: don't try to output to CWD

sammccall updated this revision to Diff 80553. sammccall added a comment. Hoist cd %T to avoid repeating it. https://reviews.llvm.org/D27504 Files: test/Driver/compilation_database.c Index: test/Driver/compilation_database.c ==

[PATCH] D27504: Compilation database test: don't try to output to CWD

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. Annoying. This test really shouldn't generate binary object files. Can we check in this patch now to unblock stuff and then look into how to do a dry run with -MJ? Usually driver tests use `

[PATCH] D27403: [OpenCL] Added a LIT test for ensuring address space mangling is done the same both in OpenCL1.2 and OpenCL2.0.

bader added a comment. @echuraev, please, request commit access as described here: http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access Repository: rL LLVM https://reviews.llvm.org/D27403 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D27403: [OpenCL] Added a LIT test for ensuring address space mangling is done the same both in OpenCL1.2 and OpenCL2.0.

This revision was automatically updated to reflect the committed changes. Closed by commit rL288891: [OpenCL] Added a LIT test for ensuring address space mangling is done the same… (authored by bader). Changed prior to commit: https://reviews.llvm.org/D27403?vs=80401&id=80549#toc Repository:

r288891 - [OpenCL] Added a LIT test for ensuring address space mangling is done the same both in OpenCL1.2 and OpenCL2.0.

Author: bader Date: Wed Dec 7 02:43:49 2016 New Revision: 288891 URL: http://llvm.org/viewvc/llvm-project?rev=288891&view=rev Log: [OpenCL] Added a LIT test for ensuring address space mangling is done the same both in OpenCL1.2 and OpenCL2.0. Patch by Egor Churaev (echuraev). Reviewers: Anasta

[PATCH] D27300: [OpenCL] Fix SPIR version generation.

This revision was automatically updated to reflect the committed changes. Closed by commit rL288890: [OpenCL] Fix SPIR version generation. (authored by bader). Changed prior to commit: https://reviews.llvm.org/D27300?vs=80229&id=80548#toc Repository: rL LLVM https://reviews.llvm.org/D27300

r288890 - [OpenCL] Fix SPIR version generation.

Author: bader Date: Wed Dec 7 02:38:24 2016 New Revision: 288890 URL: http://llvm.org/viewvc/llvm-project?rev=288890&view=rev Log: [OpenCL] Fix SPIR version generation. Patch by Egor Churaev (echuraev). Reviewers: Anastasia Subscribers: bader, yaxunl, cfe-commits Differential Revision: https:

[PATCH] D27453: [OpenCL] Enable unroll hint for OpenCL 1.x.

echuraev updated this revision to Diff 80547. echuraev marked an inline comment as done. https://reviews.llvm.org/D27453 Files: lib/Sema/SemaStmtAttr.cpp test/CodeGenOpenCL/unroll-hint.cl test/SemaOpenCL/unroll-hint.cl Index: test/SemaOpenCL/unroll-hint.cl

<    1   2