[PATCH] D30087: [Driver] Unify linking of OpenMP runtime. NFCI.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D30087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32164: [clang-tidy] misc-misplaced-widening-cast: Disable checking of implicit widening casts by default

This revision was automatically updated to reflect the committed changes. Closed by commit rL300699: [clang-tidy] misc-misplaced-widening-cast: Disable checking of implicit… (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D32164?vs=95563=95751#toc Repository: rL LLVM

[PATCH] D32176: Add #pragma clang attribute support for the external_source_symbol attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D32176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r300689 - [Driver] Unify linking of OpenMP runtime. NFCI.

Author: hahnfeld Date: Wed Apr 19 08:55:39 2017 New Revision: 300689 URL: http://llvm.org/viewvc/llvm-project?rev=300689=rev Log: [Driver] Unify linking of OpenMP runtime. NFCI. While at it, extend test for FreeBSD and check for -lrt iff on Linux. Differential Revision:

[PATCH] D30087: [Driver] Unify linking of OpenMP runtime. NFCI.

This revision was automatically updated to reflect the committed changes. Closed by commit rL300689: [Driver] Unify linking of OpenMP runtime. NFCI. (authored by Hahnfeld). Changed prior to commit: https://reviews.llvm.org/D30087?vs=94372=95733#toc Repository: rL LLVM

[PATCH] D30295: [analyzer] clarify undef shift result when shift count is negative or exceeds the bit width

danielmarjamaki marked 4 inline comments as done. danielmarjamaki added inline comments. Comment at: include/clang/StaticAnalyzer/Core/PathSensitive/CheckerHelpers.h:46 -} // end GR namespace +bool isExprResultConformsComparisonRule(CheckerContext , +

[PATCH] D32178: Delete unstable integration tests

jroelofs added a comment. I think you'd have to check for a maximum host SDK version, and then bump it upstream every time there's a new one thats known to work with the then-current trunk. It can't be done based on language features because by definition, one cannot know what features are

[PATCH] D31885: Remove TBAA information from LValues representing union members

dberlin added a comment. In https://reviews.llvm.org/D31885#730072, @rjmccall wrote: > Thanks for CC'ing me. There are two problems here. > > The second is that our alias-analysis philosophy says that the fact that two > accesses "sufficiently obviously" can alias should always override TBAA.

[PATCH] D30295: [analyzer] clarify undef shift result when shift count is negative or exceeds the bit width

danielmarjamaki updated this revision to Diff 95740. danielmarjamaki added a comment. Fix review comments - renamed - reorder function arguments (CheckerContext last) Repository: rL LLVM https://reviews.llvm.org/D30295 Files:

[clang-tools-extra] r300699 - [clang-tidy] misc-misplaced-widening-cast: Disable checking of implicit widening casts by default.

Author: xazax Date: Wed Apr 19 09:55:58 2017 New Revision: 300699 URL: http://llvm.org/viewvc/llvm-project?rev=300699=rev Log: [clang-tidy] misc-misplaced-widening-cast: Disable checking of implicit widening casts by default. Patch by Ádám Balogh! Differential Revision:

[PATCH] D31097: [clang-tidy] don't warn about implicit widening casts in function calls

danielmarjamaki abandoned this revision. danielmarjamaki added a comment. I believe https://reviews.llvm.org/D32164 is better Repository: rL LLVM https://reviews.llvm.org/D31097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

danielmarjamaki requested changes to this revision. danielmarjamaki added inline comments. This revision now requires changes to proceed. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:788 +SVal MallocChecker::SValBinMulOp(CheckerContext , const Expr *Blocks, +

[PATCH] D32176: Add #pragma clang attribute support for the external_source_symbol attribute

arphaman updated this revision to Diff 95754. arphaman marked 4 inline comments as done. arphaman added a comment. Addressed Aaron's comments. Repository: rL LLVM https://reviews.llvm.org/D32176 Files: include/clang/Basic/Attr.td lib/Sema/SemaDeclAttr.cpp

[PATCH] D32176: Add #pragma clang attribute support for the external_source_symbol attribute

arphaman added inline comments. Comment at: lib/Sema/SemaDeclAttr.cpp:5773 + // Check whether the attribute appertains to the given subject. + if (!Attr.diagnoseAppertainsTo(S, D)) +return true; I hoisted it after `diagnoseLangOpts` to keep some tests

r300703 - Remove unnecessary condition as suggested by clang-tidy. NFC

Author: xazax Date: Wed Apr 19 10:11:10 2017 New Revision: 300703 URL: http://llvm.org/viewvc/llvm-project?rev=300703=rev Log: Remove unnecessary condition as suggested by clang-tidy. NFC Patch by: Gergely Angeli! Differential Revision: https://reviews.llvm.org/D31938 Modified:

[PATCH] D29827: [AVR] Add -mmcu option to the driver

xiangzhai accepted this revision. xiangzhai added a comment. This revision is now accepted and ready to land. Hi Peter, Thanks for your rebase! LGTM! > Based on the context, the change from lib/Driver/Tools.cpp -> > lib/Driver/ToolChains/CommonArgs.cpp seems most appropriate (Gnu.cpp seems to

[PATCH] D32210: [Sema][ObjC] Add support for attribute "noescape"

jroelofs added a comment. This doesn't forbid assigning them to block properties... is that intentional? typedef void (^Block)(int); @interface Foo @property Block B; @end void foo(Foo *f, Block __attribute__((noescape)) b) { f.B = b; } Comment at:

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

gtbercea updated this revision to Diff 95737. gtbercea marked an inline comment as done. gtbercea added a comment. Avoid renaming by enabling PTXAS to generate an output file with the appropriate extension, in this case a cubin extension. Repository: rL LLVM https://reviews.llvm.org/D29654

[PATCH] D32210: [Sema][ObjC] Add support for attribute "noescape"

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:1222 +def NoEscape : InheritableAttr { + let Spellings = [GCC<"noescape">, CXX11<"clang", "noescape">]; + let Subjects = SubjectList<[ParmVar], WarnDiag, "ExpectedParameter">; I do

[PATCH] D32176: Add #pragma clang attribute support for the external_source_symbol attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rL300712: Add #pragma clang attribute support to the external_source_symbol attribute (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D32176?vs=95754=95767#toc Repository: rL

r300712 - Add #pragma clang attribute support to the external_source_symbol attribute

Author: arphaman Date: Wed Apr 19 10:52:11 2017 New Revision: 300712 URL: http://llvm.org/viewvc/llvm-project?rev=300712=rev Log: Add #pragma clang attribute support to the external_source_symbol attribute Prior to this commit the external_source_symbol attribute wasn't supported by #pragma

[PATCH] D32207: Corrrect warn_unused_result attribute

erichkeane added a comment. 1 more thing: I excepted post-increment/decrement from this warning because I figured it would give a TON of warnings from people using post-inc/dec in for loops. However, after further discussion with Craig (who brought this up on the mailing list), I severely

r300718 - Prefer addAttr(Attribute::AttrKind) over the AttributeList overload

Author: rnk Date: Wed Apr 19 12:28:52 2017 New Revision: 300718 URL: http://llvm.org/viewvc/llvm-project?rev=300718=rev Log: Prefer addAttr(Attribute::AttrKind) over the AttributeList overload This should simplify the call sites, which typically want to tweak one attribute at a time. It should

r300723 - [Coverage] Don't emit mappings for functions in dependent contexts (fixes PR32679)

Author: vedantk Date: Wed Apr 19 12:58:30 2017 New Revision: 300723 URL: http://llvm.org/viewvc/llvm-project?rev=300723=rev Log: [Coverage] Don't emit mappings for functions in dependent contexts (fixes PR32679) The coverage implementation marks functions which won't be emitted as 'deferred',

[PATCH] D32231: [CMake] Enable ARM target in Fuchsia toolchain

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM https://reviews.llvm.org/D32231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31885: Remove TBAA information from LValues representing union members

kparzysz added a comment. In https://reviews.llvm.org/D31885#730038, @hfinkel wrote: > I'm somewhat concerned that this patch is quadratic in the AST. I'd be happy to address this, but I'm not sure how. Memoizing results could be one way, but don't know if that's acceptable. This location

[PATCH] D31885: Remove TBAA information from LValues representing union members

rjmccall added a comment. In https://reviews.llvm.org/D31885#730539, @dberlin wrote: > In https://reviews.llvm.org/D31885#730072, @rjmccall wrote: > > > Thanks for CC'ing me. There are two problems here. > > > > The second is that our alias-analysis philosophy says that the fact that > > two

[PATCH] D32231: [CMake] Enable ARM target in Fuchsia toolchain

phosek updated this revision to Diff 95766. Repository: rL LLVM https://reviews.llvm.org/D32231 Files: cmake/caches/Fuchsia-stage2.cmake Index: cmake/caches/Fuchsia-stage2.cmake === --- cmake/caches/Fuchsia-stage2.cmake +++

[PATCH] D31885: Remove TBAA information from LValues representing union members

dberlin added a comment. In https://reviews.llvm.org/D31885#730766, @rjmccall wrote: > In https://reviews.llvm.org/D31885#730539, @dberlin wrote: > > > In https://reviews.llvm.org/D31885#730072, @rjmccall wrote: > > > > > Thanks for CC'ing me. There are two problems here. > > > > > > The second

[PATCH] D32207: Corrrect warn_unused_result attribute

erichkeane marked an inline comment as done. erichkeane added inline comments. Comment at: lib/AST/Decl.cpp:3010 +(OpCode == OO_PlusPlus || OpCode == OO_MinusMinus) && +(this->getNumParams() + (isa(this) ? 1 : 0)) == 2; +if (Ret && !IsPostfix) {

[PATCH] D31745: [OpenCL] Added diagnostic for implicit declaration of function in OpenCL

Anastasia added inline comments. Comment at: test/SemaOpenCL/clang-builtin-version.cl:32 + work_group_reserve_write_pipe(tmp, tmp); // expected-error{{implicit declaration of function 'work_group_reserve_write_pipe' is invalid in OpenCL}} + // expected-note@-1{{did you mean

[PATCH] D31542: [clang-tidy] Extend readability-container-size-empty to add comparisons to newly-constructed objects

aaron.ballman added inline comments. Comment at: clang-tidy/utils/ASTUtils.cpp:28 +bool IsBinaryOrTernary(const Expr *expr) { + if (clang::isa(expr->IgnoreImpCasts()) || + clang::isa(expr->IgnoreImpCasts())) { Rather than call `IgnoreImpCasts()` three

[PATCH] D32210: [Sema][ObjC] Add support for attribute "noescape"

TheRealAdamKemp added inline comments. Comment at: include/clang/Basic/AttrDocs.td:122 +* Cannot be returned from a function +* Cannot be captured by a block +* Cannot be assigned to a variable This may be too restrictive in some cases. Consider this: ```

[PATCH] D32207: Corrrect warn_unused_result attribute

aaron.ballman added a comment. In https://reviews.llvm.org/D32207#730681, @erichkeane wrote: > 1 more thing: I excepted post-increment/decrement from this warning because > I figured it would give a TON of warnings from people using post-inc/dec in > for loops. > > However, after further

[PATCH] D31885: Remove TBAA information from LValues representing union members

kparzysz updated this revision to Diff 95780. kparzysz added a comment. Memoize known results of checking for union access. Repository: rL LLVM https://reviews.llvm.org/D31885 Files: lib/CodeGen/CGExpr.cpp lib/CodeGen/CodeGenFunction.cpp lib/CodeGen/CodeGenFunction.h

r300722 - [Sema][ObjC] Disallow jumping into ObjC fast enumeration loops.

Author: ahatanak Date: Wed Apr 19 12:54:08 2017 New Revision: 300722 URL: http://llvm.org/viewvc/llvm-project?rev=300722=rev Log: [Sema][ObjC] Disallow jumping into ObjC fast enumeration loops. rdar://problem/31635406 Differential Revision: https://reviews.llvm.org/D32187 Modified:

[PATCH] D32144: [Coverage] Don't emit mappings for functions in dependent contexts (fixes PR32679)

This revision was automatically updated to reflect the committed changes. Closed by commit rL300723: [Coverage] Don't emit mappings for functions in dependent contexts (fixes… (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D32144?vs=95513=95783#toc Repository: rL

[PATCH] D31885: Remove TBAA information from LValues representing union members

rjmccall added a comment. In https://reviews.llvm.org/D31885#730853, @hfinkel wrote: > > There was a deliberate decision to make TBAA conservative about type > > punning in LLVM because, in practice, the strict form of TBAA you think we > > should follow has proven to be a failed optimization

[PATCH] D31885: Remove TBAA information from LValues representing union members

rjmccall added a comment. In https://reviews.llvm.org/D31885#730920, @dberlin wrote: > Just so i understand: Ignoring everything else (we can't actually make > likelyalias work, i think the code in the bugs makes that very clear), None of the code in the bugs I've seen makes that very clear,

r300741 - Parse backend options during thinlto backend compile actions

Author: dblaikie Date: Wed Apr 19 15:08:21 2017 New Revision: 300741 URL: http://llvm.org/viewvc/llvm-project?rev=300741=rev Log: Parse backend options during thinlto backend compile actions Added: cfe/trunk/test/CodeGen/thinlto-backend-option.ll Modified:

[PATCH] D32207: Corrrect warn_unused_result attribute

erichkeane updated this revision to Diff 95807. erichkeane marked 3 inline comments as done. erichkeane added a comment. Added the tests, plus the two formatting changes. https://reviews.llvm.org/D32207 Files: include/clang/AST/Decl.h lib/AST/Decl.cpp test/SemaCXX/warn-unused-result.cpp

[PATCH] D31885: Remove TBAA information from LValues representing union members

dberlin added a comment. > Your proposal to we simply drop TBAA from all accesses related to unions is > extremely conservative. It means that an access through a union has to be > treated as potentially aliasing every other visible access, at least in terms > of their types. That level of

[PATCH] D32207: Corrrect warn_unused_result attribute

aaron.ballman added a comment. I'm surprised this change didn't cause any other tests to need to be updated. A few small formatting nits and a request for another test, but otherwise looking good. Comment at: test/SemaCXX/warn-unused-result.cpp:166 +// C++ Methods should

[PATCH] D32238: [Clangd] Failed to decode params using 1.x-compatible request message

bkramer added a comment. A test case would be nice. Repository: rL LLVM https://reviews.llvm.org/D32238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32237: [OpenMP] Prepare sema to support combined constructs with omp distribute and omp for

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rL LLVM https://reviews.llvm.org/D32237 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31885: Remove TBAA information from LValues representing union members

rjmccall added a comment. In https://reviews.llvm.org/D31885#730799, @dberlin wrote: > In https://reviews.llvm.org/D31885#730766, @rjmccall wrote: > > > In https://reviews.llvm.org/D31885#730539, @dberlin wrote: > > > > > In https://reviews.llvm.org/D31885#730072, @rjmccall wrote: > > > > > > >

[PATCH] D31975: [Analyzer] Iterator Checkers

zaks.anna added a comment. @baloghadamsoftware Thanks for working on this! However, this patch is getting too big. Could you, please, split it into incremental patches so that it would be easier to review? More motivation of why this is very important is here

[PATCH] D31885: Remove TBAA information from LValues representing union members

dberlin added a comment. In https://reviews.llvm.org/D31885#730909, @rjmccall wrote: > In https://reviews.llvm.org/D31885#730853, @hfinkel wrote: > > > > There was a deliberate decision to make TBAA conservative about type > > > punning in LLVM because, in practice, the strict form of TBAA you

[PATCH] D32207: Corrrect warn_unused_result attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D32207 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r300743 - [libc++] Use _LIBCPP_ABI_MICROSOFT instead of _MSC_VER

Author: smeenai Date: Wed Apr 19 15:11:04 2017 New Revision: 300743 URL: http://llvm.org/viewvc/llvm-project?rev=300743=rev Log: [libc++] Use _LIBCPP_ABI_MICROSOFT instead of _MSC_VER _LIBCPP_ABI_MICROSOFT is more appropriate to use here, since the conditionals are controlling Microsoft

[PATCH] D31885: Remove TBAA information from LValues representing union members

hfinkel added a comment. > There was a deliberate decision to make TBAA conservative about type punning > in LLVM because, in practice, the strict form of TBAA you think we should > follow has proven to be a failed optimization paradigm: it just leads users > to globally disable TBAA, which is

[PATCH] D31885: Remove TBAA information from LValues representing union members

hfinkel added a comment. In https://reviews.llvm.org/D31885#730728, @kparzysz wrote: > In https://reviews.llvm.org/D31885#730038, @hfinkel wrote: > > > I'm somewhat concerned that this patch is quadratic in the AST. > > > I'd be happy to address this, but I'm not sure how. Memoizing results

[PATCH] D32207: Corrrect warn_unused_result attribute

erichkeane updated this revision to Diff 95797. erichkeane added a comment. As discussed, removed the exception for postfix operators. It seems like the right thing to do.I didn't add the [[nodiscard]] test, since it is the same intended behavior now. https://reviews.llvm.org/D32207 Files:

[PATCH] D32234: [Clangd] Support Authority-less URIs

bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. This is fine. Test case would be nice though. Repository: rL LLVM https://reviews.llvm.org/D32234 ___ cfe-commits mailing list

[PATCH] D32234: [Clangd] Support Authority-less URIs

malaperle-ericsson updated this revision to Diff 95809. malaperle-ericsson added a comment. Add test https://reviews.llvm.org/D32234 Files: clangd/Protocol.cpp test/clangd/completion.test Index: test/clangd/completion.test

[PATCH] D31885: Remove TBAA information from LValues representing union members

dberlin added a comment. In https://reviews.llvm.org/D31885#730936, @rjmccall wrote: > In https://reviews.llvm.org/D31885#730920, @dberlin wrote: > > > Just so i understand: Ignoring everything else (we can't actually make > > likelyalias work, i think the code in the bugs makes that very

r300738 - [sanitizer-coverage] deprecate some of the stale coverage variants

Author: kcc Date: Wed Apr 19 14:57:16 2017 New Revision: 300738 URL: http://llvm.org/viewvc/llvm-project?rev=300738=rev Log: [sanitizer-coverage] deprecate some of the stale coverage variants Modified: cfe/trunk/docs/SanitizerCoverage.rst cfe/trunk/lib/Driver/SanitizerArgs.cpp

r300744 - [sanitizer-coverage] deprecate -fsanitize-coverage=8bit-counters

Author: kcc Date: Wed Apr 19 15:15:58 2017 New Revision: 300744 URL: http://llvm.org/viewvc/llvm-project?rev=300744=rev Log: [sanitizer-coverage] deprecate -fsanitize-coverage=8bit-counters Modified: cfe/trunk/lib/Driver/SanitizerArgs.cpp cfe/trunk/test/Driver/fsanitize-coverage.c

[PATCH] D32243: Fix a leak in tools/driver/cc1as_main.cpp

kcc created this revision. For some reason, the asan bot has recently started reporting this leak even though it existed for ages. https://reviews.llvm.org/D32243 Files: tools/driver/cc1as_main.cpp Index: tools/driver/cc1as_main.cpp

[PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

rsmith added a comment. I don't like calling this a "TBAA sanitizer". What we're sanitizing is the object model and effective type rules; it seems irrelevant which specific compiler analysis passes would result in your program misbehaving if you break the rules. I would also expect that we

[libcxx] r300770 - Fix typo in Windows test configuration code

Author: ericwf Date: Wed Apr 19 16:52:08 2017 New Revision: 300770 URL: http://llvm.org/viewvc/llvm-project?rev=300770=rev Log: Fix typo in Windows test configuration code Modified: libcxx/trunk/utils/libcxx/test/config.py Modified: libcxx/trunk/utils/libcxx/test/config.py URL:

r300776 - [sanitizer-coverage] trim down the docs

Author: kcc Date: Wed Apr 19 17:25:30 2017 New Revision: 300776 URL: http://llvm.org/viewvc/llvm-project?rev=300776=rev Log: [sanitizer-coverage] trim down the docs Modified: cfe/trunk/docs/SanitizerCoverage.rst Modified: cfe/trunk/docs/SanitizerCoverage.rst URL:

[PATCH] D32064: [asan] Disable ASan global-GC depending on the target and compiler flags

eugenis added a comment. The ultimate solution would be a function attribute - if we want this thing to work correctly with LTO. But it sounds a bit like overkill, plus none of the settings it depends on (integrated-as, data-sections) work with LTO anway: the former is ignored and the second

r300762 - Fix assertion failure in codegen on non-template deduction guide.

Author: rsmith Date: Wed Apr 19 16:15:45 2017 New Revision: 300762 URL: http://llvm.org/viewvc/llvm-project?rev=300762=rev Log: Fix assertion failure in codegen on non-template deduction guide. Added: cfe/trunk/test/CodeGenCXX/cxx1z-class-deduction.cpp Modified:

[PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

hfinkel added a comment. In https://reviews.llvm.org/D32199#730716, @filcab wrote: > Missing a `sanitizer-ld.c` test for freebsd. Thanks for pointing this out. I'm going to remove the freebsd change for now. I suspect it works, but I've not tested it yet. Comment at:

[PATCH] D32248: CodeGen: Cast alloca to expected address space

yaxunl created this revision. Alloca always returns a pointer in alloca address space, which may be different from the type defined by the language. For example, in C++ the auto variables are in the default address space. Therefore cast alloca to the expected address space when necessary.

[PATCH] D31542: [clang-tidy] Extend readability-container-size-empty to add comparisons to newly-constructed objects

joshz updated this revision to Diff 95833. joshz marked 3 inline comments as done. joshz added a comment. Clean up IsBinaryOrTernary Repository: rL LLVM https://reviews.llvm.org/D31542 Files: clang-tidy/readability/ContainerSizeEmptyCheck.cpp clang-tidy/utils/ASTUtils.cpp

[PATCH] D32231: [CMake] Enable ARM target in Fuchsia toolchain

phosek created this revision. Herald added subscribers: mgorny, rengolin, aemerson. This is still used by some users of Fuchsia toolchain. Also include llc and opt which is useful for development and testing. Repository: rL LLVM https://reviews.llvm.org/D32231 Files:

[PATCH] D32210: [Sema][ObjC] Add support for attribute "noescape"

rjmccall added a comment. The rule we actually want is that no reference to the block derived from the parameter value will survive after the function returns. You can include examples of things that would cause potential escapes, but trying to actually lock down the list seems ill-advised.

[PATCH] D32238: [Clangd] Failed to decode params using 1.x-compatible request message

malaperle-ericsson updated this revision to Diff 95811. malaperle-ericsson added a comment. Add test https://reviews.llvm.org/D32238 Files: clangd/Protocol.cpp test/clangd/completion.test Index: test/clangd/completion.test

[PATCH] D32243: Fix a leak in tools/driver/cc1as_main.cpp

pcc accepted this revision. pcc added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D32243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31885: Remove TBAA information from LValues representing union members

rjmccall added a comment. In https://reviews.llvm.org/D31885#730958, @dberlin wrote: > In https://reviews.llvm.org/D31885#730936, @rjmccall wrote: > > > In https://reviews.llvm.org/D31885#730920, @dberlin wrote: > > > > > Just so i understand: Ignoring everything else (we can't actually make >

r300755 - Fix a leak in tools/driver/cc1as_main.cpp

Author: kcc Date: Wed Apr 19 15:57:13 2017 New Revision: 300755 URL: http://llvm.org/viewvc/llvm-project?rev=300755=rev Log: Fix a leak in tools/driver/cc1as_main.cpp Summary: For some reason, the asan bot has recently started reporting this leak even though it existed for ages. Reviewers: pcc

r300756 - [CodeGen] Use preincrement version of APInt::operator++ instead of postincrement to avoid creating and immediately discarding a temporary APInt.

Author: ctopper Date: Wed Apr 19 16:02:45 2017 New Revision: 300756 URL: http://llvm.org/viewvc/llvm-project?rev=300756=rev Log: [CodeGen] Use preincrement version of APInt::operator++ instead of postincrement to avoid creating and immediately discarding a temporary APInt. This is preparation

r300764 - Corrrect warn_unused_result attribute

Author: erichkeane Date: Wed Apr 19 16:24:55 2017 New Revision: 300764 URL: http://llvm.org/viewvc/llvm-project?rev=300764=rev Log: Corrrect warn_unused_result attribute The original idea was that if the attribute on an operator, that the return-value unused-ness wouldn't matter. However, all

[PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

hfinkel updated this revision to Diff 95829. hfinkel added a comment. Updated per review comments (use only no_sanitize("tbaa") instead of adding no_sanitize_tbaa and don't touch freebsd for now). https://reviews.llvm.org/D32199 Files: include/clang/Basic/Sanitizers.def

[PATCH] D32064: [asan] Disable ASan global-GC depending on the target and compiler flags

pcc added a comment. I won't stand in the way here if others feel strongly that the flag should be passed via a constructor. It will just mean more work to be done if/when this flag is ever changed to be passed via some other mechanism, but that's a relatively minor detail. Repository: rL

[PATCH] D31885: Remove TBAA information from LValues representing union members

hfinkel added a comment. In https://reviews.llvm.org/D31885#730853, @hfinkel wrote: > ... > > >> (And the nonsensicality of the standard very much continues. The code that >> we've all agreed is obviously being miscompiled here is still a strict >> violation of the "improved" union rules

r300802 - [OpenMP] Prepare sema to support combined constructs with omp distribute and omp for

Author: cbertol Date: Wed Apr 19 19:39:39 2017 New Revision: 300802 URL: http://llvm.org/viewvc/llvm-project?rev=300802=rev Log: [OpenMP] Prepare sema to support combined constructs with omp distribute and omp for https://reviews.llvm.org/D32237 This patch prepares sema with additional fields

[PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

filcab added a comment. Missing a `sanitizer-ld.c` test for freebsd. Comment at: include/clang/Basic/Attr.td:1849 + GNU<"no_sanitize_memory">, + GNU<"no_sanitize_tbaa">]; let Subjects = SubjectList<[Function, GlobalVar], ErrorDiag,

[PATCH] D32187: [CodeGen][ObjC]

This revision was automatically updated to reflect the committed changes. Closed by commit rL300722: [Sema][ObjC] Disallow jumping into ObjC fast enumeration loops. (authored by ahatanak). Changed prior to commit: https://reviews.llvm.org/D32187?vs=95667=95781#toc Repository: rL LLVM

[PATCH] D31561: cmath: Skip Libc for integral types in isinf, etc.

hfinkel added a comment. In https://reviews.llvm.org/D31561#731498, @dexonsmith wrote: > Marshall, that's what I assumed originally, but I figured Hal had some > non-standard-but-worth-supporting use case in mind. In this case, future-proofing and mathematical precision seemed aligned. I

[PATCH] D32265: Add __CLANG_ATOMIC__LOCK_FREE macros for use in MSVC compatibility mode.

smeenai resigned from this revision. smeenai edited reviewers, added: compnerd; removed: smeenai. smeenai added a comment. This looks good to me, but I'm not familiar enough with this part of clang to be comfortable accepting. https://reviews.llvm.org/D32265

[PATCH] D32260: [TBAA] Vector types should (only) alias with their element types

hfinkel abandoned this revision. hfinkel added a comment. @rjmccall said, on this topic, in https://reviews.llvm.org/D31885: > The root problem there is that the design of vector types and vector > interfaces is generally quite bad; you cannot rely on things like vectors > being stored with an

[libcxx] r300817 - Rename the static version of libc++ on Windows.

Author: ericwf Date: Wed Apr 19 23:19:02 2017 New Revision: 300817 URL: http://llvm.org/viewvc/llvm-project?rev=300817=rev Log: Rename the static version of libc++ on Windows. Previously both the static version of libc++ and the import library for the DLL had the same name, 'c++.lib'. This

[PATCH] D29827: [AVR] Add -mmcu option to the driver

This revision was automatically updated to reflect the committed changes. Closed by commit rL300818: [AVR] Add -mmcu option to the driver (authored by xiangzhai). Changed prior to commit: https://reviews.llvm.org/D29827?vs=95707=95879#toc Repository: rL LLVM https://reviews.llvm.org/D29827

r300818 - [AVR] Add -mmcu option to the driver

Author: xiangzhai Date: Wed Apr 19 23:23:24 2017 New Revision: 300818 URL: http://llvm.org/viewvc/llvm-project?rev=300818=rev Log: [AVR] Add -mmcu option to the driver A patch by Peter Wu! Reviewers: jroelofs, xiangzhai Reviewed By: jroelofs, dylanmckay, xiangzhai Subscribers: dlj,

[libcxx] r300820 - Disable the filesystem library on Windows by default

Author: ericwf Date: Wed Apr 19 23:24:29 2017 New Revision: 300820 URL: http://llvm.org/viewvc/llvm-project?rev=300820=rev Log: Disable the filesystem library on Windows by default Modified: libcxx/trunk/CMakeLists.txt Modified: libcxx/trunk/CMakeLists.txt URL:

[PATCH] D32248: CodeGen: Cast alloca to expected address space

yaxunl added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1105-1119 + // Alloca always returns a pointer in alloca address space, which may + // be different from the type defined by the language. For example, + // in C++ the auto variables are in the default address

[PATCH] D30771: [analyzer] Teach the MallocChecker about Glib API for two arguments

xiangzhai updated this revision to Diff 95880. Repository: rL LLVM https://reviews.llvm.org/D30771 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/gmalloc.c Index: test/Analysis/gmalloc.c === ---

[libcxx] r300786 - Add appveyor.yml config for a future Windows bot.

Author: ericwf Date: Wed Apr 19 18:26:21 2017 New Revision: 300786 URL: http://llvm.org/viewvc/llvm-project?rev=300786=rev Log: Add appveyor.yml config for a future Windows bot. I'm currently trying to get a libc++ Windows builder working on appveyor. This patch adds the configuration file

[libcxx] r300788 - change what branches Appveyor builds

Author: ericwf Date: Wed Apr 19 18:27:48 2017 New Revision: 300788 URL: http://llvm.org/viewvc/llvm-project?rev=300788=rev Log: change what branches Appveyor builds Modified: libcxx/trunk/appveyor.yml Modified: libcxx/trunk/appveyor.yml URL:

[PATCH] D31778: [Modules] Implement ODR-like semantics for tag types in C/ObjC

rsmith added inline comments. Comment at: include/clang/Sema/Sema.h:1464 + /// Determine if \p D abd \p Suggested have a structurally compatibale + /// layout as described in C11 6.2.7/1. Typo 'abd' Comment at:

[PATCH] D32199: [TBAASan] A TBAA Sanitizer (Clang)

hfinkel added a comment. In https://reviews.llvm.org/D32199#731332, @rsmith wrote: > > ! In https://reviews.llvm.org/D32199#731252, @hfinkel wrote: > > > >> How about renaming this to something more like `-fsanitize=type`? > > > > I'm fine with that. Do you like TypeSanitizer or

Re: Permissions for llvm-mirror - Setting up Libc++ Appveyor builders

Adding cfe-dev list... On Wed, Apr 19, 2017 at 5:50 PM, Eric Fiselier wrote: > Hi Will, > > I would like to request collaborator permissions for the Libc++ github > mirror. > > I plan to use the access to setup Appveyor buildbots for libc++. In order > to do this I need to be

[PATCH] D32260: [TBAA] Vector types should (only) alias with their element types

hfinkel created this revision. Herald added a subscriber: mcrosier. Currently, all of our builtin vector types are equivalent to char for TBAA purposes. It would be useful to make this less conservative. This patch makes vector types equivalent to their element types for type-aliasing purposes.

[PATCH] D32251: Implement DR1601 - Promotion of enumeration with fixed underlying type

rsmith added inline comments. Comment at: lib/Sema/SemaOverload.cpp:3850-3853 // In Microsoft mode, prefer an integral conversion to a // floating-to-integral conversion if the integral conversion // is between types of the same size. // For example:

[PATCH] D32237: [OpenMP] Prepare sema to support combined constructs with omp distribute and omp for

carlo.bertolli closed this revision. carlo.bertolli added a comment. Committed revision 300802. Repository: rL LLVM https://reviews.llvm.org/D32237 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32192: Enable leak sanitizer builds for darwin

compnerd requested changes to this revision. compnerd added a comment. This revision now requires changes to proceed. Please add a test case. The change itself looks reasonable. https://reviews.llvm.org/D32192 ___ cfe-commits mailing list

[PATCH] D31885: Remove TBAA information from LValues representing union members

rjmccall added a comment. In https://reviews.llvm.org/D31885#731306, @hfinkel wrote: > In https://reviews.llvm.org/D31885#730853, @hfinkel wrote: > > > > > > ... > > > > > > >> (And the nonsensicality of the standard very much continues. The code that > >> we've all agreed is obviously being

  1   2   >