[PATCH] D33082: Fix Libc++ build with MinGW64

mati865 accepted this revision. mati865 added a comment. This revision is now accepted and ready to land. I don't know if it is MSYS2 specific or general MinGW issue but liblibc++.a is created. Could you check your build? Here is line to blame:

[PATCH] D33135: [ASTMatchers] Add support for floatLiterals

Lekensteyn added a comment. By the way, I think that `long double` is less common than long unsigned literals, so changing unsigned to uint64_t might be something more important? Comment at: include/clang/ASTMatchers/Dynamic/Parser.h:25 ///:= true | false +///

[libcxxabi] r303016 - Revert r302978 and r302981.

Author: ahatanak Date: Sun May 14 13:46:19 2017 New Revision: 303016 URL: http://llvm.org/viewvc/llvm-project?rev=303016=rev Log: Revert r302978 and r302981. Revert the two commits to understand why the following aarch64 bot is failing.

[PATCH] D33082: Fix Libc++ build with MinGW64

compnerd added a comment. Sure, a `_LIBCPP_MSVCRT_LIKE` WFM. I just want to make sure that we don''t conflate the underlying libc implementation with the Win32 API set. https://reviews.llvm.org/D33082 ___ cfe-commits mailing list

[PATCH] D28954: [analyzer] Add support for symbolic float expressions

lirhea added a comment. In https://reviews.llvm.org/D28954#714936, @ddcc wrote: > Rebase, update tests, fix bugs Excuse me,I want to download full codes of this version,but I have no idea how to do it,can you tell me? And my system is windows. https://reviews.llvm.org/D28954

[PATCH] D33177: any: Add availability for experimental::bad_any_cast

dexonsmith created this revision. As a follow up to r302172, add missing availability for bad_any_cast. rdar://problem/32161524 https://reviews.llvm.org/D33177 Files: libcxx/include/__config libcxx/include/experimental/any

r303026 - Fix PR32933: crash on lambda capture of VLA

Author: faisalv Date: Sun May 14 20:49:19 2017 New Revision: 303026 URL: http://llvm.org/viewvc/llvm-project?rev=303026=rev Log: Fix PR32933: crash on lambda capture of VLA https://bugs.llvm.org/show_bug.cgi?id=32933 Turns out clang wasn't really handling vla's (*) in C++11's for-range entirely

[PATCH] D33177: any: Add availability for experimental::bad_any_cast

mehdi_amini accepted this revision. mehdi_amini added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D33177 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r303027 - [NFC] Remove some comments (IR aid) from a test file erroneous committed in r303026

Author: faisalv Date: Sun May 14 20:54:02 2017 New Revision: 303027 URL: http://llvm.org/viewvc/llvm-project?rev=303027=rev Log: [NFC] Remove some comments (IR aid) from a test file erroneous committed in r303026 Modified: cfe/trunk/test/CodeGenCXX/vla.cpp Modified:

r303030 - Silence buildbots by tweaking an IR codegen test to be less specific w register names.

Author: faisalv Date: Sun May 14 21:56:02 2017 New Revision: 303030 URL: http://llvm.org/viewvc/llvm-project?rev=303030=rev Log: Silence buildbots by tweaking an IR codegen test to be less specific w register names. Modified: cfe/trunk/test/CodeGenCXX/vla.cpp Modified:

[PATCH] D33013: Driver must return non-zero code on errors in command line

sepavloff updated this revision to Diff 98930. sepavloff added a comment. Herald added a subscriber: klimek. Added missed case The patch missed a case when Compilation object is created during work of clang based tool, it resulted in fail of the test 'clang-tidy/diagnostic.cpp'. This addition to

[PATCH] D33082: Fix Libc++ build with MinGW64

smeenai added a comment. @compnerd see my previous comment: > @EricWF and I discussed this on IRC a bit. I'm not a fan of overloading > _LIBCPP_WIN32API for this purpose, since to me that macro is meant for > guarding Windows API functions, not for CRT functions. Eric suggested adding > a new

[PATCH] D33082: Fix Libc++ build with MinGW64

smeenai added a comment. In https://reviews.llvm.org/D33082#754451, @compnerd wrote: > Sure, a `_LIBCPP_MSVCRT_LIKE` WFM. I just want to make sure that we don''t > conflate the underlying libc implementation with the Win32 API set. Yup, that was my concern as well. In

[PATCH] D32977: [OpenCL] Emit function-scope variable in constant address space as static variable

yaxunl added inline comments. Comment at: lib/Sema/SemaDecl.cpp:10286 + // these variables must be a compile time constant. + VDecl->getType().getAddressSpace() == LangAS::opencl_constant) CheckForConstantInitializer(Init, DclT);

[PATCH] D33082: Fix Libc++ build with MinGW64

compnerd requested changes to this revision. compnerd added inline comments. This revision now requires changes to proceed. Comment at: include/__locale:370 static const mask blank = _ISblank; -#elif defined(_LIBCPP_MSVCRT) +#elif defined(_LIBCPP_WIN32API) typedef

[PATCH] D33080: [Libc++] Use #pragma push_macro/pop_macro to better handle min/max on Windows

compnerd requested changes to this revision. compnerd added a comment. This revision now requires changes to proceed. I think that we should sink the `min`/`max` checks into `__undef_macros`. I don't like the idea of littering that check everywhere. Comment at:

[PATCH] D33178: Remove requirement for libunwind sources.

Shiz created this revision. Herald added a subscriber: mgorny. As per r241993, libunwind_ext.h is not used anymore, and thus only the public libunwind includes are needed. This eases distro packaging efforts and removes an unneeded requirement for out-of-tree building. Repository: rL LLVM

[PATCH] D33173: Modify test to look for patterns in stderr as well

sepavloff created this revision. With the change https://reviews.llvm.org/D33013 driver does not build compilation object if command line is invalid, in particular, if unrecognized option is provided. In such cases it prints diagnostics on stderr. The test 'clang-tidy/diagnostic.cpp' checks

[clang-tools-extra] r303001 - [clang-tidy] TwineLocalCheck: add param # checking

Author: yawanng Date: Sat May 13 23:14:59 2017 New Revision: 303001 URL: http://llvm.org/viewvc/llvm-project?rev=303001=rev Log: [clang-tidy] TwineLocalCheck: add param # checking Summary: The statement **getArg** tries to get the first one without checking, which may cause segmentation fault.

[PATCH] D32690: [clang-tidy] modernize-use-emplace: Remove unnecessary make_tuple calls

Prazek accepted this revision. Prazek added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D32690 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D33094: [ASTMatchers] Add clang-query support for equals matcher

Lekensteyn updated this revision to Diff 98917. Lekensteyn marked 9 inline comments as done. Lekensteyn retitled this revision from "[ASTMatchers] Add equals support for integer and boolean literals" to "[ASTMatchers] Add clang-query support for equals matcher". Lekensteyn edited the summary of

r303031 - [DOXYGEN] Minor improvements in doxygen comments.

Author: kromanova Date: Sun May 14 22:25:04 2017 New Revision: 303031 URL: http://llvm.org/viewvc/llvm-project?rev=303031=rev Log: [DOXYGEN] Minor improvements in doxygen comments. Separated very long brief sections into two sections. I got an OK from Eric Christopher to commit doxygen

[PATCH] D28954: [analyzer] Add support for symbolic float expressions

ddcc added a comment. In https://reviews.llvm.org/D28954#754478, @lirhea wrote: > In https://reviews.llvm.org/D28954#714936, @ddcc wrote: > > > Rebase, update tests, fix bugs > > > Excuse me,I want to download full codes of this version,but I have no idea > how to do it,can you tell me? > And

[PATCH] D33010: Make google-build-using-namespace skip std::.*literals

marejde updated this revision to Diff 98914. marejde added a comment. Removed use of nested namespace definition in test (C++17) and added a couple of more namespaces with "literals" in name that check should warn for. https://reviews.llvm.org/D33010 Files: