r307924 - Extend -Wdeprecated-implementations to warn about unavailable methods

Author: arphaman Date: Thu Jul 13 09:37:11 2017 New Revision: 307924 URL: http://llvm.org/viewvc/llvm-project?rev=307924=rev Log: Extend -Wdeprecated-implementations to warn about unavailable methods rdar://22867595 Modified: cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D35081: [ThinLTO] Allow multiple summary entries.

tejohnson added a comment. In https://reviews.llvm.org/D35081#808158, @mehdi_amini wrote: > Thanks, very clear :) > > I would expect that if we reprocess a GUID we invalidate the previous import > of the same GUID. Right now my impression is that the issue is that ` >

[PATCH] D35362: [clang-tidy] Add close-on-exec checks on several functions in Android module.

yawanng created this revision. yawanng added a project: clang-tools-extra. Herald added subscribers: xazax.hun, JDevlieghere, mgorny. accept() is better to be replaced by accept4() with SOCK_CLOEXEC flag to avoid file descriptor leakage. This is one of a bunch of similar APIs as below and they

r307932 - Fix spelling mistakes in comments. NFCI.

Author: rksimon Date: Thu Jul 13 10:34:44 2017 New Revision: 307932 URL: http://llvm.org/viewvc/llvm-project?rev=307932=rev Log: Fix spelling mistakes in comments. NFCI. Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h URL:

[PATCH] D35008: [AArch64] Produce the right kind of va_arg for windows

mstorsjo added a comment. Ping - the dependency, https://reviews.llvm.org/D35006, has now been committed. https://reviews.llvm.org/D35008 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35008: [AArch64] Produce the right kind of va_arg for windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL307933: [AArch64] Produce the right kind of va_arg for windows (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D35008?vs=105392=106471#toc Repository: rL LLVM

r307933 - [AArch64] Produce the right kind of va_arg for windows

Author: mstorsjo Date: Thu Jul 13 10:59:14 2017 New Revision: 307933 URL: http://llvm.org/viewvc/llvm-project?rev=307933=rev Log: [AArch64] Produce the right kind of va_arg for windows On windows on arm64, the va_list is a plain pointer. Differential Revision: https://reviews.llvm.org/D35008

[PATCH] D33537: [clang-tidy] Exception Escape Checker

jyu2 added a comment. In https://reviews.llvm.org/D33537#771274, @aaron.ballman wrote: > In https://reviews.llvm.org/D33537#771159, @baloghadamsoftware wrote: > > > In https://reviews.llvm.org/D33537#770264, @aaron.ballman wrote: > > > > > I think we should try to get as much of this

[PATCH] D34440: [Clang] Expand response files before loading compilation database

vladimir.plyashkun added inline comments. Comment at: unittests/Tooling/CompilationDatabaseTest.cpp:638-652 + ParseCompilationDatabaseFromResponseFileTest() { +std::error_code EC = llvm::sys::fs::createUniqueDirectory("unittest", TestDir); +EXPECT_TRUE(!EC); +

[PATCH] D35337: [Solaris] gcc runtime dropped support for .ctors, switch to .init_array

fedor.sergeev added inline comments. Comment at: lib/Driver/ToolChains/Gnu.cpp:2467 const Generic_GCC::GCCVersion = GCCInstallation.getVersion(); bool UseInitArrayDefault = getTriple().getArch() == llvm::Triple::aarch64 || davide wrote: > this is

[PATCH] D35081: [ThinLTO] Allow multiple summary entries.

mehdi_amini added a comment. Teresa: can you describe a bit more how we end up importing two summaries for the same GUID? I would expect that after importing one, we don't even come to try to import another since we already have one. https://reviews.llvm.org/D35081

[PATCH] D34440: [Clang] Expand response files before loading compilation database

vladimir.plyashkun updated this revision to Diff 106436. vladimir.plyashkun added a comment. - trailing period - moved test-cases to separate file Repository: rL LLVM https://reviews.llvm.org/D34440 Files: lib/Tooling/CommonOptionsParser.cpp unittests/Tooling/CMakeLists.txt

[PATCH] D35081: [ThinLTO] Allow multiple summary entries.

tejohnson added a comment. In https://reviews.llvm.org/D35081#808124, @mehdi_amini wrote: > Teresa: can you describe a bit more how we end up importing two summaries for > the same GUID? I would expect that after importing one, we don't even come to > try to import another since we already

[PATCH] D35081: [ThinLTO] Allow multiple summary entries.

mehdi_amini added a comment. Thanks, very clear :) I would expect that if we reprocess a GUID we invalidate the previous import of the same GUID. Right now my impression is that the issue is that ` ImportList[ExportModulePath][VI.getGUID()]` is indexed on the importing module. So it'd require

[PATCH] D34440: [Clang] Expand response files before loading compilation database

vladimir.plyashkun added a comment. **To discuss:** This patch is required for correct integration //Clang-Tidy// with //CLion IDE//. By this moment, we unable to use //CompilationDatabase.json// from //CLion //side which is widely used in //Clang-Tidy// and in other common tools. Anyway, there

[PATCH] D35000: [OpenCL] Added extended tests on metadata generation for half data type and arrays.

Anastasia added a comment. In https://reviews.llvm.org/D35000#807674, @echuraev wrote: > In https://reviews.llvm.org/D35000#801132, @Anastasia wrote: > > > In https://reviews.llvm.org/D35000#799705, @Anastasia wrote: > > > > > Btw, is there any reason to add testing specifically for half? Is

[PATCH] D35008: [AArch64] Produce the right kind of va_arg for windows

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: lib/CodeGen/TargetInfo.cpp:8463 Kind = AArch64ABIInfo::DarwinPCS; +else if (Triple.getOS() == llvm::Triple::Win32) + Kind = AArch64ABIInfo::Win64;

[PATCH] D35337: [Solaris] gcc runtime dropped support for .ctors, switch to .init_array

aaron.ballman added a comment. This looks reasonable to me, but I am not overly familiar with this part of the toolchain. You should wait for another LG before committing. https://reviews.llvm.org/D35337 ___ cfe-commits mailing list

[PATCH] D35109: [Analyzer] SValBuilder Comparison Rearrangement

baloghadamsoftware added a comment. I think we should exclude unsigned types completely. `A >= B` is converted to `A - B >= 0`, thus the range of `A - B` is `[0 .. INT_MAX]` which is the full range for the unsigned type. This implies that upon any conditional statement `if (A >= B) ...` the

r307914 - [OPENMP] Further reduction test fix, NFC.

Author: abataev Date: Thu Jul 13 08:02:27 2017 New Revision: 307914 URL: http://llvm.org/viewvc/llvm-project?rev=307914=rev Log: [OPENMP] Further reduction test fix, NFC. Modified: cfe/trunk/test/OpenMP/for_reduction_codegen.cpp cfe/trunk/test/OpenMP/for_reduction_codegen_UDR.cpp

[PATCH] D34588: Check for _MSC_VER before define _LIBCPP_MSVCRT

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. > Some non-windows targets using MS extensions define _WIN32 for compatibility > with Windows but do not have MSVC compatibility. So, these hypothetical targets have the Win32 API available, but

[PATCH] D16403: Add scope information to CFG for If/While/For/Do/Compound/CXXRangeFor statements

NoQ added a comment. I think the remaining switch-related code seems to be about C++17 switch condition variables, i.e. `switch (int x = ...)`(?) Repository: rL LLVM https://reviews.llvm.org/D16403 ___ cfe-commits mailing list

[PATCH] D33589: clang-format: consider not splitting tokens in optimization

Typz updated this revision to Diff 106442. Typz added a comment. Move code out of optimizer, directly into ContinuationIndenter::breakProtrudingToken(), to minimize impact on performance. Comment reflowing of breakable items which break the limit will be slightly slower, since we now consider

[PATCH] D35337: [Solaris] gcc runtime dropped support for .ctors, switch to .init_array

dlj accepted this revision. dlj added a comment. I think this change is structurally fine, but I'll defer to others on whether it's actually doing the right thing. (I'm pretty sure it is, but I'm far from an expert on Solaris or Sparc.) Comment at:

[PATCH] D32914: Introduce Wzero-as-null-pointer-constant.

lebedev.ri added a comment. PR #33771 filled. IMHO the problems with this diagnostic should be resolved before 5.0 https://reviews.llvm.org/D32914 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D32914: Introduce Wzero-as-null-pointer-constant.

On Thu, Jul 13, 2017 at 1:38 PM, Roman Lebedev via Phabricator via cfe-commits wrote: > lebedev.ri added a comment. > > PR #33771 filled. > IMHO the problems with this diagnostic should be resolved before 5.0 > iirc gcc

[PATCH] D34331: func.wrap.func.con: Unset function before destroying anything

dexonsmith added a comment. In https://reviews.llvm.org/D34331#803452, @EricWF wrote: > In https://reviews.llvm.org/D34331#803105, @dexonsmith wrote: > > > In https://reviews.llvm.org/D34331#802747, @EricWF wrote: > > > > > @dexonsmith Mind if I hijack this and check in your changes to > > > ``

[PATCH] D16403: Add scope information to CFG for If/While/For/Do/Compound/CXXRangeFor statements

m.ostapenko added a comment. In https://reviews.llvm.org/D16403#808104, @NoQ wrote: > I think the remaining switch-related code seems to be about C++17 switch > condition variables, i.e. `switch (int x = ...)`(?) Yeah, exactly. I can remove it from this patch if it looks confusing.

[PATCH] D35081: [ThinLTO] Allow multiple summary entries.

tejohnson added a comment. In https://reviews.llvm.org/D35081#808204, @mehdi_amini wrote: > In https://reviews.llvm.org/D35081#808189, @tejohnson wrote: > > > > Alternatively (and likely preferably from a compile-time point of view to > > > limit the list of import), we could keep a map of

r307910 - [OPENMP] Generalization of codegen for reduction clauses.

Author: abataev Date: Thu Jul 13 06:36:14 2017 New Revision: 307910 URL: http://llvm.org/viewvc/llvm-project?rev=307910=rev Log: [OPENMP] Generalization of codegen for reduction clauses. Reworked codegen for reduction clauses for future support of reductions in task-based directives. Modified:

r307915 - [OPENMP] Fix reduction tests, NFC.

Author: abataev Date: Thu Jul 13 08:09:05 2017 New Revision: 307915 URL: http://llvm.org/viewvc/llvm-project?rev=307915=rev Log: [OPENMP] Fix reduction tests, NFC. Modified: cfe/trunk/test/OpenMP/for_reduction_codegen.cpp cfe/trunk/test/OpenMP/for_reduction_codegen_UDR.cpp Modified:

r307916 - [OPENMP] Fix reduction tests, NFC.

Author: abataev Date: Thu Jul 13 08:15:25 2017 New Revision: 307916 URL: http://llvm.org/viewvc/llvm-project?rev=307916=rev Log: [OPENMP] Fix reduction tests, NFC. Modified: cfe/trunk/test/OpenMP/for_reduction_codegen.cpp cfe/trunk/test/OpenMP/for_reduction_codegen_UDR.cpp Modified:

[PATCH] D35118: [AArch64] Add support for handling the +sve target feature

This revision was automatically updated to reflect the committed changes. Closed by commit rL307919: [AArch64] Add support for handling the +sve target feature. (authored by aemerson). Changed prior to commit: https://reviews.llvm.org/D35118?vs=106386=106432#toc Repository: rL LLVM

r307919 - [AArch64] Add support for handling the +sve target feature.

Author: aemerson Date: Thu Jul 13 08:36:01 2017 New Revision: 307919 URL: http://llvm.org/viewvc/llvm-project?rev=307919=rev Log: [AArch64] Add support for handling the +sve target feature. This also adds the appropriate predefine for SVE if enabled. Differential Revision:

[PATCH] D16403: Add scope information to CFG for If/While/For/Do/Compound/CXXRangeFor statements

szepet added a comment. Hello Maxim! Thanks for working on this! > Ugh, yeah, SwitchStmt is tricky (thank you for pointing to Duff's device > example!). I've tried to resolve several issues with switch revealed by this > testcase, but didn't succeed for now :(. So, it was decided to remove >

r307911 - [OPENMP] Fix reduction tests, NFC.

Author: abataev Date: Thu Jul 13 07:29:19 2017 New Revision: 307911 URL: http://llvm.org/viewvc/llvm-project?rev=307911=rev Log: [OPENMP] Fix reduction tests, NFC. Modified: cfe/trunk/test/OpenMP/for_reduction_codegen.cpp cfe/trunk/test/OpenMP/for_reduction_codegen_UDR.cpp Modified:

[PATCH] D35081: [ThinLTO] Allow multiple summary entries.

tejohnson added a comment. In https://reviews.llvm.org/D35081#807497, @mehdi_amini wrote: > In https://reviews.llvm.org/D35081#807172, @fhahn wrote: > > > It's @yunlian, so if the issue you described above covers his failure, than > > that's great. @tejohnson do you have time to work on a fix

[PATCH] D33589: clang-format: consider not splitting tokens in optimization

Typz marked 2 inline comments as done. Typz added inline comments. Comment at: lib/Format/UnwrappedLineFormatter.cpp:723 FormatDecision LastFormat = Node->State.NextToken->Decision; if (LastFormat == FD_Unformatted || LastFormat == FD_Continue) +

[PATCH] D35337: [Solaris] gcc runtime dropped support for .ctors, switch to .init_array

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM. Comment at: lib/Driver/ToolChains/Gnu.cpp:2467 const Generic_GCC::GCCVersion = GCCInstallation.getVersion(); bool UseInitArrayDefault =

[PATCH] D33333: Emit warning when throw exception in destruct or dealloc functions which has a (possible implicit) noexcept specifier

baloghadamsoftware added a comment. I tested the latest revision (this fronted patch already included) on my test file in https://reviews.llvm.org/D33537. Disregarding of the (not so important) check-specific parameters (`EnabledFunctions` and `IgnoredExceptions`) I do not get warnings for any

r307912 - [OPENMP] Fix reduction tests, NFC.

Author: abataev Date: Thu Jul 13 07:54:42 2017 New Revision: 307912 URL: http://llvm.org/viewvc/llvm-project?rev=307912=rev Log: [OPENMP] Fix reduction tests, NFC. Modified: cfe/trunk/test/OpenMP/for_reduction_codegen.cpp cfe/trunk/test/OpenMP/for_reduction_codegen_UDR.cpp Modified:

[PATCH] D34588: Check for _MSC_VER before define _LIBCPP_MSVCRT

compnerd added a comment. In https://reviews.llvm.org/D34588#802533, @bruno wrote: > > Thinking more about this, on Windows, is there a strong reason to default > > to a different libc by default on Windows? > > I'm mostly concerned with `-fms-extensions` + darwin, which doesn't apply to >

RE: D34588: Check for _MSC_VER before define _LIBCPP_MSVCRT

These hypothetical targets aren’t so hypothetical. Office for Mac and iOS uses code ported from Windows but actually targeted at running on the Apple (Darwin) platform. We don’t have the MSVC CRT there.  Schwieb -Original Message- From: Reid Kleckner via Phabricator

[PATCH] D35355: Fix templated type alias completion when using global completion cache

yvvan created this revision. When we have enabled cache for global completions we did not have diagnostics for Bar and could not complete Ba as in provided code example. template struct Foo { T member; }; template using Bar = Foo; int main() { Ba } https://reviews.llvm.org/D35355

[PATCH] D35110: [Analyzer] Constraint Manager Negates Difference

baloghadamsoftware added inline comments. Comment at: lib/StaticAnalyzer/Core/RangeConstraintManager.cpp:511 + SSE->getLHS()->getType()->isSignedIntegerOrEnumerationType() || + SSE->getLHS()->getType()->isPointerType()) { + return negV->Negate(BV,

[PATCH] D33537: [clang-tidy] Exception Escape Checker

erichkeane added a comment. In https://reviews.llvm.org/D33537#801889, @baloghadamsoftware wrote: > In https://reviews.llvm.org/D33537#771274, @aaron.ballman wrote: > > > The check in https://reviews.llvm.org/D3 is using a CFG, not just > > checking direct throws. > > > I tested the latest

[PATCH] D35081: [ThinLTO] Allow multiple summary entries.

mehdi_amini added a comment. In https://reviews.llvm.org/D35081#808207, @tejohnson wrote: > My first option was if any copy is under the threshold, simply pick the > prevailing copy (it may be over threshold, but assume we want that one > anyway). Another possibility is to only allow importing

[PATCH] D35379: Add documentation for @available

erik.pilkington added a reviewer: arphaman. erik.pilkington added a subscriber: arphaman. erik.pilkington added a comment. This looks great, thanks for working on this! LGTM, but @arphaman might have some thoughts. Comment at: docs/LanguageExtensions.rst:1290 -..

[PATCH] D34121: [ubsan] Teach the pointer overflow check that "p - <= p" (PR33430)

dtzWill added a comment. In https://reviews.llvm.org/D34121#806978, @vsk wrote: > @dtzWill do you have any further comments on this one? > > I'd like to get another 'lgtm' before committing, and it'd be nice to get > this in before llvm 5.0 branches (7/19). > > FWIW we've been living on this

[PATCH] D35383: [coroutines] Add serialization/deserialization of coroutines

GorNishanov created this revision. Herald added a subscriber: EricWF. https://reviews.llvm.org/D35383 Files: include/clang/AST/StmtCXX.h include/clang/Serialization/ASTBitCodes.h lib/AST/StmtCXX.cpp lib/Serialization/ASTReaderStmt.cpp lib/Serialization/ASTWriterStmt.cpp

[PATCH] D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.

martell added inline comments. Comment at: examples/clang-interpreter/Manager.cpp:18 +#define NOMINMAX +#include +#endif windows.h with lower case `w` to not break mingw https://reviews.llvm.org/D35103 ___

[PATCH] D35378: [clang] Add getSignedSizeType method

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM https://reviews.llvm.org/D35378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35370: [clang-tidy] Add a close-on-exec check on inotify_init() in Android module.

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:60 +- New `android-cloexec-inotify-init + `_ check Please sort checks in alphabetical order.

[PATCH] D35368: [clang-tidy] Add a close-on-exec check on inotify_init1() in Android module.

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:60 +- New `android-cloexec-inotify-init1 + `_ check Please sort checks in alphabetical order.

[PATCH] D35378: [clang] Add getSignedSizeType method

alexshap updated this revision to Diff 106496. alexshap added a comment. make comments consistent Repository: rL LLVM https://reviews.llvm.org/D35378 Files: include/clang/AST/ASTContext.h include/clang/Basic/TargetInfo.h lib/AST/ASTContext.cpp Index: lib/AST/ASTContext.cpp

[PATCH] D35379: Add documentation for @available

thakis created this revision. Based on https://devstreaming-cdn.apple.com/videos/wwdc/2017/411a7o9phe4uekm/411/411_whats_new_in_llvm.pdf (I couldn't find a way to play the corresponding video on linux, so I didn't look at that.) https://reviews.llvm.org/D35379 Files:

[PATCH] D34121: [ubsan] Teach the pointer overflow check that "p - <= p" (PR33430)

vsk added a comment. In https://reviews.llvm.org/D34121#808486, @dtzWill wrote: > In https://reviews.llvm.org/D34121#806978, @vsk wrote: > > > @dtzWill do you have any further comments on this one? > > > > I'd like to get another 'lgtm' before committing, and it'd be nice to get > > this in

[PATCH] D34475: [AArch64] Add support for __builtin_ms_va_list on aarch64

rnk added inline comments. Comment at: include/clang/Basic/BuiltinsAArch64.def:65 +// Win64-compatible va_list functions +BUILTIN(__builtin_ms_va_start, "vc*&.", "nt") +BUILTIN(__builtin_ms_va_end, "vc*&", "n") mstorsjo wrote: > rnk wrote: > > I strongly suspect

[PATCH] D35367: [clang-tidy] Add a close-on-exec check on epoll_create() in Android module.

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:60 +- New `android-cloexec-epoll-create + `_ check Please sort checks in alphabetical order.

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

yaxunl marked 6 inline comments as done. yaxunl added inline comments. Comment at: lib/AST/Expr.cpp:3235 +// has non-default address space it is not treated as nullptr. +bool PointeeHasDefaultAS = false; +if (Ctx.getLangOpts().OpenCL)

[PATCH] D35082: [OpenCL] Add LangAS::opencl_private to represent private address space in AST

yaxunl updated this revision to Diff 106486. yaxunl marked 6 inline comments as done. yaxunl added a comment. Revised by Anastasia's comments. https://reviews.llvm.org/D35082 Files: include/clang/Basic/AddressSpaces.h lib/AST/ASTContext.cpp lib/AST/Expr.cpp lib/AST/ItaniumMangle.cpp

[PATCH] D34824: clang-format: add an option -verbose to list the files being processed

sylvestre.ledru added inline comments. Comment at: tools/clang-format/ClangFormat.cpp:377 break; case 1: Error = clang::format::format(FileNames[0]); djasper wrote: > I think we should restructure the code to not have to duplicate what you are >

[libcxxabi] r307941 - [demangler] Respect try_to_parse_template_args

Author: epilk Date: Thu Jul 13 12:37:37 2017 New Revision: 307941 URL: http://llvm.org/viewvc/llvm-project?rev=307941=rev Log: [demangler] Respect try_to_parse_template_args Fixes an exponential parse found by oss-fuzz. Modified: libcxxabi/trunk/src/cxa_demangle.cpp

[PATCH] D35378: [clang] Add getSignedSizeType method

alexshap created this revision. C11 standard refers to the signed counterpart of the size_t type in the paragraph 7.21.6.1 where it defines d, i, o, u, x, or x conversion specifiers (in printf format string). In Clang there is a FIXME (in lib/Analysis/PrintfFormatString.cpp) for this case (which

[PATCH] D34475: [AArch64] Add support for __builtin_ms_va_list on aarch64

mstorsjo added inline comments. Comment at: include/clang/Basic/BuiltinsAArch64.def:65 +// Win64-compatible va_list functions +BUILTIN(__builtin_ms_va_start, "vc*&.", "nt") +BUILTIN(__builtin_ms_va_end, "vc*&", "n") rnk wrote: > I strongly suspect that Microsoft

[PATCH] D35379: Add documentation for @available

thakis updated this revision to Diff 106513. thakis marked an inline comment as done. thakis added a comment. comments https://reviews.llvm.org/D35379 Files: docs/LanguageExtensions.rst include/clang/Basic/AttrDocs.td Index: include/clang/Basic/AttrDocs.td

[PATCH] D35379: Add documentation for @available

thakis added inline comments. Comment at: docs/LanguageExtensions.rst:1290 -.. _langext-overloading: - erik.pilkington wrote: > did you mean to remove this? I meant to move it above the "protocol-qualifier mangling of parameters" section; I think that's where

[PATCH] D35372: [clang-tidy] Add a close-on-exec check on memfd_create() in Android module.

Eugene.Zelenko added inline comments. Comment at: docs/ReleaseNotes.rst:60 +- New `android-cloexec-memfd_create + `_ check Please sort checks in alphabetical order.

[PATCH] D34475: [AArch64] Add support for __builtin_ms_va_list on aarch64

rnk added inline comments. Comment at: include/clang/Basic/BuiltinsAArch64.def:65 +// Win64-compatible va_list functions +BUILTIN(__builtin_ms_va_start, "vc*&.", "nt") +BUILTIN(__builtin_ms_va_end, "vc*&", "n") I strongly suspect that Microsoft will never adopt

[PATCH] D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.

martell added a comment. Just 2 small nits. Comment at: examples/clang-interpreter/main.cpp:165 + llvm::errs() << "'main' function not found in module.\n"; + return 255; +} 255 -> Res ? Comment at:

Re: r305860 - Special-case handling of destructors in override lists when dumping ASTs.

Sure. Richard - is this likely to be related to your query? Calling getName() on at least one destructor in Sema/ms_class_layout triggers the assertion in NamedDecl::getName(): (lldb) frame #4: 0x0001039600e2 clang`clang::NamedDecl::getName(this=0x000112897490) const at Decl.h:238 235

r307959 - Use getNameAsString instead of getName to get method names when dumping

Author: lhames Date: Thu Jul 13 14:08:29 2017 New Revision: 307959 URL: http://llvm.org/viewvc/llvm-project?rev=307959=rev Log: Use getNameAsString instead of getName to get method names when dumping overrides: getName can fail if the decl's name isn't a simple identifier. This is a more

[PATCH] D35081: [ThinLTO] Allow multiple summary entries.

tejohnson added a comment. In https://reviews.llvm.org/D35081#808517, @mehdi_amini wrote: > In https://reviews.llvm.org/D35081#808207, @tejohnson wrote: > > > My first option was if any copy is under the threshold, simply pick the > > prevailing copy (it may be over threshold, but assume we

[PATCH] D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.

marsupial updated this revision to Diff 106548. marsupial added a comment. Blocked Win64 SEH for MingW entirely. Theoretically it should be possible to throw a SEH from within mingw, but but I'm thinking clang may be generating exception handlers for the gcc runtime in that case. I'll leave it

Re: r305860 - Special-case handling of destructors in override lists when dumping ASTs.

FWIW: Replacing the call to getName with getNameAsString seems to fix the destructor issue as well (i.e. I can remove the special case for destructors) so I've committed this r307959. If the getName failure for destructors is unexpected it may be worth digging into as a separate issue. Cheers,

[libcxx] r307965 - [libc++] Remove unused _LIBCPP_FUNC_VIS_ONLY

Author: smeenai Date: Thu Jul 13 14:28:17 2017 New Revision: 307965 URL: http://llvm.org/viewvc/llvm-project?rev=307965=rev Log: [libc++] Remove unused _LIBCPP_FUNC_VIS_ONLY This has been unused since r282644. Modified: libcxx/trunk/include/__config Modified: libcxx/trunk/include/__config

[PATCH] D35367: [clang-tidy] Add a close-on-exec check on epoll_create() in Android module.

yawanng updated this revision to Diff 106539. yawanng marked an inline comment as done. Herald added subscribers: xazax.hun, JDevlieghere. https://reviews.llvm.org/D35367 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt

[PATCH] D35388: [libc++] Give extern templates default visibility on gcc

smeenai created this revision. Contrary to the current visibility macro documentation, it appears that gcc does handle visibility attribute on extern templates correctly, e.g. https://godbolt.org/g/EejuV7. We need this so that extern template instantiations of classes not marked

[libcxx] r307972 - [libc++] class template -> template class. NFC

Author: smeenai Date: Thu Jul 13 15:08:59 2017 New Revision: 307972 URL: http://llvm.org/viewvc/llvm-project?rev=307972=rev Log: [libc++] class template -> template class. NFC Modified: libcxx/trunk/docs/DesignDocs/VisibilityMacros.rst Modified:

[PATCH] D35370: [clang-tidy] Add a close-on-exec check on inotify_init() in Android module.

yawanng updated this revision to Diff 106517. yawanng marked an inline comment as done. https://reviews.llvm.org/D35370 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/CloexecInotifyInitCheck.cpp

[PATCH] D35385: [Driver] Darwin: Link in the profile runtime archive first

vsk created this revision. While building a project with code coverage enabled, we can link in dependencies which export a weak definition of __llvm_profile_filename. After r306710, linking in the profiling runtime could pull in a weak definition of this symbol from a dependency, instead of from

[libcxx] r307966 - [libc++] Mark string operator+ _LIBCPP_FUNC_VIS

Author: smeenai Date: Thu Jul 13 14:35:52 2017 New Revision: 307966 URL: http://llvm.org/viewvc/llvm-project?rev=307966=rev Log: [libc++] Mark string operator+ _LIBCPP_FUNC_VIS It has an extern template instantiation declaration in the headers and a corresponding instantiation definition in the

[PATCH] D35103: Expand clang-interpreter with example of throwing in and from the JIT for Windows64.

marsupial marked 3 inline comments as done. marsupial added a comment. Done, and changed to 'windows.h', but blocked mingw from even attempting SEH for now. https://reviews.llvm.org/D35103 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35365: [clang-tidy] Add a close-on-exec check on epoll_create1() in Android module.

Eugene.Zelenko added inline comments. Comment at: clang-tidy/android/CloexecEpollCreate1Check.cpp:21 + +static constexpr const char *EPOLL_CLOEXEC = "EPOLL_CLOEXEC"; + Please make this declaration consent across all checks. In some checks it declared inside

[PATCH] D35368: [clang-tidy] Add a close-on-exec check on inotify_init1() in Android module.

yawanng updated this revision to Diff 106520. yawanng marked an inline comment as done. Herald added subscribers: xazax.hun, JDevlieghere. https://reviews.llvm.org/D35368 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt

r307955 - [ubsan] Teach the pointer overflow check that "p - <= p" (PR33430)

Author: vedantk Date: Thu Jul 13 13:55:26 2017 New Revision: 307955 URL: http://llvm.org/viewvc/llvm-project?rev=307955=rev Log: [ubsan] Teach the pointer overflow check that "p - <= p" (PR33430) The pointer overflow check gives false negatives when dealing with expressions in which an unsigned

[PATCH] D34121: [ubsan] Teach the pointer overflow check that "p - <= p" (PR33430)

This revision was automatically updated to reflect the committed changes. Closed by commit rL307955: [ubsan] Teach the pointer overflow check that "p - <= p" (PR33430) (authored by vedantk). Changed prior to commit: https://reviews.llvm.org/D34121?vs=103606=106524#toc Repository: rL LLVM

r307964 - [PS4] Disable LTO unit features under ThinLTO, like for Darwin.

Author: probinson Date: Thu Jul 13 14:25:47 2017 New Revision: 307964 URL: http://llvm.org/viewvc/llvm-project?rev=307964=rev Log: [PS4] Disable LTO unit features under ThinLTO, like for Darwin. Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp cfe/trunk/test/Driver/lto-unit.c

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

enyquist added a comment. Gaaah. I'm so sorry. I wrote that last comment months ago and never submitted. No wonder you guys weren't responding. Comment at: lib/Format/WhitespaceManager.cpp:470 // definitions. return C.Tok->is(TT_StartOfName)

[PATCH] D35372: [clang-tidy] Add a close-on-exec check on memfd_create() in Android module.

yawanng updated this revision to Diff 106515. yawanng marked an inline comment as done. https://reviews.llvm.org/D35372 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/CloexecMemfdCreateCheck.cpp

[PATCH] D35379: Add documentation for @available

erik.pilkington added inline comments. Comment at: docs/LanguageExtensions.rst:1309 + void my_fun(NSSomeClass* var) { +if (@available(macOS 10.12)) { + [var fancyNewMethod]; thakis wrote: > erik.pilkington wrote: > > Don't forget the '*', ie

[libcxx] r307954 - [libc++] Use proper template terminology. NFC

Author: smeenai Date: Thu Jul 13 13:47:24 2017 New Revision: 307954 URL: http://llvm.org/viewvc/llvm-project?rev=307954=rev Log: [libc++] Use proper template terminology. NFC It's supposed to be "class template" and "function template" instead of "template class" and "template function".

[PATCH] D35365: [clang-tidy] Add a close-on-exec check on epoll_create1() in Android module.

yawanng updated this revision to Diff 106523. yawanng marked 2 inline comments as done. https://reviews.llvm.org/D35365 Files: clang-tidy/android/AndroidTidyModule.cpp clang-tidy/android/CMakeLists.txt clang-tidy/android/CloexecEpollCreate1Check.cpp

[PATCH] D35379: Add documentation for @available

thakis updated this revision to Diff 106528. thakis marked an inline comment as done. thakis added a comment. Document *, add example with multiple platforms https://reviews.llvm.org/D35379 Files: docs/LanguageExtensions.rst include/clang/Basic/AttrDocs.td Index:

r307923 - NFC, Cleanup the code for -Wdeprecated-implementations

Author: arphaman Date: Thu Jul 13 09:35:59 2017 New Revision: 307923 URL: http://llvm.org/viewvc/llvm-project?rev=307923=rev Log: NFC, Cleanup the code for -Wdeprecated-implementations and void capitalization of the warning message rdar://22867595 Modified:

[PATCH] D35081: [ThinLTO] Allow multiple summary entries.

mehdi_amini added a comment. In https://reviews.llvm.org/D35081#808189, @tejohnson wrote: > > Alternatively (and likely preferably from a compile-time point of view to > > limit the list of import), we could keep a map of GUID->Summary and reuse > > it before trying to select a new callee. > >

r307931 - Fix -Wdocumentation warning. NFCI

Author: rksimon Date: Thu Jul 13 10:29:48 2017 New Revision: 307931 URL: http://llvm.org/viewvc/llvm-project?rev=307931=rev Log: Fix -Wdocumentation warning. NFCI Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h URL:

r307995 - Add release notes for the overloadable attribute

Author: gbiv Date: Thu Jul 13 20:23:57 2017 New Revision: 307995 URL: http://llvm.org/viewvc/llvm-project?rev=307995=rev Log: Add release notes for the overloadable attribute Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL:

[libcxx] r307997 - [libc++] Clean up cl warning 4231 disabling

Author: smeenai Date: Thu Jul 13 20:56:54 2017 New Revision: 307997 URL: http://llvm.org/viewvc/llvm-project?rev=307997=rev Log: [libc++] Clean up cl warning 4231 disabling Once upon a time, extern templates used to be a Microsoft extension, so cl would warn about their usage, and libc++

r307982 - [Driver] Respect -target when determining target platform on Apple

Author: ahatanak Date: Thu Jul 13 17:21:32 2017 New Revision: 307982 URL: http://llvm.org/viewvc/llvm-project?rev=307982=rev Log: [Driver] Respect -target when determining target platform on Apple platforms. Set the target OS based on -target if it is present on the command line and -arch is

  1   2   >