[PATCH] D34654: Allow passing a regex for headers to exclude from clang-tidy

toddlipcon updated this revision to Diff 107148. toddlipcon added a comment. Regenerated patch with full context Repository: rL LLVM https://reviews.llvm.org/D34654 Files: clang-tidy/ClangTidyDiagnosticConsumer.cpp clang-tidy/ClangTidyDiagnosticConsumer.h

[PATCH] D35329: [clang-reorder-fields] Enable reordering for plain C structs

alexshap updated this revision to Diff 107143. alexshap added a comment. update the comments Repository: rL LLVM https://reviews.llvm.org/D35329 Files: clang-reorder-fields/ReorderFieldsAction.cpp test/clang-reorder-fields/PlainCStructFieldsOrder.c Index:

[PATCH] D34440: [Clang] Expand response files before loading compilation database

vladimir.plyashkun added a comment. Thanks for the response @klimek ! Sorry for possible confusions. > Yes. I'm still confused why in this case clang-tidy @file -- would be > expected to expand the response file? Am I missing something? I think that we discussed use-case when @response files

[libcxx] r308347 - [CMake] Use MATCHES for regular expression.

Author: aoli Date: Tue Jul 18 12:48:02 2017 New Revision: 308347 URL: http://llvm.org/viewvc/llvm-project?rev=308347=rev Log: [CMake] Use MATCHES for regular expression. Subscribers: mgorny Differential Revision: https://reviews.llvm.org/D35514 Modified: libcxx/trunk/lib/CMakeLists.txt

r308357 - Convert attribute 'target' parsing from a 'pair' to a 'struct' to make further improvements easier

Author: erichkeane Date: Tue Jul 18 13:41:02 2017 New Revision: 308357 URL: http://llvm.org/viewvc/llvm-project?rev=308357=rev Log: Convert attribute 'target' parsing from a 'pair' to a 'struct' to make further improvements easier Convert attribute 'target' parsing from a 'pair' to a 'struct'

[PATCH] D33561: [CMake] Add Android toolchain CMake cache files.

aoli updated this revision to Diff 107158. aoli added a comment. Add more configs. https://reviews.llvm.org/D33561 Files: cmake/caches/Android-stage2.cmake cmake/caches/Android.cmake Index: cmake/caches/Android.cmake === ---

[PATCH] D35578: Add -fswitch-tables and -fno-switch-tables flags

sgundapa added a comment. The switch-case statements generate two kinds of tables. 1. Jump tables 2. Lookup tables. While the general assumption is that switch-case statements generate jump tables, the below case generates a lookup table by late simplifycfg int foo(int x) { switch (x) {

[PATCH] D35582: [Driver] Always use -z rodynamic for Fuchsia

phosek created this revision. Fuchsia uses read-only .dynamic section. Repository: rL LLVM https://reviews.llvm.org/D35582 Files: lib/Driver/ToolChains/Fuchsia.cpp test/Driver/fuchsia.c test/Driver/fuchsia.cpp Index: test/Driver/fuchsia.cpp

[PATCH] D35578: Add -fswitch-tables and -fno-switch-tables flags

mcrosier added a comment. In https://reviews.llvm.org/D35578#813548, @sgundapa wrote: > The switch-case statements generate two kinds of tables. > > 1. Jump tables > 2. Lookup tables. > > While the general assumption is that switch-case statements generate jump > tables, the below case

[PATCH] D35559: [CMake][Modules] Tweak Modules-unfriendly builds

dblaikie added a comment. I know Richard Smith has a modules buildbot - so I'm curious: How is it working without these changes? Are these changes an effort to broaden the coverage of modular self hosting builds (what's the current coverage? (only LLVM proper) what's the new coverage? (all

r308333 - Don't set TUScope to null when generating a module in incremental processing mode.

Author: teemperor Date: Tue Jul 18 11:24:42 2017 New Revision: 308333 URL: http://llvm.org/viewvc/llvm-project?rev=308333=rev Log: Don't set TUScope to null when generating a module in incremental processing mode. Summary: When in incremental processing mode, we should never set `TUScope` to a

r308340 - Add GCC's noexcept-type alias for c++1z-compat-mangling

Author: teemperor Date: Tue Jul 18 11:52:58 2017 New Revision: 308340 URL: http://llvm.org/viewvc/llvm-project?rev=308340=rev Log: Add GCC's noexcept-type alias for c++1z-compat-mangling Summary: GCC has named this `-Wnoexcept-type`, so let's add an alias to stay compatible with the GCC flags.

r308352 - [OPENMP] Initial support for 'task_reduction' clause.

Author: abataev Date: Tue Jul 18 13:17:46 2017 New Revision: 308352 URL: http://llvm.org/viewvc/llvm-project?rev=308352=rev Log: [OPENMP] Initial support for 'task_reduction' clause. Parsing/sema analysis of the 'task_reduction' clause. Added:

[PATCH] D35572: Add isValidCPUName and isValidFeature to TargetInfo

erichkeane added a comment. In https://reviews.llvm.org/D35572#813369, @echristo wrote: > Can you update the code in CGBuiltin to use this as part of this patch? :) > > Thanks! I'm not sure which you're referring to? I don't see a bit in CGBuiltin that checks for a subset of the "Features",

[PATCH] D35583: Debug Info: Add a file: field to DIImportedEntity

aprantl updated this revision to Diff 107180. aprantl added a comment. Forgot to git-add new clang test case input files. https://reviews.llvm.org/D35583 Files: include/llvm/IR/DIBuilder.h include/llvm/IR/DebugInfoMetadata.h lib/AsmParser/LLParser.cpp

[PATCH] D35533: [Basic] Update CMakeLists.txt to handle Repo

hintonda added inline comments. Comment at: lib/Basic/CMakeLists.txt:17 macro(find_first_existing_vc_file out_var path) set(git_path "${path}/.git") LLVM already has a version of find_first_existing_vc_file in llvm/include/llvm/Support/CMakelists.txt.

[PATCH] D35329: [clang-reorder-fields] Enable reordering for plain C structs

hokein added inline comments. Comment at: clang-reorder-fields/ReorderFieldsAction.cpp:236 + +// CXXRD will be nullptr if C code (not C++) is being processed +const CXXRecordDecl *CXXRD = dyn_cast(RD); Nit: missing a trailing `.`. I think we could use

[PATCH] D35514: [CMake] Use MATCHES for regular expression comparison.

This revision was automatically updated to reflect the committed changes. Closed by commit rL308347: [CMake] Use MATCHES for regular expression. (authored by aoli). Repository: rL LLVM https://reviews.llvm.org/D35514 Files: libcxx/trunk/lib/CMakeLists.txt Index:

[PATCH] D33561: [CMake] Add Android toolchain CMake cache files.

jroelofs added inline comments. Comment at: cmake/caches/Android-stage2.cmake:37 + set(RUNTIMES_${target}-linux-android_COMPILER_RT_INCLUDE_TESTS OFF CACHE BOOL "") + set(RUNTIMES_${target}-linux-android_LLVM_ENABLE_ASSERTIONS ON CACHE BOOL "") +

[PATCH] D33561: [CMake] Add Android toolchain CMake cache files.

jroelofs added inline comments. Comment at: cmake/caches/Android-stage2.cmake:37 + set(RUNTIMES_${target}-linux-android_COMPILER_RT_INCLUDE_TESTS OFF CACHE BOOL "") + set(RUNTIMES_${target}-linux-android_LLVM_ENABLE_ASSERTIONS ON CACHE BOOL "") +

[PATCH] D35574: Convert attribute 'target' parsing from a 'pair' to a 'struct' to make further improvements easier

This revision was automatically updated to reflect the committed changes. Closed by commit rL308357: Convert attribute 'target' parsing from a 'pair' to a 'struct' to make further… (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D35574?vs=107131=107171#toc

[PATCH] D35583: Debug Info: Add a file: field to DIImportedEntity

aprantl created this revision. Herald added subscribers: eraman, mehdi_amini. DIImportedEntity has a line number, but not a file field. To determine the decl_line/decl_file we combine the line number from the DIImportedEntity with the file from the DIImportedEntity's scope. This does not work

[PATCH] D35583: Debug Info: Add a file: field to DIImportedEntity

aprantl added a comment. Note that this review contains also the corresponding clang changes in the tools/ directory. Repository: rL LLVM https://reviews.llvm.org/D35583 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35514: [CMake] Use MATCHES for regular expression comparison.

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D35514 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35012: [refactor] Add the AST source selection component

arphaman updated this revision to Diff 107138. arphaman added a comment. rm early exit bug Repository: rL LLVM https://reviews.llvm.org/D35012 Files: include/clang/AST/LexicallyOrderedRecursiveASTVisitor.h include/clang/Basic/SourceLocation.h include/clang/Basic/SourceManager.h

[PATCH] D35520: [Sema] Improve diagnostic message for unavailable c++17 aligned allocation functions

ahatanak updated this revision to Diff 107140. ahatanak marked 6 inline comments as done. ahatanak added a comment. Address review comments. https://reviews.llvm.org/D35520 Files: include/clang/Basic/AlignedAllocation.h include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D33561: [CMake] Add Android toolchain CMake cache files.

pirama added inline comments. Comment at: cmake/caches/Android-stage2.cmake:37 + set(RUNTIMES_${target}-linux-android_COMPILER_RT_INCLUDE_TESTS OFF CACHE BOOL "") + set(RUNTIMES_${target}-linux-android_LLVM_ENABLE_ASSERTIONS ON CACHE BOOL "") +

[PATCH] D35578: Add -fswitch-tables and -fno-switch-tables flags

mcrosier added a comment. What exactly is the difference between -fno-jump-tables, -fno-switch-tables, and -fno-lookup-tables? https://reviews.llvm.org/D35578 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32817: [CMake] Build runtimes for Fuchsia targets

phosek updated this revision to Diff 107178. Repository: rL LLVM https://reviews.llvm.org/D32817 Files: cmake/caches/Fuchsia-stage2.cmake cmake/caches/Fuchsia.cmake Index: cmake/caches/Fuchsia.cmake === ---

[PATCH] D35572: Add isValidCPUName and isValidFeature to TargetInfo

echristo added a comment. Can you update the code in CGBuiltin to use this as part of this patch? :) Thanks! https://reviews.llvm.org/D35572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35573: Improve SEMA for attribute-target

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM pending dependency approval https://reviews.llvm.org/D35573 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35574: Convert attribute 'target' parsing from a 'pair' to a 'struct' to make further improvements easier

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D35574 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r308356 - [Sema] NFC: Move all availability checking code to SemaDeclAttr.cpp

Author: epilk Date: Tue Jul 18 13:32:07 2017 New Revision: 308356 URL: http://llvm.org/viewvc/llvm-project?rev=308356=rev Log: [Sema] NFC: Move all availability checking code to SemaDeclAttr.cpp Previously, this was awkwardly split up between SemaExpr.cpp. Modified:

[PATCH] D35038: [libunwind] Add a test harness

manojgupta added inline comments. Comment at: test/lit.cfg:36 +else: +lit_config.fatal('Could not find libcxx test directory for test imports' + ' in: %s' % libcxx_test_src_root) jroelofs wrote: > manojgupta wrote: > > I do not have

[PATCH] D35583: Debug Info: Add a file: field to DIImportedEntity

aprantl added inline comments. Comment at: lib/Bitcode/Reader/MetadataLoader.cpp:1684 + HasFile ? getMDOrNull(Record[6]) : nullptr, + HasFile ? Record[4] : 0, getMDString(Record[5]))), NextMetadataNo);

[PATCH] D34724: [analyzer] Add MagentaHandleChecker for the Magenta kernel

haowei updated this revision to Diff 107201. haowei added a comment. Thanks for reviewing this patch. I have modified the checker according NoQ's suggestions and refactored some long functions. > We're trying to use this CallDescription thing for this purpose recently. I took a look at

[PATCH] D35578: Add -fswitch-tables and -fno-switch-tables flags

Quuxplusone added a comment. If the goal is fine-grained control over the heuristics for compiling switch statements, perhaps one should enumerate all the possible ways to lower switch statements --- jump-tables, lookup-tables, if-trees, if-chains, (more?) --- and add a separate flag for each

[libunwind] r308380 - [CMake] Set library dir to be LLVM's intermediate output dir

Author: phosek Date: Tue Jul 18 14:30:18 2017 New Revision: 308380 URL: http://llvm.org/viewvc/llvm-project?rev=308380=rev Log: [CMake] Set library dir to be LLVM's intermediate output dir This matches the behavior of libc++abi and libc++ and ensures that we get a working toolchain when building

[PATCH] D35548: [mips] Teach the driver to accept -m(no-)gpopt.

atanasyan accepted this revision. atanasyan added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D35548 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35479: [CodeGen][mips] Support `long_call/far/near` attributes

atanasyan updated this revision to Diff 107193. atanasyan added a comment. Addressed review comment: - Split MipsLongCall into a couple of attributes MipsLongCall and MipsShortCall. - Change the documentation wording. - Keep the attributes handling in the setTargetAttributes. - Show error in

[PATCH] D35583: Debug Info: Add a file: field to DIImportedEntity

probinson added a comment. Sweet. I don't have the chops to understand the Objective-C test but otherwise LGTM. Comment at: lib/Bitcode/Reader/MetadataLoader.cpp:1684 + HasFile ? getMDOrNull(Record[6]) : nullptr, + HasFile ?

r308390 - [Driver] Always use -z rodynamic for Fuchsia

Author: phosek Date: Tue Jul 18 16:23:16 2017 New Revision: 308390 URL: http://llvm.org/viewvc/llvm-project?rev=308390=rev Log: [Driver] Always use -z rodynamic for Fuchsia Fuchsia uses read-only .dynamic section. Differential Revision: https://reviews.llvm.org/D35582 Modified:

Re: [PATCH v3] [PPC64]: Add support for Swift calling convention

Another friendly ping :) Cheers, Andrew On Wed, 2017-07-05 at 11:23 +0930, Andrew Jeffery wrote: > Ping - is anyone able to provide feedback? > > Cheers, > > Andrew > > On Thu, 2017-06-22 at 16:02 +0930, Andrew Jeffery wrote: > > For the tests I've extracted the int5 and int8 cases to cater

[PATCH] D35038: [libunwind] Add a test harness

manojgupta added inline comments. Comment at: test/lit.cfg:36 +else: +lit_config.fatal('Could not find libcxx test directory for test imports' + ' in: %s' % libcxx_test_src_root) I do not have libcxx checked out since I am want to use

[PATCH] D35582: [Driver] Always use -z rodynamic for Fuchsia

phosek updated this revision to Diff 107185. phosek marked an inline comment as done. Repository: rL LLVM https://reviews.llvm.org/D35582 Files: lib/Driver/ToolChains/Fuchsia.cpp test/Driver/fuchsia.c test/Driver/fuchsia.cpp Index: test/Driver/fuchsia.cpp

[PATCH] D35582: [Driver] Always use -z rodynamic for Fuchsia

This revision was automatically updated to reflect the committed changes. Closed by commit rL308390: [Driver] Always use -z rodynamic for Fuchsia (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D35582?vs=107185=107200#toc Repository: rL LLVM

r308401 - [scan-build-py] Patch to fix "-analyzer-config" option

Author: phosek Date: Tue Jul 18 17:29:41 2017 New Revision: 308401 URL: http://llvm.org/viewvc/llvm-project?rev=308401=rev Log: [scan-build-py] Patch to fix "-analyzer-config" option I noticed that when I use "-analyze-config" option in scan-build-py, it behaves differently from original perl

[PATCH] D35338: Add the -fdestroy-globals flag

itessier added a comment. In https://reviews.llvm.org/D35338#809146, @vsk wrote: > This is interesting. Do you have any results/metrics to share (e.g some any > binary size reduction for projects you've looked at)? I only tested this with Project Loon's avionics firmware which freed up ~1.2%

[PATCH] D35572: Add isValidCPUName and isValidFeature to TargetInfo

erichkeane updated this revision to Diff 107183. erichkeane added a comment. Fixed a rebase issue, didn't do anything in CGBuiltin yet. https://reviews.llvm.org/D35572 Files: include/clang/Basic/TargetInfo.h lib/Basic/Targets.cpp Index: lib/Basic/Targets.cpp

[PATCH] D35038: [libunwind] Add a test harness

jroelofs added inline comments. Comment at: test/lit.cfg:36 +else: +lit_config.fatal('Could not find libcxx test directory for test imports' + ' in: %s' % libcxx_test_src_root) manojgupta wrote: > I do not have libcxx checked out since I

[PATCH] D35038: [libunwind] Add a test harness

jroelofs added inline comments. Comment at: test/lit.cfg:36 +else: +lit_config.fatal('Could not find libcxx test directory for test imports' + ' in: %s' % libcxx_test_src_root) manojgupta wrote: > jroelofs wrote: > > manojgupta wrote: > >

r308399 - Update for LLVM IR metadata changes (DIImportedEntity now needs a DIFile).

Author: adrian Date: Tue Jul 18 17:09:58 2017 New Revision: 308399 URL: http://llvm.org/viewvc/llvm-project?rev=308399=rev Log: Update for LLVM IR metadata changes (DIImportedEntity now needs a DIFile). https://bugs.llvm.org/show_bug.cgi?id=33822 Differential Revision:

[PATCH] D34489: [scan-build-py] Patch to fix "-analyzer-config" option

This revision was automatically updated to reflect the committed changes. Closed by commit rL308401: [scan-build-py] Patch to fix "-analyzer-config" option (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D34489?vs=103490=107214#toc Repository: rL LLVM

[PATCH] D35582: [Driver] Always use -z rodynamic for Fuchsia

mcgrathr requested changes to this revision. mcgrathr added a comment. This revision now requires changes to proceed. Looks almost right. Might be overkill to add a test case that -z rodynamic is omitted with -fuse-ld=gold or something. Comment at:

[PATCH] D35582: [Driver] Always use -z rodynamic for Fuchsia

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D35582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35450: [analyzer] Support generating and reasoning over more symbolic constraint types

ddcc updated this revision to Diff 107190. ddcc added a comment. Minor style fix https://reviews.llvm.org/D35450 Files: include/clang/AST/Expr.h include/clang/Config/config.h.cmake include/clang/StaticAnalyzer/Checkers/SValExplainer.h

[PATCH] D35577: Add -flookup-tables and -fno-lookup-tables flags

joerg added inline comments. Comment at: test/CodeGen/nouselookuptable.c:1 +// RUN: %clang_cc1 -S -fno-lookup-tables %s -emit-llvm -o - | FileCheck %s + Check positive flag and the default case as well. Comment at:

[PATCH] D35038: [libunwind] Add a test harness

EricWF added a comment. > Checking out libcxx should not be a requirement since libunwind should be > usable independently on libcxx. Nope, Sorry. As jroelofs said the code duplication is not worth it. Unfortunately you'll need the libc++ sources, and I also don't think that's a bug.

[PATCH] D35583: Debug Info: Add a file: field to DIImportedEntity

This revision was automatically updated to reflect the committed changes. Closed by commit rL308398: Debug Info: Add a file: field to DIImportedEntity. (authored by adrian). Changed prior to commit: https://reviews.llvm.org/D35583?vs=107180=107211#toc Repository: rL LLVM

[PATCH] D35479: [CodeGen][mips] Support `long_call/far/near` attributes

rjmccall added a comment. One minor revision, but otherwise looks great, thank you. Comment at: lib/CodeGen/CodeGenModule.cpp:1166 +if (!IsForDefinition) + getTargetCodeGenInfo().setTargetAttributes(FD, F, *this); + } I think you should probably pass

r308397 - Debug Info: Set the MainFileName when generating -gmodules debug info for PCM.

Author: adrian Date: Tue Jul 18 16:58:34 2017 New Revision: 308397 URL: http://llvm.org/viewvc/llvm-project?rev=308397=rev Log: Debug Info: Set the MainFileName when generating -gmodules debug info for PCM. Previously it was uninitialized and thus always defaulted to "". This is mostly a

[PATCH] D35603: [Driver] Consider -fno-sanitize=... state when filtering out -fsanitize-coverage=...

mcgrathr created this revision. The driver ignores -fsanitize-coverage=... flags when also given -fsanitize=... flags for sanitizer flavors that don't support the coverage runtime. This logic failed to account for subsequent -fno-sanitize=... flags that disable the sanitizer flavors that

[PATCH] D35216: [analyzer] Escape symbols when creating std::initializer_list.

dcoughlin added a comment. In this case, I would be fine with some sort of AbstractStorageMemoryRegion that meant "here is a memory region and somewhere reachable from here exists another region of type T". Or even multiple regions with different identifiers. This wouldn't specify how the

[PATCH] D33561: [CMake] Add Android toolchain CMake cache files.

pirama added inline comments. Comment at: cmake/caches/Android-stage2.cmake:27 + set(RUNTIMES_${target}-linux-android_CMAKE_ASM_FLAGS ${ANDROID_${target}_C_FLAGS} CACHE PATH "") + set(RUNTIMES_${target}-linux-android_CMAKE_BUILD_TYPE RELEASE CACHE STRING "") +

[PATCH] D35338: Add the -fdestroy-globals flag

george.burgess.iv added a comment. Thanks for working on this! One small drive-by nit for you. Same "no need to update the diff this very second" as vsk; I can't LGTM this with confidence. (Also, in the future, please try to include context

[PATCH] D32817: [CMake] Build runtimes for Fuchsia targets

This revision was automatically updated to reflect the committed changes. Closed by commit rL308412: [CMake] Build runtimes for Fuchsia targets (authored by phosek). Changed prior to commit: https://reviews.llvm.org/D32817?vs=107236=107240#toc Repository: rL LLVM

[PATCH] D34937: Suppressing Reference Counting Diagnostics for Functions Containing 'rc_ownership_trusted_implementation' Annotate Attribute

dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. LGTM! One thing I should have noted in a prior review is that the helper functions should be declared 'static' so that we don't have a public symbol for them. Making them static will

[PATCH] D35538: [CodeGen][ARM] ARM runtime helper functions are not always soft-fp

compnerd requested changes to this revision. compnerd added a comment. This revision now requires changes to proceed. Can you please add a test that shows that the AEABI functions are not given the wrong CC? Also, can you show that if someone also passes `-meabi=gnu` with a VFP target, that we

r308412 - [CMake] Build runtimes for Fuchsia targets

Author: phosek Date: Tue Jul 18 19:57:47 2017 New Revision: 308412 URL: http://llvm.org/viewvc/llvm-project?rev=308412=rev Log: [CMake] Build runtimes for Fuchsia targets This relies on the multi-target runtimes build support. Differential Revision: https://reviews.llvm.org/D32817 Modified:

[PATCH] D32817: [CMake] Build runtimes for Fuchsia targets

phosek updated this revision to Diff 107236. Repository: rL LLVM https://reviews.llvm.org/D32817 Files: cmake/caches/Fuchsia-stage2.cmake cmake/caches/Fuchsia.cmake Index: cmake/caches/Fuchsia.cmake === ---

[PATCH] D35572: Add isValidCPUName and isValidFeature to TargetInfo

craig.topper added inline comments. Comment at: lib/Basic/Targets.cpp:2931 + + // Fallthrough +case CK_Nocona: Use LLVM_FALLTHROUGH? https://reviews.llvm.org/D35572 ___ cfe-commits mailing list

Re: r308044 - Add documentation for @available

> On Jul 18, 2017, at 8:07 AM, Nico Weber wrote: > > On Mon, Jul 17, 2017 at 8:39 AM, Aaron Ballman > wrote: > On Sun, Jul 16, 2017 at 7:49 PM, Nico Weber > wrote:

[PATCH] D34937: Suppressing Reference Counting Diagnostics for Functions Containing 'rc_ownership_trusted_implementation' Annotate Attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rL308416: [analyzer] Add annotation attribute to trust retain count implementation (authored by dcoughlin). Changed prior to commit: https://reviews.llvm.org/D34937?vs=107020=107243#toc Repository: rL

r308416 - [analyzer] Add annotation attribute to trust retain count implementation

Author: dcoughlin Date: Tue Jul 18 21:10:44 2017 New Revision: 308416 URL: http://llvm.org/viewvc/llvm-project?rev=308416=rev Log: [analyzer] Add annotation attribute to trust retain count implementation Add support to the retain-count checker for an annotation indicating that a function's

[PATCH] D34937: Suppressing Reference Counting Diagnostics for Functions Containing 'rc_ownership_trusted_implementation' Annotate Attribute

dcoughlin added a comment. Committed in r308416. Repository: rL LLVM https://reviews.llvm.org/D34937 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35479: [CodeGen][mips] Support `long_call/far/near` attributes

atanasyan updated this revision to Diff 107246. atanasyan added a comment. - Pass `IsForDefinition` argument to the `setTargetAttributes` method. Repository: rL LLVM https://reviews.llvm.org/D35479 Files: include/clang/Basic/Attr.td include/clang/Basic/AttrDocs.td

<    1   2