[PATCH] D35961: [llvm] Update MachOObjectFile::exports interface

compnerd added a comment. Does anyone use the overload with the `O` for `exports` with `nullptr` instead of `this`? If not, we could just inline `this` throughout. Comment at: tools/llvm-nm/llvm-nm.cpp:1230 Error Err = Error::success(); - for (const

[PATCH] D35972: Add warning to clang-reorder-fields when reordering breaks member init list dependencies

alexshap added inline comments. Comment at: test/clang-reorder-fields/FieldDependencyWarning.cpp:3 + +#include + tests should not depend on STL (for good examples see how things are done in clang-tidy tests), so simply remove this include and define a small

[PATCH] D35972: Add warning to clang-reorder-fields when reordering breaks member init list dependencies

compnerd added inline comments. Comment at: clang-reorder-fields/ReorderFieldsAction.cpp:111 +Results.insert(FD); + return Results; +} What if the `FieldDecl` belongs to a base class? Can you add a test case for that scenario? Repository: rL LLVM

[libclc] r309358 - add __kernel_exec macros

Author: jvesely Date: Thu Jul 27 20:39:03 2017 New Revision: 309358 URL: http://llvm.org/viewvc/llvm-project?rev=309358=rev Log: add __kernel_exec macros also consolidate macros into one file, and rename to clcmacros.h Signed-off-by: Jan Vesely Reviewed-by: Aaron Watry

[PATCH] D35972: Add warning to clang-reorder-fields when reordering breaks member init list dependencies

sameconrad created this revision. sameconrad added a project: clang-tools-extra. This adds a warning emitted by clang-reorder-fields when the reordering fields breaks dependencies in the initializer list (such that -Wuninitialized would warn when compiling). For example, given: Foo::Foo(int x)

r309352 - Update comment in test case after r309308.

Author: ahatanak Date: Thu Jul 27 18:58:14 2017 New Revision: 309352 URL: http://llvm.org/viewvc/llvm-project?rev=309352=rev Log: Update comment in test case after r309308. Modified: cfe/trunk/test/CodeGenCXX/eh.cpp Modified: cfe/trunk/test/CodeGenCXX/eh.cpp URL:

[libcxxabi] r309349 - [demangler] Fix some overzealous -Wreturn-type errors

Author: epilk Date: Thu Jul 27 18:35:14 2017 New Revision: 309349 URL: http://llvm.org/viewvc/llvm-project?rev=309349=rev Log: [demangler] Fix some overzealous -Wreturn-type errors Modified: libcxxabi/trunk/src/cxa_demangle.cpp Modified: libcxxabi/trunk/src/cxa_demangle.cpp URL:

[PATCH] D35941: Fix -Wshadow false positives with function-local classes.

alexfh added a comment. In https://reviews.llvm.org/D35941#823020, @rnk wrote: > I'm not really sure this is a bug. The point of -Wshadow is to warn on valid > but possibly confusing code. Shadowing a variable is perfectly legal, but > people think it's confusing, so we implemented this

[PATCH] D35056: GCC ABI incompatibility when passing object with trivial copy ctor, trivial dtor, and non-trivial move ctor

rjmccall added inline comments. Comment at: lib/CodeGen/CGCXXABI.cpp:43 if (RD->hasNonTrivialDestructor()) return false; Does canPassInRegisters() not subsume all of these earlier checks? https://reviews.llvm.org/D35056

[libcxxabi] r309342 - [demangler] Attempt to fix linux bots, include

Author: epilk Date: Thu Jul 27 17:53:30 2017 New Revision: 309342 URL: http://llvm.org/viewvc/llvm-project?rev=309342=rev Log: [demangler] Attempt to fix linux bots, include Modified: libcxxabi/trunk/src/cxa_demangle.cpp Modified: libcxxabi/trunk/src/cxa_demangle.cpp URL:

[PATCH] D34114: [clang] Change the condition of unnecessary packed warning

yawanng updated this revision to Diff 108555. yawanng marked an inline comment as done. yawanng edited the summary of this revision. yawanng added a comment. Add more tests and restrict the conditions. https://reviews.llvm.org/D34114 Files: lib/AST/RecordLayoutBuilder.cpp

[PATCH] D35056: GCC ABI incompatibility when passing object with trivial copy ctor, trivial dtor, and non-trivial move ctor

v.g.vassilev updated this revision to Diff 108556. v.g.vassilev added a comment. Move back the triviality checks in CGCXXABI. Explain why. https://reviews.llvm.org/D35056 Files: include/clang/AST/DeclCXX.h lib/AST/ASTImporter.cpp lib/AST/DeclCXX.cpp lib/CodeGen/CGCXXABI.cpp

[PATCH] D34724: [analyzer] Add MagentaHandleChecker for the Magenta kernel

haowei abandoned this revision. haowei added a comment. Superseded by https://reviews.llvm.org/D35968 https://reviews.llvm.org/D34724 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r309338 - [sanitizer-coverage] clang flags pumbing for -fsanitize-coverage=pc-table

Author: kcc Date: Thu Jul 27 17:10:10 2017 New Revision: 309338 URL: http://llvm.org/viewvc/llvm-project?rev=309338=rev Log: [sanitizer-coverage] clang flags pumbing for -fsanitize-coverage=pc-table Modified: cfe/trunk/include/clang/Driver/CC1Options.td

[PATCH] D35968: [analyzer] Add MagentaHandleChecker for the Magenta kernel

haowei created this revision. Herald added subscribers: xazax.hun, mgorny. This patch supersedes https://reviews.llvm.org/D34724. We have finished the checker but it is too big to be submitted as a single commit. So we split it into several pieces to help with the review process. This patch

[PATCH] D35961: [llvm] Update MachOObjectFile::exports interface

alexshap created this revision. This diff removes the second argument of the method MachOObjectFile::exports which was recently introduced in r308690. In all in-tree uses this argument is equal to "this", additionally without this argument the interface seems to be cleaner. Test plan: make

[PATCH] D34158: For standards compatibility, preinclude if the file is available

fedor.sergeev added a comment. Hmm... I tried this patch and now the following worries me: - it passes -finclude-if-exists stdc-predef.h on all platforms (say, including my Solaris platform that has no system stdc-predef.h) - it searches all the paths, not just "system include" ones That

[PATCH] D35056: GCC ABI incompatibility when passing object with trivial copy ctor, trivial dtor, and non-trivial move ctor

v.g.vassilev updated this revision to Diff 108535. v.g.vassilev added a comment. Put back accidentally removed test case. https://reviews.llvm.org/D35056 Files: include/clang/AST/DeclCXX.h lib/AST/ASTImporter.cpp lib/AST/DeclCXX.cpp lib/CodeGen/CGCXXABI.cpp

[PATCH] D35959: Summary: For powerpc64, disable tests that assume long double is 80-bits.

saugustine created this revision. Herald added a subscriber: nemanjai. https://reviews.llvm.org/D35959 Files: compiler-rt/test/builtins/Unit/fixunsxfti_test.c compiler-rt/test/builtins/Unit/fixxfti_test.c compiler-rt/test/builtins/Unit/floattixf_test.c

[PATCH] D35056: GCC ABI incompatibility when passing object with trivial copy ctor, trivial dtor, and non-trivial move ctor

v.g.vassilev added inline comments. Comment at: lib/Sema/SemaDecl.cpp:14841-14852 + // If a move constructor or move assignment operator was declared, the + // default copy constructors are implicitly deleted, except in one case + // related to compatibility with MSVC

[PATCH] D35056: GCC ABI incompatibility when passing object with trivial copy ctor, trivial dtor, and non-trivial move ctor

v.g.vassilev updated this revision to Diff 108533. v.g.vassilev marked 6 inline comments as done. v.g.vassilev added a comment. Address some of the comments. https://reviews.llvm.org/D35056 Files: include/clang/AST/DeclCXX.h lib/AST/ASTImporter.cpp lib/AST/DeclCXX.cpp

Re: r309327 - Headers: fix _Unwind_{G,S}etGR for non-EHABI targets

Merged to 5.0 in r309328. On Thu, Jul 27, 2017 at 2:56 PM, Saleem Abdulrasool via cfe-commits wrote: > Author: compnerd > Date: Thu Jul 27 14:56:25 2017 > New Revision: 309327 > > URL: http://llvm.org/viewvc/llvm-project?rev=309327=rev > Log: > Headers: fix

Buildmaster restart

Hello everyone, LLVM buildmaster will be updated and restarted approximately at 08:00 AM PDT 28th July. -- Best Regards, Victor Leschuk | Software Engineer |Access Softek ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r309327 - Headers: fix _Unwind_{G,S}etGR for non-EHABI targets

Author: compnerd Date: Thu Jul 27 14:56:25 2017 New Revision: 309327 URL: http://llvm.org/viewvc/llvm-project?rev=309327=rev Log: Headers: fix _Unwind_{G,S}etGR for non-EHABI targets The EHABI definition was being inlined into the users even when EHABI was not in use. Adjust the condition to

[PATCH] D34114: [clang] Change the condition of unnecessary packed warning

chh added inline comments. Comment at: lib/AST/RecordLayoutBuilder.cpp:1887 +// greater than the one after packing. +if (Packed && UnpackedAlignment <= Alignment) Diag(D->getLocation(), diag::warn_unnecessary_packed) With this change, UnpackedSize

[PATCH] D35159: [libcxxabi][demangler] Use an AST to represent the demangled name

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. In https://reviews.llvm.org/D35159#823211, @erik.pilkington wrote: > Use LLVM naming conventions for all the new stuff in this patch. Thanks for renaming everything. LGTM!

[libcxx] r309322 - [libcxx] [test] Remove an unused local typedef in enable_shared_from_this.pass.cpp.

Author: stl_msft Date: Thu Jul 27 14:16:37 2017 New Revision: 309322 URL: http://llvm.org/viewvc/llvm-project?rev=309322=rev Log: [libcxx] [test] Remove an unused local typedef in enable_shared_from_this.pass.cpp. Trivial change, committed without review. Modified:

[PATCH] D34158: For standards compatibility, preinclude if the file is available

mibintc updated this revision to Diff 108519. mibintc added a comment. Here is an updated diff which is rebased to current trunk per @fedor.sergeev 's suggestion (thank you). make check-all and check-clang are working for me on Linux with no unexpected failures. The associated patch for test

[PATCH] D35955: clang-format: Add preprocessor directive indentation

euhlmann created this revision. euhlmann added a project: clang. This is an implementation for bug 17362 which adds support for indenting preprocessor statements inside if/ifdef/endif. This takes previous work from fmauch and makes it into a

[PATCH] D35934: [Headers] Add a test for arm64intr.h

This revision was automatically updated to reflect the committed changes. Closed by commit rL309314: [Headers] Add a test for arm64intr.h (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D35934?vs=108438=108515#toc Repository: rL LLVM

r309314 - [Headers] Add a test for arm64intr.h

Author: mstorsjo Date: Thu Jul 27 12:45:13 2017 New Revision: 309314 URL: http://llvm.org/viewvc/llvm-project?rev=309314=rev Log: [Headers] Add a test for arm64intr.h This tests the ARM64 specific constants added in SVN r309081, similar to the one added in r277928 for armintr.h. Differential

[PATCH] D35577: Add -flookup-tables and -fno-lookup-tables flags

sgundapa added a comment. The only change that is needed is to disable lookup-tables based on the attribute "no-jump-tables" set by "-fno-jump-tables" clang flag. It implies that this change is not required. https://reviews.llvm.org/D35577 ___

[PATCH] D35578: Add -fswitch-tables and -fno-switch-tables flags

sgundapa abandoned this revision. sgundapa added a comment. Refer to https://reviews.llvm.org/D35577 as we decided to disable lookup tables under -fno-jump-tables https://reviews.llvm.org/D35578 ___ cfe-commits mailing list

[PATCH] D34114: [clang] Change the condition of unnecessary packed warning

yawanng updated this revision to Diff 108513. yawanng marked 2 inline comments as done. yawanng edited the summary of this revision. https://reviews.llvm.org/D34114 Files: lib/AST/RecordLayoutBuilder.cpp test/CodeGenCXX/warn-padded-packed.cpp Index: test/CodeGenCXX/warn-padded-packed.cpp

r309309 - [OPENMP] Allow all lvalues in 'depend' clause.

Author: abataev Date: Thu Jul 27 12:15:30 2017 New Revision: 309309 URL: http://llvm.org/viewvc/llvm-project?rev=309309=rev Log: [OPENMP] Allow all lvalues in 'depend' clause. According to upcoming OpenMP 5.0 all addressable lvalue expressions are allowed in deoend clause. Modified:

[PATCH] D34114: [clang] Change the condition of unnecessary packed warning

srhines added a comment. This looks better. It did lose context however, so some of the review is harder to read. Comment at: test/CodeGenCXX/warn-padded-packed.cpp:84 + +struct S16 { // expected-warning {{padding size of 'S16' with 2 bytes to alignment boundar}}

r309308 - Revert r264998 and r265035.

Author: ahatanak Date: Thu Jul 27 11:52:44 2017 New Revision: 309308 URL: http://llvm.org/viewvc/llvm-project?rev=309308=rev Log: Revert r264998 and r265035. r303175 made changes to have __cxa_allocate_exception return a 16-byte aligned pointer, so it's no longer necessary to specify a lower

[PATCH] D33561: [CMake] Add Android toolchain CMake cache files.

srhines accepted this revision. srhines added a comment. This revision is now accepted and ready to land. Awesome! https://reviews.llvm.org/D33561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libcxx] r309307 - Disable the deduction guide test I added in 309296 for the moment, while I figure out which compilers don't support deduction guides

Author: marshall Date: Thu Jul 27 11:47:35 2017 New Revision: 309307 URL: http://llvm.org/viewvc/llvm-project?rev=309307=rev Log: Disable the deduction guide test I added in 309296 for the moment, while I figure out which compilers don't support deduction guides Modified:

[PATCH] D35056: GCC ABI incompatibility when passing object with trivial copy ctor, trivial dtor, and non-trivial move ctor

rsmith added inline comments. Comment at: lib/CodeGen/CGCXXABI.cpp:33-47 + // See also Sema::ShouldDeleteSpecialMember. These two functions + // should be kept consistent. + // If RD has a non-trivial move or copy constructor, we cannot copy the // argument. if

[PATCH] D35056: GCC ABI incompatibility when passing object with trivial copy ctor, trivial dtor, and non-trivial move ctor

v.g.vassilev updated this revision to Diff 108505. v.g.vassilev added a comment. Move the checks in Sema. https://reviews.llvm.org/D35056 Files: include/clang/AST/DeclCXX.h lib/AST/ASTImporter.cpp lib/AST/DeclCXX.cpp lib/CodeGen/CGCXXABI.cpp lib/CodeGen/ItaniumCXXABI.cpp

[PATCH] D34030: Fix the postorder visting of the ClassTemplateSpecializationDecl nodes in the RecursiveASTVisitor.

MontyKutyi added a comment. Is there any particular parameter for the clang-format what I should use? If I just run it without any parameter it changes lines of the original test too. https://reviews.llvm.org/D34030 ___ cfe-commits mailing list

[PATCH] D35930: [CMake] Include sancov tool in Fuchsia toolchain

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. LGTM Repository: rL LLVM https://reviews.llvm.org/D35930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35934: [Headers] Add a test for arm64intr.h

mgrang accepted this revision. mgrang added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D35934 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: r309189 - Clang and LLVM search for different versions of libxml2, reset found

Looks like this was resolved. I noticed that we have a window of commits with extra git-svn-rev notes: commit 820faedb92322a3a550bd994b652f2e3d0c77b13 Author: Eric Beckmann Date: Wed Jul 26 21:47:17 2017 + Clang and LLVM search for different versions of libxml2,

[PATCH] D35941: Fix -Wshadow false positives with function-local classes.

rnk added a comment. I'm not really sure this is a bug. The point of -Wshadow is to warn on valid but possibly confusing code. Shadowing a variable is perfectly legal, but people think it's confusing, so we implemented this warning. Are we concerned that people might get confused between the

[PATCH] D35577: Add -flookup-tables and -fno-lookup-tables flags

sgundapa added a comment. Thanks. I will make change to this affect https://reviews.llvm.org/D35577 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35950: [clangd] Don't reverse priorities of completion items.

This revision was automatically updated to reflect the committed changes. Closed by commit rL309295: [clangd] Don't reverse priorities of completion items. (authored by ibiryukov). Repository: rL LLVM https://reviews.llvm.org/D35950 Files: clang-tools-extra/trunk/clangd/ClangdUnit.cpp

[libcxx] r309296 - Implement P0739R0: 'Some improvements to class template argument deduction integration into the standard library' This is an API change (not ABI change) due to a late change in the

Author: marshall Date: Thu Jul 27 10:44:03 2017 New Revision: 309296 URL: http://llvm.org/viewvc/llvm-project?rev=309296=rev Log: Implement P0739R0: 'Some improvements to class template argument deduction integration into the standard library' This is an API change (not ABI change) due to a

[clang-tools-extra] r309295 - [clangd] Don't reverse priorities of completion items.

Author: ibiryukov Date: Thu Jul 27 10:43:07 2017 New Revision: 309295 URL: http://llvm.org/viewvc/llvm-project?rev=309295=rev Log: [clangd] Don't reverse priorities of completion items. Summary: Current algorithm incorrectly provides completion results in a reverse order. Reviewers: krasimir,

[PATCH] D34158: For standards compatibility, preinclude if the file is available

mibintc planned changes to this revision. mibintc added a comment. I'm going to rebase the patch to latest. Repository: rL LLVM https://reviews.llvm.org/D34158 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34030: Fix the postorder visting of the ClassTemplateSpecializationDecl nodes in the RecursiveASTVisitor.

bruno added a comment. In https://reviews.llvm.org/D34030#821282, @MontyKutyi wrote: > Added test for the fix. Great! The test code you added doesn't seem to be compatible with clang style, can you run clang format and update the test? https://reviews.llvm.org/D34030

Re: r309226 - Headers: improve ARM EHABI coverage of unwind.h

Merged to 5.0 in r309290. On Wed, Jul 26, 2017 at 3:55 PM, Saleem Abdulrasool via cfe-commits wrote: > Author: compnerd > Date: Wed Jul 26 15:55:23 2017 > New Revision: 309226 > > URL: http://llvm.org/viewvc/llvm-project?rev=309226=rev > Log: > Headers: improve ARM

[PATCH] D35577: Add -flookup-tables and -fno-lookup-tables flags

hans added a comment. In https://reviews.llvm.org/D35577#818956, @mcrosier wrote: > In https://reviews.llvm.org/D35577#818936, @kparzysz wrote: > > > In https://reviews.llvm.org/D35577#817944, @echristo wrote: > > > > > "Should this just be part of the tuning for the hexagon backend and not > >

r309289 - Update to use enum classes for various ARM *Kind enums

Author: fhahn Date: Thu Jul 27 09:28:39 2017 New Revision: 309289 URL: http://llvm.org/viewvc/llvm-project?rev=309289=rev Log: Update to use enum classes for various ARM *Kind enums Summary: This updates the relevant Clang parts for the LLVM change D35882. Reviewers: rengolin, chandlerc,

[PATCH] D35854: Fix double destruction of objects when OpenMP construct is canceled

This revision was automatically updated to reflect the committed changes. Closed by commit rL309288: Fix double destruction of objects when OpenMP construct is canceled (authored by erichkeane). Changed prior to commit: https://reviews.llvm.org/D35854?vs=108153=108489#toc Repository: rL

r309288 - Fix double destruction of objects when OpenMP construct is canceled

Author: erichkeane Date: Thu Jul 27 09:28:20 2017 New Revision: 309288 URL: http://llvm.org/viewvc/llvm-project?rev=309288=rev Log: Fix double destruction of objects when OpenMP construct is canceled When an omp for loop is canceled the constructed objects are being destructed twice. It looks

[PATCH] D33900: Print registered targets in clang's version information

hans added a comment. In https://reviews.llvm.org/D33900#822313, @mehdi_amini wrote: > In https://reviews.llvm.org/D33900#820281, @hans wrote: > > > In https://reviews.llvm.org/D33900#818968, @mehdi_amini wrote: > > > > > I think @thakis is right: this too verbose to be the default --version. >

[PATCH] D33945: [OpenCL] Add support for missing sub_group functions.

Anastasia accepted this revision. Anastasia added a comment. LGTM! Thanks! https://reviews.llvm.org/D33945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35884: Update to use enum classes for various ARM *Kind enums

fhahn added inline comments. Comment at: lib/Basic/Targets/AArch64.cpp:94 llvm::AArch64::parseCPUArch(Name) != - static_cast(llvm::AArch64::ArchKind::AK_INVALID); + llvm::AArch64::ArchKind::INVALID; } rovka wrote: > My eyes might

[PATCH] D35884: Update to use enum classes for various ARM *Kind enums

fhahn updated this revision to Diff 108479. fhahn marked an inline comment as done. fhahn added a comment. Addressed reviewer comments https://reviews.llvm.org/D35884 Files: lib/Basic/Targets/AArch64.cpp lib/Basic/Targets/ARM.cpp lib/Basic/Targets/ARM.h lib/Driver/ToolChain.cpp

[PATCH] D35746: Make new PM honor -fdebug-info-for-profiling (clang side)

danielcdh marked an inline comment as done. danielcdh added a comment. Thanks for the review! In https://reviews.llvm.org/D35746#822498, @chandlerc wrote: > LGTM with a tiny tweak below. > > Would be good to add a test that this flag is being honored, either in this > patch or in a follow-up.

r309282 - Make new PM honor -fdebug-info-for-profiling (clang side)

Author: dehao Date: Thu Jul 27 08:29:53 2017 New Revision: 309282 URL: http://llvm.org/viewvc/llvm-project?rev=309282=rev Log: Make new PM honor -fdebug-info-for-profiling (clang side) Summary: The new PM needs to invoke add-discriminator pass when building with -fdebug-info-for-profiling.

r309276 - [clang-diff] Rename, NFC

Author: krobelus Date: Thu Jul 27 08:04:44 2017 New Revision: 309276 URL: http://llvm.org/viewvc/llvm-project?rev=309276=rev Log: [clang-diff] Rename, NFC Modified: cfe/trunk/tools/clang-diff/ClangDiff.cpp Modified: cfe/trunk/tools/clang-diff/ClangDiff.cpp URL:

[PATCH] D35884: Update to use enum classes for various ARM *Kind enums

rovka accepted this revision. rovka added a comment. This revision is now accepted and ready to land. Looks entirely mechanical, I don't see any problem with it (just a couple of nits). Comment at: lib/Basic/Targets/AArch64.cpp:94 llvm::AArch64::parseCPUArch(Name)

[PATCH] D35932: [clang-tidy] Add integer division check

alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. Could you run the check over LLVM+Clang code and post a summary of results here? https://reviews.llvm.org/D35932 ___ cfe-commits

[PATCH] D35932: [clang-tidy] Add integer division check

alexfh added inline comments. Comment at: docs/clang-tidy/checks/bugprone-integer-division.rst:21-24 + // Do not warn, there are signs of deliberateness. + sin(abs(3) / 5); + sin(1 + abs(1 + 7 / 2)); + 1 << 2 / 3; I'd argue that the presence of `abs` here

[PATCH] D26350: Keep invalid Switch in the AST

aaron.ballman added a comment. This looks reasonable to me, but you should wait for @rsmith to sign off before committing. Comment at: lib/Sema/SemaStmt.cpp:669 if (Cond.isInvalid()) -return StmtError(); +Cond = ConditionResult( +*this, nullptr,

Re: r309106 - Recommit r308327 2nd time: Add a warning for missing

On Thu, Jul 27, 2017 at 3:41 AM, Alex L wrote: > > > On 26 July 2017 at 22:32, Hans Wennborg wrote: >> >> On Wed, Jul 26, 2017 at 11:27 AM, Hans Wennborg wrote: >> > On Wed, Jul 26, 2017 at 5:20 AM, Alex Lorenz via cfe-commits >> >

[PATCH] D35937: [clang-tidy] Add new readability non-idiomatic static access

aaron.ballman added inline comments. Comment at: clang-tidy/readability/StaticAccessedThroughInstanceCheck.cpp:23 + memberExpr(hasDeclaration(anyOf(cxxMethodDecl(isStaticStorageClass()), + varDecl(hasStaticStorageDuration(, +

[PATCH] D35937: [clang-tidy] Add new readability non-idiomatic static access

Eugene.Zelenko added a comment. It also seems that your code is not based on trunk, since Release Notes were cleared when version was changed to 6. Please update. Repository: rL LLVM https://reviews.llvm.org/D35937 ___ cfe-commits mailing list

[PATCH] D35937: [clang-tidy] Add new readability non-idiomatic static access

Eugene.Zelenko added inline comments. Comment at: docs/clang-tidy/checks/readability-static-accessed-through-instance.rst:7 +Checks for member expressions that access static members through instances, and +replaces them with the corresponding expressions that use a more

[PATCH] D33945: [OpenCL] Add support for missing sub_group functions.

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. Thanks! Overall the patch looks good, but I would suggest splitting it into three commits (as they seems to be independent): 1. [OpenCL] Check that cl_khr_subgroups pragma is enabled if

[PATCH] D35941: Fix -Wshadow false positives with function-local classes.

alexfh created this revision. Fixes http://llvm.org/PR33947. https://godbolt.org/g/54XRMT void f(int a) { struct A { void g(int a) {} A() { int a; } }; } 3 : :3:16: warning: declaration shadows a local variable [-Wshadow] void g(int a) {} ^ 1 : :1:12: note:

r309270 - [OPENMP] Codegen for 'in_reduction' clause.

Author: abataev Date: Thu Jul 27 06:20:36 2017 New Revision: 309270 URL: http://llvm.org/viewvc/llvm-project?rev=309270=rev Log: [OPENMP] Codegen for 'in_reduction' clause. Added codegen for task-based directive with in_reduction clause. ``` ``` The next code is emitted: ``` void *td; ... td =

[PATCH] D33945: [OpenCL] Add support for missing sub_group functions.

joey updated this revision to Diff 108452. joey added a comment. Updated all the comments you made and rebased. Sorry for the long delay. https://reviews.llvm.org/D33945 Files: CodeGen/CGBuiltin.cpp CodeGenOpenCL/cl20-device-side-enqueue.cl CodeGenOpenCL/pipe_builtin.cl

[PATCH] D34748: [clang-diff] improve mapping accuracy

arphaman added a comment. In general this patch is too big, and combines a lot of changes that could be separated using multiple patches. I've suggested one pre-commit and a new patch so far, but more changes might be required once I see the updated patch. Comment at:

[PATCH] D35937: [clang-tidy] Add new readability non-idiomatic static access

barancsuk created this revision. barancsuk added a project: clang-tools-extra. Herald added subscribers: baloghadamsoftware, xazax.hun, whisperity, JDevlieghere, mgorny. Checks for member expressions that access static members through instances, and replaces them with the corresponding

r309263 - [CodeGen][ARM] ARM runtime helper functions are not always soft-fp

Author: psmith Date: Thu Jul 27 03:43:53 2017 New Revision: 309263 URL: http://llvm.org/viewvc/llvm-project?rev=309263=rev Log: [CodeGen][ARM] ARM runtime helper functions are not always soft-fp Re-commit r309257 with less precise register checks in arm-float-helpers.c test. Added:

Re: r309106 - Recommit r308327 2nd time: Add a warning for missing

On 26 July 2017 at 22:32, Hans Wennborg wrote: > On Wed, Jul 26, 2017 at 11:27 AM, Hans Wennborg wrote: > > On Wed, Jul 26, 2017 at 5:20 AM, Alex Lorenz via cfe-commits > > wrote: > >> Author: arphaman > >> Date: Wed Jul 26

r309259 - [CodeGen][ARM] Revert r309257

Author: psmith Date: Thu Jul 27 02:57:13 2017 New Revision: 309259 URL: http://llvm.org/viewvc/llvm-project?rev=309259=rev Log: [CodeGen][ARM] Revert r309257 The test arm-float-helpers.c appears to be failing on some builders and needs some work to make it more robust. Removed:

[PATCH] D35746: Make new PM honor -fdebug-info-for-profiling (clang side)

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM with a tiny tweak below. Would be good to add a test that this flag is being honored, either in this patch or in a follow-up. Comment at:

[PATCH] D35746: Make new PM honor -fdebug-info-for-profiling (clang side)

chandlerc added a comment. (Also, sorry for the delay reviewing this, for some reason I thought this already got reviewed and landed...) https://reviews.llvm.org/D35746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D35538: [CodeGen][ARM] ARM runtime helper functions are not always soft-fp

This revision was automatically updated to reflect the committed changes. Closed by commit rL309257: [CodeGen][ARM] ARM runtime helper functions are not always soft-fp (authored by psmith). Changed prior to commit: https://reviews.llvm.org/D35538?vs=108245=108436#toc Repository: rL LLVM

r309257 - [CodeGen][ARM] ARM runtime helper functions are not always soft-fp

Author: psmith Date: Thu Jul 27 02:21:41 2017 New Revision: 309257 URL: http://llvm.org/viewvc/llvm-project?rev=309257=rev Log: [CodeGen][ARM] ARM runtime helper functions are not always soft-fp The ARM Runtime ABI document (IHI0043) defines the AEABI floating point helper functions in 4.1.2 The

[PATCH] D33820: [PowerPC] Pass CPU to assembler with -no-integrated-as

This revision was automatically updated to reflect the committed changes. Closed by commit rL309256: [PowerPC] Pass CPU to assembler with -no-integrated-as (authored by nemanjai). Changed prior to commit: https://reviews.llvm.org/D33820?vs=101508=108434#toc Repository: rL LLVM

r309256 - [PowerPC] Pass CPU to assembler with -no-integrated-as

Author: nemanjai Date: Thu Jul 27 01:58:28 2017 New Revision: 309256 URL: http://llvm.org/viewvc/llvm-project?rev=309256=rev Log: [PowerPC] Pass CPU to assembler with -no-integrated-as This just adds the CPU to a list of commands passed to GAS when not using the integrated assembler.

[PATCH] D35932: [clang-tidy] Add integer division check

rnkovacs created this revision. rnkovacs added a project: clang-tools-extra. Herald added subscribers: baloghadamsoftware, JDevlieghere, mgorny. Finds integer divisions in environments expecting floating-point values. Examples of possibly unintended precision loss: sin(7 / (2 + 3));

[PATCH] D35930: [CMake] Include sancov tool in Fuchsia toolchain

phosek created this revision. Herald added a subscriber: mgorny. Repository: rL LLVM https://reviews.llvm.org/D35930 Files: cmake/caches/Fuchsia-stage2.cmake Index: cmake/caches/Fuchsia-stage2.cmake === ---