[PATCH] D36487: Emit section information for extern variables.

efriedma added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:2434 +// Emit section information for extern variables. +if (D->hasExternalStorage() && !D->isThisDeclarationADefinition()) { + if (const SectionAttr *SA = D->getAttr()) Why

[PATCH] D36208: [mips] Enable `long_call/short_call` attributes on MIPS64

atanasyan added a comment. Thanks for review. Repository: rL LLVM https://reviews.llvm.org/D36208 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36171: AMDGPU: Use direct struct returns

arsenm added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:7386 + bool isHomogeneousAggregateBaseType(QualType Ty) const override; + bool isHomogeneousAggregateSmallEnough(const Type *Base, + uint64_t Members) const override;

[PATCH] D35955: clang-format: Add preprocessor directive indentation

euhlmann added a comment. In https://reviews.llvm.org/D35955#835439, @klimek wrote: > I think if we need this info, we can just make it count down to -1 again (or, > but that's isomorphic, let it run from 0 and make sure we never index into > the data structures at 0 :) Should I do one of

[PATCH] D36492: [RFC][time-report] Add preprocessor timer

modocache created this revision. `gcc -ftime-report` provides a breakdown of how much time GCC spends doing preprocessing, parsing, template instantiation, and more: g++ -ftime-report foo.cpp Execution times (seconds) phase setup : 0.00 ( 0%) usr 0.00 ( 0%) sys 0.00 (

[PATCH] D36431: Add powerpc64 to compiler-rt build infrastructure.

saugustine added a comment. In https://reviews.llvm.org/D36431#835165, @nemanjai wrote: > This patch appears to be perfectly fine. However, it triggers a large number > of warnings. Namely, there's a large number of `warning: ISO C forbids an > empty translation unit [-Wpedantic]` warnings

[PATCH] D36487: Emit section information for extern variables.

efriedma added a comment. Please propose a patch for LangRef clarifying what exactly it means to have a section attribute on a declaration. Comment at: test/CodeGenCXX/extern-section-attribute.cpp:1 +// RUN: %clang_cc1 -emit-llvm %s -o - -ffreestanding

r310418 - [mips] Enable `long_call/short_call` attributes on MIPS64

Author: atanasyan Date: Tue Aug 8 14:17:33 2017 New Revision: 310418 URL: http://llvm.org/viewvc/llvm-project?rev=310418=rev Log: [mips] Enable `long_call/short_call` attributes on MIPS64 This change enables `long_call/short_call/far/near` attributes on MIPS64 targets. Differential revision:

[PATCH] D36208: [mips] Enable `long_call/short_call` attributes on MIPS64

This revision was automatically updated to reflect the committed changes. Closed by commit rL310418: [mips] Enable `long_call/short_call` attributes on MIPS64 (authored by atanasyan). Changed prior to commit: https://reviews.llvm.org/D36208?vs=110252=110275#toc Repository: rL LLVM

[PATCH] D36450: [X86][Ms-InlineAsm] Extend MS Dot operator to accept "this" + struct/class pointers aliases

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: lib/Sema/SemaStmtAsm.cpp:702-705 + // MS InlineAsm often uses struct pointer aliases as a base + const QualType QT = TD->getUnderlyingType(); + RT

[PATCH] D36487: Emit section information for extern variables.

eandrews added inline comments. Comment at: lib/CodeGen/CodeGenModule.cpp:2434 +// Emit section information for extern variables. +if (D->hasExternalStorage() && !D->isThisDeclarationADefinition()) { + if (const SectionAttr *SA = D->getAttr())

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

jyknight added a comment. In https://reviews.llvm.org/D34158#827178, @joerg wrote: > I had a long discussion with James about this on IRC without reaching a clear > consensus. I consider forcing this behavior on all targets to be a major bug. > It should be opt-in and opt-in only: > > (1) The

[PATCH] D36491: clang-format: [JS] detect ASI after closing parens.

mprobst created this revision. Herald added a subscriber: klimek. A closing parenthesis followed by a declaration or statement should always terminate the current statement. https://reviews.llvm.org/D36491 Files: lib/Format/UnwrappedLineParser.cpp unittests/Format/FormatTestJS.cpp

[PATCH] D36171: AMDGPU: Use direct struct returns

b-sumner added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:7571 + + // XXX: Should this be i64 instead, and should the limit increase? + llvm::Type *I32Ty = llvm::Type::getInt32Ty(getVMContext()); arsenm wrote: > b-sumner wrote: > > What we

[PATCH] D36349: [CMake] Build sanitized C++ runtimes for Fuchsia

phosek updated this revision to Diff 110311. Repository: rL LLVM https://reviews.llvm.org/D36349 Files: cmake/caches/Fuchsia-stage2.cmake Index: cmake/caches/Fuchsia-stage2.cmake === --- cmake/caches/Fuchsia-stage2.cmake +++

[PATCH] D36427: [libcxxabi][demangler] Improve representation of substitutions/templates

erik.pilkington added inline comments. Comment at: src/cxa_demangle.cpp:1575-1577 -sub_type names; -template_param_type subs; -Vector template_param; dexonsmith wrote: > - Why not rename `names` as well? > - Please rename these in a separate prep

[PATCH] D36427: [libcxxabi][demangler] Improve representation of substitutions/templates

erik.pilkington updated this revision to Diff 110281. erik.pilkington marked 14 inline comments as done. erik.pilkington added a comment. Address review comments. Thanks! Erik https://reviews.llvm.org/D36427 Files: src/cxa_demangle.cpp test/unittest_demangle.pass.cpp Index:

r310423 - Lexer: always allow imaginary constants in GNU mode.

Author: tnorthover Date: Tue Aug 8 15:03:54 2017 New Revision: 310423 URL: http://llvm.org/viewvc/llvm-project?rev=310423=rev Log: Lexer: always allow imaginary constants in GNU mode. Added: cfe/trunk/test/Lexer/imaginary-constants.cpp Modified: cfe/trunk/lib/Lex/LiteralSupport.cpp

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

fedor.sergeev added a comment. In https://reviews.llvm.org/D34158#836026, @jyknight wrote: > In https://reviews.llvm.org/D34158#827178, @joerg wrote: > > > I had a long discussion with James about this on IRC without reaching a > > clear consensus. I consider forcing this behavior on all

r310426 - Revert "Lexer: always allow imaginary constants in GNU mode."

Author: tnorthover Date: Tue Aug 8 16:17:51 2017 New Revision: 310426 URL: http://llvm.org/viewvc/llvm-project?rev=310426=rev Log: Revert "Lexer: always allow imaginary constants in GNU mode." This reverts r310423. It was committed by mistake, I intended to commit the improved diagnostics for

r310427 - Sema: disable implicit conversion from _Complex to real types in C++.

Author: tnorthover Date: Tue Aug 8 16:18:05 2017 New Revision: 310427 URL: http://llvm.org/viewvc/llvm-project?rev=310427=rev Log: Sema: disable implicit conversion from _Complex to real types in C++. Converting a _Complex type to a real one simply discards the imaginary part. This can easily

[PATCH] D36171: AMDGPU: Use direct struct returns

arsenm added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:7571 + + // XXX: Should this be i64 instead, and should the limit increase? + llvm::Type *I32Ty = llvm::Type::getInt32Ty(getVMContext()); b-sumner wrote: > arsenm wrote: > > b-sumner

[PATCH] D36261: [clangd] Use multiple working threads in clangd.

klimek added a comment. High-level question: Why can't we use llvm::ThreadPool? https://reviews.llvm.org/D36261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36452: [clang-tidy] Fix another crash in make-unique check.

hokein created this revision. Herald added subscribers: xazax.hun, JDevlieghere. The crash happens when calling `reset` method without any preceding operation like "->" or ".", this could happen in a subclass of the "std::unique_ptr". https://reviews.llvm.org/D36452 Files:

[PATCH] D36398: [clangd] Check if CompileCommand has changed on forceReparse.

ilya-biryukov marked an inline comment as done. ilya-biryukov added a comment. In https://reviews.llvm.org/D36398#834904, @klimek wrote: > Also missing tests :) Done :-) Comment at: clangd/ClangdUnitStore.h:45-48 + struct RecreateResult { +std::shared_ptr

[PATCH] D36398: [clangd] Check if CompileCommand has changed on forceReparse.

ilya-biryukov updated this revision to Diff 110155. ilya-biryukov added a comment. Addressed review comments. - Added a test for forceReparse. - Got rid of a redundant `= nullptr` assignment. https://reviews.llvm.org/D36398 Files: clangd/ClangdServer.cpp clangd/ClangdServer.h

[PATCH] D36398: [clangd] Check if CompileCommand has changed on forceReparse.

klimek added a comment. Also missing tests :) Comment at: clangd/ClangdUnitStore.cpp:45 + .first; +Result.RemovedFile = nullptr; + } else if (!compileCommandsAreEqual(It->second->getCompileCommand(), ilya-biryukov wrote: > klimek wrote: > >

[PATCH] D30295: [analyzer] clarify undef shift result when shift count is negative or exceeds the bit width

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. It looks good to me but let's wait for Anna, NoQ, or Devin for the final word. Repository: rL LLVM https://reviews.llvm.org/D30295 ___

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

xazax.hun added inline comments. Comment at: lib/StaticAnalyzer/Checkers/CheckSecuritySyntaxOnly.cpp:622 +} +//===--===// +// Check: Use of 'sprintf', 'vsprintf', 'scanf', 'wscanf', 'fscanf', I

[PATCH] D35955: clang-format: Add preprocessor directive indentation

djasper added a comment. Manuel: Can you take a look at the last comment here? Why does PPBranchLevel start at -1? https://reviews.llvm.org/D35955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36159: clang-format: [JS] handle single lines comments ending in `\\`.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg Comment at: lib/Format/FormatTokenLexer.cpp:544-545 +while (BackslashPos != StringRef::npos) { + if (BackslashPos + 1 < FormatTok->TokenText.size() && +

[PATCH] D36453: [libclang] Fix PR34055 (incompatible update of clang-c/Index.h)

n.bozhenov created this revision. Fixes a regression introduced by r308218. https://reviews.llvm.org/D36453 Files: clang/include/clang-c/Index.h Index: clang/include/clang-c/Index.h === --- clang/include/clang-c/Index.h +++

[PATCH] D36453: [libclang] Fix PR34055 (incompatible update of clang-c/Index.h)

n.bozhenov added a comment. If the patch is accepted, it should also be merged into 5.0, I believe. https://reviews.llvm.org/D36453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36450: [X86][Ms-InlineAsm] Extend MS Dot operator to accept "this" + struct/class pointers aliases

coby created this revision. Herald added a subscriber: eraman. MS InlineAsm Dot operator accepts "Bases" such as "this" (cpp) and class/struct pointer typedef. This patch enhance its implementation with this behavior. Repository: rL LLVM https://reviews.llvm.org/D36450 Files:

[PATCH] D35068: [analyzer] Detect usages of unsafe I/O functions

xazax.hun added a comment. In https://reviews.llvm.org/D35068#811437, @NoQ wrote: > It'd look good in clang-tidy (especially if extended to provide fixits), but > if Daniel is interested in having this feature in the analyzer (and picked by > clang-tidy from there), i wouldn't mind. > > I

[PATCH] D36261: [clangd] Use multiple working threads in clangd.

ilya-biryukov added a comment. In https://reviews.llvm.org/D36261#834902, @klimek wrote: > High-level question: Why can't we use llvm::ThreadPool? It is not an in-place replacement as it does not allow to prioritize new tasks over old ones (new tasks are usually more important for clangd as

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

gtbercea added a comment. I have just pushed a fix, revision 310433. https://reviews.llvm.org/D29654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36423: [libc++] Introsort based sorting function

bcraig added a comment. Those are interesting (and useful) results... but they don't look like they came from the same algorithms.bench.cpp that I'm looking at... https://github.com/llvm-mirror/libcxx/blob/master/benchmarks/algorithms.bench.cpp That being said, the benchmark there only does 1k

[PATCH] D36491: clang-format: [JS] detect ASI after closing parens.

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D36491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

r310435 - Allow operator delete to be an invalid Decl.

Author: rtrieu Date: Tue Aug 8 19:03:59 2017 New Revision: 310435 URL: http://llvm.org/viewvc/llvm-project?rev=310435=rev Log: Allow operator delete to be an invalid Decl. Do not discard invalid Decl when searching for the operator delete function. The lookup for this function always expects to

r310436 - [AST] Move visibility computations into a class; NFC

Author: gbiv Date: Tue Aug 8 21:02:49 2017 New Revision: 310436 URL: http://llvm.org/viewvc/llvm-project?rev=310436=rev Log: [AST] Move visibility computations into a class; NFC This is patch 1 in a 2 patch series that aims to fix PR29160. Its goal is to cache decl visibility/linkage for the

[PATCH] D36503: [libcxx] [test] Update for C++17 feature removals.

STL_MSFT created this revision. [libcxx] [test] Update for C++17 feature removals. test/std/containers/Emplaceable.h test/std/containers/NotConstructible.h test/support/counting_predicates.hpp Replace unary_function/binary_function inheritance with typedefs.

r310441 - [clang-fuzzer] Resolve proto dependencies

Author: vitalybuka Date: Tue Aug 8 21:45:00 2017 New Revision: 310441 URL: http://llvm.org/viewvc/llvm-project?rev=310441=rev Log: [clang-fuzzer] Resolve proto dependencies Modified: cfe/trunk/tools/clang-fuzzer/proto-to-cxx/CMakeLists.txt Modified:

[PATCH] D36324: Integrate Kostya's clang-proto-fuzzer with LLVM.

vitalybuka added inline comments. Comment at: clang/cmake/modules/ProtobufMutator.cmake:6 + +ExternalProject_Add(${PBM_PREFIX} + PREFIX ${PBM_PREFIX} Just noticed, for cmake projects shorter syntax can be used. Example:

[PATCH] D36501: add flag to undo ABI change in r310401

rsmith created this revision. Herald added a subscriber: sanjoy. This patch adds a flag `-fpass-indirect-ignore-move` that can be used to undo the ABI change in r310401, reverting Clang to its prior C++ ABI for pass/return by value of class types affected by that change. This flag is enabled

[PATCH] D36441: Add Support for Reference Counting of Parameters on the Callee Side in RetainCountChecker

dcoughlin added a comment. Nice work! This looks good, with some nits and testing comments inline. Have you run this on real code? What kind of false positives do you see? Comment at: lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp:1853 + +void

r310437 - [AST] Cache intermediate visibility/linkage results

Author: gbiv Date: Tue Aug 8 21:12:17 2017 New Revision: 310437 URL: http://llvm.org/viewvc/llvm-project?rev=310437=rev Log: [AST] Cache intermediate visibility/linkage results This is a follow-up to r310436 with actual functional changes. Please see that commit message for a description of why

[PATCH] D36501: add flag to undo ABI change in r310401

rjmccall added a comment. Yeah, I think having an internal C++ ABI version makes a lot more sense than having a million different flags. Is there a reason to expose this as a knob to users at all? Repository: rL LLVM https://reviews.llvm.org/D36501

[PATCH] D36423: [libc++] Introsort based sorting function

bcraig added a comment. I like this change in general. Dinkumware has been using introsort for 10+ years, so I'm a bit surprised that libc++ wasn't already. Comment at: include/algorithm:4208 + + // Threshold(or depth limit) for introsort is taken to be 2*log2(size) +

r310444 - Attempt to appease msc buildbot

Author: gbiv Date: Tue Aug 8 22:20:05 2017 New Revision: 310444 URL: http://llvm.org/viewvc/llvm-project?rev=310444=rev Log: Attempt to appease msc buildbot It was timing out on this test, but for reasons unrelated to the specific bug it was testing for. Randomly breaking in gdb with `clang

[PATCH] D35355: Fix templated type alias completion when using global completion cache

yvvan added a comment. Ping... https://reviews.llvm.org/D35355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

yvvan added a comment. Please check that one https://reviews.llvm.org/D36390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r308722 - Fixed failing assert in code completion.

Ping? On 21 July 2017 at 10:44, Alex L wrote: > Hans, can you please merge this to the LLVM 5.0 branch? > > AFAIK It's a recent regression that should get fixed in LLVM 5.0. > > Cheers, > Alex > > > On 21 July 2017 at 10:24, Ilya Biryukov via cfe-commits < >

[PATCH] D36208: [mips] Enable `long_call/short_call` attributes on MIPS64

aaron.ballman added inline comments. Comment at: include/clang/Basic/Attr.td:268 def TargetMips : TargetArch<["mips", "mipsel"]>; +def TargetAnyMips : TargetArch<["mips", "mipsel", "mips64", "mips64el"]>; def TargetMSP430 : TargetArch<["msp430"]>; Can you also

[PATCH] D35937: [clang-tidy] Add new readability non-idiomatic static access

barancsuk added inline comments. Comment at: clang-tidy/readability/StaticAccessedThroughInstanceCheck.cpp:23 + memberExpr(hasDeclaration(anyOf(cxxMethodDecl(isStaticStorageClass()), + varDecl(hasStaticStorageDuration(, +

[PATCH] D35937: [clang-tidy] Add new readability non-idiomatic static access

barancsuk updated this revision to Diff 110175. barancsuk marked 4 inline comments as done. barancsuk added a comment. Further reviews addressed https://reviews.llvm.org/D35937 Files: clang-tidy/readability/CMakeLists.txt clang-tidy/readability/ReadabilityTidyModule.cpp

[PATCH] D36458: Fix crash when current lexer is nullptr

yvvan added a comment. And if you just meant how to reproduce: You need to parse and reparse standard header (my current one is C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\memory). I can provide the options and a command line that I have if you can't reproduce it with

[PATCH] D36456: [clang-tidy] 'implicit cast' -> 'implicit conversion'

alexfh updated this revision to Diff 110166. alexfh added a comment. Added redirections from the old check documents. https://reviews.llvm.org/D36456 Files: clang-tidy/performance/CMakeLists.txt clang-tidy/performance/ImplicitCastInLoopCheck.cpp

r310347 - Darwin's toolchain should be initialized before openmp offloading

Author: arphaman Date: Tue Aug 8 04:22:21 2017 New Revision: 310347 URL: http://llvm.org/viewvc/llvm-project?rev=310347=rev Log: Darwin's toolchain should be initialized before openmp offloading is processed This fixes an 'openmp-offload.c' test failure introduced by r310263. Modified:

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

arphaman added a comment. The revert commit is r310345 btw https://reviews.llvm.org/D29654 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35056: GCC ABI incompatibility when passing object with trivial copy ctor, trivial dtor, and non-trivial move ctor

rnk added inline comments. Comment at: test/CodeGenCXX/uncopyable-args.cpp:101 + +// In MSVC 2013, the copy ctor is not deleted by a move assignment. In MSVC 2015, it is. +// WIN64-18-LABEL: declare void @"\01?foo@implicitly_deleted@@YAXUA@1@@Z"(i64 rsmith

[PATCH] D36453: [libclang] Fix PR34055 (incompatible update of clang-c/Index.h)

hans added a comment. In https://reviews.llvm.org/D36453#834949, @n.bozhenov wrote: > If the patch is accepted, it should also be merged into 5.0, I believe. Sounds like a good idea. r310390 https://reviews.llvm.org/D36453 ___ cfe-commits

Re: r310359 - [libclang] Fix PR34055 (incompatible update of clang-c/Index.h)

Merged to 5.0 in r310390 as suggested in the review. Thanks, Hans On Tue, Aug 8, 2017 at 7:13 AM, Nikolai Bozhenov via cfe-commits wrote: > Author: n.bozhenov > Date: Tue Aug 8 07:13:50 2017 > New Revision: 310359 > > URL:

[PATCH] D36324: Integrate Kostya's clang-proto-fuzzer with LLVM.

kcc added a comment. Looks good! Now, please add a clang/tools/clang-fuzzer/README.txt describing how to build the fuzzers (both the old one and the new one) and how to run them. For the new one explain how to install the deps https://reviews.llvm.org/D36324

[PATCH] D35817: Ban implicit _Complex to scalar conversions in C++

t.p.northover added a comment. Pingy. https://reviews.llvm.org/D35817 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36474: Use the file name from linemarker for debug info if an input is preprocessed source.

twoh updated this revision to Diff 110237. twoh added a comment. Addressing dblaikie's comments. Thanks! https://reviews.llvm.org/D36474 Files: lib/CodeGen/CGDebugInfo.cpp test/CodeGen/debug-info-preprocessed-file.i Index: test/CodeGen/debug-info-preprocessed-file.i

[PATCH] D36327: [OpenCL] Allow targets emit optimized pipe functions for power of 2 type sizes

yaxunl added a comment. In https://reviews.llvm.org/D36327#835634, @Anastasia wrote: > In https://reviews.llvm.org/D36327#835153, @b-sumner wrote: > > > In https://reviews.llvm.org/D36327#834032, @Anastasia wrote: > > > > > In https://reviews.llvm.org/D36327#833891, @yaxunl wrote: > > > > > > >

Re: r309263 - [CodeGen][ARM] ARM runtime helper functions are not always soft-fp

Merged to 5.0 in r310393. On Thu, Jul 27, 2017 at 3:43 AM, Peter Smith via cfe-commits wrote: > Author: psmith > Date: Thu Jul 27 03:43:53 2017 > New Revision: 309263 > > URL: http://llvm.org/viewvc/llvm-project?rev=309263=rev > Log: > [CodeGen][ARM] ARM runtime

Re: r308722 - Fixed failing assert in code completion.

Sorry for the slow reply; I missed this somehow. Merged in r310395. Thanks, Hans On Tue, Aug 8, 2017 at 5:20 AM, Alex L wrote: > Ping? > > On 21 July 2017 at 10:44, Alex L wrote: >> >> Hans, can you please merge this to the LLVM 5.0 branch? >> >> AFAIK

[PATCH] D35817: Ban implicit _Complex to scalar conversions in C++

hfinkel added a comment. What's going on with the OpenMP test changes? https://reviews.llvm.org/D35817 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36327: [OpenCL] Allow targets emit optimized pipe functions for power of 2 type sizes

bader added a comment. @rsmith do you have an opinion on what would be the right place for the kind of proposed optimization? It looks like it can be implemented as target independent optimization, acting only for target with specified properties - in this case target must provide required

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

gtbercea added a comment. In https://reviews.llvm.org/D29654#835429, @arphaman wrote: > The "x86_64-apple-darwin17.0.0-x86_64-host" triple looks suspicious though It looks like the triple is in the list though: second = "x86_64-apple-darwin17.0.0-x86_64-host it is entry [1].

[PATCH] D36411: Restore previous structure ABI for bitfields with 'packed' attribute for PS4 targets

ormris added a comment. Great. Thanks for the review! I don't have commit access currently. https://reviews.llvm.org/D36411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36475: [analyzer] Add "create_sink" annotation support to MagentaHandleChecker

haowei created this revision. Herald added a subscriber: xazax.hun. This patch adds "mx_create_sink" annotation support to MagentaHandleChecker to address the false positives found in Magenta unit tests. After this patch, when a call to a function contains this annotation, MagentaHandleChecker

[PATCH] D36474: Use the file name from linemarker for debug info if an input is preprocessed source.

twoh created this revision. Herald added a subscriber: aprantl. Even in the case of the input file is a preprocessed source, clang uses the file name of the preprocesses source for debug info (DW_AT_name attribute for DW_TAG_compile_unit). However, gcc uses the file name specified in the first

[PATCH] D36474: Use the file name from linemarker for debug info if an input is preprocessed source.

twoh updated this revision to Diff 110230. twoh added a comment. Relocate. https://reviews.llvm.org/D36474 Files: lib/CodeGen/CGDebugInfo.cpp test/CodeGen/debug-info-preprocessed-file.i Index: test/CodeGen/debug-info-preprocessed-file.i

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

gtbercea added a comment. In https://reviews.llvm.org/D29654#835548, @hfinkel wrote: > In https://reviews.llvm.org/D29654#835392, @gtbercea wrote: > > > In https://reviews.llvm.org/D29654#835371, @arphaman wrote: > > > > > The last RUN line in the new commit triggers the same assertion failure:

[PATCH] D36250: [coverage] Special-case calls to noreturn functions.

efriedma updated this revision to Diff 110249. efriedma added a comment. Update to call VisitStmt(E) Repository: rL LLVM https://reviews.llvm.org/D36250 Files: lib/CodeGen/CoverageMappingGen.cpp test/CoverageMapping/md.cpp test/CoverageMapping/switch.cpp Index:

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

arphaman added a comment. Hi @gtbercea, I couldn't reply to the email as cfe-commits didn't even register this commit somehow, so I'm replying here. Unfortunately I had to revert this commit (r310291), + two others for a clean revert (r310300 and r310332) because it caused a test failure on

[PATCH] D36456: [clang-tidy] 'implicit cast' -> 'implicit conversion'

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D36456 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36458: Fix crash when current lexer is nullptr

yvvan added a comment. Do you mean the testcase that runs only for windows with ms-extensions flag and msvc includes? I don't know if clang has that kind of tests. Does it? https://reviews.llvm.org/D36458 ___ cfe-commits mailing list

[PATCH] D36359: [clang-format] Put '/**' and '*/' on own lines in jsdocs ending in comment pragmas

krasimir updated this revision to Diff 110157. krasimir added a comment. - Remove debugging https://reviews.llvm.org/D36359 Files: lib/Format/BreakableToken.cpp lib/Format/BreakableToken.h lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTestJS.cpp Index:

[PATCH] D36359: [clang-format] Put '/**' and '*/' on own lines in jsdocs ending in comment pragmas

krasimir updated this revision to Diff 110156. krasimir added a comment. - Simplify getSplitAfterLastLine https://reviews.llvm.org/D36359 Files: lib/Format/BreakableToken.cpp lib/Format/BreakableToken.h lib/Format/ContinuationIndenter.cpp unittests/Format/FormatTestJS.cpp Index:

r310345 - Revert r310291, r310300 and r310332 because of test failure on Darwin

Author: arphaman Date: Tue Aug 8 04:20:17 2017 New Revision: 310345 URL: http://llvm.org/viewvc/llvm-project?rev=310345=rev Log: Revert r310291, r310300 and r310332 because of test failure on Darwin The commit r310291 introduced the failure. r310332 was a test fix commit and r310300 was a

[PATCH] D36458: Fix crash when current lexer is nullptr

bkramer added a comment. Test case? https://reviews.llvm.org/D36458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36456: [clang-tidy] 'implicit cast' -> 'implicit conversion'

alexfh created this revision. Herald added subscribers: xazax.hun, JDevlieghere, mgorny. This patch renames checks, check options and changes messages to use correct term "implicit conversion" instead of "implicit cast" (which has been in use in Clang AST since ~10 years, but it's still

[PATCH] D33672: [analyzer] INT50-CPP. Do not cast to an out-of-range enumeration checker

aaron.ballman added a comment. In https://reviews.llvm.org/D33672#830492, @gamesh411 wrote: > As for the the loss of precision problem, in the special case of char the > size of char is known. However does the analysis have the necessary > information in this stage to know the size of an int

[PATCH] D36327: [OpenCL] Allow targets emit optimized pipe functions for power of 2 type sizes

b-sumner added a comment. In https://reviews.llvm.org/D36327#834032, @Anastasia wrote: > In https://reviews.llvm.org/D36327#833891, @yaxunl wrote: > > > In https://reviews.llvm.org/D36327#833653, @bader wrote: > > > > > Hi Sam, > > > > > > What do you think about implementing this optimization

[PATCH] D29654: [OpenMP] Integrate OpenMP target region cubin into host binary

gtbercea added a comment. In https://reviews.llvm.org/D29654#835045, @arphaman wrote: > Hi @gtbercea, > I couldn't reply to the email as cfe-commits didn't even register this > commit somehow, so I'm replying here. > > Unfortunately I had to revert this commit (r310291), + two others for a

r310359 - [libclang] Fix PR34055 (incompatible update of clang-c/Index.h)

Author: n.bozhenov Date: Tue Aug 8 07:13:50 2017 New Revision: 310359 URL: http://llvm.org/viewvc/llvm-project?rev=310359=rev Log: [libclang] Fix PR34055 (incompatible update of clang-c/Index.h) Fixes a regression introduced by r308218. Modified: cfe/trunk/include/clang-c/Index.h

[PATCH] D36453: [libclang] Fix PR34055 (incompatible update of clang-c/Index.h)

n.bozhenov closed this revision. n.bozhenov added a comment. committed r310359 https://reviews.llvm.org/D36453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r310360 - [OPENMP][DEBUG] Set proper address space info if required by target.

Author: abataev Date: Tue Aug 8 07:25:14 2017 New Revision: 310360 URL: http://llvm.org/viewvc/llvm-project?rev=310360=rev Log: [OPENMP][DEBUG] Set proper address space info if required by target. Arguments, passed to the outlined function, must have correct address space info for proper Debug

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

mibintc updated this revision to Diff 110193. mibintc added a comment. Responding to @fedor.sergeev 's comment. This is an updated patch which pulls out the "isValid" check on GCCInstallation. Also I'm putting back the dummy sysroot tree which contains stdc-predef.h and adding a new test run

[PATCH] D35755: [Solaris] gcc toolchain handling revamp

aaron.ballman added a comment. Aside from a coding style nit and the unanswered question that hopefully @tstellar can help answer, this LGTM. I'll wait to accept until we figure out the answer for Linux, however. Comment at: lib/Driver/ToolChains/Solaris.cpp:208 if

[PATCH] D36101: Fix usage of right shift operator in fold expressions

Rakete added a comment. Ping? https://reviews.llvm.org/D36101 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D36431: Add powerpc64 to compiler-rt build infrastructure.

nemanjai added a comment. This patch appears to be perfectly fine. However, it triggers a large number of warnings. Namely, there's a large number of `warning: ISO C forbids an empty translation unit [-Wpedantic]` warnings produced. The reason is that all the code in the file is wrapped with an

[PATCH] D36411: Restore previous structure ABI for bitfields with 'packed' attribute for PS4 targets

probinson added a comment. FTR, from a PS4 perspective this is all good, but we'd like somebody from outside our team to take a look. https://reviews.llvm.org/D36411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D36390: Fix overloaded static functions in SemaCodeComplete

bkramer added inline comments. Comment at: include/clang/Sema/Sema.h:2681 + bool PartialOverloading = false, + bool ExtraFirstArgument = false); void AddMethodCandidate(DeclAccessPair FoundDecl, I'd prefer something

[PATCH] D35056: GCC ABI incompatibility when passing object with trivial copy ctor, trivial dtor, and non-trivial move ctor

v.g.vassilev added a comment. And thanks for working on this!! Repository: rL LLVM https://reviews.llvm.org/D35056 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35056: GCC ABI incompatibility when passing object with trivial copy ctor, trivial dtor, and non-trivial move ctor

v.g.vassilev added a comment. I do not feel qualified enough to review this patch but I added few minor comments. Comment at: include/clang/AST/DeclCXX.h:827 +return data().DefaultedCopyConstructorIsDeleted; + } + /// \brief \c true if a defaulted move constructor for

  1   2   >