[PATCH] D34018: Support __float128 on NetBSD libstdc++ x86/x86_64

krytarowski planned changes to this revision. krytarowski added a comment. Rescheduled for future. Maybe I will need to check and improve how good is this i386 __float128 support. Repository: rL LLVM https://reviews.llvm.org/D34018 ___

[PATCH] D39308: [libcxx] Keep track of heap allocated regex states

timshen updated this revision to Diff 120334. timshen added a comment. Add an assertion to __push. https://reviews.llvm.org/D39308 Files: libcxx/include/regex Index: libcxx/include/regex === --- libcxx/include/regex +++

[PATCH] D38985: [refactor] Add support for editor commands that connect IDEs/editors to the refactoring actions

arphaman added a comment. In https://reviews.llvm.org/D38985#906893, @sammccall wrote: > Thanks, this looks a bunch simpler. > > I have a question about the direction here: AFAICS there's various efforts in > the refactoring infrastructure to allow consumers of the Refactor libs (e.g. >

[PATCH] D38985: [refactor] Add support for editor commands that connect IDEs/editors to the refactoring actions

arphaman updated this revision to Diff 120335. arphaman added a comment. - Refactoring operations like ExtractFunction should be declared in headers and should contain the initiation checks. - Refactoring actions can now be all created in one "engine" file. - A new descriptor interface describes

[PATCH] D38985: [refactor] Add support for editor commands that connect IDEs/editors to the refactoring actions

arphaman updated this revision to Diff 120336. arphaman added a comment. Remove unused function Repository: rL LLVM https://reviews.llvm.org/D38985 Files: include/clang/Tooling/Refactoring/Extract/ExtractFunction.h include/clang/Tooling/Refactoring/RefactoringActionRegistry.def

[PATCH] D38985: [refactor] Add support for editor commands that connect IDEs/editors to the refactoring actions

arphaman added a comment. The updated patch introduces some redundancy between the `RefactoringAction` and the descriptor interface. I will address this in a follow-up patch. Repository: rL LLVM https://reviews.llvm.org/D38985 ___ cfe-commits

[PATCH] D39290: [rename] Use SymbolOccurrence in RenameLocFinder.

ioeric added a comment. Could you elaborate on the intention of this change? Is the intention of having more information in `SymbolOccurrence` to benefit users of the rename library or to simplify the internal implementation? Comment at:

[PATCH] D39224: Moved QualTypeNames.h from Tooling to AST.

rnk added a comment. In https://reviews.llvm.org/D39224#906225, @ilya-biryukov wrote: > In https://reviews.llvm.org/D39224#905431, @rnk wrote: > > > Can you remind me why `NamedDecl::printQualifiedName` is not appropriate > > for your needs? > > > The use-case in code completion (see

[PATCH] D36347: New lldb python module for adding diagnostic breakpoints

hintonda added a comment. Thanks for the quick feedback. I'll make all you suggested changes, but need to think a little more about `diagtool`. Comment at: utils/clangdiag.py:75-78 +diagtool = os.path.join(exe.GetDirectory(), 'diagtool') +if not

[PATCH] D36347: New lldb python module for adding diagnostic breakpoints

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. Use the form of the command that gets an SBExecutionContext, then you can avoid having to cache the target at all. Comment at: utils/clangdiag.py:98-100 +def

r316611 - [CUDA] Print an error if you try to compile with < sm_30 on CUDA 9.

Author: jlebar Date: Wed Oct 25 14:32:06 2017 New Revision: 316611 URL: http://llvm.org/viewvc/llvm-project?rev=316611=rev Log: [CUDA] Print an error if you try to compile with < sm_30 on CUDA 9. Summary: CUDA 9's minimum sm is sm_30. Ideally we should also make sm_30 the default when compiling

[PATCH] D36347: New lldb python module for adding diagnostic breakpoints

clayborg added inline comments. Comment at: utils/clangdiag.py:62 + +def enable(debugger, args): +# Always disable existing breakpoints Pass exe_ctx or target into this instead of the debugger (see Jim's comment on execution contexts below.

[PATCH] D39220: [Analyzer] Store BodyFarm in std::unique_ptr

george.karpenkov added a comment. @dcoughlin OK, I'll commit that [I assuming not doing the review would be fine here] Repository: rL LLVM https://reviews.llvm.org/D39220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39308: [libcxx] Keep track of heap allocated regex states

timshen created this revision. Herald added a subscriber: sanjoy. Herald added a reviewer: EricWF. Build abstraction on regex's allocation This fixes a fuzzer crasher from a huge input (provided by Marshall), which seems to be a stackoverflow during destruction. However, I can't reproduce

[PATCH] D38819: [libunwind] Add support for dwarf unwinding on windows on x86_64

mstorsjo added inline comments. Comment at: src/UnwindRegistersRestore.S:72 + movq 56(%rcx), %rax # rax holds new stack pointer + subq $16, %rax + movq %rax, 56(%rcx) mstorsjo wrote: > compnerd wrote: > > Hmm, why is this `$16`? The `$rsp` was adjusted by

[PATCH] D39305: Simplify codegen and debug info generation for block context parameters.

aprantl created this revision. The exisiting code goes out of its way to put block parameters into an alloca at -O0 only, but then describes the function argument (instead of the alloca) with a dbg.declare and the value loaded from the alloca with a dbg.value. Describing a function argument

[PATCH] D38954: [Sema] -Wzero-as-null-pointer-constant: don't warn for system macros other than NULL.

lebedev.ri updated this revision to Diff 120316. lebedev.ri added a comment. Add `Diags.isIgnored()` early return + move `C++11` early return earlier too. At least partially should help avoid the penalty of `findMacroSpelling()` I don't think i see any way to avoid `findMacroSpelling()` :/

[PATCH] D36347: New lldb python module for adding diagnostic breakpoints

jingham added a comment. Yes definitely use names for your breakpoints. It makes them easier to handle. Note starting a month or two ago you can set names to not get deleted except by an explicit gesture. That hasn't shown up in releases yet, but once you can rely on its being there, you

r316618 - [Analyzer] [Tests] Do not discard output from CmpRuns.py when running integration tests

Author: george.karpenkov Date: Wed Oct 25 14:49:46 2017 New Revision: 316618 URL: http://llvm.org/viewvc/llvm-project?rev=316618=rev Log: [Analyzer] [Tests] Do not discard output from CmpRuns.py when running integration tests Contrary to the deleted comment, in most cases CmpRuns.py produces a

r316617 - [Analyzer] Give more descriptive name to BdyFrm field.

Author: george.karpenkov Date: Wed Oct 25 14:49:41 2017 New Revision: 316617 URL: http://llvm.org/viewvc/llvm-project?rev=316617=rev Log: [Analyzer] Give more descriptive name to BdyFrm field. Discussion at: https://reviews.llvm.org/D39220 Modified:

[PATCH] D36347: Add new script to launch lldb and set breakpoints for diagnostics all diagnostics seen.

hintonda updated this revision to Diff 120308. hintonda added a comment. Reimplement at a python module. https://reviews.llvm.org/D36347 Files: utils/clangdiag.py Index: utils/clangdiag.py === --- /dev/null +++

[PATCH] D36836: [clang-tidy] Implement readability-function-cognitive-complexity check

aaron.ballman added inline comments. Comment at: clang-tidy/readability/FunctionCognitiveComplexityCheck.cpp:102 +const unsigned short Nesting; /// How deeply nested is Loc located? +const Criteria C : 3; /// The criteria of the increment +

[PATCH] D36347: New lldb python module for adding diagnostic breakpoints

clayborg added a comment. Looks good. A little bit of cleanup. Let me know what you think of the comments. Comment at: utils/clangdiag.py:17 +import os +from subprocess import check_output as qx; + I would rather just do: ``` import subprocess ``` Then later

[PATCH] D38954: [Sema] -Wzero-as-null-pointer-constant: don't warn for system macros other than NULL.

thakis accepted this revision. thakis added a comment. This revision is now accepted and ready to land. In general, "I don't see any way to prevent $slow_thing" just means the patch can't move ahead. But in this case, this looks like fairly small overhead for a worst-case input, so this won't

[clang-tools-extra] r316621 - Handle PragmaDebug in PPChainedCallbacks

Author: arphaman Date: Wed Oct 25 15:01:23 2017 New Revision: 316621 URL: http://llvm.org/viewvc/llvm-project?rev=316621=rev Log: Handle PragmaDebug in PPChainedCallbacks The test is in clang-tools-extra/test/pp-trace Modified:

r316621 - Handle PragmaDebug in PPChainedCallbacks

Author: arphaman Date: Wed Oct 25 15:01:23 2017 New Revision: 316621 URL: http://llvm.org/viewvc/llvm-project?rev=316621=rev Log: Handle PragmaDebug in PPChainedCallbacks The test is in clang-tools-extra/test/pp-trace Modified: cfe/trunk/include/clang/Lex/PPCallbacks.h Modified:

[PATCH] D36347: New lldb python module for adding diagnostic breakpoints

jingham added a comment. Note, BTW, Enrico also added a form of the command add that allows you to use a Python class to wrap the callable. That was in early 2015 so it's probably safe to use as well by now. That's even more convenient, and obviates the need for globals at all. One instance

[PATCH] D38774: [CodeGen] Add support for IncompleteArrayType in Obj-C ivars.

vsapsai added inline comments. Comment at: clang/lib/CodeGen/CGObjCMac.cpp:5095 +fieldType = fieldType->getAsArrayTypeUnsafe()->getElementType(); + } + rjmccall wrote: > vsapsai wrote: > > rjmccall wrote: > > > You can't just use isa<> here; there can be

[PATCH] D38774: [CodeGen] Add support for IncompleteArrayType in Obj-C ivars.

vsapsai updated this revision to Diff 120337. vsapsai added a comment. - Address rjmccall review comment about nested arrays. https://reviews.llvm.org/D38774 Files: clang/lib/CodeGen/CGObjCMac.cpp clang/test/CodeGenObjC/ivar-layout-flexible-array.m Index:

[PATCH] D36347: New lldb python module for adding diagnostic breakpoints

hintonda updated this revision to Diff 120340. hintonda edited the summary of this revision. hintonda added a comment. Herald added a subscriber: ilya-biryukov. - Addressed comments. https://reviews.llvm.org/D36347 Files: utils/clangdiag.py Index: utils/clangdiag.py

[PATCH] D36347: New lldb python module for adding diagnostic breakpoints

hintonda added inline comments. Comment at: utils/clangdiag.py:83 +# Remove all diag breakpoints. +bkpts = lldb.SBBreakpointList(target) +target.FindBreakpointsByName("clang::Diagnostic", bkpts) Can't use iterator because it gets invalidated and not

[PATCH] D39310: [CGBlocks] Improve line info in backtraces containing *_helper_block

vsk created this revision. Instead of only setting a non-zero debug location on the return instruction in *_helper_block functions, set a proper location on all instructions within these functions. Pick the start location of the block literal expr for maximum clarity. The debugger does not step

[PATCH] D39310: [CGBlocks] Improve line info in backtraces containing *_helper_block

vsk updated this revision to Diff 120342. vsk added a comment. - Simplify the checks by not hardcoding a line number. https://reviews.llvm.org/D39310 Files: lib/CodeGen/CGBlocks.cpp test/CodeGenObjC/debug-info-blocks.m Index: test/CodeGenObjC/debug-info-blocks.m

r316571 - [rename] support renaming class member.

Author: hokein Date: Wed Oct 25 04:54:45 2017 New Revision: 316571 URL: http://llvm.org/viewvc/llvm-project?rev=316571=rev Log: [rename] support renaming class member. Reviewers: ioeric Reviewed By: ioeric Subscribers: klimek, cfe-commits, mgorny Differential Revision:

[PATCH] D39178: [rename] support renaming class member.

This revision was automatically updated to reflect the committed changes. Closed by commit rL316571: [rename] support renaming class member. (authored by hokein). Repository: rL LLVM https://reviews.llvm.org/D39178 Files: cfe/trunk/lib/Tooling/Refactoring/Rename/USRLocFinder.cpp

[PATCH] D39284: [c++2a] Decomposed _condition_

aaron.ballman added a comment. I'm not opposed to the functionality, but this isn't a part of C++2a either; I think we should be diagnosing this code with a warning so users don't expect it to work on every compiler. https://reviews.llvm.org/D39284

SemaTemplateInstantiateDecl mistakenly issuing diag::warn_func_template_missing for templated deduction guides

Following compilation shows the issue: $ clang++ --version clang version 6.0.0 (trunk 316414) Target: x86_64-unknown-linux-gnu Thread model: posix InstalledDir: /opt/compiler-explorer/clang-trunk/bin $ cat a.cpp template struct S { template

[PATCH] D37470: [analyzer] Handle ObjC messages conservatively in CallDescription

xazax.hun updated this revision to Diff 120233. xazax.hun added a comment. Herald added a subscriber: szepet. - Modify a test to trigger the assertion fail before the patch is applied. https://reviews.llvm.org/D37470 Files: lib/StaticAnalyzer/Core/CallEvent.cpp test/Analysis/objc-message.m

[PATCH] D39053: [Bitfield] Add more cases to making the bitfield a separate location

spetrovic added a comment. Well, basically I'm just expanding the existing algorithm, why should we split fields just in case when current field is integer, I'm not resolving specific problem with unaligned loads/stores on MIPS. In this example: typedef struct { unsigned int f1 : 28;

[PATCH] D39284: [c++2a] Decomposed _condition_

lichray created this revision. This feature was discussed but not yet proposed. It allows a structured binding to appear as a //condition// if (auto [ok, val] = f(...)) So the user can save an extra //condition// if the statement can query the value to-be-decomposed instead. Formally, it

[PATCH] D34272: [Tooling] A new framework for executing clang frontend actions.

ioeric updated this revision to Diff 120232. ioeric added a comment. - Get rid of the unused 'createExecutorByName' interface. https://reviews.llvm.org/D34272 Files: include/clang/Tooling/CommonOptionsParser.h include/clang/Tooling/Execution.h include/clang/Tooling/StandaloneExecution.h

[PATCH] D39220: [Analyzer] Store BodyFarm in std::unique_ptr

alexfh added inline comments. Comment at: include/clang/Analysis/AnalysisDeclContext.h:424 /// methods during the analysis. - BodyFarm *BdyFrm = nullptr; + std::unique_ptr BdyFrm; george.karpenkov wrote: > alexfh wrote: > > BdyFrm is somewhat cryptic.

r316585 - [OPENMP] Improve debug info for taskgroup implicitly generated

Author: abataev Date: Wed Oct 25 08:54:04 2017 New Revision: 316585 URL: http://llvm.org/viewvc/llvm-project?rev=316585=rev Log: [OPENMP] Improve debug info for taskgroup implicitly generated expressions. Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp

[PATCH] D34272: [Tooling] A new framework for executing clang frontend actions.

ioeric updated this revision to Diff 120250. ioeric added a comment. - Only expose result reporting interface from ExecutionContext so that callbacks don't have access to results. https://reviews.llvm.org/D34272 Files: include/clang/Tooling/CommonOptionsParser.h

[PATCH] D34272: [Tooling] A new framework for executing clang frontend actions.

ioeric updated this revision to Diff 120254. ioeric added a comment. - Minor comment update. https://reviews.llvm.org/D34272 Files: include/clang/Tooling/CommonOptionsParser.h include/clang/Tooling/Execution.h include/clang/Tooling/StandaloneExecution.h

[PATCH] D34272: [Tooling] A new framework for executing clang frontend actions.

ioeric added inline comments. Comment at: include/clang/Tooling/Execution.h:51-53 + virtual std::vector> AllKVResults() = 0; + virtual void forEachResult( + llvm::function_ref Callback) = 0;

r316584 - [OPENMP] Constify function parameters, NFC.

Author: abataev Date: Wed Oct 25 08:44:52 2017 New Revision: 316584 URL: http://llvm.org/viewvc/llvm-project?rev=316584=rev Log: [OPENMP] Constify function parameters, NFC. Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp Modified: cfe/trunk/lib/Sema/SemaOpenMP.cpp URL:

[PATCH] D37470: [analyzer] Handle ObjC messages conservatively in CallDescription

dcoughlin added a comment. I think it would be better to add a new "test/Analysis/block-in-critical-section.m" file rather than enabling a random alpha checker in a file that tests the analyzer core. https://reviews.llvm.org/D37470 ___

[PATCH] D39008: [CodeGen] Propagate may-alias'ness of lvalues with TBAA info

kosarev added a comment. Now that https://reviews.llvm.org/D38796 is comitted and added the tbaa-cast.cpp test case to the mainline, we fail on it with this patch applied. The reason is that we have no special TBAA type node for may-alias accesses, so everything that ever been a potential

r316578 - Also update IsUbuntu() with Ubuntu Bionic

Author: sylvestre Date: Wed Oct 25 07:23:27 2017 New Revision: 316578 URL: http://llvm.org/viewvc/llvm-project?rev=316578=rev Log: Also update IsUbuntu() with Ubuntu Bionic Follow up of r316577 Modified: cfe/trunk/include/clang/Driver/Distro.h Modified:

[PATCH] D38985: [refactor] Add support for editor commands that connect IDEs/editors to the refactoring actions

ioeric added inline comments. Comment at: include/clang/Tooling/Refactoring/RefactoringActionRule.h:60 + /// associated with this rule. + virtual Optional> getEditorCommandInfo() { +return None; I think

[PATCH] D39293: Add objcCategoryImplDecl matcher

kastiglione created this revision. Herald added a subscriber: klimek. Add `objcCategoryImplDecl` which matches ObjC category definitions (`@implementation`). This matcher complements `objcCategoryDecl` (`@interface`) which was added in https://reviews.llvm.org/D30854.

[PATCH] D37187: [Analyzer] Fix Bug 25609 - Assertion UNREACHABLE: 'Unexpected ProgramPoint' with widen-loops=true

MTC updated this revision to Diff 120265. MTC marked 3 inline comments as done. MTC added a comment. The message about invalidate variable values is temporarily not printed. This work can be done with separate patch. https://reviews.llvm.org/D37187 Files:

r316579 - Add support of the next Debian (Debian buster - version 10)

Author: sylvestre Date: Wed Oct 25 07:25:28 2017 New Revision: 316579 URL: http://llvm.org/viewvc/llvm-project?rev=316579=rev Log: Add support of the next Debian (Debian buster - version 10) Modified: cfe/trunk/include/clang/Driver/Distro.h cfe/trunk/lib/Driver/Distro.cpp Modified:

[PATCH] D39239: [AST] Incorrectly qualified unscoped enumeration as template actual parameter.

CarlosAlbertoEnciso added a comment. In https://reviews.llvm.org/D39239#905641, @probinson wrote: > Have you tried this change against the GDB and LLDB test suites? If they > have failures then we should think about whether those tests are > over-specific or whether we should put this under a

[PATCH] D37624: add support for -fno-instrument-functions and -finstrument-functions-exclude-{file, function}-list=<arg1, arg2, ...> to match gcc options.

choikwa updated this revision to Diff 120252. choikwa added a comment. rebase to trunk https://reviews.llvm.org/D37624 Files: docs/ClangCommandLineReference.rst include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.h lib/CodeGen/CodeGenFunction.cpp

[PATCH] D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches

JonasToth updated this revision to Diff 120251. JonasToth marked 8 inline comments as done. JonasToth added a comment. - Merge 'master' - address review comments https://reviews.llvm.org/D37808 Files: clang-tidy/hicpp/CMakeLists.txt clang-tidy/hicpp/HICPPTidyModule.cpp

[PATCH] D37808: [clang-tidy] Add new hicpp-multiway-paths-covered check for missing branches

JonasToth added a comment. simplified the if-else stuff https://reviews.llvm.org/D37808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34272: [Tooling] A new framework for executing clang frontend actions.

klimek added inline comments. Comment at: include/clang/Tooling/Execution.h:76 + + void appendArgumentsAdjuster(ArgumentsAdjuster Adjuster); + I think the argument adjuster adjustment shouldn't be part of this interface, as the argument adjusters cannot be

[PATCH] D38126: Make TBAA information to be part of LValueBaseInfo

kosarev abandoned this revision. kosarev added a comment. Indeed, if LValueBaseInfo is what we know about the very first value in a sequence, then TBAA info certainly should not be part of it. This also means whatever is specified as a direct base lvalue to the lvalue we are constructing

r316577 - Add support of the next Ubuntu (Ubuntu 18.04 - Bionic Beaver)

Author: sylvestre Date: Wed Oct 25 07:21:33 2017 New Revision: 316577 URL: http://llvm.org/viewvc/llvm-project?rev=316577=rev Log: Add support of the next Ubuntu (Ubuntu 18.04 - Bionic Beaver) Modified: cfe/trunk/include/clang/Driver/Distro.h cfe/trunk/lib/Driver/Distro.cpp Modified:

[PATCH] D34158: For Linux/gnu compatibility, preinclude if the file is available

mibintc added a comment. I pulled out all the test changes and the only one that is needed presently is Clang :: Driver/crash-report.c; huh, that's different than what I encountered earlier in the summer. Now I'll recheck those extra tests. https://reviews.llvm.org/D34158

[PATCH] D38688: [clang-tidy] Misc redundant expressions checker updated for macros

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. LGTM! But wait for @aaron.ballman, @alexfh, or @hokein for the final word. https://reviews.llvm.org/D38688 ___ cfe-commits mailing list

[PATCH] D39015: [Analyzer] Always use non-reference types when creating expressions in BodyFarm, removes std::call_once crash

alexfh added inline comments. Comment at: cfe/trunk/lib/Analysis/BodyFarm.cpp:366 +M.makeLvalueToRvalue(D->getParamDecl(i), + /* RefersToEnclosingVariableOrCapture= */ false)); george.karpenkov wrote: > alexfh wrote: > >

[PATCH] D39138: [CodeGen] Generate TBAA info for 'this' pointers

kosarev added a comment. Hmm, according to our research such loads constitute about 18% of all loads under ##-O -Xclang -disable-llvm-passes## on the LLVM code base. I wonder, do you think it would be nice to not generate them at all? I mean, provided that necessary changes do not add too much

[PATCH] D39290: [rename] Use SymbolOccurrence in RenameLocFinder.

hokein created this revision. Herald added a subscriber: klimek. This is first step to integrate qualified rename into clang-refactor. Also a few changes to SymbolOccurrence: - add more information to SymbolOccurrence - remove the way of using SourceLocation as the array size

[PATCH] D39321: ARM: centralise SizeType, PtrDiffType, and IntPtrType

compnerd created this revision. compnerd added a project: clang. Herald added subscribers: kristof.beyls, javed.absar, aemerson. Centralise the definitions of these compiler vended types to aid inspection to ensure that they are defined similarly. The one case that stands out is the Darwin case

[PATCH] D39220: [Analyzer] Store BodyFarm in std::unique_ptr

dcoughlin added a comment. In https://reviews.llvm.org/D39220#907160, @george.karpenkov wrote: > @dcoughlin OK, I'll commit that [I assuming not doing the review would be > fine here] Yes, thanks! Repository: rL LLVM https://reviews.llvm.org/D39220

r316632 - [Analyzer] [Tests] Consistently use exit codes. Use code=42 to signify different results

Author: george.karpenkov Date: Wed Oct 25 18:13:22 2017 New Revision: 316632 URL: http://llvm.org/viewvc/llvm-project?rev=316632=rev Log: [Analyzer] [Tests] Consistently use exit codes. Use code=42 to signify different results Modified: cfe/trunk/utils/analyzer/SATestBuild.py

[PATCH] D39310: [CGBlocks] Improve line info in backtraces containing *_helper_block

vsk added inline comments. Comment at: lib/CodeGen/CGBlocks.cpp:1651 StartFunction(FD, C.VoidTy, Fn, FI, args); - // Create a scope with an artificial location for the body of this function. - auto AL = ApplyDebugLocation::CreateArtificial(*this); + ApplyDebugLocation

[PATCH] D39308: [libcxx] Keep track of heap allocated regex states

mclow.lists added a comment. A couple of notes. - This change means that now requires C++11 (the new `__push` function w/ the varargs). I don't know how important that is; but I'm pretty sure libc++ currently provides `` in C++03 mode. - This is an ABI change; existing code that was compiled

Buildbot numbers for the last week of 10/15/2017 - 10/21/2017

Hello everyone, Below are some buildbot numbers for the last week of 10/15/2017 - 10/21/2017. Please see the same data in attached csv files: The longest time each builder was red during the week; "Status change ratio" by active builder (percent of builds that changed the builder status from

r316636 - [LSan] Enable -fsanitize=leak for PPC64 Linux.

Author: alekseyshl Date: Wed Oct 25 20:09:53 2017 New Revision: 316636 URL: http://llvm.org/viewvc/llvm-project?rev=316636=rev Log: [LSan] Enable -fsanitize=leak for PPC64 Linux. Summary: . Reviewers: eugenis Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D39312

[PATCH] D24933: Enable configuration files in clang

hfinkel added inline comments. Comment at: lib/Driver/Driver.cpp:630 + for (const char *Dir : Directories) { +assert(Dir); +FilePath.clear(); assert(Dir && "Directory path should not be null"); Comment at: lib/Driver/Driver.cpp:637

[PATCH] D39312: [LSan] Enable -fsanitize=leak for PPC64 Linux.

alekseyshl created this revision. . https://reviews.llvm.org/D39312 Files: lib/Driver/ToolChains/Linux.cpp test/Driver/fsanitize.c Index: test/Driver/fsanitize.c === --- test/Driver/fsanitize.c +++ test/Driver/fsanitize.c @@

[PATCH] D39166: [NFC] Add some assertions to placate my paranoia about sharing a variant bit across FunctionDecl and CXXDeductionGuideDecl - should I do this?

faisalv updated this revision to Diff 120346. faisalv marked 4 inline comments as done. faisalv added a comment. Incorporated Aaron's feedback (although not sure if I caugh tall the white space issues). Additionally, I was thinking of reordering the bits - and using UseSEHTry (this bit really

[PATCH] D39308: [libcxx] Keep track of heap allocated regex states

mclow.lists added a comment. I can confirm that with this patch the (large) regex that used to cause a stack overflow does not any more. https://reviews.llvm.org/D39308 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D39312: [LSan] Enable -fsanitize=leak for PPC64 Linux.

This revision was automatically updated to reflect the committed changes. Closed by commit rL316636: [LSan] Enable -fsanitize=leak for PPC64 Linux. (authored by alekseyshl). Repository: rL LLVM https://reviews.llvm.org/D39312 Files: cfe/trunk/lib/Driver/ToolChains/Linux.cpp

[PATCH] D24933: Enable configuration files in clang

hfinkel added inline comments. Comment at: lib/Driver/Driver.cpp:661 + + // If not found, try searching the directory where executable resides. + FilePath.clear(); hfinkel wrote: > Why not just add this directory to the end of the list of directories? (by

[PATCH] D39284: [c++2a] Decomposed _condition_

lichray added a comment. In https://reviews.llvm.org/D39284#906450, @aaron.ballman wrote: > I'm not opposed to the functionality, but this isn't a part of C++2a either; > I think we should be diagnosing this code with a warning so users don't > expect it to work on every compiler. C++2a the

[PATCH] D39301: Ignore implicity casts for zero-as-null-pointer-constant warning

lebedev.ri added inline comments. Comment at: test/SemaCXX/warn-zero-nullptr.cpp:29 + +// Shouldn't warn. +struct pr34362 { operator int*() { return nullptr; } }; Maybe wrap into a `namespace PR34362 {}` https://reviews.llvm.org/D39301

[PATCH] D38985: [refactor] Add support for editor commands that connect IDEs/editors to the refactoring actions

sammccall added a comment. Thanks, this looks a bunch simpler. I have a question about the direction here: AFAICS there's various efforts in the refactoring infrastructure to allow consumers of the Refactor libs (e.g. clang-refactor, clangd, XCode?) to operate without knowing the details of

[PATCH] D39301: Ignore implicity casts for zero-as-null-pointer-constant warning

lebedev.ri added inline comments. Comment at: lib/Sema/Sema.cpp:441 return; - if (E->getType()->isNullPtrType()) + if (E->IgnoreImpCasts()->getType()->isNullPtrType()) return; erichkeane wrote: > aaron.ballman wrote: > > Do we also want to ignore

Re: r315126 - Driver: hoist the `wchar_t` handling to the driver

On 10/6/2017 4:09 PM, Saleem Abdulrasool via cfe-commits wrote: Modified: cfe/trunk/lib/Driver/ToolChains/Clang.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains/Clang.cpp?rev=315126=315125=315126=diff

[PATCH] D38824: [X86] Synchronize the existing CPU predefined macros with the cases that gcc defines them

craig.topper added a comment. Ping https://reviews.llvm.org/D38824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38796: [CodeGen] EmitPointerWithAlignment() to generate TBAA info along with LValue base info

rjmccall added a comment. I think probably the best solution is to track may-alias-ness explicitly in the TBAAAccessInfo instead of relying in the frontend on being able to distinguish things in the LLVM metadata. Repository: rL LLVM https://reviews.llvm.org/D38796

[PATCH] D39301: Ignore implicity casts for zero-as-null-pointer-constant warning

aaron.ballman added inline comments. Comment at: lib/Sema/Sema.cpp:441 return; - if (E->getType()->isNullPtrType()) + if (E->IgnoreImpCasts()->getType()->isNullPtrType()) return; Do we also want to ignore parens here as well with

[PATCH] D39293: Add objcCategoryImplDecl matcher

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D39293 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D38596: Implement attribute target multiversioning

erichkeane updated this revision to Diff 120278. erichkeane added a comment. Just a quick rebase, there were a few changes in the area. https://reviews.llvm.org/D38596 Files: include/clang/AST/Decl.h include/clang/Basic/Attr.td include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D39210: Add default calling convention support for regcall.

eandrews added inline comments. Comment at: lib/Sema/SemaType.cpp:3269-3273 + bool IsMain = false; + if (D.getIdentifier() && D.getIdentifier()->isStr("main") && + S.CurContext->getRedeclContext()->isTranslationUnit() && + !S.getLangOpts().Freestanding) +IsMain =

[PATCH] D39138: [CodeGen] Generate TBAA info for 'this' pointers

rjmccall added a comment. In https://reviews.llvm.org/D39138#906623, @kosarev wrote: > Hmm, according to our research such loads constitute about 18% of all loads > under ##-O -Xclang -disable-llvm-passes## on the LLVM code base. I wonder, do > you think it would be nice to not generate them

[PATCH] D39284: [c++2a] Decomposed _condition_

lichray added a comment. In https://reviews.llvm.org/D39284#906860, @aaron.ballman wrote: > I'm aware, but I was unaware that we've accepted this functionality in C++2a > yet within WG21. Did we vote this in and I simply didn't remember it? No. In the first line of the Summary I said this

[PATCH] D39301: Ignore implicity casts for zero-as-null-pointer-constant warning

erichkeane updated this revision to Diff 120289. erichkeane added a comment. Lets ignore parens too! https://reviews.llvm.org/D39301 Files: lib/Sema/Sema.cpp test/SemaCXX/warn-zero-nullptr.cpp Index: lib/Sema/Sema.cpp ===

[PATCH] D39284: [c++2a] Decomposed _condition_

aaron.ballman added a comment. In https://reviews.llvm.org/D39284#906889, @lichray wrote: > In https://reviews.llvm.org/D39284#906860, @aaron.ballman wrote: > > > I'm aware, but I was unaware that we've accepted this functionality in > > C++2a yet within WG21. Did we vote this in and I simply

[PATCH] D39210: Add default calling convention support for regcall.

eandrews updated this revision to Diff 120284. eandrews added a comment. Updated patch to set default calling convention for main() in CheckMain() https://reviews.llvm.org/D39210 Files: include/clang/Basic/LangOptions.h include/clang/Driver/CC1Options.td

r316599 - CodeGen: fix PPC Darwin variadics

Author: compnerd Date: Wed Oct 25 10:56:50 2017 New Revision: 316599 URL: http://llvm.org/viewvc/llvm-project?rev=316599=rev Log: CodeGen: fix PPC Darwin variadics Darwin uses char * for the variadic list type (va_list). We use the PPC SVR4 ABI for PPC, which uses a structure type for the

[PATCH] D39284: [c++2a] Decomposed _condition_

aaron.ballman added a comment. In https://reviews.llvm.org/D39284#906800, @lichray wrote: > In https://reviews.llvm.org/D39284#906450, @aaron.ballman wrote: > > > I'm not opposed to the functionality, but this isn't a part of C++2a > > either; I think we should be diagnosing this code with a

[PATCH] D39301: Ignore implicity casts for zero-as-null-pointer-constant warning

erichkeane created this revision. The repro in https://bugs.llvm.org/show_bug.cgi?id=34362 caused the left nullptr to be cast to a int* implicitly, which resulted diagnosing this falsely. https://reviews.llvm.org/D39301 Files: lib/Sema/Sema.cpp test/SemaCXX/warn-zero-nullptr.cpp Index:

[PATCH] D39301: Ignore implicity casts for zero-as-null-pointer-constant warning

erichkeane updated this revision to Diff 120288. erichkeane marked an inline comment as done. erichkeane added a comment. Response to Roman's comment. https://reviews.llvm.org/D39301 Files: lib/Sema/Sema.cpp test/SemaCXX/warn-zero-nullptr.cpp Index: lib/Sema/Sema.cpp

[PATCH] D39301: Ignore implicity casts for zero-as-null-pointer-constant warning

erichkeane added inline comments. Comment at: lib/Sema/Sema.cpp:441 return; - if (E->getType()->isNullPtrType()) + if (E->IgnoreImpCasts()->getType()->isNullPtrType()) return; aaron.ballman wrote: > Do we also want to ignore parens here as well with

  1   2   >